[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Jeremy Orlow
On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: Some things to consider: 1. On windows, breakpad used to be wired in test_shell. And I'm pretty sure we used to archive crash dumps for the layout tests too. It should not be hard to do that again. Huan also write a

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Mohamed Mansour
When people change themes regularly, I believe their intension is to try out themes. When theme preview is going to come in, that would be simpler. A person isn't going to change themes every day, if they want to change themes, they could just goto the UI and change to any theme they please. I

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-10 Thread Amanda Walker
On Mon, Aug 10, 2009 at 12:32 AM, PhistucK phist...@chromium.org wrote: Obviously, but since there is a website (what started this thread) and people do run into issues (Help forums) with such a thing, is a specific solution for Flash, at least, coming up soon? People getting infected while

[chromium-dev] Re: Urgent, a very evil site i think which does evil things (no joke)

2009-08-10 Thread Caleb Eggensperger
I think that maybe a viable interim workaround to flash's vulnerability problems would be to implement something like flashblock by default. There would have to be some always show flash on *.google.com whitelisting option (maybe automatically whitelist bookmarked sites?), and it would have to be

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Dimitri Glazkov
2. The show stopper for any implementation of this feature is that the machines running the layout tests don't have the pdbs for test_shell. Since the binary is built on another machine, it was too slow to copy the pdbs from one machine to another. If you guys think it's important, and can

[chromium-dev] Re: Hyperlink-like UI element

2009-08-10 Thread Scott Violet
On Sun, Aug 9, 2009 at 2:41 PM, Peter Kastingpkast...@google.com wrote: On Sun, Aug 9, 2009 at 4:43 AM, Caleb Eggensperger caleb...@gmail.com wrote: I associate a button with doing something and a link with navigating somewhere. But a link is used to remove a bookmark (from the menu you get

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Avi Drissman
On Mon, Aug 10, 2009 at 7:46 AM, Mohamed Mansour m...@chromium.org wrote: I have been told that once you installed a new theme, the old theme will not be archived (stored on the system), so switching themes would be harder when the CL comes in. That isn't the case today; that may be the case

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 8:50 AM, Avi Drissmana...@google.com wrote: Right now there's no real control over themes. Once they're installed, they're permanently installed; there's no easy way to remove them We should completely drop the concept of theme installation. We can do this by changing

[chromium-dev] Re: How not to spend the day getting depot_tools, cygwin svn to play nicely...

2009-08-10 Thread Andrew Scherkus
My experience with this is that it's either all-or-nothing when it comes to using cygwin tools. My main git-svn checkout was created using cygwin svn+python, so I now need to comment out the lines in gclient that tries to run the .bat file :\ Overall I think I'm happier with my all-cygwin

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Ojan Vafai
On Mon, Aug 10, 2009 at 3:12 AM, Jeremy Orlow jor...@chromium.org wrote: On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: 2. The show stopper for any implementation of this feature is that the machines running the layout tests don't have the pdbs for test_shell.

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 9:24 AM, Steve Vandebogartvand...@google.com wrote: Undoubtedly, there will be hundreds of themes, finding the same one you were using last week before you decided to try a different one will be a daunting task.  From a usability perspective, it seems to me that

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Ben Goodger (Google)
Seems like all of this can be done on the page. The nice property of the page is that there's room to show a preview of the theme, which in many cases is more memorable than the name. -Ben On Mon, Aug 10, 2009 at 10:02 AM, Aaron Boodmana...@chromium.org wrote: On Mon, Aug 10, 2009 at 9:24 AM,

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Peter Kasting
[Edit: right as I was going to send this, I see you seem to be thinking along similar lines.] You're right that a dropdown with the names of every theme the user has ever used is both unwieldy and unhelpful. How about this: We replace the Options buttons with a page with the 5 MRU themes

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 10:05 AM, Peter Kastingpkast...@google.com wrote: [Edit: right as I was going to send this, I see you seem to be thinking along similar lines.] You're right that a dropdown with the names of every theme the user has ever used is both unwieldy and unhelpful.  How about

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Jeremy Orlow
On Mon, Aug 10, 2009 at 9:59 AM, Ojan Vafai o...@chromium.org wrote: On Mon, Aug 10, 2009 at 3:12 AM, Jeremy Orlow jor...@chromium.org wrote: On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: 2. The show stopper for any implementation of this feature is that the

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Nicolas Sylvain
On Mon, Aug 10, 2009 at 10:35 AM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Aug 10, 2009 at 9:59 AM, Ojan Vafai o...@chromium.org wrote: On Mon, Aug 10, 2009 at 3:12 AM, Jeremy Orlow jor...@chromium.orgwrote: On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain

[chromium-dev] Re: Hyperlink-like UI element

2009-08-10 Thread Jens Alfke
The use of blue-underlined links for actions, as opposed to navigation, is unfortunately common in a number of Google's web UIs (like Sites and Docs.) I'm not sure what the official position is on it at Google, or among the web UI design community at large, but I personally think it's a

[chromium-dev] Re: How not to spend the day getting depot_tools, cygwin svn to play nicely...

2009-08-10 Thread Jens Alfke
On Aug 7, 2009, at 5:25 PM, Peter Kasting wrote: Yep. You MUST have the depot_tools svn ahead of the cygwin svn and use only that to check out Chromium. I thought we noted this somewhere... Thanks for the tip. I'm just going through this setup right now, though it sounds like I'll be

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread viettrungluu
[Still didn't make it to chromium-dev -- trying yet again. Sorry for any dupes.] Here's a slightly improved (well, much improved, in that it doesn't crash[*]) version, again if anyone wants to mess with it: http://codereview.chromium.org/165224 (pardon the ugly code). Unfortunately, it

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Viet-Trung Luu
Here's a slightly improved (well, much improved, in that it doesn't crash[*]) version, again if anyone wants to mess with it: http://codereview.chromium.org/165224 (pardon the ugly code). Unfortunately, it fails miserably at resolving many symbols (my implementation falls back to

[chromium-dev] Re: Hyperlink-like UI element

2009-08-10 Thread Evan Stade
I agree that Get Themes ought to be a link. There are other links in the options menu (Learn More, Manage Certificates), so I think this was just an oversight. -- Evan Stade On Mon, Aug 10, 2009 at 11:14 AM, Jens Alfkes...@google.com wrote: The use of blue-underlined links for actions, as

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Brian Rakowski
Yes, I wholeheartedly agree that these are gallery features. We should remove them from options/prefs panels. On Mon, Aug 10, 2009 at 11:09 AM, Avi Drissman a...@google.com wrote: On Mon, Aug 10, 2009 at 1:31 PM, Aaron Boodman a...@chromium.org wrote: Incidentally, two other asks: * When

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread stourw...@googlemail.com
As a user I don't mind going back to the gallery each time I want to change theme (and my mood will make me change themes regularly), but what is frustrating is that everytime I go back to one that I've tried in the past it redownloads the file again rather than using the .crx that is already

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Viet-Trung Luu
[I can't seem to get this reply to chromium-dev. Maybe it didn't like the Chinese characters in Albert's name? I hope N duplicates don't eventually show up on the list.] Here's a slightly improved (well, much improved, in that it doesn't crash[*]) version, again if anyone wants to mess with

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Viet-Trung Luu
I hereby hang my head in shame. :-( (Should have noticed the new members moderated bit) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: How not to spend the day getting depot_tools, cygwin svn to play nicely...

2009-08-10 Thread Andrew Scherkus
This thread couldn't have been more appropriately timed. I ran into the Error 34 issue again checking out a fresh client :\ Never again... http://codereview.chromium.org/164281 On Mon, Aug 10, 2009 at 11:17 AM, Jens Alfke s...@google.com wrote: On Aug 7, 2009, at 5:25 PM, Peter Kasting

[chromium-dev] Re: Do we have any existing code for reading/writing INI files?

2009-08-10 Thread Brett Wilson
On Mon, Aug 10, 2009 at 3:28 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Just wondering if there's any code kicking around somewhere in the codebase for reading/writing INI files? No, we don't deal with ini files at all to my knowledge. We use JSON for that type of thing. What do you need it

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Ojan Vafai
On Mon, Aug 10, 2009 at 1:39 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Mon, Aug 10, 2009 at 10:35 AM, Jeremy Orlow jor...@chromium.orgwrote: On Mon, Aug 10, 2009 at 9:59 AM, Ojan Vafai o...@chromium.org wrote: On Mon, Aug 10, 2009 at 3:12 AM, Jeremy Orlow jor...@chromium.orgwrote:

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

2009-08-10 Thread Aaron Boodman
On Mon, Aug 10, 2009 at 11:09 AM, Avi Drissmana...@google.com wrote: On Mon, Aug 10, 2009 at 1:31 PM, Aaron Boodman a...@chromium.org wrote: Incidentally, two other asks: * When installing a theme, give the user a way to switch back to the previous theme (e.g. an infobar).  We currently

[chromium-dev] build error, libavcodec.so.52

2009-08-10 Thread Paweł Hajdan Jr .
Just got this error: scons: *** [/chromium/src/sconsbuild/Debug/libavcodec.so.52] Source `/chromium/src/sconsbuild/Debug/obj/third_party/ffmpeg/binaries/chromium/libavcodec.so.52' not found, needed by target `/chromium/src/sconsbuild/Debug/libavcodec.so.52'. I'll try to workaround it, but it

[chromium-dev] Re: build error, libavcodec.so.52

2009-08-10 Thread Paweł Hajdan Jr .
Looks like gclient sync --force fixed that. I think something confused git while switching old branches. On Mon, Aug 10, 2009 at 17:04, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: Just got this error: scons: *** [/chromium/src/sconsbuild/Debug/libavcodec.so.52] Source

[chromium-dev] Re: build error, libavcodec.so.52

2009-08-10 Thread 王重傑
On the bright side, now you only download the binaries that make sense for your platform. :) -Albert On Mon, Aug 10, 2009 at 5:18 PM, Andrew Scherkus scher...@chromium.orgwrote: We shuffled these around on Friday such that these binaries now live in /deps/third_party/ffmpeg and are pulling in

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-10 Thread Bradley Nelson
Not that I know of. Too bad really...-BradN On Thu, Aug 6, 2009 at 10:56 PM, Mohamed Mansour m...@chromium.org wrote: What is stopping us doing Massive line endings commit for all the files in our repository in src/chrome. +1 on the presubmit check! Is there a way to force Visual Studio

[chromium-dev] Clobbering

2009-08-10 Thread Jeremy Orlow
We really need a better way to submit patches that we know require a clobber. Today alone, there were 2 WebKit deps rolls that we _knew_ would need a clobber. Both ended up closing the tree for a bit. What if we added an optional flag to the CL descriptions that tells the bots that a clobber is