[chromium-dev] Re: Is it possible to trigger JavaScript Garbage collection programatically

2009-08-13 Thread Mads Sig Ager
By default, it is not possible to trigger at V8 GC programatically. Use of such an API is tricky and most of the time you will end up slowing down instead of helping. For that reason, we have avoided exposing GC through the API. We do have a flag in V8 called expose-gc that adds a JavaScript

[chromium-dev] Rogers SMS login page does not save password

2009-08-13 Thread Gobbledegook
The option to save the password does not appear on the following login page: http://websms.rogers.page.ca/2way/ Chrome (3.0.197.11) only saves the password when settings are imported from Firefox which handles the password correctly. --~--~-~--~~~---~--~~

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Julian Harris
What about Cmd-Opt-H? On Wed, Aug 12, 2009 at 7:15 PM, Robert Sesek rse...@gmail.com wrote: Two things about the Mac history menu that I'd like people to weigh in on: 1. The Show All History command should have a keyboard shortcut. We can't use the logical Cmd+H because it's bound by the

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Nico Weber
cmd-opt-h is used by the os too (cmd-h: hide current app, cmd-opt-h: hide others). On Thu, Aug 13, 2009 at 8:08 AM, Julian Harrisk...@google.com wrote: What about Cmd-Opt-H? On Wed, Aug 12, 2009 at 7:15 PM, Robert Sesek rse...@gmail.com wrote: Two things about the Mac history menu that I'd

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Robert Sesek
On Thu, Aug 13, 2009 at 11:08, Julian Harris k...@google.com wrote: What about Cmd-Opt-H? Cmd+Opt+H is also bound by the system for Hide Others. 2. Currently, items in the history menu open in the current foreground tab. I'm currently working on a CL to make it so that if you hold down the

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread Marshall Greenblatt
On Wed, Aug 12, 2009 at 5:49 PM, Darin Fisher da...@chromium.org wrote: Yes, sorry about that. Please see render_view.cc. They are just implemented using WebFrame::executeCommand. Ah, I see. As an API consumer I would prefer to have separate methods for each supported command, or have

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Pam Greene
They always felt pretty different to me. In one case, I'm undoing something I did, and I expect the state to be restored to how it was. In the other, I'm initiating a new action, and I expect the behavior to be the same as for bookmarks. - Pam On Thu, Aug 13, 2009 at 6:50 AM, Mike Pinkerton

[chromium-dev] Re: Rogers SMS login page does not save password

2009-08-13 Thread Jeremy Orlow
This is not the right place to bring this up. http://new.crbug.com On Thu, Aug 13, 2009 at 3:51 AM, Gobbledegook aftabkha...@gmail.com wrote: The option to save the password does not appear on the following login page: http://websms.rogers.page.ca/2way/ Chrome (3.0.197.11) only saves the

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread Darin Fisher
Yeah, I agree. Those are problems. However, the intent is to match the set of commands reachable by script. The values for execCommand are well known. I also worry about having to keep the WebKit API in sync with WebCore. I agree that selectAll should be dropped in favor of

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread James Su
If I understand correctly, selectAll() and executeCommand(SelectAll) are different. The first one selects all text in the frame, while the second one selects all text in an editor (input box). Regards James Su 2009/8/14 Darin Fisher da...@chromium.org Yeah, I agree. Those are problems.

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread Darin Fisher
Oh, good catch. If that is indeed the case, then eliminating WebFrame::selectAll would be a mistake.-Darin On Thu, Aug 13, 2009 at 9:58 AM, James Su su...@chromium.org wrote: If I understand correctly, selectAll() and executeCommand(SelectAll) are different. The first one selects all text in

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread Marshall Greenblatt
On Thu, Aug 13, 2009 at 12:58 PM, James Su su...@chromium.org wrote: If I understand correctly, selectAll() and executeCommand(SelectAll) are different. The first one selects all text in the frame, while the second one selects all text in an editor (input box). Ok :-) Can we document this in

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread Marshall Greenblatt
On Thu, Aug 13, 2009 at 1:07 PM, Darin Fisher da...@chromium.org wrote: Hmm... take a look at EditorCommands.cpp. The executeSelectAll method just calls frame-selection()-selectAll(). That's the same method that WebFrameImpl::selectAll() calls. I just verified this in the debugger -- the

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Nico Weber
Robert: How about grabbing a random person, setting them in front of chromium, telling them I need you to do some UX testing for me. This is about testing the program and not about testing you, you cannot do anything wrong. Up here we have the history menu. What would you expect what happens if

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Glen Murphy
I think you'd need more than one person and twenty minutes. One person isn't going give you any useful data - this thread is full of one-persons. I happen to agree with Pink, though I think there should be less difference between History and Closed Items (I have a long running rant about how

[chromium-dev] Re: Halting JS execution in V8?

2009-08-13 Thread Erik Corry
2009/8/12 Drew Wilson atwil...@chromium.org: Hi all, It appears from looking at the worker code that if worker script enters into an infinite loop, the associated worker thread/process will never exit. The JavaScriptCore implementation uses the JSC timeoutChecker mechanism to halt script

[chromium-dev] The role of libv8 with Google chrome and Chromium on Linux

2009-08-13 Thread codfather
I noticed that the size of the installation of these two builds , Google Chrome 3.0.198.1 and Chromium 4.0.202.r23182 were considerably different, and was wondering do they both use the separate libv8 - r2650 library? Thanks Nick --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Nico Weber
…and repeat 3 times, for each version gives you six opinions – and uninvolved opinions, too. On Thu, Aug 13, 2009 at 10:43 AM, Glen Murphyg...@chromium.org wrote: I think you'd need more than one person and twenty minutes. One person isn't going give you any useful data - this thread is full

[chromium-dev] Re: The role of libv8 with Google chrome and Chromium on Linux

2009-08-13 Thread Adam Langley
On Thu, Aug 13, 2009 at 1:29 AM, codfatherswcodfat...@gmail.com wrote: I noticed that the size of the installation of these two builds , Google Chrome 3.0.198.1 and Chromium 4.0.202.r23182 were considerably different, and was wondering do they both use the separate libv8 - r2650 library? We

[chromium-dev] Chrome Core Product Principles

2009-08-13 Thread Ben Goodger (Google)
I've put together a brief document describing the core principles of the Chrome product and some of the ways we try and achieve them. http://dev.chromium.org/developers/core-principles Thanks to Ian Fette and John Grabowski for helping me fill this out. Feel free to edit if you have anything else

[chromium-dev] Re: Chrome Core Product Principles

2009-08-13 Thread Peter Kasting
On Thu, Aug 13, 2009 at 11:22 AM, Mike Beltzner beltz...@mozilla.comwrote: This is great, Ben. I hope you don't mind if I let this inspire me to update the Firefox Charter that you wrote back in 2004 with something similar :) I wholeheartedly support anything that makes Firefox better! To

[chromium-dev] gears:// and HTML dialogs

2009-08-13 Thread Tim Steele
Currently most of the code for showing HTML dialogs is hard-coded to the gears scheme (gears://), used by the 'Create Application Shortcuts' dialog. If you wanted to add another HTML dialog today, you would need to add a new scheme for the URL that points to the resource you would like to have

[chromium-dev] Re: gears:// and HTML dialogs

2009-08-13 Thread Tim Steele
On Thu, Aug 13, 2009 at 1:18 PM, Tim Steele t...@chromium.org wrote: and use a RenderViewHost directly. The personalization code used to do something like this using a thing I added called HWNDHtmlView. I think extensions used it for a while, and there was a bug+todo there to try and

[chromium-dev] Re: gears:// and HTML dialogs

2009-08-13 Thread Tim Steele
Thanks for the speedy response guys. I got the impression chrome-resource is coupled to the new tab page from stuff like this: // Special case the new tab page. In older versions of Chrome, the new tab // page was hosted at chrome-internal:blah. This might be in people's saved // sessions or

[chromium-dev] Star of the day

2009-08-13 Thread Dimitri Glazkov
I thought this is something I should mention here: This change: http://src.chromium.org/viewvc/chrome?view=revrevision=23244 reduced the number of crashes on Mac from 13-15 with high degree of flakiness to a very consistent 2. pkasting, this is your man. :DG

[chromium-dev] Re: Star of the day

2009-08-13 Thread Peter Kasting
On Thu, Aug 13, 2009 at 3:02 PM, Dimitri Glazkov dglaz...@google.comwrote: I thought this is something I should mention here: This change: http://src.chromium.org/viewvc/chrome?view=revrevision=23244 reduced the number of crashes on Mac from 13-15 with high degree of flakiness to a very

[chromium-dev] Re: gears:// and HTML dialogs

2009-08-13 Thread Matt Perry
On Thu, Aug 13, 2009 at 3:11 PM, Tim Steele t...@chromium.org wrote: On Thu, Aug 13, 2009 at 2:56 PM, Tim Steele t...@chromium.org wrote: Thanks for the speedy response guys. I got the impression chrome-resource is coupled to the new tab page from stuff like this: hm. make that

[chromium-dev] Re: date and time storage

2009-08-13 Thread Antony Sargent
Also, note that there's no guarantee we won't change this representation in the future. There is a proposed history API for our in-development extensions system, but it's not implemented yet: http://dev.chromium.org/developers/design-documents/extensions/history-api

[chromium-dev] Re: date and time storage

2009-08-13 Thread Antony Sargent
You can probably find the answer somewhere in http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/ http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/In particular, it looks like visit_database.cc uses Time::ToInternalValue(). Have a look at:

[chromium-dev] Re: gears:// and HTML dialogs

2009-08-13 Thread Ben Goodger (Google)
I think that rather than having a scheme that opens a dialog, we should make the HTML dialog open any URL you give it. Then you can just re-use chrome:// which is used by the NTP etc. -Ben On Thu, Aug 13, 2009 at 1:18 PM, Tim Steele t...@chromium.org wrote: Currently most of the code for

[chromium-dev] Re: Chrome Core Product Principles

2009-08-13 Thread Linus Upson
It would be nice to have something about memory consumption in the Speed section as well. Linus On Thu, Aug 13, 2009 at 12:04 PM, Darin Fisher da...@chromium.org wrote: Very nice! Some things I would add to the speed section: *How will my code perform when the operating system or hard disk

[chromium-dev] Re: selection methods removed from WebFrame

2009-08-13 Thread Darin Fisher
http://code.google.com/p/chromium/issues/detail?id=19270 (patches welcome!) On Thu, Aug 13, 2009 at 3:35 PM, James Su su...@chromium.org wrote: Oh yes, you are right. So it might be safe to remove selectAll(). Regards James Su 2009/8/14 Marshall Greenblatt magreenbl...@gmail.com On Thu,