[chromium-dev] Re: Chromium Linux 64-bit

2009-08-21 Thread Mads Sig Ager
We have focused on making the 64-bit version complete, so there is still some performance tuning to be done. Currently, the performance of the 64-bit version is pretty close to the performance of the 32-bit version when Chrome 2 stable was released. -- Mads On Thu, Aug 20, 2009 at 7:26 PM,

[chromium-dev] Re: Use git to checkout chromium source

2009-08-21 Thread hap 497
I guess this is the command to checkout Webkit source using git But I don't see 'git-chrome/src/DEPS' file when I checkout chromium source using git. And what is the purpose of the command 'git svn find-rev'? Isn't the code is already checkout using the 'git checkout -b $i' command? And what is

[chromium-dev] Re: Chromium Linux 64-bit

2009-08-21 Thread Mads Sig Ager
On Thu, Aug 20, 2009 at 7:17 PM, Marshall Greenblattmagreenbl...@gmail.com wrote: Out of curiosity, what work remains to support a 64bit build on Windows? V8 does not yet compile in 64-bit mode on Windows. We have focused on making the 64-bit version of V8 work on Linux and Mac at first. We

[chromium-dev] Re: WebKit API guidance?

2009-08-21 Thread Darin Fisher
It would be easier to recommend advice if I could see / review the code. Can you provide a link to the in-progress CL? -Darin On Thu, Aug 20, 2009 at 9:46 PM, Drew Wilson atwil...@chromium.org wrote: On Thu, Aug 20, 2009 at 8:39 PM, Darin Fisher da...@chromium.org wrote: On Thu, Aug 20,

[chromium-dev] Question about Browser IO thread

2009-08-21 Thread n179911
Hi, From this chromium document, http://sites.google.com/a/chromium.org/dev/developers/design-documents/multi-process-architecture Browser has an IO thread which receives messages from each Renderer process and dispatch them to Browser Process. But when I look at the code , the IOThread class

[chromium-dev] Re: Question about Browser IO thread

2009-08-21 Thread Adam Barth
You want to look at the MessageLoop and possibly RenderViewHost. Adam On Thu, Aug 20, 2009 at 11:27 PM, n179911n179...@gmail.com wrote: Hi, From this chromium document, http://sites.google.com/a/chromium.org/dev/developers/design-documents/multi-process-architecture Browser has an IO

[chromium-dev] Re: Question about Browser IO thread

2009-08-21 Thread Jeremy Orlow
What exactly are you trying to do? On Thu, Aug 20, 2009 at 11:27 PM, n179911 n179...@gmail.com wrote: Hi, From this chromium document, http://sites.google.com/a/chromium.org/dev/developers/design-documents/multi-process-architecture Browser has an IO thread which receives messages from

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread alenpeacock
On Aug 20, 5:40 pm, Dean McNamee de...@chromium.org wrote: This thread is massive.  Having been the one who wrote the majority of the Omnibox code on Linux, I can promise you that this debate has already happened about 15 times previously.  I'm not sure there is any more information here,

[chromium-dev] Re: Question about Browser IO thread

2009-08-21 Thread Evan Martin
On Thu, Aug 20, 2009 at 11:27 PM, n179911n179...@gmail.com wrote: But when I look at the code , the IOThread class in browser_process_impl.cc just contains below. It does not has any logic which dispatches messages. Can you please tell me if it is the right code? if not , can you please point

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Dean McNamee
A bug tracker is the right place to have this discussion, and I see you've filed 19508 which was closed WontFix. I appreciate your opinion and dedication to Linux. We have plenty of Linux users who have gotten adjusted to this behavior and prefer it. There is no clear answer, which is why

[chromium-dev] Re: Chromium Linux 64-bit

2009-08-21 Thread Joel Stanley
On Fri, Aug 21, 2009 at 01:14, Dean McNameede...@chromium.org wrote: The v8 team did some amazing work this quarter building a working 64-bit port.  After a handful of changes on the Chromium side, I've had Chromium Linux building on 64-bit for the last few weeks. This is awesome. You should

[chromium-dev] Re: Use git to checkout chromium source

2009-08-21 Thread Evan Martin
On Thu, Aug 20, 2009 at 8:42 PM, hap 497hap...@gmail.com wrote: But I don't understand how to use git to check out Webkit source which chromium depends on. Should I use 'git-svn'? If yes, what is the url for the repository? http://trac.webkit.org/wiki/UsingGitWithWebKit Note that it is your

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Dean McNamee
The Omnibox widget code is already very involved, and I don't think it is a good idea to add any more complexity or additional modes. Chromium of course is open source, which is a very hidden form of configuration. Good luck, -- dean On Fri, Aug 21, 2009 at 8:57 AM, JT Olds jto...@xnet5.com

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Evan Martin
The problem fundamentally comes down to matching an existing platform behavior versus try to do something better. I assert inline autocomplete and tabs on top fall strictly into the latter category, so you can't win an argument by just saying it matches the platform. Inline autocomplete is a

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread JT Olds
Can we please make it configurable? I hate the click once select all thing. It really drives me nuts. Chromium is so nice otherwise. I don't care how hidden of a configuration parameter it is, just so long as I can change it. On Fri, Aug 21, 2009 at 9:12 AM, Dean McNameede...@chromium.org

[chromium-dev] Re: WebKit API guidance?

2009-08-21 Thread Drew Wilson
Sure, although I've only just started (have only updated the code to reflect the changes to WorkerObjectProxy/WorkerContextProxy on the WebCore side, and am now cascading the changes down into the WebKit API/browser). http://codereview.chromium.org/173193 Thanks for the help, everyone. I think I

[chromium-dev] Re: Lock the Render process in chromium

2009-08-21 Thread Dean McNamee
Joel had some ideas about doing something like thing for power saving. On Thu, Aug 20, 2009 at 12:51 PM, Adam Langley a...@chromium.org wrote: On Thu, Aug 20, 2009 at 9:38 AM, n179911n179...@gmail.com wrote: I don't want the renderer process to die. I just want it 'locked' so that i can dump

[chromium-dev] Tab-modal dialog/sheet UI design document (long)

2009-08-21 Thread Viet-Trung Luu
Having played with my proof-of-concept for tab-modal file selection (etc.) sheets (CL: http://codereview.chromium.org/164547), I think it's time for a draft design document. I'd especially appreciate feedback from the UI people. Here goes Definitions: A tab-specific dialog box or sheet

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread JT Olds
Evan, I don't know if you already got this, sorry if you did, but it looks like it got lost somewhere. I guess I suck at Google Groups. The problem fundamentally comes down to matching an existing platform behavior versus try to do something better.  I assert inline autocomplete and tabs on

[chromium-dev] Re: Overloading operator for TimeDelta

2009-08-21 Thread Matt Perry
Defining operator is fine. Other types do this:

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Elliot Glaysher (Chromium)
On Fri, Aug 21, 2009 at 10:25 AM, JT Oldsjto...@xnet5.com wrote: It's a shame this is what is left on the table, but hooray for git-svn! FYI: don't use git-svn. We have a dedicated git mirror that you can clone and fetch from. Much, much faster. http://code.google.com/p/chromium/wiki/UsingGit

[chromium-dev] Re: [HTML5] Please add HTML5 to your bugs

2009-08-21 Thread Jon
When I sync issues from WebKit they will get the label HTML5 if they have the keyword HTML5 in their Bugzilla database. However, I will add the label OWP so we can have simple searches on our side. Jon On Mon, Aug 17, 2009 at 1:20 PM, Andrew Scherkus scher...@chromium.orgwrote: That works for

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Mohamed Mansour
Let me summarize what you all have stated: - ALT: Highlight App menu button - ALT-P: Show Page menu - ALT-A: Show App menu or.. - ALT: Highlight App menu button - ALT-P: Highlight Page menu button - ALT-A: Highlight App menu button First set or second set? Thanks! -

[chromium-dev] Handling layout test expectations for failing tests

2009-08-21 Thread Dirk Pranke
Hi all, As Glenn noted, we made great progress last week in rebaselining the tests. Unfortunately, we don't have a mechanism to preserve the knowledge we gained last week as to whether or not tests need to be rebaselined or not, and why not. As a result, it's easy to imagine that we'd need to

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Jeremy Orlow
On Fri, Aug 21, 2009 at 1:00 PM, Dirk Pranke dpra...@chromium.org wrote: Hi all, As Glenn noted, we made great progress last week in rebaselining the tests. Unfortunately, we don't have a mechanism to preserve the knowledge we gained last week as to whether or not tests need to be

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Mohamed Mansour
I really want to name it tools as Peter stated, If anyone has any objections, please let me know, it will now be: ALT-T = Tools Menu (previously known as App menu) ALT-P = Page Menu. The only difference within these sets is that within the first set, it shows the menu (the menu popup will be

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Peter Kasting
On Fri, Aug 21, 2009 at 1:17 PM, Mohamed Mansour m...@chromium.org wrote: I really want to name it tools as Peter stated, If anyone has any objections, please let me know, it will now be: ALT-T = Tools Menu (previously known as App menu) ALT-P = Page Menu. The only difference within these

[chromium-dev] Cross-compiling on ARM

2009-08-21 Thread Antoine Labour
There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's make sure everyone is on the same page so that we don't duplicate efforts. I understand that Joel Stanley, Dean McNamee and Lei Zhang have already been doing a lot of work towards that. There's

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Dean McNamee
On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's make sure everyone is on the same page so that we don't duplicate efforts. I understand that Joel Stanley, Dean

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Peter Kasting
On Fri, Aug 21, 2009 at 11:41 AM, Mohamed Mansour m...@chromium.org wrote: Let me summarize what you all have stated: - ALT: Highlight App menu button - ALT-P: Show Page menu - ALT-A: Show App menu or.. - ALT: Highlight App menu button - ALT-P: Highlight Page menu button

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread alenpeacock
On Aug 21, 10:17 am, Dean McNamee de...@chromium.org wrote: The Omnibox widget code is already very involved, and I don't think it is a good idea to add any more complexity or additional modes. ...but, wait a sec, Chromium on OSX seems to do exactly the right thing (for both Mac and Linux).

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Lei Zhang
On Fri, Aug 21, 2009 at 2:25 PM, Dean McNameede...@chromium.org wrote: On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: - Gyp uses pkg-config to find includes/lib dependencies, i.e. it's going to look at the host for them. If your target distribution matches your host

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Antoine Labour
On Fri, Aug 21, 2009 at 2:46 PM, Dean McNameede...@chromium.org wrote: On Fri, Aug 21, 2009 at 2:34 PM, Lei Zhang thes...@chromium.org wrote: On Fri, Aug 21, 2009 at 2:25 PM, Dean McNameede...@chromium.org wrote: On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: - Gyp

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Antoine Labour
On Fri, Aug 21, 2009 at 2:45 PM, Erik Corryerik.co...@gmail.com wrote: 2009/8/21 Antoine Labour pi...@google.com: There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's make sure everyone is on the same page so that we don't duplicate efforts.

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Dean McNamee
On Fri, Aug 21, 2009 at 2:58 PM, Antoine Labour pi...@google.com wrote: On Fri, Aug 21, 2009 at 2:45 PM, Erik Corryerik.co...@gmail.com wrote: 2009/8/21 Antoine Labour pi...@google.com: There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Dean McNamee
Note: Firefox on OSX selects all on single click. So there isn't a clear answer on OSX either. On Fri, Aug 21, 2009 at 2:52 PM, Dean McNamee de...@chromium.org wrote: On Fri, Aug 21, 2009 at 12:18 PM, alenpeacock alenlpeac...@gmail.com wrote: On Aug 21, 10:17 am, Dean McNamee

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Evan Martin
This seems to me like a lot more work for minimal gain. Because you've thought more about it than I have, it makes me think I'm misunderstanding something. Can you explain this more simply, in terms of use cases? Here's what I think you're saying: 1) We don't have notes on why tests are

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Dan Kegel
On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labourpi...@google.com wrote: - Gyp uses pkg-config to find includes/lib dependencies, i.e. it's going to look at the host for them. If your target distribution matches your host maybe you're fine, but it may not work at all, so it'd would be good to

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Erik Corry
2009/8/21 Antoine Labour pi...@google.com: There's growing interest from several parties in getting Chrome to cross-compile onto linux/ARM. Let's make sure everyone is on the same page so that we don't duplicate efforts. I understand that Joel Stanley, Dean McNamee and Lei Zhang have

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Dean McNamee
On Fri, Aug 21, 2009 at 2:34 PM, Lei Zhang thes...@chromium.org wrote: On Fri, Aug 21, 2009 at 2:25 PM, Dean McNameede...@chromium.org wrote: On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: - Gyp uses pkg-config to find includes/lib dependencies, i.e. it's going to

[chromium-dev] Survey: Gathering our core team principles!

2009-08-21 Thread Ben Goodger (Google)
I'm trying to get a sense for what people perceive as the core team values of Chromium, and I would like to enlist everyone in helping figuring it out. Basically, I want to put together a small set of core values and a variety of example actions that support (or detract from) those values. A

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Stuart Morgan
On Fri, Aug 21, 2009 at 3:36 PM, Dean McNameede...@chromium.org wrote: Note: Firefox on OSX selects all on single click.  So there isn't a clear answer on OSX either. Firefox has historically tended to favor do what Firefox does on other platforms over follow the platform standard. In other

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Stuart Morgan
On Fri, Aug 21, 2009 at 4:12 PM, Dean McNameede...@chromium.org wrote: My argument was just that I know of only 2 frequently used URL bars in browser.  Safari, and Firefox.  They differ in their behavior.  I don't know how you have an established standard when you only have a few reference

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Pam Greene
At least in the batch of tests I examined, the ones that needed re-baselining weren't tests we'd originally failed and suddenly started passing. They were new tests that nobody had ever taken a good look at. If that matches everyone else's experience, then all we need is an UNTRIAGED annotation

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Peter Kasting
As others have said, this thread has been beaten into the ground, and before it we had 15 other threads get beaten into the ground. Various relevant stakeholders such as beng, glen, pinkerton, etc. have been conversed with, and while we are interested in getting more data (see the bug I filed)

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Peter Kasting
On Fri, Aug 21, 2009 at 2:33 PM, Pam Greene p...@chromium.org wrote: I'm not convinced that passing tests we used to fail, or failing tests differently, happens often enough to warrant the extra work of producing, storing, and using expected-bad results. Of course, I may be completely wrong.

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Dirk Pranke
On Fri, Aug 21, 2009 at 4:47 PM, Peter Kastingpkast...@chromium.org wrote: On Fri, Aug 21, 2009 at 2:33 PM, Pam Greene p...@chromium.org wrote: I'm not convinced that passing tests we used to fail, or failing tests differently, happens often enough to warrant the extra work of producing,

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Dean McNamee
On Fri, Aug 21, 2009 at 12:18 PM, alenpeacock alenlpeac...@gmail.com wrote: On Aug 21, 10:17 am, Dean McNamee de...@chromium.org wrote: The Omnibox widget code is already very involved, and I don't think it is a good idea to add any more complexity or additional modes.  ...but, wait a sec,

[chromium-dev] Chromium / Google Summer of Code

2009-08-21 Thread Lei Zhang
With the Google Summer of Code program winding down, I'm curious how our GSoC participants are doing. Can the students and their mentors share their experiences? (Assuming you're all done with evaluations and all that.) --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] [Linux folks] Splitting First Run into it's own process

2009-08-21 Thread Jeremy Moskovich
I'm looking at splitting the First Run UI import machinery into it's own process on OS X. I just wanted to sync up with people working on the Linux side of things to make sure no-one else is working on the same thing in Linux-land? Best regards, Jeremy

[chromium-dev] Re: [Linux folks] Splitting First Run into it's own process

2009-08-21 Thread Rahul Kuchhal
AFAIK no one is working on it for Linux. On Fri, Aug 21, 2009 at 5:11 PM, Jeremy Moskovich jer...@chromium.orgwrote: I'm looking at splitting the First Run UI import machinery into it's own process on OS X. I just wanted to sync up with people working on the Linux side of things to make

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread alenpeacock
On Aug 21, 4:36 pm, Dean McNamee de...@chromium.org wrote: Note: Firefox on OSX selects all on single click.  So there isn't a clear answer on OSX either. According to Gruber, this is badly broken: http://daringfireball.net/2008/04/firefox_3_safari_3 LOCATION FIELD — The new Firefox 3

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

2009-08-21 Thread Dean McNamee
On Fri, Aug 21, 2009 at 4:01 PM, Stuart Morgan stuartmor...@chromium.org wrote: On Fri, Aug 21, 2009 at 3:36 PM, Dean McNameede...@chromium.org wrote: Note: Firefox on OSX selects all on single click.  So there isn't a clear answer on OSX either. Firefox has historically tended to favor do

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Peter Kasting
On Fri, Aug 21, 2009 at 4:50 PM, Dirk Pranke dpra...@chromium.org wrote: This is all good feedback, thanks! To clarify, though: what do you think the cost will be? Perhaps you are assuming things about how I would implement this that are different than what I had in mind. Some amount of your

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Ojan Vafai
On Fri, Aug 21, 2009 at 4:54 PM, Peter Kasting pkast...@chromium.orgwrote: On Fri, Aug 21, 2009 at 4:50 PM, Dirk Pranke dpra...@chromium.org wrote: This is all good feedback, thanks! To clarify, though: what do you think the cost will be? Perhaps you are assuming things about how I would

[chromium-dev] Re: [Linux folks] Splitting First Run into it's own process

2009-08-21 Thread Evan Martin
What's the motivation? On Fri, Aug 21, 2009 at 5:11 PM, Jeremy Moskovichjer...@chromium.org wrote: I'm looking at splitting the First Run UI import machinery into it's own process on OS X. I just wanted to sync up with people working on the Linux side of things to make sure no-one else is

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Dirk Pranke
On Fri, Aug 21, 2009 at 6:43 PM, Ojan Vafaio...@chromium.org wrote: On Fri, Aug 21, 2009 at 4:54 PM, Peter Kasting pkast...@chromium.org wrote: On Fri, Aug 21, 2009 at 4:50 PM, Dirk Pranke dpra...@chromium.org wrote: This is all good feedback, thanks! To clarify, though: what do you think

[chromium-dev] Re: Handling layout test expectations for failing tests

2009-08-21 Thread Jeremy Orlow
On Fri, Aug 21, 2009 at 2:33 PM, Pam Greene p...@chromium.org wrote: At least in the batch of tests I examined, the ones that needed re-baselining weren't tests we'd originally failed and suddenly started passing. They were new tests that nobody had ever taken a good look at. If that matches

[chromium-dev] Re: Question about how to skip a directory in gclient sync

2009-08-21 Thread hap 497
Sorry, I find out answer to my problem. I need to put the directory name same as the ones listed in DEPS. On Fri, Aug 21, 2009 at 10:07 PM, hap 497 hap...@gmail.com wrote: Hi, I have added 'src/third_party/WebKit/WebKit: None,' to my .gclient file. But when I do 'gclient sync', it

[chromium-dev] Question about how to skip a directory in gclient sync

2009-08-21 Thread hap 497
Hi, I have added 'src/third_party/WebKit/WebKit: None,' to my .gclient file. But when I do 'gclient sync', it still tries to sync up a subdirectory 'mac', under src/third_party/WebKit/WebKit. $ gclient sync found .git directory; skipping src svn: