I see. Yeah, we've had to deal with the quit asap issues in other cases
too. For example, the host resolver uses detached threads so that it can
simply leak a thread that is stuck on a getaddrinfo call. (FF does the same
thing.)
-Darin
On Wed, Sep 23, 2009 at 10:30 PM, Tim Steele
Yes, please!! The srcdir should not be littered with output from the build
system. (At least it should be an option.)-Darin
On Wed, Sep 23, 2009 at 2:56 PM, Evan Martin e...@chromium.org wrote:
We need builddir != srcdir. sgk was working on it, I helped with a
patch, not sure what became
Do websites provide users with previous versions after overhauling their UX?
Some do (gmail seems to), but most do not. You just get to surf the
latest. Hopefully, the website changes for the better. That's our burden
to bear.
-Darin
On Wed, Sep 23, 2009 at 8:59 PM, Mike Belshe
I think the tools should support your use of tags, but thanks for switching
back to tr...@version.
-Darin
On Thu, Sep 24, 2009 at 12:12 AM, Mads Sig Ager a...@chromium.org wrote:
I think something else is going on here as well. The changes you are
talking about making sounds great though,
I think something else is going on here as well. The changes you are
talking about making sounds great though, so please do!
The increased number of issues with V8 updates was caused by the V8
team and I should have sent an email about it. We changed the DEPS
file to pull V8 from
Hi,
Chromium Mac (valgrind) and I just had a good time. The bot is green now,
but some tests still finish as FAILED (they just don't leak). Most of
them were in that state before my CL made me look into this. Most of
the failing tests seem to be related to NSPasteboard.
1. Does the valgrind
On Thu, Sep 24, 2009 at 12:11 AM, Darin Fisher da...@chromium.org wrote:
Do websites provide users with previous versions after overhauling their
UX? Some do (gmail seems to), but most do not. You just get to surf the
latest. Hopefully, the website changes for the better. That's our burden
If you're already in there, go ahead.
Thanks,
Avi
On Wed, Sep 23, 2009 at 9:32 PM, Dirk Pranke dpra...@google.com wrote:
I think this plan sounds good, too.
I'm mucking with those scripts a bit at the moment for the LTTF
reporting, so I can make this change tomorrow, unless someone else
I had assumed that test_shell was also going to be modified, in order to
produce IMAGEFAIL or TEXTFAIL automatically in regressions.txt. So
it wouldn't require any intervention other than a first pass through
test_expectations.txt to mark the partial failures. I'm sure how often
IMAGEFAIL - FAIL
We've got a bug that covers some strange issues with pasteboards on
the valgrind bot, but the exact bug escapes me. Were you seeing
outright test failures or new leaks?
I think Mark was poking into it at one point, but I don't think we got
anywhere closer to resolving the underlying issue.
On
Test failures. This is from an old run:
[--] Global test environment tear-down
[==] 981 tests from 219 test cases ran. (908043 ms total)
[ PASSED ] 978 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] AutocompleteTextFieldEditorTest.CutCopyTest
[ FAILED ]
Yes, I was poking this a little bit last week, and a little bit the
week before. It seems that under Valgrind, tests involving the
pasteboard, and maybe a couple of other things too, will always fail.
In some cases, the test failures result in certain things not being
cleaned up, which in turn
At work today, I talked to the CEO of my company to ship Chrome browser with
all our Kiosk's and recommended Chrome to be our default browser for our web
products. I bench marked our current web applications with Chrome (ToT) vs
IE 7, and our applications run at average 10 times faster. (For
We still have problems with resources, examples:
[FATAL:tab_renderer.cc(132)] Check failed:
waiting_animation_frames-width() % waiting_animation_frames-height()
== 0.
[FATAL:image_operations.cc(373)] Check failed: rgb.width() == alpha.width().
[FATAL:resource_bundle_win.cc(155)] Check failed:
On Thu, Sep 24, 2009 at 3:03 PM, Paweł Hajdan Jr.
phajdan...@chromium.org wrote:
We still have problems with resources, examples:
[FATAL:tab_renderer.cc(132)] Check failed: waiting_animation_frames-width()
% waiting_animation_frames-height() == 0.
[FATAL:image_operations.cc(373)] Check
I don't think this is just about ignoring image-only results on mac for the
short-term. My subjective sense is that we have many tests that start out as
failing only image comparisons (e.g. due to theming), but over time another
failure creeps in that causes a text failure that goes unnoticed.
Which build was this? I checked in a change that changes how grit
generates IDs. This type of change requires a clobber since I don't
think we depend on all the grit .py files. I think these changes are
rare enough that we can just clobber as needed.
On Thu, Sep 24, 2009 at 12:03 PM, Paweł
You can't clobber when it's flaky. I think I can extract the build ID from
the flakiness report...
On Thu, Sep 24, 2009 at 12:19, Tony Chang t...@chromium.org wrote:
Which build was this? I checked in a change that changes how grit
generates IDs. This type of change requires a clobber since
Right--the question is for the long term if this will be a useful feature to
keep around or if we'll be dropping it once the Mac tests work. I'll take
the change either way but I can appreciate the extra granularity that this
would provide.
Pam:
having a way to say oh, it's 'only' the image
On Thu, Sep 24, 2009 at 3:19 PM, Tony Chang t...@chromium.org wrote:
Which build was this? I checked in a change that changes how grit
generates IDs. This type of change requires a clobber since I don't
think we depend on all the grit .py files. I think these changes are
rare enough that
I've shared a document with you:
[HTML5] registerProtocolHandler API
http://docs.google.com/Doc?docid=0AVgZ1iILHLkdZGQ0bjd6cTVfMGdqZmpiNGZrhl=eninvite=CI6z8vgG
It's not an attachment -- it's stored online at Google Docs. To open this
document, just click the link above.
This is a design
On Thu, Sep 24, 2009 at 3:11 PM, Ojan Vafai o...@chromium.org wrote:
I don't think this is just about ignoring image-only results on mac for
the short-term. My subjective sense is that we have many tests that start
out as failing only image comparisons (e.g. due to theming), but over time
Hi All,
I'm trying to debug the leak of CachedResource objects in test_shell. Every
time I browse to a page that contains an image or CSS file a new
CachedResource object is created in Cache.cpp createResource(). However,
none of these objects are ever freed. Does anyone happen to know
On Tue, Sep 22, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote:
On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek j...@chromium.org
wrote:
Is this even possible? i.e. I had uploaded a WebKit patch on codereview
but
none of the patchsets got run on the try server
Yes.
With git:git try -b bot --webkit webkit branch chromium branch
With gcl:
Manually create a patch by concatenating two (chromium + webkit) patches.
Make sure that the webkit patches have the right prefixes by using
--src-prefix=src/third_party/WebKit --dst-prefix=src/third_party/WebKit on
On Thu, Sep 24, 2009 at 1:49 PM, Yaar Schnitman y...@chromium.org wrote:
Yes.
With git:git try -b bot --webkit webkit branch chromium branch
With gcl:
Manually create a patch by concatenating two (chromium + webkit) patches.
Make sure that the webkit patches have the right prefixes by
Before we start enforcing penalties for people who screw this up, we need to
do some tools work to make this less error prone/manual-hackery, I think.
-atw
On Thu, Sep 24, 2009 at 1:56 PM, Steve Vandebogart vand...@chromium.orgwrote:
On Thu, Sep 24, 2009 at 1:49 PM, Yaar Schnitman
Maybe this is something that one of the task forces should address?
On Thu, Sep 24, 2009 at 2:20 PM, Marc-Antoine Ruel mar...@chromium.orgwrote:
Thanks for proposing yourself in improving gcl.py and trychange.py.
On Thu, Sep 24, 2009 at 5:18 PM, Drew Wilson atwil...@chromium.org
wrote:
Why the snark? Is it inappropriate to point out pain points in a proposed
process without attaching a patch to my email?
As someone who happily spent an hour+ yesterday tracking down an obscure bug
in trychange.py, I don't think I'm someone who just sits on the sidelines
making work for other
The src/chrome_frame/tools/test/reference_build directory takes ages
to svn up, is there a way to skip it? I don't think I really need all
those .dll and .exe files on Linux anyway...
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
Have you considered using Google Chrome Frame instead? That would let
you keep all your existing IE7 integration points but have the
rendering speed up by the factor of 10 that you cited.
Adam
On Thu, Sep 24, 2009 at 11:37 AM, Mohamed Mansour m...@chromium.org wrote:
At work today, I talked
That wasn't meant to be snarky at all! Contributions are always appreciated.
One thing that is helpful is filing feature request (and assigning
them to me) so I can better prioritize the feature request and not
forget about them.
M-A
On Thu, Sep 24, 2009 at 5:25 PM, Drew Wilson
On Thu, Sep 24, 2009 at 12:24, Thomas Van Lenten thoma...@chromium.orgwrote:
Brad landed support for depending on all the python files that go into
grit, so that part would have worked. The not always rebuilding for .h
files is the problem.
Does it mean we're missing some deps in the gyp
We have already scolded Alex about this, but it's too late now.
Repeat PSA: plz to not be dumping large Windows binaries into the
tree. We have DEPS for a reason.
On Thu, Sep 24, 2009 at 3:20 PM, Michael michael.monr...@gmail.com wrote:
The src/chrome_frame/tools/test/reference_build
IIRC, someone asked this a couple months ago. I believe the answer was
that http://code.google.com/p/chromiumembedded/ might be of interest.
I could see patches being welcome as long as they were fairly clean. I know
that's not an official answer, but you're probably not going to get a
yes from
I just ran a build here at home on my i7 workstation. It took 14
minutes. This is the same system that would build in 7 minutes when I
set it up in May.
What gives? We need to figure this out ASAP.
-Ben
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
Hey Ben, same here ... I see this additional message today (havn't seen it
before) 59LINK : C:\Sandbox\Code\Chrome\src\chrome\Debug\chrome.dll not
found or not built by the last incremental link; performing full link
Changing one file used to take me 5 minutes to build. But now it takes me
~10-15
Not sure, but it's possible shutting off precompiled headers is part of it.
In addition, I'm sure the code base has grown. It'd be interesting to know
how many lines of code there are now vs. then.
Even if those are major contributors, I'd find it surprising if they were
enough to double the
I think in our current model, the outside entity that wants to sync
stuff with us needs to maintain a separate copy of their data. In the
future, if we sync other types, i'm not sure whether they want to do
that or not. If that's true, then we don't really need to provide a
read write lock.
+Adding back chromium-dev
-Munjal
On Wed, Sep 23, 2009 at 5:22 PM, Munjal Doshi mun...@chromium.org wrote:
I am not sure. But it doesn't seem crazy to use sync data as a database
directly for certain data types.
-Munjal
On Wed, Sep 23, 2009 at 5:04 PM, Jonathan Huang ch...@google.com
Hi,
I'm writing some unittests in test_shell_tests. Some of the tests need to
run on the IO thread, but test_shell_tests uses the UI thread for its tests.
Can anyone point me to some sample code (preferably a test_shell_test) that
uses an IO thread in the test?
So far, what I've tried is
Preliminary feedback shows that people are having a hard time fully
embracing the new tab page. While they love the fact that now they can move,
pin, hide thumbnails, other more vocal users are really missing the
customized search boxes. We'll continue to monitor.
On Wed, Sep 23, 2009 at 10:43
Answering my own question:
* Don't use ScopedRunnableMethodFactory to create a task to be run on a
different thread. Either create a subclass of RefCountedThreadSafe or Task
to PostTask() to a different thread. Do not make the test class a subclass
of RefCountedThreadSafe as the GTest code will
On Thu, Sep 24, 2009 at 9:46 PM, Jenn Braithwaite (胡慧鋒)
je...@google.com wrote:
Answering my own question:
* Don't use ScopedRunnableMethodFactory to create a task to be run on a
different thread.
Yeah, that doesn't work. If you can think of more DCHECKs we can add
to help you figure that
On Thu, Sep 24, 2009 at 9:57 PM, Adam Barth aba...@chromium.org wrote:
On Thu, Sep 24, 2009 at 9:46 PM, Jenn Braithwaite (胡慧鋒)
je...@google.com wrote:
Answering my own question:
* Don't use ScopedRunnableMethodFactory to create a task to be run on a
different thread.
Yeah, that doesn't
On Thu, Sep 24, 2009 at 11:37 AM, Mohamed Mansour m...@chromium.org wrote:
At work today, I talked to the CEO of my company to ship Chrome browser
with all our Kiosk's and recommended Chrome to be our default browser for
our web products. I bench marked our current web applications with Chrome
I think you should really consider embedding chrome frame ActiveX in your
own simple shell. That will not only enable the application to be started
with desired real estate and get rid of status bubble but allow you to
customize it further if needed.
On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher
On Thu, Sep 24, 2009 at 10:32 PM, Adam Barth aba...@chromium.org wrote:
On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher da...@chromium.org wrote:
Maybe I'm in the minority, but it doesn't sound that unreasonable to support
command line options for disabling the status bubble and starting in
Chrome Frame is a good option, but you'd still need a way to turn off some
features. For example, a kiosk probably doesn't want to have a context
menu.
-Darin
On Thu, Sep 24, 2009 at 10:24 PM, Amit Joshi a...@chromium.org wrote:
I think you should really consider embedding chrome frame
Actually, ChromeFrame is not yet an option on Mac or Linux.-Darin
On Thu, Sep 24, 2009 at 10:47 PM, Darin Fisher da...@chromium.org wrote:
Chrome Frame is a good option, but you'd still need a way to turn off some
features. For example, a kiosk probably doesn't want to have a context
menu.
On Thu, Sep 24, 2009 at 10:47 PM, Darin Fisher da...@chromium.org wrote:
Chrome Frame is a good option, but you'd still need a way to turn off some
features. For example, a kiosk probably doesn't want to have a context
menu.
Chrome Frame can/will offer control over the context menu. This is
51 matches
Mail list logo
