This is a work in progress, according to some recent (few days) change
lists. Someone currently goes over most of the sources and lint cleans them
in preparation for adding the lint check to the presubmit check, or
something like that.
☆PhistucK
On Tue, Nov 17, 2009 at 07:48, Peter Kasting
Very cool, Steven, thanks a lot.
Two notes:
1) I cannot see Dromaeo benchmark;
2) is it possible to make column titles sticky? I mean that when you
scroll down and don't see nor footer, nor header, it's hard to tell
the flavour of each graph in the raw.
And just an observation. At least for
OK, so I am trying with Visual C++ 2005 Express. After working around most
of the errors, I got one (hopefully...) left -
fatal error LNK1104: cannot open file ‘atl.lib’ chrome_dll
The last error that I resolved before that, was almost the same, but “atlz”
instead of “atl” in the file name.
So I
On Nov 13, 2009, at 1:05 PM, Chase Phillips wrote:
Thanks for the feedback. gcl no longer requires --force to create CL in a
read-only checkout.
It wasn't actually a read-only checkout. WebKit doesn't use a separate URL for
the writeable repo; after you get commit privileges, your repo is
Automatically closing tree for unit_tests on Mac10.5 Tests
http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/8528
http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.5%20Tests
--= Automatically closing tree for unit_tests on Mac10.5 Tests =--
Glad to see you back, gatekeeper!
chase++
On Tue, Nov 17, 2009 at 12:29 PM, build...@chromium.org wrote:
http://build.chromium.org/buildbot/waterfall/
Automatically closing tree for unit_tests on Mac10.5 Tests
Hi,
I noticed that SKIA is by default using floating point calculation
inside android. Does this mean that if the CPU has VFP unit, SKIA will
run faster?
I asked this due to my interest in JPEG viewer on android which is
based on SKIA + libjpeg. Will VFP unit boost this application as well?
2009/11/16 Evan Martin e...@chromium.org
I spent some quality time with nm. With it I can take a release
binary (so all the inlining and optimizations like dead code removal
have been done) and display symbol sizes as well as which file they're
from.
My Release Linux build stripped is
On Mon, Nov 16, 2009 at 11:19 PM, Andy Quan androidr...@gmail.com wrote:
Hi,
I noticed that SKIA is by default using floating point calculation
inside android. Does this mean that if the CPU has VFP unit, SKIA will
run faster?
I asked this due to my interest in JPEG viewer on android which
Chromium developers,
I have just submitted a PRESUBMIT.py for chrome/ which will run
cpplint.py on your change as part of the presubmit process. cpplint is
currently run at reduced strictness--cpplint run separately may
generate more errors[1]. Currently, it only runs it at (gcl/git cl)
upload
To be clear, it'll be a warning prompt on commit, not an error. You
can say (y)es to continue.
M-A
On Tue, Nov 17, 2009 at 2:16 PM, Elliot Glaysher (Chromium)
e...@chromium.org wrote:
Chromium developers,
I have just submitted a PRESUBMIT.py for chrome/ which will run
cpplint.py on your
On Tue, Nov 17, 2009 at 11:16 AM, Elliot Glaysher (Chromium)
e...@chromium.org wrote:
Currently, it only runs it at (gcl/git cl)
upload time and only generates warnings. In the future, it should
error at commit time, but I want to put this through a trial period so
please pay attention to
On Tue, Nov 17, 2009 at 11:29 AM, Peter Kasting pkast...@google.com wrote:
There are some unittests where we have super-long bits which go over 80
chars, and there are also some where the linter thinks our indenting is
strange when we do something like:
struct Foo { ... };
Foo foo_cases[] = {
On Tue, Nov 17, 2009 at 11:31 AM, Nico Weber tha...@google.com wrote:
Is cpplint the thing that generates the lint errors column on codereview?
If so, it doesn't work very well for objective-c++ files (.mm) and .h files
that contain objc++ declarations.
The PRESUBMIT.py file only runs on cc
On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin ev...@google.com wrote:
Since we're talking about style, I'll note that this pattern is no
good (and I've seen it explicitly called out somewhere before).
The problem is that your assertions are not helpful. You get
expected 'foo', got 'bar' on
On Tue, Nov 17, 2009 at 20:43, Peter Kasting pkast...@google.com wrote:
On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin ev...@google.com wrote:
Since we're talking about style, I'll note that this pattern is no
good (and I've seen it explicitly called out somewhere before).
The problem is
Automatically closing tree for compile on Chromium Mac Builder
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac%20Builder/builds/7073
http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Mac%20Builder
--= Automatically closing tree for compile on
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
On Wed, Nov 18, 2009 at 05:23, Antoine Labour pi...@google.com wrote:
That's really a question for the Android team, not Chromium...
As far as Chrome's use of Skia, if you compile for ARMv7, you'll get NEON
acceleration when available.
Except that the tree won't build for ARM, because we don't
On Tue, Nov 17, 2009 at 3:02 PM, Joel Stanley j...@chromium.org wrote:
On Wed, Nov 18, 2009 at 05:23, Antoine Labour pi...@google.com wrote:
That's really a question for the Android team, not Chromium...
As far as Chrome's use of Skia, if you compile for ARMv7, you'll get NEON
acceleration
On Tue, Nov 17, 2009 at 10:49 AM, Jonathan Dixon j...@chromium.org wrote:
This is tangential to the core of your question, but just to check, are
asserts disabled on linux release builds?
This is a good thing to check! But it looks like they are.
There are numerous calls to ASSERT within the
Hey all --
I'm trying to get an understanding of the history system and there is
one thing that I can't seem to figure out. Each visit that gets added
to the visits database table can get assigned a segment_id (a foreign
key to the segments table, stating that the visit is part of a
particular
Automatically closing tree for compile on Webkit Linux (valgrind)
http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux%20%28valgrind%29/builds/6483
http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Linux%20%28valgrind%29
--= Automatically closing tree for
Automatically closing tree for unit_tests on XP Tests (dbg)(1)
http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20%28dbg%29%281%29/builds/15667
http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Tests%20%28dbg%29%281%29
--= Automatically closing tree for
Heads up to explain the sudden jump on Linux Startup perf test.
I just submitted r32264 which makes opening and closing processes happen off
the UI thread. Surprisingly enough, according to UMA stats these would take
an average of 1s on Linux for the first renderer, and 100ms on Windows.
25 matches
Mail list logo
