[chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656

2010-01-21 Thread Marc-Antoine Ruel
[+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): -

Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656

2010-01-21 Thread Marc-Antoine Ruel
at 9:36 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: [+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last

Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656

2010-01-21 Thread Marc-Antoine Ruel
With regards to BookmarkContextMenuTest.DeleteURL, I filed http://crbug.com/32784. Glen, you should make sure this bug is triaged accordingly since flaky crashers can't be tolerated. M-A On Thu, Jan 21, 2010 at 9:45 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: Clobber Done. On Thu, Jan

[chromium-dev] Build exceptions

2010-01-08 Thread Marc-Antoine Ruel
Don't panic with the main waterfal, it's just a hotpatch to fix an exception that ... generated more exceptions. At least, the original exception is fixed. So I'll just restart the master to make sure nothing dangling is left. M-A -- Chromium Developers mailing list:

Re: [chromium-dev] Missing symbols for Chrome 3.0.195.38

2010-01-04 Thread Marc-Antoine Ruel
FYI, the symbols were added on Dec 30. http://build.chromium.org/buildbot/symbols/3.0.195.38/chrome_dll.pdb http://build.chromium.org/buildbot/symsrv/chrome_dll.pdb/A94BABB37F7A4445A7A2C7BC2B796FD81/chrome_dll.pdb M-A On Tue, Dec 29, 2009 at 10:14 PM, yuhong yuhongbao_...@hotmail.com wrote:

Re: [chromium-dev] How to deal with flaky unit tests

2009-12-18 Thread Marc-Antoine Ruel
http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/scripts/master/log_parser/gtest_command.py?revision=28463view=markup has some logic for that but doesn't seem to work anymore. Nicolas is on vacation, I'll take a look soon: http://crbug.com/30599 M-A On Fri, Dec 18, 2009 at 1:47 AM,

Re: [chromium-dev] Trybot to run WebKit's LayoutTests?

2009-12-17 Thread Marc-Antoine Ruel
1. Install VS2005 Pro or better. or 2. Yes there is a wekbit try server but it cannot be triggered outside Google yet. Check your emails. http://build.chromium.org/buildbot/webkit-try/waterfall M-A On Thu, Dec 17, 2009 at 1:09 PM, Dominic Mazzoni dmazz...@google.com wrote: That's what I was

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-16 Thread Marc-Antoine Ruel
Thanks Lei for fixing everything! M-A On Wed, Dec 16, 2009 at 12:42 AM, Lei Zhang thes...@chromium.org wrote: I also needed to install libpam0g-dev. Linux_view try bots should be happy now. On Tue, Dec 15, 2009 at 7:03 PM, Lei Zhang thes...@chromium.org wrote: It'll reload the try server

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Marc-Antoine Ruel
I've been offline most of the day. On Dec 15, 2009 6:46 PM, Mitsuru Oshima osh...@google.com wrote: satorux asked maruel to fix it several hours ago. maruel? - oshima On Tue, Dec 15, 2009 at 3:37 PM, Lei Zhang thes...@chromium.org wrote: It has a custom .gcli... -- Chromium Developers

Re: [chromium-dev] linux_view trybot seems unable to accept any patch

2009-12-15 Thread Marc-Antoine Ruel
This lame email was a courtesy of Nexus One. So if you have time, good ahead otherwise I'll take care. On Dec 15, 2009 6:46 PM, Mitsuru Oshima osh...@google.com wrote: satorux asked maruel t... - oshima On Tue, Dec 15, 2009 at 3:37 PM, Lei Zhang thes...@chromium.org wrote: It has a custom

Re: [chromium-dev] Modifying .gyp files

2009-12-10 Thread Marc-Antoine Ruel
the list and the list will be extended               by the list of matching files.  Example:    hooks = [      { pattern: \\.(gif|jpe?g|pr0n|png)$,        action:  [python, image_indexer.py, --all]},    ] Marc-Antoine Ruel wrote: Humm, that's a good question. Right now the only doc

Re: [chromium-dev] Embedding Chromium

2009-12-10 Thread Marc-Antoine Ruel
http://code.google.com/p/chromiumembedded/. Marshall would probably appreciate to have some help. On Thu, Dec 10, 2009 at 12:43 PM, hap 497 hap...@gmail.com wrote: Hi, Is it possible to embed a chromium in my c/c++ application? (just like someone embed a Webkit rendering engine in his

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-10 Thread Marc-Antoine Ruel
On Thu, Dec 10, 2009 at 2:24 PM, Peter Kasting pkast...@google.com wrote: On Thu, Dec 10, 2009 at 11:20 AM, Jacob Mandelson ja...@mandelson.org wrote: If something extra in an expression is a common case, I've sometimes seen it done like: return DoWork(foo) POSIX_ONLY(

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-10 Thread Marc-Antoine Ruel
On Thu, Dec 10, 2009 at 3:02 PM, Shall be Unnamed @google.com wrote: On Thu, Dec 10, 2009 at 2:29 PM, Marc-Antoine Ruel mar...@chromium.orgwrote: On Thu, Dec 10, 2009 at 2:24 PM, Peter Kasting pkast...@google.com wrote: On Thu, Dec 10, 2009 at 11:20 AM, Jacob Mandelson ja...@mandelson.org

Re: [chromium-dev] Modifying .gyp files

2009-12-09 Thread Marc-Antoine Ruel
Humm, that's a good question. Right now the only doc is gclient help runhooks which is .. uh .. not really useful. M-A On Wed, Dec 9, 2009 at 3:28 PM, Igor Gatis igorga...@gmail.com wrote: Is there documentation somewhere regarding gclient? I'd like to know more about how hooks and other

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Marc-Antoine Ruel
On Tue, Dec 8, 2009 at 4:13 PM, Evan Martin e...@chromium.org wrote: On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Marc-Antoine Ruel
/json On Tue, Dec 8, 2009 at 4:22 PM, Marc-Antoine Ruel mar...@chromium.org wrote: On Tue, Dec 8, 2009 at 4:13 PM, Evan Martin e...@chromium.org wrote: On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http

Re: [chromium-dev] Re: Never build chromium by Visual Studio 2008 + SP1

2009-12-01 Thread Marc-Antoine Ruel
Thanks for the notice but we have good performance regression testing. Also, the official builds don't use /O2. Only the continuous build uses /O2. IIRC, VS2008 RTM cannot be used to build Chromium. M-A On Tue, Dec 1, 2009 at 4:54 AM, avcoder ffm...@gmail.com wrote: Sorry: .I can only get

Re: [chromium-dev] Where buildbot outputs the intermediate builds?

2009-12-01 Thread Marc-Antoine Ruel
I had intention in archiving the intermediate build outputs in a shallow git repo for try server speedup but I have no intention in publishing this repo externally. I would recommend you to checkout the buildbot code and setup a local continuous build yourself. Instructions:

Re: [chromium-dev] Compiler version used for official Windows builds?

2009-11-30 Thread Marc-Antoine Ruel
On Mon, Nov 30, 2009 at 4:48 PM, Ted Mielczarek ted.mielcza...@gmail.comwrote: On Wed, Nov 25, 2009 at 7:42 PM, Wan-Teh Chang w...@google.com wrote: (The official build does whole program optimization and must be done on a 64-bit Windows machine with lots of memory.) Thanks for the info.

Re: [chromium-dev] Compiler version used for official Windows builds?

2009-11-25 Thread Marc-Antoine Ruel
On Wed, Nov 25, 2009 at 7:42 PM, Wan-Teh Chang w...@google.com wrote: On Wed, Nov 25, 2009 at 4:22 AM, Ted Mielczarek ted.mielcza...@gmail.com wrote: Hi, I couldn't find this info anywhere on the dev site (maybe I just wasn't looking hard enough), but I'm curious as to what version of

Re: [chromium-dev] Xcode builds and dependencies

2009-11-24 Thread Marc-Antoine Ruel
You mean you implemented http://code.google.com/p/gyp/issues/detail?id=42 but for xcode only? On Tue, Nov 24, 2009 at 9:51 AM, Thomas Van Lenten thoma...@chromium.orgwrote: Last week Mark and I talked with someone in Apple's devtools team about some of the dependency problems we've seen in our

Re: [chromium-dev] How do I generate an msvs_guid for the GYP file?

2009-11-24 Thread Marc-Antoine Ruel
AFAIK, you don't need one, it was mainly for the transition period. Brad, can we remove them all? On Tue, Nov 24, 2009 at 3:27 PM, Chris Bentzel cbent...@google.com wrote: In http://codereview.chromium.org/428004, I introduced a new GYP target - but don't have an msvs_guid for it. I'm

Re: [chromium-dev] workflow for cross-platform development

2009-11-23 Thread Marc-Antoine Ruel
On Sat, Nov 21, 2009 at 1:52 PM, Chris Bentzel cbent...@google.com wrote: Have there been any thoughts about adding gcl patch and unpatch commands which will grab the file diffs as well as duplicate the CL metadata in src/.svn/gcl_info? There's the gcl metadata and the svn metadata. Webkit

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Marc-Antoine Ruel
It's really about the unit tests, not in chromium. I guess we could probably leak the singleton in the unit tests too on each reset. Pawel, what do you think? Note to all the static local makers: you create an implicit atexit() each time... Use a leaky singleton instead. M-A On Sun, Nov 22,

Re: [chromium-dev] gcl upload error

2009-11-21 Thread Marc-Antoine Ruel
Thanks, when I replied to Munjal, I only replied to him by error. So the fix is to run gclient. M-A On Sat, Nov 21, 2009 at 2:56 PM, Munjal Doshi mun...@chromium.org wrote: Just in case anyone else hit this, it was fixed in 32748. -Munjal On Sat, Nov 21, 2009 at 10:04 AM, Evan Martin

Re: [chromium-dev] gcl upload error

2009-11-21 Thread Marc-Antoine Ruel
[+chromium-dev] One issue is that even a smoke test wouldn't have caught this problem since as I said, it was windows specific. Maybe it's time to create a try server for depot_tools. :/ M-A On Sat, Nov 21, 2009 at 5:23 PM, Marc-Antoine Ruel mar...@google.com wrote: I totally agree, I fully

Re: [chromium-dev] support for WATCHLISTS in git-cl

2009-11-19 Thread Marc-Antoine Ruel
On Thu, Nov 19, 2009 at 4:46 PM, Evan Martin e...@chromium.org wrote: On Thu, Nov 19, 2009 at 12:56 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: It turns out that WATCHLISTS aren't fully effective because git-cl doesn't support them. It doesn't look very hard to implement the support

[chromium-dev] Re: New Presubmit actions

2009-11-18 Thread Marc-Antoine Ruel
First, I'd prefer to keep the presubmit checks from having any side-effect. For a) You haven't mentioned which editor you use but if it is a problem for you, maybe you should tweak the editor? VS, emacs, vim can be modified to do it or at least highlight it; I don't know about xcode. Otherwise a

Re: [chromium-dev] buildbot failure in Chromium on Mac10.5 Tests, revision 32176

2009-11-17 Thread Marc-Antoine Ruel
Glad to see you back, gatekeeper! chase++ On Tue, Nov 17, 2009 at 12:29 PM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for unit_tests on Mac10.5 Tests

Re: [chromium-dev] Linting chrome/ in pre-submit checks

2009-11-17 Thread Marc-Antoine Ruel
To be clear, it'll be a warning prompt on commit, not an error. You can say (y)es to continue. M-A On Tue, Nov 17, 2009 at 2:16 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: Chromium developers, I have just submitted a PRESUBMIT.py for chrome/ which will run cpplint.py on your

Re: [chromium-dev] gclient failed to get the source

2009-11-16 Thread Marc-Antoine Ruel
I don't know where you put your depot_tools but I'd try to delete depot_tools\python.bat and try again. It seems like downloading the python zip failed. M-A On Sun, Nov 15, 2009 at 11:23 PM, Eduardo Maggio mag...@gmail.com wrote: Well, I'm not sure if it's the right place to post that, but

[chromium-dev] gcl misbehaving

2009-11-16 Thread Marc-Antoine Ruel
If gcl is misbehaving at home, please run gclient to update your depot_tools; it was broken this morning. M-A -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-15 Thread Marc-Antoine Ruel
that fix is in. You'd need to set GYP_MSVS_VERSION=2008e Let me know how that goes for you. -BradN On Wed, Nov 11, 2009 at 12:50 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Updated http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows to reference

Re: [chromium-dev] Getting 'This is a read-only checkout' error from gcl

2009-11-13 Thread Marc-Antoine Ruel
Fixed, http://src.chromium.org/viewvc/chrome?view=revrevision=31942 On Fri, Nov 13, 2009 at 3:51 PM, Dominic Mazzoni dmazz...@google.com wrote: I got the same error yesterday.  Note that I don't have write access, so it's true that I do have a read-only checkout, but before, there was no

Re: [chromium-dev] building without svg

2009-11-13 Thread Marc-Antoine Ruel
Dean had done one, at least on Windows, I don't recall offhand since it's been a while. On Fri, Nov 13, 2009 at 5:39 PM, Evan Martin e...@chromium.org wrote: We track total binary size here:  http://build.chromium.org/buildbot/perf/dashboard/sizes.html I don't know of any place we track

Re: [chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-11-12 Thread Marc-Antoine Ruel
Ah, I always close it instinctively. :) /me who is always shocked by people keeping the two useless right-side box on their IDE, the server db and the toolbox. That's totally 16 pixels wasted. M-A On Wed, Nov 11, 2009 at 11:38 PM, Eric Roman ero...@chromium.org wrote: Yuck, I experienced the

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Marc-Antoine Ruel
Wouha, let me reply! :) To clarify things, I already made an experimental webkit try server on the same host that the chromium try server master on a different port. The remaining blocking issue is the revert implementation. br...@apple told me he would look at the implementation but he hasn't

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Marc-Antoine Ruel
To be clear, I have ~10 mac minis dying in a closet waiting for jobs. On Thu, Nov 12, 2009 at 4:52 PM, Jeremy Orlow jor...@google.com wrote: On Thu, Nov 12, 2009 at 1:50 PM, Adam Barth aba...@chromium.org wrote: On Thu, Nov 12, 2009 at 1:46 PM, Jeremy Orlow jor...@google.com wrote: Btw,

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-11 Thread Marc-Antoine Ruel
Updated http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows to reference your blog entry. I don't want to copy these instructions since it's too lengthy, inefficient and unsupported. I didn't realize one could download WDK 7 without needing a MSDN account.

Re: [chromium-dev] Re: [gyp-developer] Coping with configurations differences in sources

2009-11-11 Thread Marc-Antoine Ruel
On Tue, Nov 10, 2009 at 1:52 PM, Gregory Dardyk grego...@google.com wrote: We might build Chrome for 64-bit Windows in the future, but there are several reasons why we would like to avoid porting all Chrome code to 64-bit Windows now: We are now in the process of porting Native Client code

Re: [chromium-dev] Beginning with development

2009-11-10 Thread Marc-Antoine Ruel
And you can use distcc. On Tue, Nov 10, 2009 at 1:21 PM, Paweł Hajdan jr phajdan...@gmail.com wrote: Note however that you can build specific projects. When working on base or net for example, you can build just base_unittests and net_unittests. When working on webkity things, you can

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Marc-Antoine Ruel
Here are the fixes for your debugger sluggishness problems: Bind this macro to F7 http://code.google.com/p/chromium/wiki/WindowsVisualStudioMacros?ts=1256870705updated=WindowsVisualStudioMacros#Only_build_startup_project and bind this macro to F5

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Marc-Antoine Ruel
After thinking about it, just setting in Debugging properties: Command = c:\program files\Debugging Tools for Windows (x86)\windbg.exe Command Arguments = -o $(TargetPath) is way simpler, then you just use Ctrl-F5 to start debugging your app! M-A On Thu, Oct 29, 2009 at 10:50 PM, Marc-Antoine

[chromium-dev] Re: Is there any plan to support Visual Studio 2010? (Current in Beta 2)

2009-10-28 Thread Marc-Antoine Ruel
[Subtly setting expectations here] Updated http://crbug.com/25628 accordingly. You have your answer in this feature request and read my comment on it before adding any comment. (as in don't add any please) Feel free to star it though. But as a sane person, well, as sane as I can be, I can only

[chromium-dev] Re: Are we going to use tcmalloc on Mac?

2009-10-28 Thread Marc-Antoine Ruel
On Wed, Oct 28, 2009 at 1:30 AM, Darin Fisher da...@chromium.org wrote: I'm pretty sure that enabling USE_SYSTEM_MALLOC will also lead to corruption since WebKit is not hermetic (we allocate things externally that we then delete inside WebKit). -Darin Wouha! That really limit our capacity to

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Marc-Antoine Ruel
An additional note: Most Windows boxes have an AV installed while most linux boxes don't. Never underestimate the sluggishness of AVs. M-A On Wed, Oct 28, 2009 at 11:05 AM, Evan Martin e...@chromium.org wrote: On Tue, Oct 27, 2009 at 9:11 PM, Adam Barth aba...@chromium.org wrote: My three

[chromium-dev] Re: Reference build has been changed?

2009-10-28 Thread Marc-Antoine Ruel
FTR, you could have got the same info with: src\chrome\tools\test\reference_build\chromechrome about:version M-A On Wed, Oct 28, 2009 at 12:46 PM, Anton Muhin ant...@chromium.org wrote: Thanks a lot, Tony. yours, anton. On Wed, Oct 28, 2009 at 7:44 PM, Tony Chang t...@chromium.org

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Marc-Antoine Ruel
Have you tried starring http://crbug.com/22044 ? On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: If I'm not mistaken, I think like most everyone running on linux is using the make build nowadays, and the make build seems to work well enough for most people.  

[chromium-dev] Re: How can we kill scons?

2009-10-28 Thread Marc-Antoine Ruel
Not that it is effective :) On Wed, Oct 28, 2009 at 3:34 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Have you tried starring http://crbug.com/22044 ? On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: If I'm not mistaken, I think like most everyone running

[chromium-dev] Re: Fun with timers! A horror story

2009-10-27 Thread Marc-Antoine Ruel
http://crbug.com/22926 You know the funny part? I had hacked that exact thing (in ChromiumCurrentTime.cpp) locally during work on this bug. M-A On Tue, Oct 27, 2009 at 9:53 PM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: Would a hack like running  nm --defined-only on each generated

[chromium-dev] depot_tools and pymox

2009-10-19 Thread Marc-Antoine Ruel
Hi I finally checked-in pymox into depot_tools. This mean that if you ever ran the depot_tools unit_tests, you may get this error svn: svn: Failed to add directory 'tests/pymox': a versioned directory of the same name already exists git-svn: error: Untracked working tree file

[chromium-dev] Re: Please update svn:ignore for gyp changes

2009-10-16 Thread Marc-Antoine Ruel
I'm doing it, I have a change pending, I was waiting for the tree to reopen... M-A On Fri, Oct 16, 2009 at 3:56 PM, Peter Kasting pkast...@google.com wrote: After a recent sync I now have a large number of .rules/.sln/.vcproj files in chrome_frame/.  Someone changed the gyp files in a way

[chromium-dev] Re: Please update svn:ignore for gyp changes

2009-10-16 Thread Marc-Antoine Ruel
... and by the time I synced, it was closed again. :) On Fri, Oct 16, 2009 at 3:58 PM, Marc-Antoine Ruel mar...@chromium.org wrote: I'm doing it, I have a change pending, I was waiting for the tree to reopen... M-A On Fri, Oct 16, 2009 at 3:56 PM, Peter Kasting pkast...@google.com wrote

[chromium-dev] Re: weird Visual Studio link error, will clobber fix it?

2009-10-16 Thread Marc-Antoine Ruel
... more hotfixes for you to install http://dev.chromium.org/developers/how-tos/build-instructions-windows On Fri, Oct 16, 2009 at 3:57 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: I'm consistently getting this error when linking (fails 57 times when compiling the entire chrome.sln):

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Marc-Antoine Ruel
Actually, can you package this so it could be upstreamed to webkit.org? On Thu, Oct 15, 2009 at 1:09 PM, Glenn Wilson gwil...@chromium.org wrote: The tool lives in src/webkit/tools/layout_tests/test_output_formatter{.bat,.sh}, and it can actually be run against any builder, not just the

[chromium-dev] Re: Building chromium stable

2009-10-09 Thread Marc-Antoine Ruel
Adding a few potentially interested people. On Fri, Oct 9, 2009 at 6:45 AM, Rozenkraft rozenkr...@gmail.com wrote: As a few of you know, I've been trying to build a stable version of chromium for a month now. The problem is the DEPS file of the 195 branch is outdated so it has wrong

[chromium-dev] Re: GYP and cross-compiling

2009-10-08 Thread Marc-Antoine Ruel
On Thu, Oct 8, 2009 at 12:49 PM, Evan Martin e...@chromium.org wrote: 3- Well, it only works for the make build. The current patch probably breaks the scons one. XCode and MSVS should be mostly unaffected - but won't supposrt this, which I don't think is a big deal. How about 32/64-bit

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-10-08 Thread Marc-Antoine Ruel
Did you try the right file? On Thu, Oct 8, 2009 at 1:20 PM, yu...@chromium.org yu...@chromium.orgwrote: When trying to install the hotfix on Win7/64 I'm getting following message: The upgrade patch cannot be installed by the Windows Installer service because the program to be upgraded

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

2009-10-07 Thread Marc-Antoine Ruel
For the record, I build on win7 (both x86 and x64) on vs2008 without problem here. M-A On Tue, Oct 6, 2009 at 9:21 PM, vha14 vuh...@gmail.com wrote: Still having the same issue after following John's suggestions. Being forced to use a separate cygwin's bash.exe. On Oct 2, 12:16 am,

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Marc-Antoine Ruel
It's better to be non-animated. Remember,ichrome is using too much CPU already. Second; the user is doing something, he doesn't want to be distracted with information unrelated to his current task. If the user finds himself waiting on his current tab, his eyes will probably see a tab being

[chromium-dev] Re: Scalability

2009-10-05 Thread Marc-Antoine Ruel
Yes, Nicolas is working on making webkit.dll. It's painful to do; I know, I tried last year. :) On Mon, Oct 5, 2009 at 11:42 AM, Evan Martin e...@chromium.org wrote: On Fri, Oct 2, 2009 at 8:26 AM, Marc-Antoine Ruel mar...@chromium.org wrote: is linking. To give you an idea, here's a truncated

[chromium-dev] Re: Google Blogoscoped author tries out Chrome app shortcuts

2009-10-05 Thread Marc-Antoine Ruel
[+chromium-dev] On Mon, Oct 5, 2009 at 12:36 PM, Philipp Lenssen philipp.lens...@gmail.com wrote: Hi Peter and Marc-Antoine! (forwarding my post via email as the Google Groups discussion is moderated) You need to subscribe first to not be moderated, e.g. ignored. I'm glad to see the issues

[chromium-dev] Re: build time speed improvement with solid state drive?

2009-10-05 Thread Marc-Antoine Ruel
Marshall, don't waste money on SSD (especially not MLC SSD). Get 2 standard HD, put the checkout on the secondary drive, get a dual-cpu quad-core ht with 8+ gigs of RAM (or up to the limit you can afford but get at least 8 gigs of RAM and at least one quad core). Core i7 or xeon nehalem *highly*

[chromium-dev] Re: Google Blogoscoped author tries out Chrome app shortcuts

2009-10-04 Thread Marc-Antoine Ruel
On Sun, Oct 4, 2009 at 7:13 PM, Peter Kasting pkast...@google.com wrote: With larger textarea content, Chrome’s up and downwards scrolling can show minimal lags. Firefox handles this smoothly. Didn't try to test this one, filed crbug.com/23788 . We can trick things with ScrollWindowEx when

[chromium-dev] Scalability

2009-10-02 Thread Marc-Antoine Ruel
net in two to remove the dependency injection. We may go back to disabling PDBs, saving several gigs but that slightly reduce the usefulness. That's probably what needs to happen right now. Thanks, Marc-Antoine On Thu, Oct 1, 2009 at 9:37 PM, Marc-Antoine Ruel mar...@chromium.org wrote: [bcc

[chromium-dev] Try server follow up

2009-10-02 Thread Marc-Antoine Ruel
The windows slaves are really having a hard time to compile, if it fails, just try again :( The command is or s/gcl/git/: gcl try foo --bot win In the short term, I'm disabling debug info on windows so they are at least somewhat useful. I'll probably restart the master in the middle of the day

[chromium-dev] Re: Try server follow up

2009-10-02 Thread Marc-Antoine Ruel
The windows try slaves are now back up with the symbols disabled. A side-effect is that process dump will always be red, since the symbols cannot be found. I'll remove this step soon. M-A On Fri, Oct 2, 2009 at 1:10 PM, Marc-Antoine Ruel mar...@chromium.org wrote: The windows slaves

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-10-01 Thread Marc-Antoine Ruel
[uninformed question] From a quick search, when you're talking about decommit, you seem to always use MEM_DECOMMIT instead of MEM_RELEASE; I see no MEM_RELEASE in tcmalloc. You do leak the reserved pages or are they first reused? What I am referring to is to a potential virtual address space

[chromium-dev] Re: url request failing on unix with os_error = -7

2009-10-01 Thread Marc-Antoine Ruel
[bcc: chromium-dev] As I said in my previous email (which was blocked by the ML) you should have just replied to the email and saved 1600+ people time. That what is written on the try job status email for a reason. I'll send a follow up email with more information. M-A On Thu, Oct 1, 2009 at

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-09-30 Thread Marc-Antoine Ruel
I have done that last week. You can see the list grew even more. On Wed, Sep 30, 2009 at 1:44 PM, Stephen White senorbla...@chromium.org wrote: I see it's now listed as required for MSVC2005 (thanks to whoever updated the build instructions). On Wed, Sep 30, 2009 at 1:39 PM, Stephen White

[chromium-dev] Re: Try-ing WebKit patches (was WebKit Chromium Port Update Sep 29th)

2009-09-29 Thread Marc-Antoine Ruel
+Dimitri, who is doing that and didn't put Jeremy in the loop. On Tue, Sep 29, 2009 at 4:06 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Sep 29, 2009 at 12:52 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Sep 29, 2009 at 12:05 PM, Eric Seidel esei...@chromium.org wrote: On

[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?

2009-09-29 Thread Marc-Antoine Ruel
If I understand correctly, you're asking for a webkit try server? And in particular a apple windows builder/tester. M-A On Tue, Sep 29, 2009 at 6:18 PM, Peter Kasting pkast...@google.com wrote: I figure this question is most suited for the Green Tree folks. Ojan told me today that he had a

[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?

2009-09-29 Thread Marc-Antoine Ruel
I don't think it'd be very hard, I didn't know this was a wanted feature. M-A On Tue, Sep 29, 2009 at 6:47 PM, Peter Kasting pkast...@google.com wrote: On Tue, Sep 29, 2009 at 3:35 PM, Marc-Antoine Ruel mar...@chromium.org wrote: If I understand correctly, you're asking for a webkit try

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-29 Thread Marc-Antoine Ruel
I think I'm right to say that a lot of the knobs stated by Mohamed can be achieved with content script. Everything that can be done with javascript for this particular use case should be done as javascript. For example, destroying the window.print prototype. I think you try to block to many

[chromium-dev] Re: Skipping reference_build ?

2009-09-28 Thread Marc-Antoine Ruel
As usual, please file a feature request unless you plan on doing it, otherwise I'll forget. On Fri, Sep 25, 2009 at 3:59 PM, Jeremy Orlow jor...@chromium.org wrote: Sounds like we need a presubmit check. On Fri, Sep 25, 2009 at 6:38 AM, Marc-Antoine Ruel mar...@chromium.org wrote: It's too

[chromium-dev] Re: FYI, project cruft

2009-09-28 Thread Marc-Antoine Ruel
GYP debugger? On Mon, Sep 28, 2009 at 2:00 PM, Nick Carter n...@chromium.org wrote: I've noticed that the use of the 'direct_dependent_settings' in gyp to propagate #defines and include paths makes it trickier to decipher the actual build-order dependencies.  I've had cases where I needed to

[chromium-dev] Re: Error in using gclient

2009-09-28 Thread Marc-Antoine Ruel
On Mon, Sep 28, 2009 at 2:09 PM, Dan Kegel d...@kegel.com wrote: On Sat, Sep 26, 2009 at 6:23 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Something disable a trick we use to download a zip file containing svn and uncompressing it. You can do it manually since it's one time process

[chromium-dev] Re: Error in using gclient

2009-09-28 Thread Marc-Antoine Ruel
78 svn.bat 2009-09-22 16:32REP svn_bin 2 fichier(s) 145 octets On Mon, Sep 28, 2009 at 11:13 AM, Marc-Antoine Ruel mar...@chromium.org wrote: On Mon, Sep 28, 2009 at 2:09 PM, Dan Kegel d...@kegel.com wrote: On Sat, Sep 26, 2009 at 6

[chromium-dev] gclient sync

2009-09-28 Thread Marc-Antoine Ruel
If you can, please don't sync for the next 15 minutes. Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

[chromium-dev] Re: gclient sync

2009-09-28 Thread Marc-Antoine Ruel
Now fixed as http://chrome-svn/viewvc/chrome?view=revrevision=27386 . Will take a few minutes before it propagates to the proxies. On Mon, Sep 28, 2009 at 2:45 PM, Marc-Antoine Ruel mar...@chromium.org wrote: If you can, please don't sync for the next 15 minutes. Thanks

[chromium-dev] Re: gclient sync

2009-09-28 Thread Marc-Antoine Ruel
Err, meant http://src.chromium.org/viewvc/chrome?view=revrevision=27386 On Mon, Sep 28, 2009 at 2:57 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Now fixed as http://chrome-svn/viewvc/chrome?view=revrevision=27386 . Will take a few minutes before it propagates to the proxies. On Mon, Sep

[chromium-dev] Re: Error in using gclient

2009-09-26 Thread Marc-Antoine Ruel
Hi Something disable a trick we use to download a zip file containing svn and uncompressing it. You can do it manually since it's one time process. See for the details: http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/bootstrap/win/win_tools.bat?view=markup If you follow the

[chromium-dev] FYI, project cruft

2009-09-26 Thread Marc-Antoine Ruel
Project dependencies went out of control lately. As an example; mini_installer was depending of gtest. :) I started by splitting most constants out of chrome/common into common_constants and fixed 2 projects accordingly. My next target is most of the ui tests series and fetch_* that are linking

[chromium-dev] Re: Build time doubled since May - what gives?

2009-09-25 Thread Marc-Antoine Ruel
http://code.google.com/p/chromium/issues/detail?id=21266 This is a real problem, I just haven't looked into this one in particular. Sometimes I just feel like renaming the dll... M-A On Thu, Sep 24, 2009 at 10:29 PM, Mohamed Mansour m...@chromium.org wrote: Hey Ben, same here ... I see this

[chromium-dev] Re: Build time doubled since May - what gives?

2009-09-25 Thread Marc-Antoine Ruel
Oh and a lot of warnings appeared recently. It is surprising how much warnings slow down the build, probably due to stdout serialization. http://code.google.com/p/chromium/issues/detail?id=23039 M-A On Fri, Sep 25, 2009 at 9:18 AM, Marc-Antoine Ruel mar...@chromium.org wrote: http

[chromium-dev] Re: Skipping reference_build ?

2009-09-25 Thread Marc-Antoine Ruel
It's too late for git but not for svn and tarballs. Please move them to DEPS. M-A On Thu, Sep 24, 2009 at 6:26 PM, Evan Martin e...@chromium.org wrote: We have already scolded Alex about this, but it's too late now. Repeat PSA: plz to not be dumping large Windows binaries into the tree.  

[chromium-dev] Re: Kiosk Mode for Chrome

2009-09-25 Thread Marc-Antoine Ruel
Well, Mohamed's patch is *way* simpler and portable. On Fri, Sep 25, 2009 at 12:40 PM, Amit Joshi a...@chromium.org wrote: Sorry for not being clear. What I meant was that you could create your own kiosk shell and embed Chrome Frame as ActiveX control to render the pages you want in it. That

[chromium-dev] Re: Build time doubled since May - what gives?

2009-09-25 Thread Marc-Antoine Ruel
: I'll volunteer to fix any build issues created as a result of sync. Building the protobuf compiler (protoc.exe) emits a bunch of warnings -- the bulk are signed/unsigned warnings.  I'll put together a change to suppress those.  - nick On Fri, Sep 25, 2009 at 6:34 AM, Marc-Antoine Ruel mar

[chromium-dev] gclient hang

2009-09-25 Thread Marc-Antoine Ruel
Your next gclient sync will probably hang. The easiest way to fix it is to: rm -rf src/third_party/WebKit/WebKit/chromium or rd /q /s src\third_party\WebKit\WebKit\chromium before syncing. Sorry for the trouble, M-A --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: gclient hang

2009-09-25 Thread Marc-Antoine Ruel
Yep, I specified one directory too deep. On Fri, Sep 25, 2009 at 2:50 PM, Mike Pinkerton pinker...@chromium.org wrote: To get mine to work, I had to  rm -rf src/third_party/WebKit/WebKit just doing chromium wasn't enough to stop the hangs. On Fri, Sep 25, 2009 at 2:36 PM, Marc-Antoine

[chromium-dev] Re: new values for failures in test_expectations.txt

2009-09-25 Thread Marc-Antoine Ruel
On Fri, Sep 25, 2009 at 9:12 PM, Dirk Pranke dpra...@chromium.org wrote: Hi all, If you don't run layout_tests or ever need to modify test_expecations.txt, you can ignore this ... As a reminder, every build sheriff needs to be able to modify this. M-A As discussed earlier this week,

[chromium-dev] Re: flaky resource failures

2009-09-24 Thread Marc-Antoine Ruel
On Thu, Sep 24, 2009 at 3:03 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: We still have problems with resources, examples: [FATAL:tab_renderer.cc(132)] Check failed: waiting_animation_frames-width() % waiting_animation_frames-height() == 0. [FATAL:image_operations.cc(373)] Check

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-24 Thread Marc-Antoine Ruel
work for other people. -atw On Thu, Sep 24, 2009 at 2:20 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Thanks for proposing yourself in improving gcl.py and trychange.py. On Thu, Sep 24, 2009 at 5:18 PM, Drew Wilson atwil...@chromium.org wrote: Before we start enforcing penalties

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-23 Thread Marc-Antoine Ruel
On Tue, Sep 22, 2009 at 9:35 PM, Adam Barth aba...@chromium.org wrote: On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek j...@chromium.org wrote: Is this even possible?  i.e. I had uploaded a WebKit patch on codereview but none of the patchsets got run on the try server

[chromium-dev] Try server moved

2009-09-23 Thread Marc-Antoine Ruel
The try server moved. There should be no side-effects except that the logs are lost (yet again). If you want to access the old try job logs, the old try server is still running for a few days, so use the continuous buildbot's address with the try server's port. If you don't have access to corp

[chromium-dev] Re: Xcode dependency analysis

2009-09-22 Thread Marc-Antoine Ruel
VS has the same kinds of problem when a project is reusing files generated inside it. The fix is usually splitting the project in two so that generated files by a rule/action aren't reused inside the same project. On Tue, Sep 22, 2009 at 8:30 AM, Thomas Van Lenten thoma...@chromium.org wrote:

[chromium-dev] Important; gclient failure

2009-09-17 Thread Marc-Antoine Ruel
If you synchronized sources between [26423, 26461[, be sure to sync to 26461 or manually run gclient runhooks. The hooks weren't called anymore, causing stale project files to be used, causing all kind of weird build failures. Sorry for the trouble, M-A

[chromium-dev] Re: Linux views trybot

2009-09-16 Thread Marc-Antoine Ruel
I created a builder for that. It is not in the default pool since I connected only one slave to it. On Wed, Sep 16, 2009 at 1:24 AM, Peter Kasting pkast...@google.com wrote: We need one.  I have broken the Linux views build three times in the past three days.  This is wasting my time and the

[chromium-dev] Re: Need help on how to send data from RenderView to a custom DOMUI instantly

2009-09-16 Thread Marc-Antoine Ruel
Step 4 is wrong, you don't replace in-place, you do a navigation, like view-source. Random idea; the page's could be duplicated in a hidden iframe with javascript disabled, greatly simplifying the code to generated the print preview pages jpg and making the DOM duplication a 100% javascript

  1   2   3   >