On Thu, Sep 10, 2009 at 6:19 PM, Paweł Hajdan
Jr.phajdan...@chromium.org wrote:
On Thu, Sep 10, 2009 at 10:16, Dan Kegel d...@kegel.com wrote:
In this case, the code may have been submitted by a committer
without using the trybots (tsk, tsk). We don't currently mention
the trybots on
On Thu, Sep 10, 2009 at 2:05 PM, Jacob Mandelson ja...@mandelson.org wrote:
It was more surprised that I was expected to have built chrome at home
under multiple platforms.
I wouldn't say that we expect people to build chrome at home under
multiple platforms. We expect patches not to break
On Fri, Sep 11, 2009 at 4:28 PM, Jacob Mandelson ja...@mandelson.org wrote:
The trybot is restricted access to committers only.
I'm not a committer, and as such I don't have access.
go/chrometryserver
M-A
--~--~-~--~~~---~--~~
Chromium Developers mailing list:
I agree it should be the responsibility of the committer to make sure
the code passes the trybots on all platforms (I have in the past made
the mistake of thinking the trybots were open to everyone, but they
are not). I think many committers will not be willing to go through
very many iterations
I generally leave the figure out the errors bit to the committer.
Once you've made sure a patch isn't malicious:
git checkout origin
git cl patch -b theirname 12345 # code review number
git try
git checkout branch_i_was_working_on
You can then point them to the try server build page and
On Fri, Sep 11, 2009 at 7:03 PM, Evan Martin e...@chromium.org wrote:
I generally leave the figure out the errors bit to the committer.
I assume you mean the contributor. The problem is then that you are
trusting a non-committer to tell you whether to commit, which defeats
the purpose of having
We could do this instead:gcl try --url http://url/to/patch.diff --email
contribut...@email.com --issue rietveldIssueNumber
No need to download and apply the patch.
- Mohamed Mansour
On Fri, Sep 11, 2009 at 10:03 PM, Evan Martin e...@chromium.org wrote:
I generally leave the figure out the
On Thu, Sep 10, 2009 at 1:03 PM, Dan Kegel d...@kegel.com wrote:
An external contributor was recently surprised that a change tested
on linux was reverted because it broke the build on windows.
(His mental model was that linux developers don't have to
worry about other platforms, that's what
For me it was obvious, but if people are surprised by this, then improving
the documentation is probably a good idea.
Just curious... the change has been submitted to trybots before landing,
hasn't it?
On Thu, Sep 10, 2009 at 10:03, Dan Kegel d...@kegel.com wrote:
An external contributor was
OK, we should probably improve
http://dev.chromium.org/developers/contributing-code
similarly, then.
In this case, the code may have been submitted by a committer
without using the trybots (tsk, tsk). We don't currently mention
the trybots on dev.chromium.org. Is it time to?
On Thu, Sep 10,
On Thu, Sep 10, 2009 at 10:16, Dan Kegel d...@kegel.com wrote:
In this case, the code may have been submitted by a committer
without using the trybots (tsk, tsk). We don't currently mention
the trybots on dev.chromium.org. Is it time to?
Submitting without trybots and breaking the
An external contributor was recently surprised that a change tested
on linux was reverted because it broke the build on windows.
(His mental model was that linux developers don't have to
worry about other platforms, that's what windows developers are for.)
[...]
Anyone think we need
I blogged about that when we kicked off the additional platform
efforts, though it's probably a good idea to say something about it on
the site as well.
--Amanda
On Thu, Sep 10, 2009 at 1:20 PM, Nico Weber tha...@chromium.org wrote:
An external contributor was recently surprised that a
Sure. I'd run anything I write up past Ben, brian, etc. first before
posting anything.
--Amanda
On Thu, Sep 10, 2009 at 3:07 PM, Peter Kasting pkast...@google.com wrote:
On Thu, Sep 10, 2009 at 10:20 AM, Nico Weber tha...@chromium.org wrote:
While you're on it, could you add something like
On Thu, Sep 10, 2009 at 10:19 AM, Paweł Hajdan Jr.
phajdan...@chromium.orgwrote:
On Thu, Sep 10, 2009 at 10:16, Dan Kegel d...@kegel.com wrote:
In this case, the code may have been submitted by a committer
without using the trybots (tsk, tsk). We don't currently mention
the trybots on
15 matches
Mail list logo
