[chromium-dev] Re: yet another browser benchmark

2009-06-25 Thread 신정식, 申政湜
2009/6/24 Evan Martin e...@chromium.org http://www.codexon.com/posts/a-real-benchmark-real-websites-with-chrome-firefox-opera-safari-ie Brief summary: - measures warm-disk-based snapshots of real websites - hand-injected script src into pages that uses addEventListener(load) /

[chromium-dev] Re: Using custom builds of chromium in a commercial setting

2009-06-25 Thread Ciaran
Excellent, clearly a far superior approach to my current overwriting of image files and re-compiling the default.dll ! :) Will read and absorb. - cj. On Wed, Jun 24, 2009 at 7:32 PM, Glen Murphy g...@chromium.org wrote: Not sure about the theme part, Glen is the right person to answer that

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Hi, Thanks for review. 2009/6/25 Jeremy Orlow jor...@chromium.org I only skimmed, but it looks well thought out. One question though: is this going to be functional for non-Chromium browsers? Given that your design doc mentions v8 and hooks into Chromium's network stack, but no mention of

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too. Sure. I've added a diagram in webkit part. * Does

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Hi, 2009/6/25 Drew Wilson atwil...@google.com BTW, I checked in with IanH - it sounds like WebSockets are also on the Worker roadmap, so that's something to keep in mind while you iterate on your design. Ok, I see. +1 to avoiding WebCore/loader, but also +1 to refactoring to enable as

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
2009/6/25 Chris Evans cev...@google.com On Wed, Jun 24, 2009 at 2:32 AM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.orgwrote: Hi, yuzo, tyoshino and I start working to implement HTML5 Web Socket and write design docs WebKit part: http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh Chromium

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 坊野 博典
Hi Ukai-san, ViewHostMsg_WebSocket*: IPC messages sent from renderer to browser. ViewHostMsg_WebSocketOpen: open a new Web Socket. called by WebSocketHandle::connect(). int request_id // idenfity WebSocket object {GURL url, std::wstring protocol, std::wstring origin, bool secure, [...]}

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Hi, 2009/6/25 Hironori Bono (坊野 博典) hb...@chromium.org Hi Ukai-san, ViewHostMsg_WebSocket*: IPC messages sent from renderer to browser. ViewHostMsg_WebSocketOpen: open a new Web Socket. called by WebSocketHandle::connect(). int request_id // idenfity WebSocket object {GURL url,

[chromium-dev] Re: How do I deploy an NPAPI plugin over the internet from HTML ?

2009-06-25 Thread Non-Stick
OK. Thanks for that Matt. At least now I know I was using the wrong mechanism. So what is the recommended way to download and install an NPAPI Plugin over the internet under Chrome ? There are 4 files that I need to download (the plugin dll plus 3 helper files): npmyplugin.dll

[chromium-dev] Re: question about helpwanted items (how it works)

2009-06-25 Thread PhistucK
It means that it is a good bug to send patches for, that will not be fixed soon by a Chromium developer. If you want to start handling it, you should post a message to chromium-dev, after you briefly thought about how to implement it and show some kind of a brief design document, if needed, or

[chromium-dev] Linux buildbots, which locale?

2009-06-25 Thread Dean McNamee
http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)/builds/9486/steps/base_unittests/logs/stdio http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)/builds/9486/steps/net_unittests/logs/stdio I just committed a change that converted our

[chromium-dev] Re: Linux buildbots, which locale?

2009-06-25 Thread Dean McNamee
I just took a look at what was happening on one of the Linux buildbots. It looks like we completely clear the env and just explicitly set a few things. We need to add LANG=en_US.UTF-8 to that list of things. Any takers? Thanks On Thu, Jun 25, 2009 at 2:12 PM, Dean McNameede...@chromium.org

[chromium-dev] Re: question about helpwanted items (how it works)

2009-06-25 Thread Evan Martin
On Thu, Jun 25, 2009 at 3:37 AM, nakroyoav.zilberb...@gmail.com wrote: when you mark an itemm as helpWanted, how is it supposed to work from there ? If it's an obvious bug, like page fails to scroll if screen is in 16 bit color mode, then you can just comment on the bug that you're looking

[chromium-dev] Re: Linux buildbots, which locale?

2009-06-25 Thread Evan Martin
On Thu, Jun 25, 2009 at 6:27 AM, Nicolas Sylvainnsylv...@chromium.org wrote: On Thu, Jun 25, 2009 at 5:27 AM, Dean McNamee de...@chromium.org wrote: I just took a look at what was happening on one of the Linux buildbots.  It looks like we completely clear the env and just explicitly set a

[chromium-dev] Re: Linux buildbots, which locale?

2009-06-25 Thread Nicolas Sylvain
On Thu, Jun 25, 2009 at 7:03 AM, Evan Martin e...@chromium.org wrote: On Thu, Jun 25, 2009 at 6:27 AM, Nicolas Sylvainnsylv...@chromium.org wrote: On Thu, Jun 25, 2009 at 5:27 AM, Dean McNamee de...@chromium.org wrote: I just took a look at what was happening on one of the Linux

[chromium-dev] Re: question about helpwanted items (how it works)

2009-06-25 Thread nakro
I agree, but no browser has a keyboard shortcut for this what FF and Safari have is a menu option to change the behavior of Zoom (via a check box) and IE only does full page zoom since chrome is so religious about minimal UI, i thought to have these options with no UI at all but i can easily add

[chromium-dev] Re: question about helpwanted items (how it works)

2009-06-25 Thread Finnur Thorarinsson
I wasn't suggesting we should add a UI in addition/instead of a keyboard modifier. Since there is no standard modifier you should do as Evan suggested an just pick one. We can always change it. On Thu, Jun 25, 2009 at 08:14, nakro yoav.zilberb...@gmail.com wrote: I agree, but no browser has a

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread John Abd-El-Malek
2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too.

[chromium-dev] Re: Memory usage in chrome

2009-06-25 Thread Mike Belshe
On Thu, Jun 25, 2009 at 9:40 AM, Mike Beltzner beltz...@mozilla.com wrote: On 22-Jun-09, at 12:57 PM, Mike Belshe wrote: Yes, that accurately represents the private memory for a process, but it doesn't reflect the user's experience. Windows generally tracks working set. Why? Because the

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread Michael Nordman
2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too.

[chromium-dev] Chromium-reviews is down

2009-06-25 Thread Mark Larson (Google)
The chromium-reviews emailing list has been blacklisted (for spam apparently). No review email is going out. We're working to get the list restored, but don't have an ETA at this point. In the meantime, you'll need to ping people directly to let them know about pending reviews and comments.

[chromium-dev] Re: Chromium-reviews is down

2009-06-25 Thread Evan Martin
You can also point a feed reader at http://codereview.chromium.org/rss/all I think. On Thu, Jun 25, 2009 at 11:05 AM, Mark Larson (Google)m...@chromium.org wrote: The chromium-reviews emailing list has been blacklisted (for spam apparently). No review email is going out. We're working to

[chromium-dev] Re: Chromium-reviews is down

2009-06-25 Thread dhhwai
And chromium-bugs has also been blacklisted for the same reason. On Jun 25, 11:10 am, Evan Martin e...@chromium.org wrote: You can also point a feed reader at  http://codereview.chromium.org/rss/all I think. On Thu, Jun 25, 2009 at 11:05 AM, Mark Larson (Google)m...@chromium.org wrote:

[chromium-dev] Re: Is it possible to do a gclient sync without running hooks?

2009-06-25 Thread Marc-Antoine Ruel
Send patches to gclient.py to 'disable automatic runhooks on sync' to me. You can hack directly inside your depot_tools and use 'gcl change bleh' and 'gcl upload bleh --send-mail -r mar...@chromium.org'. You'll need to update the unit tests. M-A On Tue, Jun 23, 2009 at 9:01 PM, Nicolas

[chromium-dev] Re: about gtest's main in chromium

2009-06-25 Thread Marc-Antoine Ruel
It's set through .sln dependencies; src\chromepython tools\build\win\sln_deps.py chrome.sln printing_unittests printing_unittests base gtest gtestmain icui18n icuuc printing M-A 2009/6/25 Jickae Davis jick...@gmail.com: ah, in fact, I don't really understand what the .gyp

[chromium-dev] Re: question about helpwanted items (how it works)

2009-06-25 Thread Marc-Antoine Ruel
In any case, make sure to ping the @chromium.org person that added the HelpWanted flag! M-A On Thu, Jun 25, 2009 at 11:29 AM, Finnur Thorarinssonfin...@chromium.org wrote: I wasn't suggesting we should add a UI in addition/instead of a keyboard modifier. Since there is no standard modifier

[chromium-dev] Re: Gmock compilation errors on VS2008SP1

2009-06-25 Thread 王重傑
I haven't heard back about any more VS2008 issues. I'm going to remove boost tuple from the chromium tree next week, which will break the workaround nakro posted earlier. If there any more VS2008 issues, please let me know soon so I don't break you. :) Thanks, Albert On Tue, Jun 23, 2009 at

[chromium-dev] Re: How do I deploy an NPAPI plugin over the internet from HTML ?

2009-06-25 Thread John Abd-El-Malek
On Thu, Jun 25, 2009 at 1:54 AM, Non-Stick kevin.ra...@ntlworld.com wrote: OK. Thanks for that Matt. At least now I know I was using the wrong mechanism. So what is the recommended way to download and install an NPAPI Plugin over the internet under Chrome ? There's no way to make Chrome

[chromium-dev] Re: Chromium-reviews is down

2009-06-25 Thread dhhwai
And the chromium-bugs list has also been blacklisted for the same reason. On Jun 25, 11:05 am, Mark Larson (Google) m...@chromium.org wrote: The chromium-reviews emailing list has been blacklisted (for spam apparently). No review email is going out. We're working to get the list restored, but

[chromium-dev] Purify/Valgrind FIXIT

2009-06-25 Thread Huan Ren
For people looking for FIXIT items next week, these are lists of Purify/Valgrind FIXIT bugs without owner assigned.

[chromium-dev] Re: Memory usage in chrome

2009-06-25 Thread Mike Beltzner
On 25-Jun-09, at 12:52 PM, Mike Belshe wrote: Yeah, the APIs all have constraints. We end up walking the pages and adding them up. See process_util_win.cc in the chromium tree. Be sure to check about:memory and hover over the little ? icons to see what we measure. This screen

[chromium-dev] Re: Memory usage in chrome

2009-06-25 Thread Mike Beltzner
On 25-Jun-09, at 6:26 PM, Mike Beltzner wrote: here's a ZIP with the required code (needs Python 2.5 or later to be installed on your system): Oops, forgot the link! http://people.mozilla.org/~beltzner/membuster-talos.rar cheers, mike --~--~-~--~~~---~--~~

[chromium-dev] Landing two sided patches

2009-06-25 Thread Adam Langley
Dear Lords of the WebKit, I come to you seeking guidance about how best to avoid the mess that the tree got into this afternoon. Japhet and I both had two sided patches to land (where one needs to land both the WebKit and Chromium sides together). We emailed the merger for the day (jianli) and

[chromium-dev] Re: Memory usage in chrome

2009-06-25 Thread Mike Belshe
On Thu, Jun 25, 2009 at 3:26 PM, Mike Beltzner beltz...@mozilla.com wrote: On 25-Jun-09, at 12:52 PM, Mike Belshe wrote: Yeah, the APIs all have constraints. We end up walking the pages and adding them up. See process_util_win.cc in the chromium tree. Be sure to check about:memory and

[chromium-dev] Re: Memory usage in chrome

2009-06-25 Thread Mike Beltzner
On 25-Jun-09, at 7:02 PM, Mike Belshe wrote: This screen actually confuses me a little, as the Summary statistics don't match the summation of the process based statistics. Do you mean to say your summary statistics take into account the memory that's being shared across the various

[chromium-dev] Re: Landing two sided patches

2009-06-25 Thread Darin Fisher
I suspect there are things we can do that will avoid much of the need to do a Chromium side change in unison with a WebKit side change. #1 is probably upstreaming some .gypi files so that the set of files to build can be stored in svn.webkit.org. The WebKit API will also help, and completing the

[chromium-dev] gclient runhooks --force not forceful enough?

2009-06-25 Thread Dan Kegel
I did rm Makefile gclient runhooks --force and it didn't regenerate Makefile. tools/gyp/gyp -f make build/all.gyp does rebuild it. Seems like gclient runhooks --force ought to, no? --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread 王重傑
Doesn't gclient runhooks --force setup the scons build on linux? Or did the make build become default at some point? On Thu, Jun 25, 2009 at 5:57 PM, Dan Kegel daniel.r.ke...@gmail.com wrote: I did rm Makefile gclient runhooks --force and it didn't regenerate Makefile. tools/gyp/gyp -f

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Dan Kegel
On Thu, Jun 25, 2009 at 6:03 PM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: Doesn't gclient runhooks --force setup the scons build on linux? Or did the make build become default at some point? Forgot to mention, I have GYP_GENERATORS=make in my environment. The scons build is so slow I

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Antoine Labour
On Thu, Jun 25, 2009 at 5:57 PM, Dan Kegeldaniel.r.ke...@gmail.com wrote: I did  rm Makefile  gclient runhooks --force and it didn't regenerate Makefile. tools/gyp/gyp -f make build/all.gyp does rebuild it. Seems like gclient runhooks --force ought to, no? Are you seeing the same thing

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Dan Kegel
On Thu, Jun 25, 2009 at 6:13 PM, Antoine Labourpi...@google.com wrote: Are you seeing the same thing I am seeing ? For me, through gclient, Makefile is generated one directory up and is messed up. By gum, yes: $ diff Makefile ../Makefile 22c22 builddir ?=

[chromium-dev] apologies for build breakage

2009-06-25 Thread Evan Martin
I did run it through try bots, but overlooked mac because it finished running my job 50 minutes after I submitted it. :~( The especial irony was that the patch is for windowed plugins, which only exist on Windows and Linux; it was just getting typedefs wrong. I will try again later.

[chromium-dev] Re: apologies for build breakage

2009-06-25 Thread Mark Larson (Google)
We're working on adding more trybot capacity (3x for Mac). Additional Macs should come online in the next week or so, which will reduce the try latency. Right now, we're really underpowered. Yoda would be happy that there is no try. Developers, not so much. --Mark On Thu, Jun 25, 2009 at 18:39,

[chromium-dev] Re: about gtest's main in chromium

2009-06-25 Thread Jickae Davis
y, that's what I want. I know nothing about .gyp files, that's the way I can understand, 3x~! 2009/6/26 Marc-Antoine Ruel mar...@chromium.org It's set through .sln dependencies; src\chromepython tools\build\win\sln_deps.py chrome.sln printing_unittests printing_unittests base gtest

[chromium-dev] Re: gclient runhooks --force not forceful enough?

2009-06-25 Thread Antoine Labour
On Thu, Jun 25, 2009 at 6:20 PM, Dan Kegeld...@kegel.com wrote: On Thu, Jun 25, 2009 at 6:13 PM, Antoine Labourpi...@google.com wrote: Are you seeing the same thing I am seeing ? For me, through gclient, Makefile is generated one directory up and is messed up. By gum, yes: $ diff Makefile

[chromium-dev] Where is the CGContextDrawImage() for MacOSx defined

2009-06-25 Thread n179911
Hi, Can you please tell me Where is the CGContextDrawImage() for MacOSx defined? I have tried setting up a Breakpoints in ImageCG.cpp:197. It breaks there but when I click 'step into', it never goes to the implementation of CGContextDrawImage. XCode just jumps to the next line. And I also tried

[chromium-dev] how to judge layouttests' running result?

2009-06-25 Thread David Jones
I have ran layouttests on Windows XP, and got a result as: Expected to fail, but passed (5): LayoutTests/css2.1/t0805-c5519-brdr-r-01-e.html LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html LayoutTests/css2.1/t0905-c5525-flthw-00-c-g.html LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html

[chromium-dev] Re: Where is the CGContextDrawImage() for MacOSx defined

2009-06-25 Thread Eric Roman
CGContextDrawImage() is not defined in Chromium -- it part of Mac OS X's quartz 2D library: http://developer.apple.com/documentation/GraphicsImaging/Reference/CGContext/Reference/reference.html#//apple_ref/c/func/CGContextDrawImage I imagine the reason you can't step into it with XCode, is that

[chromium-dev] Re: Landing two sided patches

2009-06-25 Thread Dimitri Glazkov
Yes, we're working feverishly (is that a good word for this? :) to make this situation a bit less hard. However, in the meantime, the process could go like this: 1) Make sure the canary had a green run. This would really help the WebKit gardener to know which revision to roll up to. 2) Land

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
2009/6/26 John Abd-El-Malek j...@chromium.org 2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the

[chromium-dev] Re: how to judge layouttests' running result?

2009-06-25 Thread Lei Zhang
http://dev.chromium.org/developers/testing/webkit-layout-tests says: ./run_webkit_tests.sh LayoutTests/path/to/your/test.html --full-results-html will produce a page including links to the expected result, actual result, and diff. Does that help? 2009/6/25 David Jones ds...@163.com: I have

[chromium-dev] Re: how to judge layouttests' running result?

2009-06-25 Thread Nico Weber
I usually try to execute the regressing tests manually (most of the time by just open the html file in test shell, sometimes you have to start some local web server). If they pass, I tell myself that the test is just flaky. If they still fail, I start debugging. 2009/6/25 David Jones

[chromium-dev] New waterfall mode for sheriffs

2009-06-25 Thread Nicolas Sylvain
Hello, The console view is not the best for sheriffs since it does not show in details the current state of the tree. The waterfall has always been better for that. But since our waterfall is really big, it can be hard to scroll all the time and keep track of all the failures. For that, I