On Thu, Jun 11, 2009 at 8:03 PM, Michael Nordman wrote:
> Sounds like the underlying issue is not the number of requests (or
> type of request), but the number of SharedMemory instances in use on
> behalf of request handling at any one time.
True; I'll take a look at how else SharedMemory is used
On Thu, Jun 11, 2009 at 7:45 PM, Darin Fisher wrote:
> It seems like this issue, since it is about the shared memory used for
> streaming resources to a renderer, is not particular to file://. It could
> happen with http:// as well assuming we had a fast enough network or a janky
> enough local s
Sounds like the underlying issue is not the number of requests (or
type of request), but the number of SharedMemory instances in use on
behalf of request handling at any one time. Maybe put some limits on
directly on that. When a request gets to the point where it needs a
SharedMemory block it may
On Thu, Jun 11, 2009 at 7:45 PM, Darin Fisher wrote:
> On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan
> wrote:
>
>>
>> I'm working on getting the Intl2 test set from the page cycler up and
>> running on the Mac, which currently crashes very quickly. It turns out
>> that one of the test pages has
On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan wrote:
>
> I'm working on getting the Intl2 test set from the page cycler up and
> running on the Mac, which currently crashes very quickly. It turns out
> that one of the test pages has hundreds of images on it, and we
> simultaneously make hundreds
On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan wrote:
>
> I'm working on getting the Intl2 test set from the page cycler up and
> running on the Mac, which currently crashes very quickly. It turns out
> that one of the test pages has hundreds of images on it, and we
> simultaneously make hundreds
In my experience, taking code which assumes a low number of file
descriptors and just ramping up the file descriptor limits to
accommodate a particular case doesn't work out well. You end up
finding out that there are three or four other edge cases which cause
problems, things like O(N^2) code pa
On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan wrote:
>
> I'm working on getting the Intl2 test set from the page cycler up and
> running on the Mac, which currently crashes very quickly. It turns out
> that one of the test pages has hundreds of images on it, and we
> simultaneously make hundreds
I'm working on getting the Intl2 test set from the page cycler up and
running on the Mac, which currently crashes very quickly. It turns out
that one of the test pages has hundreds of images on it, and we
simultaneously make hundreds of URLRequestFileJobs to load them. Each
of those uses a SharedM
I think such a build would be useful for performance testing of the
rest of our infrastructure. It also makes having a webkit.org
chromium-webkit build easier. I'm not sure how hard maintaining such
a build would be with the new gyp goodness.
-eric
On Thu, Jun 11, 2009 at 4:06 PM, Dimitri Glaz
Kind of tangential, but having a JSC build today would mean that on
linux we could build a 64bit version of chromium so we can test IMEs
sooner on our 64bit workstations.
On Thu, Jun 11, 2009 at 4:06 PM, Dimitri Glazkov wrote:
>
> Team,
>
> Now that we're unforked, we want to concentrate on elimi
IIRC from the Mac porting effort (a year ago now), the JSC build
relies significantly on objective-C dom bindings which we neither want
to use nor are easy to get working in our build system. We jettisoned
them for a reason and my guess is that it would be a non-trivial
effort to re-instate them (
Team,
Now that we're unforked, we want to concentrate on eliminating layout
test failures. Through the magic of the WebKit merge, we've
accumulated quite a few. Today, we expect around 400 failures, which
is not a good number by any stretch.
As one of the ways to help determine the source of the
FWIW, we don't use _cocoa or _mac in browser/cocoa at all, assuming it
was implied. I assumed gtk was doing the same.
On Thu, Jun 11, 2009 at 11:53 AM, Ben Goodger (Google) wrote:
>
> Well, class name is supposed to match the file name in Google style.
>
> -Ben
>
> On Thu, Jun 11, 2009 at 11:22 A
It's in the class registration function in widget_win.cc
-Ben
On Thu, Jun 11, 2009 at 2:52 PM, Peter Kasting wrote:
> On Thu, Jun 11, 2009 at 2:48 PM, Ben Goodger (Google)
> wrote:
>>
>> Daniel, do you want to try making this change instead? It'll be pretty
>> obvious to you if it doesn't work.
On Thu, Jun 11, 2009 at 2:48 PM, Ben Goodger (Google) wrote:
> Daniel, do you want to try making this change instead? It'll be pretty
> obvious to you if it doesn't work.
Filed as crbug.com/13926 . We should try and find if we set a value in the
WindowWin or WidgetWin (or somewhere) window crea
Daniel, do you want to try making this change instead? It'll be pretty
obvious to you if it doesn't work.
-Ben
On Thu, Jun 11, 2009 at 2:43 PM, Ben Goodger (Google) wrote:
> It's worth a shot. We should make sure this is one of the WNDCLASSEX
> fields that when not set causes the window not to b
It's worth a shot. We should make sure this is one of the WNDCLASSEX
fields that when not set causes the window not to be created,
obviously!
-Ben
On Thu, Jun 11, 2009 at 2:40 PM, Peter Kasting wrote:
> On Thu, Jun 11, 2009 at 2:38 PM, Ben Goodger (Google)
> wrote:
>>
>> Is the default cursor c
On Thu, Jun 11, 2009 at 2:38 PM, Ben Goodger (Google) wrote:
> Is the default cursor config in the window class even necessary? Isn't
> the default pointer the arrow anyway? Maybe we could just remove it
> from WindowWin.
As long as Windows doesn't make the mouse cursor disappear by default
when
I see a very faint flicker on XP. It may be exaggerated with different
hardware/driver configs I suppose.
Is the default cursor config in the window class even necessary? Isn't
the default pointer the arrow anyway? Maybe we could just remove it
from WindowWin.
-Ben
On Thu, Jun 11, 2009 at 2:16
If anyone sees this somewhere other than Gmail replies, please comment on
the bug.
On Thu, Jun 11, 2009 at 1:00 PM, Nick Baum wrote:
> Doh, thanks!
> -Nick
>
>
> On Thu, Jun 11, 2009 at 12:18 PM, Peter Kasting wrote:
>
>> On Thu, Jun 11, 2009 at 12:17 PM, Nick Baum wrote:
>>
>>> Has anyone else
On Thu, Jun 11, 2009 at 9:58 AM, Peter Kasting wrote:
> Also if there are problems like this with existing classes please file
> bugs, and since you have some idea of the fix consider fixing them.
>
It looks like maybe this problem occurs when mousing over text in the
Omnibox -- on Vista my curs
fwiw, I created a bug on this:
http://code.google.com/p/chromium/issues/detail?id=13912
I suspect this will be a fun one to fix :)
- a
2009/6/11 Aaron Boodman :
> I think views are going to have to sometimes "check in" with the
> background page on creation. But since the background page is mea
Doh, thanks!
-Nick
On Thu, Jun 11, 2009 at 12:18 PM, Peter Kasting wrote:
> On Thu, Jun 11, 2009 at 12:17 PM, Nick Baum wrote:
>
>> Has anyone else run into this behavior in Chrome, in Gmail or elsewhere?
>> Any suggestions for next steps to track this down?
>>
>
> I suggest searching the bug d
I have the same issue with the Windows language bar and the SCIM
toolbar, I don't think there's really any way to fix this though.
On Thu, Jun 11, 2009 at 1:52 PM, Peter wrote:
>
> Is this possible in chrome currently (perhaps some theme hack would
> allow this??) or through and extension?
>
> I
There's no easy way to do this today.
Erik
On Thu, Jun 11, 2009 at 12:52 PM, Peter wrote:
>
> Is this possible in chrome currently (perhaps some theme hack would
> allow this??) or through and extension?
>
> I want to exclude the tab bar from using some space near the window
> controls in the
Is this possible in chrome currently (perhaps some theme hack would
allow this??) or through and extension?
I want to exclude the tab bar from using some space near the window
controls in the upper left corner of the window.
This space is permanently occupied by winamp on my system (set to
alway
On Thu, Jun 11, 2009 at 12:17 PM, Nick Baum wrote:
> Has anyone else run into this behavior in Chrome, in Gmail or elsewhere?
> Any suggestions for next steps to track this down?
>
I suggest searching the bug database. You will find this:
http://crbug.com/12785
PK
--~--~-~--~~
Hi,
I've been running into a really annoying freeze when typing messages in
Gmail, and I'm trying to figure out if it's Chrome or Gmail. I'll be happily
typing away, and the tab will freeze for several seconds. It keeps accepting
keyboard input and eventually catches up, but in the meantime it's
co
On Thu, Jun 11, 2009 at 11:49 AM, Albert J. Wong
(王重傑) wrote:
> I'll probably just submit the generated files as tony suggested.
Check with Tony, but I think I just reviewed a GYP change which will
make (forgive the pun) it work again.
AGL
--~--~-~--~~~---~--~~
C
Well, class name is supposed to match the file name in Google style.
-Ben
On Thu, Jun 11, 2009 at 11:22 AM, Erik Kay wrote:
> So the class name is the same too in this case? (InfoBubble and InfoBubble)
> Erik
>
> On Thu, Jun 11, 2009 at 10:46 AM, Ben Goodger (Google)
> wrote:
>>
>> sure why no
sorry for the bustage. I had assumed the make file was still a toy with
only 2-3 people using it (not many linux chrome folks where I am).
Thanks for rolling it back Adam. I'll probably just submit the generated
files as tony suggested.
-Albert
On Thu, Jun 11, 2009 at 9:51 AM, Thomas Van Lent
Hi Brad,It started approximately 2 weeks ago
so I guess its more likely the chrome.sln conversion that did it.
Sverrir
On Thu, Jun 11, 2009 at 2:20 PM, Bradley Nelson wrote:
> By last gyp Sverrir, do you mean the modules in chrome.sln switching over,
> or the ones in webkit?There was one genera
On Wed, Jun 10, 2009 at 10:19 PM, Meryl Silverburgh <
silverburgh.me...@gmail.com> wrote:
> On Wed, Jun 10, 2009 at 12:18 PM, John Abd-El-Malek
> wrote:
> >
> >
> > On Wed, Jun 10, 2009 at 11:48 AM, Meryl Silverburgh
> > wrote:
> >>
> >> From this document, it talks about Messaging between
> >>
>
So the class name is the same too in this case? (InfoBubble and InfoBubble)
Erik
On Thu, Jun 11, 2009 at 10:46 AM, Ben Goodger (Google) wrote:
>
> sure why not... the _platform suffix is supposed to be for files in a
> location where multiple platfomrs are built.
>
> -Ben
>
> On Thu, Jun 11, 20
By last gyp Sverrir, do you mean the modules in chrome.sln switching over,
or the ones in webkit?There was one generated set of targets in webkit.gyp,
that we ended up adding a makefile emission option for.
It was just too slow with rules (all the overhead of crossing over into
cygwin per file).
Th
Use of OS X spellchecker integration in our multi process model
probably should be the primary goal here to begin with. If that is
achieved, the other stuff (auto spell correct, automatically setting
the dictionary etc) should not be too problematic.
Note that the actual replacement for auto-corr
I think views are going to have to sometimes "check in" with the
background page on creation. But since the background page is meant to
hold on the "core" logic of your extension, it makes much more sense
to me have its lifetime bookend all other parts of the extension.
- a
On Thu, Jun 11, 2009
sure why not... the _platform suffix is supposed to be for files in a
location where multiple platfomrs are built.
-Ben
On Thu, Jun 11, 2009 at 2:47 AM, Dean McNamee wrote:
> Does this mean we can do something similar for GTK?
>
> It feels a bit unfair that we have to name everything
> browser/g
On Thu, Jun 11, 2009 at 12:26 AM, Daniel Cowx wrote:
> I've fixed this flickering problem by calling ::SetClassLong(hwnd,
> GCL_HCURSOR, NULL) within my OnMouseEntered and then I reset it back
> to the original class cursor in OnMouseExited. Not sure if this is a
> reasonable solution or if you e
On Thu, Jun 11, 2009 at 12:48 PM, Adam Langley wrote:
>
> On Thu, Jun 11, 2009 at 8:52 AM, Tony Chang wrote:
> > Albert, what do you think? I estimate that about 5-7 people on the
> > linux team use the make build these days.
>
> I reverted in r18168. It sucks that there's no try or builders for
On Thu, Jun 11, 2009 at 8:52 AM, Tony Chang wrote:
> Albert, what do you think? I estimate that about 5-7 people on the
> linux team use the make build these days.
I reverted in r18168. It sucks that there's no try or builders for the
make build, but it's what everyone uses these days.
AGL
--
Well, the issue with loading views first is that when you open a new window,
that would create new views. In the extension we've implemented, the
background page iterates through the views whenever it needs to update them.
Alternatively, we may want to implement onViewCreated events so it's easier
I am somewhat confused wrt. loading sequence. If background page main task
is to load data once for all views, and then to update them, shouldn't then
views be loaded first (toolstrips etc.)?
*background_page*:
...
1. gather data once
...
2. update all views // if loads first, no other views are go
The make file generator has a bug. I started to work on fixing the
build last night but it's not finished and I'm not sure how long it
will take me this morning. I think it's a little unfair to revert
even though all the buildbots are green (since there's no make
buildbot and we can use the scon
Hey all,
Dean reminded me that because we are developing Chrome for multiple
platforms, there will be differences between the various ports that
may affect the security of our code. E.g. if we use different
implementations of image decoders on different ports, Chromium as a
whole will have more "
Yes, it was my patch, it is completely my fault, I take all the blame.. I'm
very sorry about that...
The patch had been reviewed but through another revision that was mentioned
in the comments... I should have put a link to it as opposed to only the
revision ID (I'm used to internal tools that inse
On Thu, Jun 11, 2009 at 2:39 AM, Dean McNamee wrote:
> At least for me, I'm hitting an error with generate_stubs.py. Will
> try to figure out the proper fix, in the mean time I fixed up the
> paths manually and ran the following from my source root. I was able
> to successfully build. This is f
Just wanted to echo Mohamed's findings. My build has been very slow the
past two weeks. I'm using VS2008 and I have not used /MP recently. I have
a top of the line machine (xw6600 Quad Core 8G mem, Intel SSD) and building
chrome.exe after a sync/clean takes approx 40 minutes.I think this started
Reoccuring lesson, when you're looking for a shotty change, look for
the ones with the worst commit messages:
Of course I overlooked the change 50 times because the message tells
you absolutely nothing, doesn't have a review URL, etc.
I don't feel like figuring out what is wrong with this patch,
One of the ideas would be to bisect the archived builds
(http://build.chromium.org/buildbot/continuous/linux/LATEST/).
I am also working on hunting this down. I'll let you know when/if I
find anything.
Thanks for the great help
-- dean
On Thu, Jun 11, 2009 at 1:15 PM, Craig
Schlenter wrote:
>
It might not be r18131 ... I compiled head without 18131 and even
though it looked like that helped earlier, it's broken again now.
Interestingly when opening new tabs, only some of them are broken
which is probably why I thought it was ok earlier ... will leave
something bisecting in the backroun
Hi Dean
I am seeing the same thing ... it seems to be r18131 that is at fault.
I have not tracked it down further than that ...
Shared build is also bust. See attached patch ... dunno if that's the right fix.
--Craig
On Thu, Jun 11, 2009 at 11:58 AM, Dean McNamee wrote:
> Something related to i
most of it will, but i never tried it
however, i saw here in this forum ppl complaining that /MP on 2005
creates corrupted .PDB (the debug info) files
so i don't know, but the incremental linking should work
if you wish you can PM me and i will send you whatever you want
(even the tool i wrote t
Do you think it will also work for Visual Studio 2005 and Windows Vista?
☆PhistucK
On Thu, Jun 11, 2009 at 12:39, nakro wrote:
>
> Mohamed, if you wish i can share with you the "tricks" i do on my
> machine
> they make the difference of even building chrome.exe from 10 mins to
> less than 1 (af
Does this mean we can do something similar for GTK?
It feels a bit unfair that we have to name everything
browser/gtk/blah_gtk.cc and BrowserToolbarGtk, etc, while views gets
the short name. For example
views: views/info_bubble.cc and class name InfoBubble
gtk: gtk/info_bubble_gtk.cc and class
At least for me, I'm hitting an error with generate_stubs.py. Will
try to figure out the proper fix, in the mean time I fixed up the
paths manually and ran the following from my source root. I was able
to successfully build. This is for a debug build, replace Debug w/
Release for a release buil
Mohamed, if you wish i can share with you the "tricks" i do on my
machine
they make the difference of even building chrome.exe from 10 mins to
less than 1 (after a small source code change)
all this on my very very slow machine
i wrote a small exe program which parses the .vsprops and ..vcproj so
I've fixed this flickering problem by calling ::SetClassLong(hwnd,
GCL_HCURSOR, NULL) within my OnMouseEntered and then I reset it back
to the original class cursor in OnMouseExited. Not sure if this is a
reasonable solution or if you even think this is a problem. If so, I
can file a bug report an
You can set the environmental variable in XCode by double clicking on the
executable target.
I'm not sure the logging code is enabled on OSX, the right place to look
would be in chrome/common/ipc_channel_posix.cc, search for
IPC_MESSAGE_LOG_ENABLED.
If that's compiled in, then if the env variable
60 matches
Mail list logo
