[chromium-dev] Re: buildbot failure in Chromium on Chromium Builder (dbg), revision 36644

2010-01-20 Thread Jeremy Orlow
on it. Sorry. On Wed, Jan 20, 2010 at 10:52 AM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for compile on Chromium Builder (dbg) http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder%20%28dbg%29/builds/15729

Re: [chromium-dev] how to disable SVG when building chromium

2010-01-18 Thread Jeremy Orlow
http://trac.webkit.org/browser/trunk/WebKit/chromium/features.gypi WebKit is under third_party/WebKit in the src tree On Mon, Jan 18, 2010 at 11:45 PM, n179911 n179...@gmail.com wrote: Hi, Webkit has an option to disable SVG build with the executable. Can you please tell me how can I

Re: [chromium-dev] Ajax maximum response size

2010-01-15 Thread Jeremy Orlow
Either way, it seems like these are bugs that are worthy of being filed. Greg, any advice? J On Fri, Jan 15, 2010 at 10:20 AM, Rryk rryk...@gmail.com wrote: Hello, I am implementing 3D rendering engine for Chromium and I need to download huge scenes via Ajax. However I've noticed that

Re: [chromium-dev] RFC: Extensions Incognito

2010-01-13 Thread Jeremy Orlow
On Wed, Jan 13, 2010 at 3:48 PM, Antony Sargent asarg...@google.com wrote: What if the Incognito profile started with a copy-on-write version of extensions' localStorage? That way extensions in Incognito mode would see the writes they just made, but changes would not persist beyond Incognito

Re: [chromium-dev] Re: updates to tech talks page: added link to Exploring Chrome Internals slide deck, etc

2010-01-13 Thread Jeremy Orlow
On Wed, Jan 13, 2010 at 3:55 PM, Chase Phillips ch...@chromium.org wrote: On Wed, Jan 13, 2010 at 14:50, Chase Phillips ch...@chromium.org wrote: Darin's June 2, 2009 Google I/O Exploring Chrome Internals presentation slide deck is now available from

Re: [chromium-dev] WebKit Gardeners 3 rebaseline.py -w

2010-01-08 Thread Jeremy Orlow
Same here. On Fri, Jan 8, 2010 at 4:51 PM, Drew Wilson atwil...@chromium.org wrote: Do you find that you have time to figure out if rebaselining a test is the right thing to do while you're actively gardening? Maybe I just work too slowly, but I often find that if I'm trying to rebaseline on

Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-07 Thread Jeremy Orlow
On Thu, Jan 7, 2010 at 1:10 PM, Charlie Reis cr...@chromium.org wrote: On Thu, Jan 7, 2010 at 12:53 PM, Ben Laurie b...@google.com wrote: On Thu, Jan 7, 2010 at 8:43 PM, Fady Samuel fadysam...@gmail.com wrote: Charles, I've read your paper and ultimately I think my goal may be somewhere

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07 Thread Jeremy Orlow
(As discussed during lunch...) Why not just do this in this case and remove EmptyString() altogether? const std::string MyClass::foo() const { static std::string empty = EmptyString(); return (everything == OK) ? member_string : empty; } I forget if this runs the constructor on first use or

Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-07 Thread Jeremy Orlow
And before you suggest using software transactional memory, keep in mind that side effects (XHRs and other network activity for example) are prevalent in normal JavaScript usage. I don't mean to discourage you too muchespecially if you were interested in digging really deeply into this

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07 Thread Jeremy Orlow
On Thu, Jan 7, 2010 at 1:38 PM, Peter Kasting pkast...@google.com wrote: On Thu, Jan 7, 2010 at 1:34 PM, Jeremy Orlow jor...@chromium.org wrote: (As discussed during lunch...) Why not just do this in this case and remove EmptyString() altogether? const std::string MyClass::foo() const

Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07 Thread Jeremy Orlow
What about renaming the function? EmptyStringHACK() or something? On Thu, Jan 7, 2010 at 1:49 PM, Peter Kasting pkast...@google.com wrote: On Thu, Jan 7, 2010 at 1:43 PM, Jeremy Orlow jor...@chromium.org wrote: You ignored the second half of my suggestion. The second half of your

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-30 Thread Jeremy Orlow
On Wed, Dec 30, 2009 at 3:43 PM, Peter Kasting pkast...@google.com wrote: On Wed, Dec 30, 2009 at 3:22 PM, Jeremy Orlow jor...@google.com wrote: I just got back from vacation and would like to take action on this. I read through the thread, but I don't see any sort of consensus on what

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-30 Thread Jeremy Orlow
won't delete the --enable-webgl flag bug forget to delete the --disable-sandbox-until flag. On Wed, Dec 30, 2009 at 3:56 PM, Jeremy Orlow jor...@google.com wrote: On Wed, Dec 30, 2009 at 3:43 PM, Peter Kasting pkast...@google.com wrote: On Wed, Dec 30, 2009 at 3:22 PM, Jeremy Orlow jor

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

2009-12-11 Thread Jeremy Orlow
On Fri, Dec 11, 2009 at 1:10 AM, Kenneth Russell k...@chromium.org wrote: (Resending from chromium.org) On Thu, Dec 10, 2009 at 8:22 PM, Darin Fisher da...@chromium.org wrote: After reading the WebGL blog post today, and following the link to the wiki, it struck me as fairly *bad* that we

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

2009-12-11 Thread Jeremy Orlow
On Fri, Dec 11, 2009 at 8:06 AM, Darin Fisher da...@chromium.org wrote: I don't understand the argument for a periodic indicator. We don't have a periodic indicator telling the user when to restart their browser to pick up auto-updates. I don't think this is a fair comparison. One is a

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread Jeremy Orlow
Or reject extensions that could be written without a NPAPI component. *ducks* On Thu, Dec 10, 2009 at 5:12 PM, Peter Kasting pkast...@google.com wrote: On Thu, Dec 10, 2009 at 5:02 PM, Avi Drissman a...@google.com wrote: Q: Can't we have the extensions gallery warn that it won't work? A:

Re: [chromium-dev] Extensions and the Mac

2009-12-10 Thread Jeremy Orlow
Much of what can't be done on the web platform also can't be done inside the NaCl sandbox. On Thu, Dec 10, 2009 at 5:49 PM, John Abd-El-Malek jabdelma...@google.comwrote: NaCl is the answer to all these problems... On Thu, Dec 10, 2009 at 5:15 PM, Jeremy Orlow jor...@google.com wrote

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-10 Thread Jeremy Orlow
-in to disabling the sandbox, but I'm not sure that out-weighs the cost of having a good number of dev channel users running *permanently* without the sandbox. Was this idea considered? Any other ideas? From a past thread on the subject: On Thu, Oct 8, 2009 at 9:58 AM, Jeremy Orlow jor

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-10 Thread Jeremy Orlow
On Thu, Dec 10, 2009 at 9:29 PM, Jeremy Orlow jor...@google.com wrote: On Thu, Dec 10, 2009 at 8:22 PM, Darin Fisher da...@chromium.org wrote: After reading the WebGL blog post today, and following the link to the wiki, it struck me as fairly *bad* that we are telling people to disable

[chromium-dev] Re: Chromium Tech Talks

2009-12-09 Thread Jeremy Orlow
On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow jor...@chromium.org wrote: Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they are! http://www.youtube.com/watch?v=JFzC_Gx76E8 Darin Fisher talks about the recently upstreamed

Re: [chromium-dev] Re: Chromium Tech Talks

2009-12-09 Thread Jeremy Orlow
Personally, I really like the tech talk format as an introduction to a topic, but you're right that some would prefer something in written form and that a Wiki has many benefits that a video does not have. If you're willing to transcribe the information, I'm sure it would help others. On Wed,

Re: [chromium-dev] Reflecting SSL state in a world with SharedWorkers and cross-window sharing/x-domain messaging

2009-12-09 Thread Jeremy Orlow
Personally, I feel the opposite, and I'm not sure the perfect is the enemy of good analogy doesn't really fit. If we erode the meaning of the secure (as opposed to mixed) content icon, it seems like we're just going to need to create UI in the future that says this is really super secure. I

[chromium-dev] Chromium Tech Talks

2009-12-08 Thread Jeremy Orlow
Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they are! http://www.youtube.com/watch?v=JFzC_Gx76E8 Darin Fisher talks about the recently upstreamed Chromium WebKit API. http://www.youtube.com/watch?v=bO3XEBuIDns Pam Greene talks

[chromium-dev] Re: Chromium Tech Talks

2009-12-08 Thread Jeremy Orlow
On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow jor...@chromium.org wrote: Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they are! http://www.youtube.com/watch?v=JFzC_Gx76E8 Darin Fisher talks about the recently upstreamed

Re: [chromium-dev] Need a linux-views build buddy.

2009-12-03 Thread Jeremy Orlow
Isn't gcl try cl -b linux_view what you want? On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton pinker...@chromium.orgwrote: I've got a cl that builds fine on win/mac/linux but I'm afraid I could impact views_linux. And, since there's no trybot, I have no way of knowing until I actually check in

Re: [chromium-dev] Beginning with development

2009-11-20 Thread Jeremy Orlow
libraries (by the builbots) corresponding to the revision you're syncing. With this, a full initial checkout will produce a structure where you only need to rebuild the modules you've changed their sourcecode to get the final executable. On Tue, Nov 10, 2009 at 11:34 PM, Jeremy Orlow jor

Re: [chromium-dev] Any interest in command line tools for network stack?

2009-11-13 Thread Jeremy Orlow
What's the intended purpose of such tools? Do they offer any functionality beyond the standard tools? Do you envision them being helpful to people debugging the Chromium network stack? (Me replying does in no way imply that I have the authority to say yes or no, btw. :-) On Fri, Nov 13, 2009

Re: [chromium-dev] More sheriffs?

2009-11-13 Thread Jeremy Orlow
For a while now, I've advocated having 2 pacific timezone sheriffs always on duty and having one or two in other time zones. I still advocate such an idea. So, to be clear, I think this is a good idea as long as the distribution of sheriffs (time zone wise) is deliberate. (I think this

Re: [chromium-dev] Re: [chromium-extensions] openDatabase() maximum size

2009-11-13 Thread Jeremy Orlow
Just for the record, you're also the one who originally said it was fine to limit them to 5mb (for LocalStorage anyhow). :-) What kind of extra space did you have in mind? Unlimited? It's pretty late in the game to be making a decision like this for mstone-4, but it might be possible if this

Re: [chromium-dev] Re: [chromium-extensions] openDatabase() maximum size

2009-11-13 Thread Jeremy Orlow
On Fri, Nov 13, 2009 at 1:21 PM, Aaron Boodman a...@chromium.org wrote: On Fri, Nov 13, 2009 at 1:07 PM, Jeremy Orlow jor...@chromium.org wrote: Just for the record, you're also the one who originally said it was fine to limit them to 5mb (for LocalStorage anyhow). :-) It is a consistent

Re: [chromium-dev] Re: More sheriffs?

2009-11-13 Thread Jeremy Orlow
Maybe we should say at least one PST and at least one non-Americas? Note that even if people outside of the Americas are getting sheriff duty more often, the duty is lighter weight...so I think it balances out fairly well. As we get more non-Americas committers, we can think about adding

Re: sheriff's keep the tree *open* WAS: [chromium-dev] More sheriffs?

2009-11-13 Thread Jeremy Orlow
+1 (for what it's worth) On Fri, Nov 13, 2009 at 2:28 PM, Ojan Vafai o...@google.com wrote: On Fri, Nov 13, 2009 at 1:25 PM, Peter Kasting pkast...@google.comwrote: On Fri, Nov 13, 2009 at 1:15 PM, Finnur Thorarinsson fin...@google.comwrote: If the sheriff load is too much for two people

Re: [chromium-dev] More sheriffs?

2009-11-13 Thread Jeremy Orlow
On Fri, Nov 13, 2009 at 3:38 PM, Peter Kasting pkast...@google.com wrote: On Fri, Nov 13, 2009 at 2:56 PM, Dirk Pranke dpra...@chromium.org wrote: I think two sheriffs in US/Pacific during US/Pacific work hours is plenty. I was told at lunch that we already try to some degree to schedule

[chromium-dev] Re: OWP feature owners: Please update the OWP roadmap.

2009-11-13 Thread Jeremy Orlow
of the reasons this list is so incomplete). On Thu, Nov 12, 2009 at 12:56 PM, Jeremy Orlow jor...@chromium.org wrote: Things here have gotten a little stale: http://dev.chromium.org/developers/web-platform-status Can everyone working on OWP features please take a look and make sure what's written

[chromium-dev] OWP feature owners: Please update the OWP roadmap.

2009-11-12 Thread Jeremy Orlow
Things here have gotten a little stale: http://dev.chromium.org/developers/web-platform-status Can everyone working on OWP features please take a look and make sure what's written there syncs up with reality? To edit: Scroll to the bottom, click sign in, sign in, then click edit page at the top.

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Jeremy Orlow
On Thu, Nov 12, 2009 at 1:30 PM, Peter Kasting pkast...@google.com wrote: A while ago I asked about the feasibility of setting up a WebKit Windows try server. I seem to recall maruel mentioning that he didn't know it was an interesting case and he'd look into it; and I know in general that

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Jeremy Orlow
On Thu, Nov 12, 2009 at 1:46 PM, Peter Kasting pkast...@google.com wrote: On Thu, Nov 12, 2009 at 1:43 PM, Nicolas Sylvain nsylv...@google.comwrote: On Thu, Nov 12, 2009 at 1:30 PM, Peter Kasting pkast...@google.comwrote: I'm wondering if this is any more doable today than it was last time I

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Jeremy Orlow
On Thu, Nov 12, 2009 at 1:50 PM, Adam Barth aba...@chromium.org wrote: On Thu, Nov 12, 2009 at 1:46 PM, Jeremy Orlow jor...@google.com wrote: Btw, there's a webkit-dev thread out there right now about adding try servers. I don't think anyone's figured out where the hardware will come from

Re: [chromium-dev] WebKit Windows try server?

2009-11-12 Thread Jeremy Orlow
can put them to work within a week. Adam On Thu, Nov 12, 2009 at 1:54 PM, Marc-Antoine Ruel mar...@chromium.org wrote: To be clear, I have ~10 mac minis dying in a closet waiting for jobs. On Thu, Nov 12, 2009 at 4:52 PM, Jeremy Orlow jor...@google.com wrote: On Thu, Nov 12, 2009 at 1

Re: [chromium-dev] Re: Tech talk topics

2009-11-11 Thread Jeremy Orlow
for a GraphicsContext port? What is the bottleneck in the paint process (e.g. the Skia blit ops)? 2009/11/5 Jeremy Orlow jor...@chromium.org Thanks for the suggestions so far! Here's what I've seen so far: WebKit API - Darin? Eric's WebKit talk LayoutTests - Pam? Bindings - Andrew? Keep the ideas coming

Re: [chromium-dev] Re: Tech talk topics

2009-11-11 Thread Jeremy Orlow
, Peter Kasting pkast...@google.com wrote: On Wed, Nov 11, 2009 at 11:20 AM, Jeremy Orlow jor...@chromium.org wrote: I think there's some painting stuff touched on in the first round of talks, but nothing terribly in depth. Are there others that would be interested

[chromium-dev] Local Storage directory moved as of rev 31584

2009-11-10 Thread Jeremy Orlow
*If you don't use extensions that use Local Storage or you only use the official Google Chrome builds, you can probably ignore this. (Local Storage was only enabled by default as of last Friday.)* As of svn rev 31584http://src.chromium.org/viewvc/chrome?view=revrevision=31584, local storage

Re: [chromium-dev] Beginning with development

2009-11-10 Thread Jeremy Orlow
On Tue, Nov 10, 2009 at 2:31 PM, Roberto Perez robj.pe...@gmail.com wrote: As Phistuck said, modifying gclient config file and then skipping the changes of the modules that you're not working on seems a good solution to prevent continuous rebuildings of other modules. But this doesn't skip

[chromium-dev] Re: 437k files checked out for an official build

2009-11-09 Thread Jeremy Orlow
This is related to the thread (last Friday?) about making a light weight checkout of Chromium the default. Btw a quick look indicates that 100k are Google specific files (hermetic build environment and such). 200k are layout tests. So that leaves only 150k filesprobably many of which are

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Jeremy Orlow
In general, it might be interesting to document how to get a more lean checkout of Chromium. On Thu, Nov 5, 2009 at 11:34 AM, Adam Barth aba...@chromium.org wrote: Can we note this on dev.chromium.org somewhere? Adam On Thu, Nov 5, 2009 at 11:16 AM, Steve VanDeBogart vand...@chromium.org

[chromium-dev] Lean Chromium checkout (WAS: Large commit - update your .gclient files to avoid)

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 12:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.orgwrote: it'd be nice to have a gclient config lean or something like that. It'd be nice for it to be the default in fact. I know we've avoided

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Jeremy Orlow
I started a new thread about a lite version of the checkout. Might be good to move discussion there. On Thu, Nov 5, 2009 at 12:44 PM, Scott Hess sh...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread Jeremy Orlow
On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.org wrote: Over the last week, I've been making some changes to how threads are used in the browser process, with the goal of simplifying cross-thread access and improving stability. *The problem* We were using a number of

[chromium-dev] Tech talk topics

2009-11-05 Thread Jeremy Orlow
About 6 months ago, we had a series of tech talks on various bits of Chromium's architecture. (They're listed here: http://dev.chromium.org/developers/tech-talk-videos) The youtube ratings are pretty high, they've all had over a thousand views, and I've seen them mentioned in a couple

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Nov 2, 2009 at 9:50 PM, John Abd-El-Malek j...@chromium.orgwrote: Over the last week, I've been making some changes to how threads

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Jeremy Orlow
about some WebKit tech talks? Such talks would be incredibly valuable to those helping out now and then with WebKit. -Scott On Thu, Nov 5, 2009 at 1:35 PM, Jeremy Orlow jor...@chromium.org wrote: About 6 months ago, we had a series of tech talks on various bits of Chromium's architecture

[chromium-dev] Re: Changes to using threads in the browser process

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 2:01 PM, John Abd-El-Malek j...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:42 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:34 PM, John Abd-El-Malek j...@chromium.orgwrote: On Thu, Nov 5, 2009 at 1:15 PM, Jeremy Orlow jor

[chromium-dev] The future for test shell (WAS: test_shell performance is bad compared to Chromium)

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 2:46 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: test_shell being a test shell used mostly for

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Jeremy Orlow
: A general big picture talk would be a great starter. How the DOM is modeled, how the render tree works, the interesting objects ... -Scott On Thu, Nov 5, 2009 at 2:22 PM, Jeremy Orlow jor...@chromium.org wrote: Sure...we definitely have some in-house expertise on this. I could even see if any

[chromium-dev] Re: The future for test shell (WAS: test_shell performance is bad compared to Chromium)

2009-11-05 Thread Jeremy Orlow
On Thu, Nov 5, 2009 at 3:01 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Nov 5, 2009 at 2:46 PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Nov 5, 2009 at 1:59 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: On Thu, Nov 5, 2009 at 4:32 PM, Dirk Pranke dpra

[chromium-dev] Re: Tech talk topics

2009-11-05 Thread Jeremy Orlow
. - Mohamed Mansour On Thu, Nov 5, 2009 at 5:17 PM, Scott Violet s...@chromium.org wrote: It's not Chromium, but how about some WebKit tech talks? Such talks would be incredibly valuable to those helping out now and then with WebKit. -Scott On Thu, Nov 5, 2009 at 1:35 PM, Jeremy Orlow jor

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-11-03 Thread Jeremy Orlow
Ha. http://tech.slashdot.org/story/09/11/03/1334203/X11-Chrome-Reportedly-Outperforms-Windows-and-Mac-Versions On Fri, Oct 30, 2009 at 9:44 AM, Linus Upson li...@google.com wrote: scrolling jank in gmail http://crbug.com/25741 Linus On Wed, Oct 28, 2009 at 12:05 PM, Adam Barth

[chromium-dev] Re: Which editor do you recommend on Mac OS X?

2009-11-03 Thread Jeremy Orlow
On Tue, Nov 3, 2009 at 10:12 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: On Tue, Nov 3, 2009 at 19:08, Drew Wilson atwil...@chromium.org wrote: I've also been known to use the built-in GNU emacs from a terminal shell (especially when working remotely/SSH-ing). I see no reason why you

[chromium-dev] PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Jeremy Orlow
I've spent a good deal of this week trying to track down what turned out to be a simple but fairly common problem: I forgot virtual dispatch only partially works in destructors. There have been several email threads about this, but it still bites us form time to time, so I thought it was worth

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Jeremy Orlow
any mention of such a thing. On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow jor...@chromium.org wrote: I've spent a good deal of this week trying to track down what turned out to be a simple but fairly common problem: I forgot virtual dispatch only partially works in destructors. There have

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Jeremy Orlow
From http://dev.chromium.org/developers/how-tos/build-instructions-windows Ensure that /MP is enabled. You can do this by creating a file called inc lude.gypi which contains the following lines: { 'variables': { 'msvs_multi_core_compile': 1 } } Put this file in a folder

[chromium-dev] Re: [Green Tree] Task Force Status Update 10/26

2009-10-28 Thread Jeremy Orlow
On Tue, Oct 27, 2009 at 11:37 PM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote: On Wed, Oct 28, 2009 at 00:44, Ian Fette i...@chromium.org wrote: In an effort to provide more transparency into what the team is working on, I'm sending out the meeting notes from the green tree task force to

[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Jeremy Orlow
Why did you use the internal nacl mailing list? This is an issue that affects all of Chromium. The NaCl team members are on chromium-dev, right? If not, they should have been the day that our fates became intertwined. J On Tue, Oct 20, 2009 at 12:17 PM, John Grabowski j...@chromium.org wrote:

[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Jeremy Orlow
I'll follow up with the NaCl team to make sure they are. On Wed, Oct 21, 2009 at 11:57 AM, John Grabowski j...@chromium.org wrote: On Wed, Oct 21, 2009 at 11:37 AM, Jeremy Orlow jor...@chromium.orgwrote: Why did you use the internal nacl mailing list? To keep things unambiguous and try

[chromium-dev] Crashing layout tests

2009-10-20 Thread Jeremy Orlow
Today I noticed a bunch of recently added CRASH test expectations for layout tests. I know that we sometimes have to roll in a crasher or two, but aren't we supposed to be filing p0-p1, dev channel release blockers at least until we can prove the crash is not exploitable in the browser and

[chromium-dev] Re: Crashing layout tests

2009-10-20 Thread Jeremy Orlow
, they can draft someone. (In general, I think we should empower gardeners to draft people when there are lots of high prioirity items stacking up and/or we get really behind ToT.) On Tue, Oct 20, 2009 at 9:23 AM, Jeremy Orlow jor...@chromium.org wrote: Today I noticed a bunch of recently added

[chromium-dev] Re: Crashing layout tests

2009-10-20 Thread Jeremy Orlow
On Tue, Oct 20, 2009 at 10:25 AM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Oct 20, 2009 at 10:19 AM, David Levin le...@google.com wrote: That sounds like a reasonable policy. Hmm...I thought this was the policy. I guess not? :-) There is the current idea of figuring out

[chromium-dev] Re: WebKit API wrapper for Document

2009-10-20 Thread Jeremy Orlow
Darin knows for sure, but I'm not aware of any intentions on Google's part to engineer such an elaborate API. As long as it didn't add a major maintenance burden (i.e. exposed things similar to one of the other WebKit APIs) I'd imagine patches would be welcome though. I believe only Darin can

[chromium-dev] Re: LTTF helping the GTTF make cycle times *minutes* faster

2009-10-16 Thread Jeremy Orlow
On Fri, Oct 16, 2009 at 2:34 PM, Ojan Vafai o...@google.com wrote: Thanks for everyone's help. Good overnight progress. 6 media tests skipped. 2 tests marked SLOW. 5 assigned. 12 unassigned general tests. 10 unassigned Mac plugin tests. Any takers? WIN/LINUX/MAC

[chromium-dev] Re: When disabling a test, please assign to whoever wrote it

2009-10-15 Thread Jeremy Orlow
This is still happening. VERY annoying. ANYONE who is disabling tests, marking them flaky, etc needs to take the 30 seconds required to svn blame the file and cc people the relevant people. On Tue, Sep 22, 2009 at 2:33 PM, Aaron Boodman a...@chromium.org wrote: Seriously. In a project as big

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Jeremy Orlow
, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 7:17 PM, Jeremy Orlow jor...@chromium.org wrote: I think the main points of contention regarding SecurityOrigin::toString() are the name toString and what type it should return. In terms of the names: I think we should provide

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Jeremy Orlow
Christmas came early for anyone working on WebKit! Thanks Glen. :-) On Thu, Oct 15, 2009 at 9:17 AM, Erik Corry erik.co...@gmail.com wrote: This makes me very happy! 2009/10/15 Glenn Wilson gwil...@chromium.org: Hi Webkit gardeners, The Windows canary bot now generates formatted layout

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Jeremy Orlow
On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.com

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Jeremy Orlow
On Thu, Oct 15, 2009 at 12:17 PM, Michael Nordman micha...@google.comwrote: On Thu, Oct 15, 2009 at 12:16 PM, Michael Nordman micha...@google.comwrote: On Thu, Oct 15, 2009 at 11:45 AM, Jeremy Orlow jor...@chromium.orgwrote: On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman micha

[chromium-dev] Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
Right now, we don't have a good story for what to do with WebCore::SecurityOrigins in Chromium. We now have a WebSecurityOrigin in WebKit, but if you want to move the data between processes, you need to convert it to a string and then send that. In some cases we then convert the string to a

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
::WebSecurityOrigin). We can then deal with these details only if/when we need to. On Wed, Oct 14, 2009 at 1:36 PM, Jeremy Orlow jor...@chromium.org wrote: Right now, we don't have a good story for what to do with WebCore::SecurityOrigins in Chromium. We now have a WebSecurityOrigin in WebKit

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow jor...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman micha...@google.comwrote: +1 SecurityOrigin class Sounds like a reasonable plan. I suspect

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.com wrote: As mentioned f2f, this falls apart as soon as Chrome tries to manufacture a security origin. I'm not sure, may already have instances of that

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 2:48 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:30 PM, Jeremy Orlow jor...@chromium.orgwrote: On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher da...@chromium.orgwrote

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 3:58 PM, Dumitru Daniliuc d...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:30 PM, Jeremy Orlow jor...@chromium.orgwrote: On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher da...@chromium.orgwrote

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow jor...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman micha...@google.comwrote: +1 SecurityOrigin class Sounds like a reasonable plan. I suspect

[chromium-dev] Re: layout test dashboard goofup

2009-10-14 Thread Jeremy Orlow
I assume we're going to start backing this data up from now on? On Wed, Oct 14, 2009 at 4:13 PM, Peter Kasting pkast...@google.com wrote: On Wed, Oct 14, 2009 at 3:58 PM, Ojan Vafai o...@google.com wrote: I accidentally checked in some test code (one number was wrong!) and clobbered all but

[chromium-dev] Re: layout test dashboard goofup

2009-10-14 Thread Jeremy Orlow
a volunteer! :D :D :D On Wed, Oct 14, 2009 at 4:15 PM, Jeremy Orlow jor...@chromium.org wrote: I assume we're going to start backing this data up from now on? On Wed, Oct 14, 2009 at 4:13 PM, Peter Kasting pkast...@google.com wrote: On Wed, Oct 14, 2009 at 3:58 PM, Ojan Vafai o...@google.com

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
On Wed, Oct 14, 2009 at 4:32 PM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 4:03 PM, Jeremy Orlow jor...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:58 PM, Dumitru Daniliuc d...@chromium.orgwrote: On Wed, Oct 14, 2009 at 2:47 PM, Darin Fisher da

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
If this is the case, then I don't think a SecurityOrigin wrapper buys us anything. Never mind. On Wed, Oct 14, 2009 at 4:37 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:59 PM, Jeremy Orlow jor...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:48 PM, Darin Fisher da

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Jeremy Orlow
, but if all WebKit types follow this same convention, then it's much less likely that people will do stupid things with them. J On Wed, Oct 14, 2009 at 5:15 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 4:51 PM, Jeremy Orlow jor...@chromium.org wrote: You mean string16

[chromium-dev] Re: Please confirm the bug (some bitmaps aren/t displayed)

2009-10-12 Thread Jeremy Orlow
I think the bigger issue is how/when Area-Misc bugs get triaged. Do they ever? If not, we should probably change that. On Mon, Oct 12, 2009 at 11:50 AM, Guria guria...@gmail.com wrote: Please confirm the bug http://code.google.com/p/chromium/issues/detail?id=12900 It really annoys me. I

[chromium-dev] Re: Buildbot upgrade

2009-10-11 Thread Jeremy Orlow
Is there documentation anywhere for all the parameters you can feed into the buildbot webpage? If not, a cheat sheet would be really helpful. On Sat, Oct 10, 2009 at 6:25 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, Today I upgraded buildbot to the latest version. If you have a

[chromium-dev] Re: Friendly reminder: don't let changes rot

2009-10-08 Thread Jeremy Orlow
Part of this has to do with your level of experience and how big the review is. Doing code reviews for people not yet up to speed is _painful_. And large reviews also can be. I think part of the reason things seem better to you is a reflection on your level of experience. That said, some of us

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Jeremy Orlow
Pawel, I was responding to the idea of suspending a tab. I agree that exposing this information to extensions wouldn't be too hard and could be quite useful. On Wed, Oct 7, 2009 at 12:37 PM, Charles Reis cr...@chromium.org wrote: On Wed, Oct 7, 2009 at 12:25 PM, Jeremy Orlow jor

[chromium-dev] Re: networking code in src/third_party/WebKit/WebCore/platform/network/mac

2009-10-06 Thread Jeremy Orlow
I'm 99% sure we use what's in third_party On Mon, Oct 5, 2009 at 11:06 PM, hap 497 hap...@gmail.com wrote: Hi, Can you please tell me if chromium on Mac OS X uses the networking code in src/third_party/WebKit/WebCore/platform/network/mac? Or the code there is for Webkit? I asked because

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread Jeremy Orlow
On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.org wrote: On Tue, Oct 6, 2009 at 4:30 PM, Carlos Pizano c...@google.com wrote: On Tue, Oct 6, 2009 at 4:14 PM, John Abd-El-Malek j...@chromium.org wrote: I'm not sure how Carlos is doing it? Will we know if something is

[chromium-dev] Re: build time speed improvement with solid state drive?

2009-10-05 Thread Jeremy Orlow
On Mon, Oct 5, 2009 at 11:14 AM, Amanda Walker ama...@chromium.org wrote: On Mon, Oct 5, 2009 at 2:08 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: I'm putting together a new computer and I'd like to optimize my chromium build times :-) Is anyone currently building chromium using a

[chromium-dev] Re: Drive Chrome Automation from Outside Browser Process

2009-10-05 Thread Jeremy Orlow
How is this different from ChromeBot? How you control things depends on what level of realism you want. If you're just verifying the sites work correctly, you might just use the code the UI tests use. If you want to actually simulate button clicks and such, then you'll need something more like

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-10-02 Thread Jeremy Orlow
I totally agree. I envision it being something much more like RSS feeds. In my mind, it should always advertise itself to the browser and then the browser should decide how to advertise it to the user. Requiring scripts to initiate things seems silly to me. Is this API even part of any

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-10-02 Thread Jeremy Orlow
On Fri, Oct 2, 2009 at 2:48 PM, Peter Kasting pkast...@google.com wrote: On Fri, Oct 2, 2009 at 2:47 PM, Jeremy Orlow jor...@chromium.org wrote: Is this API even part of any standard? Maybe we should bring this up on WhatWG? The thread title is a clue that these are specced in HTML5

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

2009-10-02 Thread Jeremy Orlow
all of this functionality for a site in one shot... e.g. if the site published the data via some kind of link tag then a menu item in the browser might activate that the user could use to activate it. -Ben On Fri, Oct 2, 2009 at 2:55 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 2

[chromium-dev] Re: XP Perf page load regression on morejs and moz page cyclers

2009-10-01 Thread Jeremy Orlow
On Thu, Oct 1, 2009 at 12:38 PM, Scott Hess sh...@chromium.org wrote: On Thu, Oct 1, 2009 at 11:32 AM, Mike Belshe mbel...@google.com wrote: On Thu, Oct 1, 2009 at 11:27 AM, Scott Hess sh...@chromium.org wrote: Could we set jemalloc on selected renderer processes? I realize that wouldn't

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

2009-09-30 Thread Jeremy Orlow
I saw this on Vista 64 as well. On Wed, Sep 30, 2009 at 10:39 AM, Stephen White senorbla...@chromium.orgwrote: Just in case someone else runs into this: I recently installed MSVC2005 and the Win7 Platform SDK on my win7/64 machine and it gave me this error at link time:

[chromium-dev] Re: WebKit has a buildbot console view too!

2009-09-30 Thread Jeremy Orlow
S much better than grid view. :-) On Wed, Sep 30, 2009 at 3:49 PM, Adam Barth aba...@chromium.org wrote: Nice! On Wed, Sep 30, 2009 at 3:47 PM, Eric Seidel esei...@chromium.org wrote: Who knew? Looks like Mark (Rowe) recently updated their buildbot:

  1   2   3   >