[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-26 Thread 鵜飼文敏
2009/6/26 Michael Nordman micha...@google.com 2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Hi, Thanks for review. 2009/6/25 Jeremy Orlow jor...@chromium.org I only skimmed, but it looks well thought out. One question though: is this going to be functional for non-Chromium browsers? Given that your design doc mentions v8 and hooks into Chromium's network stack, but no mention of

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too. Sure. I've added a diagram in webkit part. * Does

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Hi, 2009/6/25 Drew Wilson atwil...@google.com BTW, I checked in with IanH - it sounds like WebSockets are also on the Worker roadmap, so that's something to keep in mind while you iterate on your design. Ok, I see. +1 to avoiding WebCore/loader, but also +1 to refactoring to enable as

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
2009/6/25 Chris Evans cev...@google.com On Wed, Jun 24, 2009 at 2:32 AM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.orgwrote: Hi, yuzo, tyoshino and I start working to implement HTML5 Web Socket and write design docs WebKit part: http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh Chromium

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 坊野 博典
Hi Ukai-san, ViewHostMsg_WebSocket*: IPC messages sent from renderer to browser. ViewHostMsg_WebSocketOpen: open a new Web Socket. called by WebSocketHandle::connect(). int request_id // idenfity WebSocket object {GURL url, std::wstring protocol, std::wstring origin, bool secure, [...]}

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
Hi, 2009/6/25 Hironori Bono (坊野 博典) hb...@chromium.org Hi Ukai-san, ViewHostMsg_WebSocket*: IPC messages sent from renderer to browser. ViewHostMsg_WebSocketOpen: open a new Web Socket. called by WebSocketHandle::connect(). int request_id // idenfity WebSocket object {GURL url,

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread John Abd-El-Malek
2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too.

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread Michael Nordman
2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too.

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread 鵜飼文敏
2009/6/26 John Abd-El-Malek j...@chromium.org 2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Jeremy Orlow
I only skimmed, but it looks well thought out. One question though: is this going to be functional for non-Chromium browsers? Given that your design doc mentions v8 and hooks into Chromium's network stack, but no mention of JavaScriptCore or WebKit's resource loading code, I'm worried that the

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread John Abd-El-Malek
On Wed, Jun 24, 2009 at 2:32 AM, Fumitoshi Ukai (鵜飼文敏) u...@chromium.orgwrote: Hi, yuzo, tyoshino and I start working to implement HTML5 Web Socket and write design docs WebKit part: http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh Chromium part:

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Michael Nordman
Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too. * Does WebSocketHandle really need to be refcounted. I know ResourceHandle is a refcounted object and this design looks

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Drew Wilson
BTW, I checked in with IanH - it sounds like WebSockets are also on the Worker roadmap, so that's something to keep in mind while you iterate on your design. +1 to avoiding WebCore/loader, but also +1 to refactoring to enable as much common code as possible cross-platform - I'm looking at the

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Drew Wilson
Also, it occurs to me that I can avoid making the problem worse by not putting the MessagePort entanglement in the proxy layer, which my patch currently does (ick). Proving that proper API design does enable better code re-use :) -atw taking my own advice 2009/6/24 John Abd-El-Malek

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Chris Evans
On Jun 24, 2:32 am, Fumitoshi Ukai (鵜飼文敏) u...@chromium.org wrote: Hi, yuzo, tyoshino and I start working to implement HTML5 Web Socket and write design docs WebKit part:http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh Chromium part:http://docs.google.com/View?id=dfm7gfvg_1dm97qxgm

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Chris Evans
On Jun 24, 2:32 am, Fumitoshi Ukai (鵜飼文敏) u...@chromium.org wrote: Hi, yuzo, tyoshino and I start working to implement HTML5 Web Socket and write design docs WebKit part:http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh Chromium part:http://docs.google.com/View?id=dfm7gfvg_1dm97qxgm

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Chris Evans
On Jun 24, 2:32 am, Fumitoshi Ukai (鵜飼文敏) u...@chromium.org wrote: Hi, yuzo, tyoshino and I start working to implement HTML5 Web Socket and write design docs WebKit part:http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh Chromium part:http://docs.google.com/View?id=dfm7gfvg_1dm97qxgm