On Tue, 7 Jun 2022 13:40:57 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Marked as reviewed by aivanov (Reviewer)
On Tue, 7 Jun 2022 12:27:51 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 94:
>
>> 92: JRadioBut
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Tue, 7 Jun 2022 11:19:10 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Marked as reviewed by aivanov (Reviewer)
On Tue, 7 Jun 2022 11:06:06 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JRadioButton/bug4380543.java line 72:
>>
>>> 70: //Adding the Test Frame to handle dispose
>>> 71: passFailJFrame.addTestFrame(testObj);
>>> 72: passFailJFrame.pos
On Tue, 7 Jun 2022 11:11:24 GMT, Alexey Ivanov wrote:
>> I think it wouldn't make any difference calling static methods via an
>> instance variable or directly with class name.
>
> Yes, the same method would be called. Yet the difference is in the semantics:
> the instance variable isn't used w
On Tue, 7 Jun 2022 10:46:15 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 58:
>
>> 56:2.
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Tue, 7 Jun 2022 10:47:25 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 72:
>
>> 70:
On Mon, 6 Jun 2022 06:08:38 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes requested by aivanov (Reviewer).
Hi Justin,
To unsubscribe from any OpenJDK mailing lists, go to its page; for
client-libs-dev, go to:
https://mail.openjdk.java.net/mailman/listinfo/client-libs-dev
Scroll to the bottom of the page, enter your email address in the
section "To unsubscribe from client-libs-dev…" and click "Uns
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Fri, 3 Jun 2022 18:48:51 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed whitespaces
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 59:
>
>> 57: Verify only
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
Please unsubscribe me from your mailing list
On Sat, Jun 4, 2022, 20:01 Tejesh R wrote:
> > Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed whitespaces
>
> ---
On Thu, 2 Jun 2022 15:32:11 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed whitespaces
Except for the minor comments, it looks good now.
te
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Removed whitespaces
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://git.openjdk.jav
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Removed windows specific jtreg
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://git.
On Thu, 2 Jun 2022 07:51:00 GMT, Alexey Ivanov wrote:
> > > I can see no reason why the test is for Windows only.
> > > The original bug
> > > [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all
> > > the operating systems as affected. Then
> > > [JDK-8134640](https://bug
On Thu, 2 Jun 2022 07:51:00 GMT, Alexey Ivanov wrote:
>>> > > > I wonder why the test is Windows-specific if it allows changing Look
>>> > > > and Feels.
>>> > > > The only Look and Feel which ignores the background is Nimbus, other
>>> > > > L&Fs on Windows at least paint the yellow and green
On Thu, 2 Jun 2022 05:25:54 GMT, Tejesh R wrote:
> > I can see no reason why the test is for Windows only.
> >
> > The original bug
> > [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all
> > the operating systems as affected. Then
> > [JDK-8134640](https://bugs.openjdk.j
On Wed, 1 Jun 2022 18:00:44 GMT, Phil Race wrote:
>>> > Shall the test be located in
>>> > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
>>> > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
>>> > Usually, there's been a folder with bugid (`/4380543/`) for each te
On Wed, 1 Jun 2022 17:09:37 GMT, Alexey Ivanov wrote:
> > > > I wonder why the test is Windows-specific if it allows changing Look
> > > > and Feels.
> > > > The only Look and Feel which ignores the background is Nimbus, other
> > > > L&Fs on Windows at least paint the yellow and green backgrou
On Thu, 2 Jun 2022 04:48:09 GMT, Tejesh R wrote:
> > > > > Shall the test be located in
> > > > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead
> > > > > of `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > > > Usually, there's been a folder with bugid (`/4380543
On Wed, 1 Jun 2022 18:00:44 GMT, Phil Race wrote:
> > > > Shall the test be located in
> > > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> > > > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > > Usually, there's been a folder with bugid (`/4380543/`) for
On Wed, 1 Jun 2022 17:37:42 GMT, Alexey Ivanov wrote:
> > > Shall the test be located in
> > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> > > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > Usually, there's been a folder with bugid (`/4380543/`) for eac
On Wed, 1 Jun 2022 16:35:01 GMT, Harshitha Onkar wrote:
> > Shall the test be located in
> > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > Usually, there's been a folder with bugid (`/4380543/`) for each test
On Wed, 1 Jun 2022 05:32:27 GMT, Tejesh R wrote:
> > > I wonder why the test is Windows-specific if it allows changing Look and
> > > Feels.
> > > The only Look and Feel which ignores the background is Nimbus, other L&Fs
> > > on Windows at least paint the yellow and green background. As such,
On Wed, 1 Jun 2022 16:29:49 GMT, Alexey Ivanov wrote:
> Shall the test be located in
> `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
>
> Usually, there's been a folder with bugid (`/4380543/`) for each test. Do we
On Wed, 1 Jun 2022 06:00:34 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes requested by aivanov (Reviewer).
On Tue, 24 May 2022 10:36:09 GMT, Alexey Ivanov wrote:
>>> Just an idea for discussion: I remember that we added some support for the
>>> manual tests, kind of framework or something. Probably it will be useful to
>>> reuse when we add "new" tests?
>>> https://bugs.openjdk.java.net/browse/JDK-
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Tue, 31 May 2022 11:15:25 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Updated based on review comments
>> - Added headful key
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 106:
On Wed, 1 Jun 2022 04:45:12 GMT, Tejesh R wrote:
> > I wonder why the test is Windows-specific if it allows changing Look and
> > Feels.
> > The only Look and Feel which ignores the background is Nimbus, other L&Fs
> > on Windows at least paint the yellow and green background. As such, the
> >
On Tue, 31 May 2022 11:30:55 GMT, Alexey Ivanov wrote:
> I wonder why the test is Windows-specific if it allows changing Look and
> Feels.
>
> The only Look and Feel which ignores the background is Nimbus, other L&Fs on
> Windows at least paint the yellow and green background. As such, the tes
On Fri, 27 May 2022 17:21:29 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updated based on review comments
> - Added headful key
I wonder why t
On Fri, 27 May 2022 17:21:29 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updated based on review comments
> - Added headful key
Marked as revi
On Fri, 27 May 2022 17:03:08 GMT, Harshitha Onkar wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains ten additional commits
>> s
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with two additional commits
since the last revision:
- Updated based on review comments
- Added headful key
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/fi
On Wed, 25 May 2022 12:21:51 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pu
On Tue, 24 May 2022 10:42:34 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains ten additional commits
>> sin
On Tue, 24 May 2022 10:36:09 GMT, Alexey Ivanov wrote:
> Just an idea for discussion: I remember that we added some support for the
> manual tests, kind of framework or something. Probably it will be useful to
> reuse when we add "new" tests?
> https://bugs.openjdk.java.net/browse/JDK-8283803
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains ten additional commits since the
last r
On Tue, 24 May 2022 05:29:43 GMT, Tejesh R wrote:
>> Just an idea for discussion: I remember that we added some support for the
>> manual tests, kind of framework or something. Probably it will be useful to
>> reuse when we add "new" tests?
>> https://bugs.openjdk.java.net/browse/JDK-8283803
>
On Mon, 16 May 2022 06:45:04 GMT, Tejesh R wrote:
> Added test for checking setMargin() of JRadioButton.
test/jdk/javax/swing/JRadioButton/bug4380543.java line 143:
> 141: {
> 142: disposeUI();
> 143: if (res.toString() == "false")
This looks weird. Why can't you use `res.g
On Tue, 24 May 2022 05:29:43 GMT, Tejesh R wrote:
> > Just an idea for discussion: I remember that we added some support for the
> > manual tests, kind of framework or something. Probably it will be useful to
> > reuse when we add "new" tests?
> > https://bugs.openjdk.java.net/browse/JDK-82838
On Tue, 24 May 2022 00:46:21 GMT, Sergey Bylokhov wrote:
> Just an idea for discussion: I remember that we added some support for the
> manual tests, kind of framework or something. Probably it will be useful to
> reuse when we add "new" tests?
> https://bugs.openjdk.java.net/browse/JDK-828380
On Mon, 16 May 2022 06:45:04 GMT, Tejesh R wrote:
> Added test for checking setMargin() of JRadioButton.
Just an idea for discussion: I remember that we added some support for the
manual tests, kind of framework or something. Probably it will be useful to
reuse when we add "new" tests? https:/
On Mon, 16 May 2022 06:45:04 GMT, Tejesh R wrote:
> Added test for checking setMargin() of JRadioButton.
Marked as reviewed by jdv (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8721
50 matches
Mail list logo
