client-libs-dev@openjdk.java.net

2021-09-13 Thread Sergey Bylokhov
On Mon, 13 Sep 2021 02:49:01 GMT, Sergey Bylokhov wrote: > As discussed here https://github.com/openjdk/jdk/pull/1813 the test should > skip the GTK L&F unfortunately the name of the GTK L&F is "GTK look and feel" > not "GTK". The ID="GTK" can be used instead. The GTK L&F is unsupported in the

Re: RFR: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1

2021-09-13 Thread Sergey Bylokhov
On Mon, 13 Sep 2021 06:03:11 GMT, Alexey Ushakov wrote: > in a normal state (when the window is created) we don't need to flush the > layer content faster than DisplayLink provide. But this is exactly related to the performance, no? When the RenderPerf test is executed it should check that del

client-libs-dev@openjdk.java.net

2021-09-13 Thread Prasanta Sadhukhan
On Mon, 13 Sep 2021 02:49:01 GMT, Sergey Bylokhov wrote: > As discussed here https://github.com/openjdk/jdk/pull/1813 the test should > skip the GTK L&F unfortunately the name of the GTK L&F is "GTK look and feel" > not "GTK". The ID="GTK" can be used instead. ok - Marked as revi

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v7]

2021-09-13 Thread Prasanta Sadhukhan
> It is seen in macos disabled JMenuItem arrow is not disabled even though > JMenuItem itself is disabled. > In native app, same menuitem arrow is disabled for disabled menuitem. > > Issue is when AquaMenuPainter#paintMenuItem() is called, it tries to draw a > ImageIcon image of the arrow via Im

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v5]

2021-09-13 Thread Prasanta Sadhukhan
On Fri, 10 Sep 2021 04:08:49 GMT, Sergey Bylokhov wrote: >> It is called from AquaMenuPainter#405 and 378 >> if (c instanceof JMenu && (model.isArmed() || model.isSelected()) && >> arrowIcon instanceof InvertableIcon) { >> ((InvertableIcon)arrowIcon).getInvertedIcon().paintIcon(c, g,

client-libs-dev@openjdk.java.net

2021-09-13 Thread Alexander Zvegintsev
On Mon, 13 Sep 2021 02:49:01 GMT, Sergey Bylokhov wrote: > As discussed here https://github.com/openjdk/jdk/pull/1813 the test should > skip the GTK L&F unfortunately the name of the GTK L&F is "GTK look and feel" > not "GTK". The ID="GTK" can be used instead. Marked as reviewed by azvegint (R

Re: [+AWTFont nsFontForJavaFont:env:]

2021-09-13 Thread Michael Hall
> On Sep 9, 2021, at 5:57 PM, Alan Snyder wrote: > > As no one is claiming ownership, should it be removed? > Or is it expected to have some use in the future? > > > >> On Sep 8, 2021, at 3:50 PM, Michael Hall wrote: >> >> >> >>> On Sep 8, 2021, at 11:23 AM, Alan Snyder wrote: >>> >>>

Re: RFR: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7

2021-09-13 Thread Alexey Ivanov
On Thu, 9 Sep 2021 07:27:10 GMT, Sergey Bylokhov wrote: > This bug was found by the test added by the > https://github.com/openjdk/jdk/pull/5042. The crash is rarely reproduced, and > in the default testrun, I was not able to crash it even once. But I have > found that if the 1000 tests are ex

Re: RFR: 8271071 accessibility of a table on macOS lacks cell navigation

2021-09-13 Thread Anton Tarasov
On Fri, 10 Sep 2021 15:11:20 GMT, Artem Semenov wrote: > We've extended the current implementation of TableAccessibility to make sure > that individual cells are voiced when navigating with the keyboard. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ColumnAccessibility.m line 52: > 50

Re: RFR: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7

2021-09-13 Thread Alexander Zvegintsev
On Thu, 9 Sep 2021 07:27:10 GMT, Sergey Bylokhov wrote: > This bug was found by the test added by the > https://github.com/openjdk/jdk/pull/5042. The crash is rarely reproduced, and > in the default testrun, I was not able to crash it even once. But I have > found that if the 1000 tests are ex

Re: RFR: 8205137: Remove Applet support from SwingSet2 [v3]

2021-09-13 Thread Phil Race
On Fri, 10 Sep 2021 23:34:19 GMT, Alisen Chung wrote: >> removed support for running demo from applet for J2Ddemo and SwingSet2 >> same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed >> branch name) > > Alisen Chung has updated the pull request incrementally with one additio

client-libs-dev@openjdk.java.net

2021-09-13 Thread Pankaj Bansal
On Mon, 13 Sep 2021 02:49:01 GMT, Sergey Bylokhov wrote: > As discussed here https://github.com/openjdk/jdk/pull/1813 the test should > skip the GTK L&F unfortunately the name of the GTK L&F is "GTK look and feel" > not "GTK". The ID="GTK" can be used instead. The test has some wildcard import

Re: RFR: 8205137: Remove Applet support from SwingSet2 [v3]

2021-09-13 Thread Alisen Chung
On Mon, 13 Sep 2021 18:18:58 GMT, Phil Race wrote: > So I don't think there is any agreed upon set of rules to follow although > most folks > when you get down to the specific package do place them in lexical order > > Here I note that the pre-existing wild card imports were of javax.swing > f

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-13 Thread Sergey Bylokhov
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Stack is unnecessary. It's recommended to use > ArrayDequeue if a thread-safe implementation is not needed. Looks fine Or maybe not, did you check that the order of pushing and the order of iteration f

RFR: 8273684: Unnecessary Stack usage

2021-09-13 Thread Andrey Turbanov
Usage of thread-safe collection Stack is unnecessary. It's recommended to use ArrayDequeue if a thread-safe implementation is not needed. - Commit messages: - [PATCH] Stack usages can be replaced with ArrayDequeue - [PATCH] Stack usages can be replaced with ArrayDequeue - [PATCH]

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-13 Thread Andrey Turbanov
On Wed, 8 Sep 2021 21:34:06 GMT, Sergey Bylokhov wrote: >> Usage of thread-safe collection Stack is unnecessary. It's recommended to >> use ArrayDequeue if a thread-safe implementation is not needed. > > src/java.desktop/share/classes/com/sun/media/sound/DLSSoundbank.java line 34: > >> 32: impo

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-13 Thread Andrey Turbanov
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Stack is unnecessary. It's recommended to use > ArrayDequeue if a thread-safe implementation is not needed. Yeah. You are right! TIL that order of iteration is different in ArrayDequeu vs Stack: Stack.p

Re: RFR: 8205137: Remove Applet support from SwingSet2 [v3]

2021-09-13 Thread Alexey Ivanov
On Fri, 10 Sep 2021 23:34:19 GMT, Alisen Chung wrote: >> removed support for running demo from applet for J2Ddemo and SwingSet2 >> same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed >> branch name) > > Alisen Chung has updated the pull request incrementally with one additio

RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java

2021-09-13 Thread lawrence . andrews
Problem : 1) Test case was failing with following exception test result: Error. Parse Exception: Arguments to `manual' option not supported: yes 2) After removing =yes/no Parser exception is not seen but test UI will show and closes immediately where the user cannot see what is on the frame.

Re: RFR: 8205137: Remove Applet support from SwingSet2 [v3]

2021-09-13 Thread Sergey Bylokhov
On Fri, 10 Sep 2021 23:34:19 GMT, Alisen Chung wrote: >> removed support for running demo from applet for J2Ddemo and SwingSet2 >> same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed >> branch name) > > Alisen Chung has updated the pull request incrementally with one additio

Re: RFR: 8205137: Remove Applet support from SwingSet2 [v3]

2021-09-13 Thread Phil Race
On Fri, 10 Sep 2021 23:34:19 GMT, Alisen Chung wrote: >> removed support for running demo from applet for J2Ddemo and SwingSet2 >> same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed >> branch name) > > Alisen Chung has updated the pull request incrementally with one additio

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]

2021-09-13 Thread lawrence . andrews
> Problem : > 1) Test case was failing with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yes > 2) After removing =yes/no Parser exception is not seen but test UI will show > and closes immediately where the user cannot see what is on