On Fri, 15 Mar 2024 06:10:05 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 47:
>>
>>> 45: */
>>> 46: public class SecurityDialogTest extends Frame {
>>> 47: private static final String INSTRUCTIONS =
>>
>> `INSTRUCTIONS` can be m
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
wild card imports and moved one folder up
-
Changes:
- all: https://git.openjd
On Fri, 15 Mar 2024 03:31:32 GMT, Tejesh R wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/SecurityD
Conversion of manual applet test to main based using PassFailJFrame manual
framework
-
Commit messages:
- Applet test converted to main manual
Changes: https://git.openjdk.org/jdk/pull/18321/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=00
Issue: https://bu
On Wed, 13 Mar 2024 07:10:32 GMT, Prasanta Sadhukhan
wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
This pull request has now been integrated.
Changeset: 06f4b7f5
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/06f
On Thu, 14 Mar 2024 19:36:53 GMT, Phil Race wrote:
> This test draws the same tray icon, has similar instructions to, and is
> subsumed by the related test DisposeInActionEventTest.java
> And because this test has incomplete instructions not covering macOS it is
> problem-listed.
> The other
On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev
wrote:
> Often manual tests have a text area in the instruction window to print
> feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these
> changes a standard featur
On Thu, 14 Mar 2024 16:40:56 GMT, Damon Nguyen wrote:
> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
> using PassFailJFrame
test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 67:
> 65: .rows(15)
> 66: .columns(40)
> 67:
On Thu, 14 Mar 2024 19:36:53 GMT, Phil Race wrote:
> This test draws the same tray icon, has similar instructions to, and is
> subsumed by the related test DisposeInActionEventTest.java
> And because this test has incomplete instructions not covering macOS it is
> problem-listed.
> The other
Often manual tests have a text area in the instruction window to print feedback
from the test to be evaluated by a tester.
I stumbled across another test that needed this, so I decided to make these
changes a standard feature.
List of changes:
* The log text area can be added below the `Pass` an
On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev
wrote:
> Often manual tests have a text area in the instruction window to print
> feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these
> changes a standard featur
On Fri, 15 Mar 2024 04:23:39 GMT, Prasanta Sadhukhan
wrote:
> It was originally meant for browser applet which as you told is not supported
> and therefore test can be removed but I see it is also used to test a Unity
> fix for [8159460](https://bugs.openjdk.org/browse/JDK-8159460) that does n
On Thu, 14 Mar 2024 21:27:47 GMT, Phil Race wrote:
> After some experimentation/thought I think it best to delete this applet test.
>
> It is supposed to be a manual test but is missing the manual keyword so
> as far as I can tell it has never been usefully run. Except perhaps a few
> times
> w
On Thu, 14 Mar 2024 21:27:47 GMT, Phil Race wrote:
> After some experimentation/thought I think it best to delete this applet test.
>
> It is supposed to be a manual test but is missing the manual keyword so
> as far as I can tell it has never been usefully run. Except perhaps a few
> times
> w
On Wed, 13 Mar 2024 13:39:08 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to automated test. CI testing is green. Link
> attached to JBS.
This pull request has now been integrated.
Changeset: f6390e5f
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/f6
On Fri, 15 Mar 2024 00:15:50 GMT, Alisen Chung wrote:
>> Adding comma to copyright years
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove middle copyright year
@alisenchung sorry I became unavailable to follow this
On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame with information panel, earlier
> this was informed through terminal.
> Please review and let me know your suggestions if any.
test/jdk/java/awt/print/PrinterJo
On Fri, 15 Mar 2024 03:14:50 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Minor update
Ma
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Ninor update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18263/file
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Minor update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18261/file
On Thu, 14 Mar 2024 16:48:57 GMT, Alexander Zuev wrote:
>> Convert test to the automatic main and move it from its own folder since it
>> is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor updat
On Thu, 14 Mar 2024 19:36:53 GMT, Phil Race wrote:
> This test draws the same tray icon, has similar instructions to, and is
> subsumed by the related test DisposeInActionEventTest.java
> And because this test has incomplete instructions not covering macOS it is
> problem-listed.
> The other
On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JColorChooser/Test4887836.java line 2:
> 1: /*
> 2: * Copyright (c) 2003, 2008, 2024 Oracle and/or its affiliates. All rig
On Thu, 14 Mar 2024 23:36:13 GMT, Alisen Chung wrote:
> Adding comma to copyright years
This pull request has now been integrated.
Changeset: e8d1ba33
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/e8d1ba33b48dc8e6b937258c3765b91426c5b6f1
Stats: 4 lines in 4 files c
On Thu, 14 Mar 2024 05:51:55 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to automated test. CI testing is green.
>> Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> UI init in sepa
On Fri, 15 Mar 2024 00:15:50 GMT, Alisen Chung wrote:
>> Adding comma to copyright years
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove middle copyright year
Trivial copyright year update. This looks good to me.
-
> Adding comma to copyright years
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove middle copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18317/files
- new: https://git.openjdk.org/jdk/pull/18
On Thu, 14 Mar 2024 23:36:13 GMT, Alisen Chung wrote:
> Adding comma to copyright years
Changes requested by dholmes (Reviewer).
test/jdk/javax/swing/JColorChooser/Test4759306.java line 2:
> 1: /*
> 2: * Copyright (c) 2002, 2008, 2024, Oracle and/or its affiliates. All
> rights reserved.
Th
Adding comma to copyright years
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18317/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18317&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328228
Stats: 4 lines in 4 files changed: 0 ins; 0
Removing applet usage from manual JColorChooser tests
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18316/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8328227
Stats: 66 lines in 2
On Wed, 13 Mar 2024 20:57:42 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: be1dd275
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b
Stats:
On Wed, 13 Mar 2024 19:26:15 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: fab0edc9
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/fab0edc9e636c69d7012e476e97661ddae993a03
Stats:
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove jframe import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18286/files
- new: https://git.openjdk.o
On Mon, 11 Mar 2024 23:57:17 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: 7c6fd337
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/7c6fd337d00d4bdeaac724a6ea26fac3654846e0
Stats:
On Tue, 12 Mar 2024 00:24:38 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: 89fb0f83
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/89fb0f837b7dbeed581f5db79d915cf405afda31
Stats:
On Thu, 14 Mar 2024 22:41:20 GMT, Harshitha Onkar wrote:
> Following test is converted to main using PassFailJFrame.
test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56:
> 54: In WIN32 systems the image under cursor would be visible
> ONLY over
> 55:
Following test is converted to main using PassFailJFrame.
-
Commit messages:
- EOF newline added
- Instructions updated
- applet to main
Changes: https://git.openjdk.org/jdk/pull/18315/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=00
Issue: https://bugs.op
On Tue, 12 Mar 2024 19:28:45 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
This pull request has now been integrated.
Changeset: df909e2f
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/commit/df909e2f9c83d6de11
After some experimentation/thought I think it best to delete this applet test.
It is supposed to be a manual test but is missing the manual keyword so
as far as I can tell it has never been usefully run. Except perhaps a few times
when first being verified.
When I run it in jtreg a window popups u
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame changes added in this PR
> https://github.com/openjdk/jdk/pull/18281
Harshitha Onkar has updated the pull request incremental
On Thu, 14 Mar 2024 19:50:18 GMT, Harshitha Onkar wrote:
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame changes added in this PR
> https://github.com/openjdk/jdk/pull/1828
This test is converted to main using PassFailJFrame. It verifies wheel rotation
value for high-res mouse on windows.
The test requires the updated PassFailJFrame changes added in this PR
https://github.com/openjdk/jdk/pull/18281
-
Commit messages:
- whitespace removed
- default t
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` thread. If the thread is pre-empted betw
On Tue, 5 Mar 2024 11:04:30 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
>> line 101:
>>
>>> 99: */
>>> 100: public synchronized void invalidateFileCache() {
>>> 101: if (filesLoader != null) {
>>
>> This is a publ
This test draws the same tray icon, has similar instructions to, and is
subsumed by the related test DisposeInActionEventTest.java
And because this test has incomplete instructions not covering macOS it is
problem-listed.
The other test explicitly covers macOS.
So the right answer is to remove
On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov wrote:
> I'm adding a regression test for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
> regression test for
> [JDK-8240690](https://bugs.openjdk.org/br
On Tue, 12 Mar 2024 22:55:02 GMT, Phil Race wrote:
> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame
This pull request has now been integrated.
Changeset: 87bd6cac
Author:Phil Race
URL:
https
On Thu, 14 Mar 2024 18:43:06 GMT, Phil Race wrote:
>> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
>> It can be converted to a main program test using PassFailJFrame
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last
On Thu, 14 Mar 2024 00:23:01 GMT, Harshitha Onkar wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8328021
>
> test/jdk/java/awt/List/SetFontTest.java line 55:
>
>> 53:.instructions(INSTRUCTION
On Thu, 14 Mar 2024 10:22:50 GMT, Abhishek Kumar wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8328021
>
> test/jdk/java/awt/List/SetFontTest.java line 42:
>
>> 40: public class SetFontTest {
>> 41:
>> 42: sta
> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8328021
-
Changes:
- all: https
On Thu, 14 Mar 2024 18:05:59 GMT, Alexey Ivanov wrote:
> I wonder if it depends on the font used. Is the selected font available on
> macOS?
I tried it with Dialog on macOS, it looked the same.
-
PR Comment: https://git.openjdk.org/jdk/pull/18285#issuecomment-1998045712
On Wed, 13 Mar 2024 18:49:03 GMT, Harshitha Onkar wrote:
> This test was previously problemlisted on macOS. When tested on macOS, the
> problem still exists…
I wonder if it depends on the font used. Is the selected font available on
macOS?
-
PR Comment: https://git.openjdk.org/jd
> Conversion of manual applet test to automated test. CI testing is green. Link
> attached to JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Minor update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1827
On Wed, 13 Mar 2024 18:49:03 GMT, Harshitha Onkar wrote:
> java/awt/font/TextLayout/TestJustification.html is converted to main manual
> test using PassFailJFrame.
>
> This test was previously problemlisted on macOS. When tested on macOS, the
> problem still exists and not all lines are just
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Added OS check and remove unused imports
-
Changes:
- all: https://git.openjdk
On Thu, 14 Mar 2024 17:04:22 GMT, Harshitha Onkar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/javax/swing/JToggleButton/bug4128979.java line 69:
>
>> 67:
>> 68: public st
On Thu, 14 Mar 2024 16:48:57 GMT, Alexander Zuev wrote:
>> Convert test to the automatic main and move it from its own folder since it
>> is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor updat
On Thu, 14 Mar 2024 05:22:40 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to automated test. CI testing is green.
>> Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Test file upd
On Thu, 14 Mar 2024 05:22:40 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to automated test. CI testing is green.
>> Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Test file upd
On Thu, 14 Mar 2024 16:26:06 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
On Wed, 13 Mar 2024 05:38:35 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment fix
Pleas
On Thu, 14 Mar 2024 16:23:20 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 44:
>>
>>> 42: 0. There is a test window with a "Press" button,
>>> 43: Its original bounds should be printed in the text area
>>> below.
>>> 44:
On Thu, 14 Mar 2024 16:49:39 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java
>> line 525:
>>
>>> 523: boolean special2 = sf2.isSpecial();
>>> 524:
>>> 525: if (special1 && special2) {
>>
>> Could you please say somethin
On Tue, 12 Mar 2024 19:35:30 GMT, Phil Race wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Handle fakePersonal on Windows 10
>>
>> The desktop folder on Windows 10 does not include
>> the Personal (Documen
On Thu, 14 Mar 2024 16:03:46 GMT, Abhishek Kumar wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 85:
>
>> 83: });
>> 84:
> Convert test to the automatic main and move it from its own folder since it
> is no longer required.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Minor updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull
Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
using PassFailJFrame
-
Commit messages:
- Update title
- Initial test conversion
Changes: https://git.openjdk.org/jdk/pull/18307/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=00
> Convert test to the automatic main and move it from its own folder since it
> is no longer required.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java
Co-authored-
On Wed, 13 Mar 2024 18:15:58 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix suggested redudant changes
>
> test/jdk/java/awt/im/JTextFieldTest.java line 47:
>
>> 45: """
>> 46:
On Thu, 14 Mar 2024 13:26:37 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> extract logFrameBounds, instructions update
>
> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 44:
>
>
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Alexander Zvegintsev has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains six addition
> Convert java/awt/im/JTextFieldTest.java applet test to main using
> PassFailJFrame.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18247/files
-
On Wed, 13 Mar 2024 01:20:11 GMT, Harshitha Onkar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> Changes requested by honkar (Reviewer).
@honkar-jdk Updated as per last review. Please tak
On Thu, 14 Mar 2024 01:01:51 GMT, Harshitha Onkar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove commented code
>
> Changes requested by honkar (Reviewer).
@honkar-jdk Updated as per last review. Please
On Thu, 14 Mar 2024 13:00:06 GMT, Alexander Zuev wrote:
>> Convert test to the automatic main and move it from its own folder since it
>> is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor fixes
On Thu, 14 Mar 2024 15:42:46 GMT, Alexander Zuev wrote:
>> Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main
>> based using PassFailJFrame. This is a performance measurement test which
>> provide benchmark to compare the outcome with different releases. I have
>> converte
On Wed, 13 Mar 2024 19:43:10 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
This pull request has now been integrated.
Changeset: 7cc1965a
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/commit/7cc1965a252347f37d
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
add empty line
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18287/files
- new: http
On Tue, 12 Mar 2024 06:03:27 GMT, Tejesh R wrote:
> Convert javax/swing/border/Test4247606.java applet test to main based test
> using PassFailJFrame.
This pull request has now been integrated.
Changeset: d4ec7831
Author:Tejesh R
URL:
https://git.openjdk.org/jdk/commit/d4ec78310882
> Convert javax/swing/border/Test4247606.java applet test to main based test
> using PassFailJFrame.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Review updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18213/
On Tue, 12 Mar 2024 06:56:20 GMT, Tejesh R wrote:
> Convert javax/swing/border/Test4252164.java applet test to main based test
> using PassFailJFrame.
This pull request has now been integrated.
Changeset: acfefc6c
Author:Tejesh R
URL:
https://git.openjdk.org/jdk/commit/acfefc6c7aea
On Thu, 29 Feb 2024 15:13:16 GMT, Alexey Ivanov wrote:
> A trivial change in a comment: consequent → _consecutive_ positions.
>
> This was found in [a code
> review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for
> [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306)
On Mon, 11 Mar 2024 17:29:50 GMT, Alexander Zvegintsev
wrote:
> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written
> to test the very specific functionality of `XFileDialogPeer`, so it shouldn't
> be run on platforms other than Linux.
>
> We also need to set `sun.awt.
On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R wrote:
> Convert sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based
> using PassFailJFrame. This is a performance measurement test which provide
> benchmark to compare the outcome with different releases. I have converted
> the test
On Tue, 12 Mar 2024 11:15:38 GMT, Tejesh R wrote:
> Convert javax/swing/border/Test6910490.java applet test to main based test
> using PassFailJFrame.
This pull request has now been integrated.
Changeset: 759cc675
Author:Tejesh R
URL:
https://git.openjdk.org/jdk/commit/759cc675915c
On Wed, 13 Mar 2024 04:54:23 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test6910490.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Marked as
On Thu, 14 Mar 2024 12:39:40 GMT, Abhishek Kumar wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 46:
>
>> 44: Choice choice;
>> 45
On Tue, 12 Mar 2024 13:35:33 GMT, Alexey Ivanov wrote:
> The test is converted to use `PassFailJFrame`.
>
> I confirmed the updated test reproduce the original problem described in
> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
> displayed as missing glyphs.
Th
On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame with information panel, earlier
> this was informed through terminal.
> Please review and let me know your suggestions if any.
Marked as reviewed by aivanov (Re
On Wed, 13 Mar 2024 16:56:39 GMT, Alexander Zvegintsev
wrote:
>> @azvegint, yes, we can support both. But I didn't test it thoroughly, so I
>> decided it was safer to add this.
>>
>> Please, don't modify `PassFailJFrame` together with tests unless it's
>> strictly required… It is for the sake
On Wed, 13 Mar 2024 19:01:27 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> extract logFrameBounds, instruc
On Thu, 14 Mar 2024 12:41:20 GMT, Abhishek Kumar wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 69:
>
>> 67: size = choic
> Convert test to the automatic main and move it from its own folder since it
> is no longer required.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Minor fixes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
On Thu, 14 Mar 2024 12:42:00 GMT, Abhishek Kumar wrote:
>> Convert test to the automatic main and move it from its own folder since it
>> is no longer required.
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 74:
>
>> 72: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK)
On Wed, 13 Mar 2024 05:00:35 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4247606.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Marked as
On Thu, 14 Mar 2024 12:40:59 GMT, Abhishek Kumar wrote:
>> Convert test to the automatic main and move it from its own folder since it
>> is no longer required.
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 65:
>
>> 63: });
>> 64: robot.waitForIdle();
>> 65:
On Wed, 13 Mar 2024 19:43:10 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
LGTM.
test/jdk/java/awt/Frame/ShownOnPack/ShownOnPack.java line 34:
> 32: * @build PassFailJFrame
> 33: * @run main/manual ShownOnPack
> 34: */
May add a bla
On Thu, 14 Mar 2024 12:27:29 GMT, Alexander Zuev wrote:
> Convert test to the automatic main and move it from its own folder since it
> is no longer required.
test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 46:
> 44: Choice choice;
> 45: Point pos;
> 46: Dimension size
On Thu, 14 Mar 2024 12:36:05 GMT, Magnus Ihse Bursie wrote:
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
> in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These fl
1 - 100 of 140 matches
Mail list logo
