Re: RFR: 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

2025-08-25 Thread Jayathirth D V
On Mon, 25 Aug 2025 20:18:49 GMT, Phil Race wrote: > The disposer for MemoryCacheImageInputStream isn't needed. All it does is > clear an ArrayList of byte[] > GC can take care of that. Marked as reviewed by jdv (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/26933#pullr

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v5]

2025-08-25 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has updated the pull request

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v4]

2025-08-25 Thread Jayathirth D V
On Tue, 26 Aug 2025 05:49:59 GMT, Prasanta Sadhukhan wrote: >> Jayathirth D V has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Make test more robust >> - Use thread lock > > src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v4]

2025-08-25 Thread Prasanta Sadhukhan
On Tue, 26 Aug 2025 05:46:13 GMT, Jayathirth D V wrote: >> We need to throw appropriate exception when we pass invalid image index >> values to ImageReader.getImageTypes(). >> We throw IOOBE in all other plugins except JPEG, Added appropriate check to >> throw IOOBE when JpegImageReader has inv

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v3]

2025-08-25 Thread Jayathirth D V
On Mon, 25 Aug 2025 14:12:05 GMT, Alexey Ivanov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update image index verification function name > > src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JPEGIm

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v4]

2025-08-25 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has updated the pull request

Re: RFR: 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

2025-08-25 Thread Prasanta Sadhukhan
On Mon, 25 Aug 2025 20:18:49 GMT, Phil Race wrote: > The disposer for MemoryCacheImageInputStream isn't needed. All it does is > clear an ArrayList of byte[] > GC can take care of that. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/2693

Integrated: 8159055: Clarify handling of null and invalid image data for ImageIcon constructors and setImage method

2025-08-25 Thread Prasanta Sadhukhan
On Thu, 12 Jun 2025 03:23:30 GMT, Prasanta Sadhukhan wrote: > When trying to call 'icon.setImage(null);' where 'icon' is an instance of > ImageIcon, a null pointer exception is thrown at runtime. > The code tried to get the `id` for that image and instantiates `MediaTracker` > to associate the

Re: RFR: 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

2025-08-25 Thread Phil Race
On Mon, 25 Aug 2025 20:41:25 GMT, Sergey Bylokhov wrote: > may be there are some hints in the history that suggest why it was initially > added? or it might simply have been an overlooked misuse of the disposer? I think it was mostly a mis-use - partly because it could also flush() the stream

Integrated: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Phil Race
On Mon, 25 Aug 2025 19:33:57 GMT, Phil Race wrote: > trivial internal cleanup This pull request has now been integrated. Changeset: e7d2a52d Author:Phil Race URL: https://git.openjdk.org/jdk/commit/e7d2a52d35e8ad5afa5d26f4c0bb1bf46a1bf0c7 Stats: 2 lines in 1 file changed: 0 ins;

Re: RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Phil Race
On Mon, 25 Aug 2025 21:06:42 GMT, Sergey Bylokhov wrote: > I was under impression that this was used to flush any errors printed before > initialization of toolkit, so it will not be conflicting with possible error > logs printed by the appkit thread. I suppose you infer that rather than someo

Re: RFR: 8361521 : BogusFocusableWindowState.java fails with StackOverflowError on Linux [v5]

2025-08-25 Thread duke
On Wed, 20 Aug 2025 05:05:20 GMT, Anass Baya wrote: >> **Analysis:** >> The getFocusableWindowState() method is not intended to modify the >> configuration; doing so can cause recursive re-entry on Linux. >> >> **Proposed Fix:** >> We are intentionally overriding getFocusableWindowState() to al

Re: RFR: 8361521 : BogusFocusableWindowState.java fails with StackOverflowError on Linux [v5]

2025-08-25 Thread Anass Baya
On Tue, 26 Aug 2025 00:52:17 GMT, Sergey Bylokhov wrote: > looks fine, please confirm that all tests are green. Yes, the tests pass with the proposed fix - PR Comment: https://git.openjdk.org/jdk/pull/26298#issuecomment-3222628788

Re: RFR: 8361387 : Test bug4655513.java fails intermittently on Windows platform. [v3]

2025-08-25 Thread Prasanta Sadhukhan
On Tue, 26 Aug 2025 04:57:26 GMT, Anass Baya wrote: >> test/jdk/javax/swing/DataTransfer/bug4655513.java line 73: >> >>> 71: robot.delay(20); >>> 72: } >>> 73: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK); >> >> mousePress parameter should be `InputEv

Re: RFR: 8361387 : Test bug4655513.java fails intermittently on Windows platform. [v3]

2025-08-25 Thread Anass Baya
> This test was recently automated and is failing intermittently in the CI due > to timing issues. > This enhancement aims to stabilize the test and also adds the missing null > pointer check. Anass Baya has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: 8361387 : Test bug4655513.java fails intermittently on Windows platform. [v3]

2025-08-25 Thread Anass Baya
On Wed, 20 Aug 2025 08:58:03 GMT, Prasanta Sadhukhan wrote: >> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add waitForIdle() > > test/jdk/javax/swing/DataTransfer/bug4655513.java line 73: > >> 71: robot.d

Integrated: 8302057: Wrong BeanProperty description for JTable.setShowGrid

2025-08-25 Thread Renjith Kannath Pariyangad
On Wed, 20 Aug 2025 09:30:31 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Updated the Bean Property description with meaningful string for > JTable.setShowGrid. > > Pleas review and let me know your suggestions if any. This pull request has now been integrated. Changeset: 0f7c

Re: RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Prasanta Sadhukhan
On Mon, 25 Aug 2025 19:33:57 GMT, Phil Race wrote: > trivial internal cleanup Update the copyright year if you may.. - Marked as reviewed by psadhukhan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26931#pullrequestreview-3153784546

Re: RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v4]

2025-08-25 Thread duke
On Mon, 25 Aug 2025 12:29:41 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated the Bean Property description with meaningful string for >> JTable.setShowGrid. >> >> Pleas review and let me know your suggestions if any. > > Renjith Kannath Pariyangad has updated the pull re

Integrated: 8361610: Avoid wasted work in ImageIcon(Image) for setting description

2025-08-25 Thread Prasanta Sadhukhan
On Thu, 21 Aug 2025 02:30:11 GMT, Prasanta Sadhukhan wrote: > The `ImageIcon(Image)` constructor sets the description field to the value of > "comment" property if it's a string. The `ImageIcon(Image, String)` > constructor calls ImageIcon(Image). Since the two-parameter constructor > explici

Integrated: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block

2025-08-25 Thread Ravi Gupta
On Mon, 30 Jun 2025 12:18:09 GMT, Ravi Gupta wrote: > Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java left > debris on system whenever fails its required frame.dispose() in finally block. > > > finally { > EventQueue.invokeAndWait(ExtraButtonDrag::disposeF

Re: RFR: 8360160: ubuntu-22-04 machine is failing client tests [v2]

2025-08-25 Thread Damon Nguyen
On Mon, 25 Aug 2025 20:21:42 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace setAutoDelay > > test/jdk/java/awt/Frame/FrameVisualTest.java line 90: > >> 88: if (frame

Re: RFR: 8360160: ubuntu-22-04 machine is failing client tests [v2]

2025-08-25 Thread Damon Nguyen
On Mon, 25 Aug 2025 17:56:16 GMT, Alexander Zvegintsev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace setAutoDelay > > test/jdk/java/awt/Frame/FrameVisualTest.java line 66: > >> 64: robot.del

Re: RFR: 8360160: ubuntu-22-04 machine is failing client tests [v3]

2025-08-25 Thread Damon Nguyen
> Ubuntu machine has multiple failing java awt tests. When looking at the > screenshots of the desktop when each test fails, a white square can be seen > at the top-left of the desktop. > > src="https://github.com/user-attachments/assets/52d023f6-18ff-46d4-98c4-e2e332ab6a03"; > /> > > This se

Re: RFR: 8365569: Remove finalize from JavaSoundAudioClip.java

2025-08-25 Thread Sergey Bylokhov
On Wed, 20 Aug 2025 20:58:08 GMT, Phil Race wrote: > Memory leaks ? Where and how ? By current implementation, you mean before and > after the PR ? I meant the reason why do you need the "new" delegate implementation is the reference to the object back from the listener lists, should not that

Re: RFR: 8361521 : BogusFocusableWindowState.java fails with StackOverflowError on Linux [v5]

2025-08-25 Thread Sergey Bylokhov
On Wed, 20 Aug 2025 05:05:20 GMT, Anass Baya wrote: >> **Analysis:** >> The getFocusableWindowState() method is not intended to modify the >> configuration; doing so can cause recursive re-entry on Linux. >> >> **Proposed Fix:** >> We are intentionally overriding getFocusableWindowState() to al

Re: RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Sergey Bylokhov
On Mon, 25 Aug 2025 19:33:57 GMT, Phil Race wrote: > trivial internal cleanup I was under impression that this was used to flush any errors printed before initialization of toolkit, so it will not be conflicting with possible error logs printed by the appkit thread. - PR Comment:

Re: RFR: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8 [v3]

2025-08-25 Thread Daniel Gredler
On Mon, 25 Aug 2025 18:59:39 GMT, Volker Simonis wrote: > I think this is a little too simplistic. Single characters on a line may be > fine, as long as they don't break a cluster. Sure, but it doesn't appear to happen with this specific text until you resize down to 70 pixels or so. Another

Re: RFR: 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

2025-08-25 Thread Sergey Bylokhov
On Mon, 25 Aug 2025 20:18:49 GMT, Phil Race wrote: > The disposer for MemoryCacheImageInputStream isn't needed. All it does is > clear an ArrayList of byte[] > GC can take care of that. may be there are some hints in the history that suggest why it was initially added? or it might simply have

RFR: 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.

2025-08-25 Thread Phil Race
The disposer for MemoryCacheImageInputStream isn't needed. All it does is clear an ArrayList of byte[] GC can take care of that. - Commit messages: - 8365197 Changes: https://git.openjdk.org/jdk/pull/26933/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26933&range=00 Is

Re: RFR: 8360160: ubuntu-22-04 machine is failing client tests [v2]

2025-08-25 Thread Alexey Ivanov
On Thu, 21 Aug 2025 03:02:07 GMT, Prasanta Sadhukhan wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace setAutoDelay > > test/jdk/java/awt/Frame/FrameVisualTest.java line 60: > >> 58: robot = new Rob

Re: RFR: 8360160: ubuntu-22-04 machine is failing client tests [v2]

2025-08-25 Thread Alexey Ivanov
On Mon, 25 Aug 2025 16:56:55 GMT, Damon Nguyen wrote: >> Ubuntu machine has multiple failing java awt tests. When looking at the >> screenshots of the desktop when each test fails, a white square can be seen >> at the top-left of the desktop. >> >> > src="https://github.com/user-attachments/as

Re: RFR: 8366002: Beans.instantiate needs to describe the lookup procedure

2025-08-25 Thread Alexey Ivanov
On Fri, 22 Aug 2025 17:39:10 GMT, Phil Race wrote: > Some text describing the Beans.instantiate lookup process existed only on the > method that used the now removed AppletInitializer. > Since there are two other Beans.instantiate methods, we need to move that > text to the remaining methods. >

Re: RFR: 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print [v2]

2025-08-25 Thread Alexey Ivanov
On Fri, 18 Jul 2025 13:19:10 GMT, Christian Heilmann wrote: >> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in t

Re: RFR: 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print [v2]

2025-08-25 Thread Alexey Ivanov
On Mon, 25 Aug 2025 19:38:15 GMT, Alexey Ivanov wrote: >>> However, the fix resets the known range of pages to the full range of the >>> document. Is it because the native code doesn't care about the range and >>> it's handled in Java side? >> >> It looks like the operating system does not exp

RFR: 8344333: Spurious System.err.flush() in LWCToolkit.java

2025-08-25 Thread Phil Race
trivial internal cleanup - Commit messages: - 8344333 Changes: https://git.openjdk.org/jdk/pull/26931/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26931&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344333 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod

Re: RFR: 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print [v2]

2025-08-25 Thread Alexey Ivanov
On Mon, 28 Jul 2025 13:15:17 GMT, Christian Heilmann wrote: > > Does it work correctly if mDocument.getNumberOfPages() in CPrinterJob.java > > returns a certain number instead of UNKNOWN_NUMBER_OF_PAGES? > > I tried both variants and it does not work. You didn't answer the question, so I had t

Re: RFR: 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print [v2]

2025-08-25 Thread Alexey Ivanov
On Fri, 18 Jul 2025 13:19:10 GMT, Christian Heilmann wrote: >> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in t

Integrated: 8365291: Remove finalize() method from sun/awt/X11InputMethodBase.java

2025-08-25 Thread Phil Race
On Tue, 12 Aug 2025 18:56:56 GMT, Phil Race wrote: > It seems that finalize() in X11InputMethodBase.java isn't useful. > It calls dispose(), which in all actual implementations has just one native > resource to release, which > is a native struct of type X11InputMethodData (this is a JDK-defined

Re: RFR: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8 [v3]

2025-08-25 Thread Volker Simonis
> No. That won't be allowed. You aren't using your own IP. > > > > Sorry, but I don't understand the problem? We have a bunch of other > > > > third-party libraries which are included in OpenJDK along with their > > > > corresponding license files. J

Re: RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v4]

2025-08-25 Thread Sergey Bylokhov
On Mon, 25 Aug 2025 12:29:41 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated the Bean Property description with meaningful string for >> JTable.setShowGrid. >> >> Pleas review and let me know your suggestions if any. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v4]

2025-08-25 Thread Alexander Zvegintsev
On Mon, 25 Aug 2025 12:29:41 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated the Bean Property description with meaningful string for >> JTable.setShowGrid. >> >> Pleas review and let me know your suggestions if any. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8 [v3]

2025-08-25 Thread Volker Simonis
On Fri, 22 Aug 2025 18:59:05 GMT, Daniel Gredler wrote: > Great write-up. I haven't followed all of the rabbit trails linked, but I > think I understand the overall issue. > Thanks :) > Regarding testing -- > > My understanding is that including any open source fonts in the tests > requires

Re: RFR: 8365291: Remove finalize() method from sun/awt/X11InputMethodBase.java

2025-08-25 Thread Alexander Zvegintsev
On Tue, 12 Aug 2025 18:56:56 GMT, Phil Race wrote: > It seems that finalize() in X11InputMethodBase.java isn't useful. > It calls dispose(), which in all actual implementations has just one native > resource to release, which > is a native struct of type X11InputMethodData (this is a JDK-defined

Re: RFR: 8360160: ubuntu-22-04 machine is failing client tests [v2]

2025-08-25 Thread Alexander Zvegintsev
On Mon, 25 Aug 2025 16:56:55 GMT, Damon Nguyen wrote: >> Ubuntu machine has multiple failing java awt tests. When looking at the >> screenshots of the desktop when each test fails, a white square can be seen >> at the top-left of the desktop. >> >> > src="https://github.com/user-attachments/as

Re: RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v4]

2025-08-25 Thread Alexey Ivanov
On Mon, 25 Aug 2025 12:29:41 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated the Bean Property description with meaningful string for >> JTable.setShowGrid. >> >> Pleas review and let me know your suggestions if any. > > Renjith Kannath Pariyangad has updated the pull re

Integrated: 8365292: Remove javax.imageio.spi.ServiceRegistry.finalize()

2025-08-25 Thread Phil Race
On Tue, 12 Aug 2025 19:32:33 GMT, Phil Race wrote: > Remove javax.imageio.spi.ServiceRegistry.finalize() since it is deprecated > for removal. > The impact of this should be minimal. The IIORegistry will now be a singleton > - which it already was > in practice since Applets are no longer supp

Re: RFR: 8360160: ubuntu-22-04 machine is failing client tests [v2]

2025-08-25 Thread Damon Nguyen
> Ubuntu machine has multiple failing java awt tests. When looking at the > screenshots of the desktop when each test fails, a white square can be seen > at the top-left of the desktop. > > src="https://github.com/user-attachments/assets/52d023f6-18ff-46d4-98c4-e2e332ab6a03"; > /> > > This se

Re: RFR: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8 [v3]

2025-08-25 Thread Philip Race
That's not relevant. This issue is about what you will contribute. You should read and understand the OCA. If necessary you should consult your organization's legal department for help. -phil. On 8/25/25 9:33 AM, Volker Simonis wrote: I can use [`hb-subset`](https://man.archlinux.org/man/ex

Re: RFR: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8 [v3]

2025-08-25 Thread Volker Simonis
On Fri, 22 Aug 2025 19:39:18 GMT, Phil Race wrote: > > > I already ran all our automated tests, and I'm not too surprised they > > > pass, since they probably don't cover this as well as they should. > > > > > > Thanks! > > > I think it would be possible and a good idea to add a test. All you

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v3]

2025-08-25 Thread Alexey Ivanov
On Mon, 25 Aug 2025 09:53:10 GMT, Jayathirth D V wrote: >> We need to throw appropriate exception when we pass invalid image index >> values to ImageReader.getImageTypes(). >> We throw IOOBE in all other plugins except JPEG, Added appropriate check to >> throw IOOBE when JpegImageReader has inv

Re: RFR: 8365886: JSplitPane loses track of the left component when the component orientation is changed [v2]

2025-08-25 Thread Alan Snyder
That is a heavy handed solution. Isn’t this better: layoutManager.updateComponents(); > On Aug 24, 2025, at 2:03 AM, Prasanta Sadhukhan > wrote: > >> When the component orientation is changed from LTR to RTL or the other way >> around, JSplitPane exchanges the left and right componen

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Albert Mingkun Yang
On Mon, 25 Aug 2025 11:40:56 GMT, Leo Korinth wrote: > while not multiplying a 10x factor with four resulting in a 40x factor. Why is that undesirable? The base is `(HOLD_TARGET_TIME + 3) * 4` and the timeout-factor changes that linearly. Using `max(..., 4)` here may come as a surprise to

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v10]

2025-08-25 Thread Alexey Ivanov
On Fri, 22 Aug 2025 07:21:58 GMT, Tejesh R wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 25 commits: >> >> - Merge master >> - JDK-8314731 : Remove all indentations accidentally introduced by the >> p

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v10]

2025-08-25 Thread Alexey Ivanov
On Mon, 9 Dec 2024 09:56:15 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK-

Re: RFR: 8365292: Remove javax.imageio.spi.ServiceRegistry.finalize() [v2]

2025-08-25 Thread Alexander Zvegintsev
On Wed, 20 Aug 2025 20:36:21 GMT, Phil Race wrote: >> Remove javax.imageio.spi.ServiceRegistry.finalize() since it is deprecated >> for removal. >> The impact of this should be minimal. The IIORegistry will now be a >> singleton - which it already was >> in practice since Applets are no longer

Re: RFR: 8365609: Fix several potential NULL native pointer dereferences in the desktop module [v2]

2025-08-25 Thread Artem Semenov
> The defect has been detected and confirmed in the function > OGLBlitToSurfaceViaTexture() located in the file > src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c with static > code analysis. This defect can potentially lead to a null pointer dereference. > > The pointer pf is

Re: RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v4]

2025-08-25 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated the Bean Property description with meaningful string for > JTable.setShowGrid. > > Pleas review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision: Upda

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java

2025-08-25 Thread Srinivas Mandalika
On Fri, 25 Jul 2025 05:33:31 GMT, Srinivas Mandalika wrote: > The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object > monitors and wait/notify to synchronise actions in the test. > > Using CountDownLatch could make the test simpler, shorter, clearer. > Tested the code on

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v2]

2025-08-25 Thread Srinivas Mandalika
> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object > monitors and wait/notify to synchronise actions in the test. > > Using CountDownLatch could make the test simpler, shorter, clearer. > Tested the code on a windows-x64, macos-x64 and lnux-x64 machines and the > test

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 15:55:38 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/jdk/java/rmi/transport/dgcDeadLock/DGCDeadLock.jav

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Wed, 20 Aug 2025 17:05:59 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 16:06:16 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/langtools/jdk/jshell/HangingRemoteAgent.java line

Re: RFR: 8361387 : Test bug4655513.java fails intermittently on Windows platform. [v2]

2025-08-25 Thread Anass Baya
> This test was recently automated and is failing intermittently in the CI due > to timing issues. > This enhancement aims to stabilize the test and also adds the missing null > pointer check. Anass Baya has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: 8361387 : Test bug4655513.java fails intermittently on Windows platform. [v2]

2025-08-25 Thread Anass Baya
On Wed, 20 Aug 2025 08:58:03 GMT, Prasanta Sadhukhan wrote: >> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove delay >> use InputEvent > > test/jdk/javax/swing/DataTransfer/bug4655513.java line 73: > >> 71:

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 15:44:28 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/hotspot/jtreg/runtime/cds/appcds/LotsOfSyntheticCl

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Sun, 24 Aug 2025 22:51:05 GMT, David Holmes wrote: >> test/hotspot/jtreg/compiler/tiered/Level2RecompilationTest.java line 36: >> >>> 34: * @build jdk.test.whitebox.WhiteBox >>> 35: * @run driver jdk.test.lib.helpers.ClassFileInstaller >>> jdk.test.whitebox.WhiteBox >>> 36: * @run main/ot

Re: RFR: 8365292: Remove javax.imageio.spi.ServiceRegistry.finalize() [v2]

2025-08-25 Thread Jayathirth D V
On Wed, 20 Aug 2025 20:36:21 GMT, Phil Race wrote: >> Remove javax.imageio.spi.ServiceRegistry.finalize() since it is deprecated >> for removal. >> The impact of this should be minimal. The IIORegistry will now be a >> singleton - which it already was >> in practice since Applets are no longer

Re: RFR: 8361606 : ConsumeNextMnemonicKeyTypedTest.java fails on Windows: character typed with VK_A: a [v3]

2025-08-25 Thread Anass Baya
> **Analysis :** > When the problem occurrs, the key press event related to the mnemonic > triggers the item selection. However, as we returned to the menu, the > subsequent key typed event arrived and was treated as a normal key press > instead of being recognized as part of the mnemonic sequen

Re: RFR: 8361606 : ConsumeNextMnemonicKeyTypedTest.java fails on Windows: character typed with VK_A: a [v2]

2025-08-25 Thread Anass Baya
> **Analysis :** > When the problem occurrs, the key press event related to the mnemonic > triggers the item selection. However, as we returned to the menu, the > subsequent key typed event arrived and was treated as a normal key press > instead of being recognized as part of the mnemonic sequen

Re: RFR: 8364363: Modify some manual test instructions [v2]

2025-08-25 Thread Alexey Ivanov
On Wed, 13 Aug 2025 20:32:10 GMT, Damon Nguyen wrote: >> When testing jtreg manual tests, some tests had unclear instructions. This >> PR is an attempt at updating these tests for clarity. >> >> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared >> to native apps and

Re: RFR: 8361606 : ConsumeNextMnemonicKeyTypedTest.java fails on Windows: character typed with VK_A: a

2025-08-25 Thread Damon Nguyen
On Thu, 14 Aug 2025 23:38:02 GMT, Anass Baya wrote: > **Analysis :** > When the problem occurrs, the key press event related to the mnemonic > triggers the item selection. However, as we returned to the menu, the > subsequent key typed event arrived and was treated as a normal key press > inst

Re: RFR: 8364363: Modify some manual test instructions [v2]

2025-08-25 Thread Alexey Ivanov
On Wed, 13 Aug 2025 20:28:57 GMT, Damon Nguyen wrote: >> test/jdk/java/awt/TextArea/TextAreaAppendScrollTest2.java line 71: >> >>> 69: coolStr.append("cool "); >>> 70: } >>> 71: area.append(coolStr.toString()); >> >> Is adding `12 * 15` _cools_ not enough? >> >> The

Re: RFR: 8361610: Avoid wasted work in ImageIcon(Image) for setting description

2025-08-25 Thread Alexey Ivanov
On Thu, 21 Aug 2025 02:30:11 GMT, Prasanta Sadhukhan wrote: > The `ImageIcon(Image)` constructor sets the description field to the value of > "comment" property if it's a string. The `ImageIcon(Image, String)` > constructor calls ImageIcon(Image). Since the two-parameter constructor > explici

Re: RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v3]

2025-08-25 Thread Alexey Ivanov
On Mon, 25 Aug 2025 03:54:44 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated the Bean Property description with meaningful string for >> JTable.setShowGrid. >> >> Pleas review and let me know your suggestions if any. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v2]

2025-08-25 Thread Jayathirth D V
On Fri, 22 Aug 2025 07:13:45 GMT, Prasanta Sadhukhan wrote: >> Jayathirth D V has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v3]

2025-08-25 Thread Jayathirth D V
> We need to throw appropriate exception when we pass invalid image index > values to ImageReader.getImageTypes(). > We throw IOOBE in all other plugins except JPEG, Added appropriate check to > throw IOOBE when JpegImageReader has invalid image index. Jayathirth D V has updated the pull request

Re: RFR: 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index [v2]

2025-08-25 Thread Jayathirth D V
On Thu, 21 Aug 2025 20:46:41 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v27]

2025-08-25 Thread Khalid Boulanouare
On Fri, 22 Aug 2025 16:41:14 GMT, Khalid Boulanouare wrote: >> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khali

Re: RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v9]

2025-08-25 Thread duke
On Wed, 6 Aug 2025 09:43:48 GMT, Ravi Gupta wrote: >> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java >> left debris on system whenever fails its required frame.dispose() in finally >> block. >> >> >> finally { >> EventQueue.invokeAndWait(ExtraButtonDrag:

Re: RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v9]

2025-08-25 Thread Manukumar V S
On Wed, 6 Aug 2025 09:43:48 GMT, Ravi Gupta wrote: >> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java >> left debris on system whenever fails its required frame.dispose() in finally >> block. >> >> >> finally { >> EventQueue.invokeAndWait(ExtraButtonDrag: