Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v9]

2025-05-06 Thread Alexey Ivanov
On Tue, 29 Apr 2025 01:23:00 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v9]

2025-05-06 Thread duke
On Tue, 29 Apr 2025 01:23:00 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v9]

2025-05-05 Thread Alisen Chung
On Tue, 29 Apr 2025 01:23:00 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v9]

2025-04-28 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]

2025-04-28 Thread Alexey Ivanov
On Fri, 25 Apr 2025 20:13:31 GMT, Alisen Chung wrote: >> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Frame null-check before disposing the frame on the EDT > > test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 93: >

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]

2025-04-28 Thread Alexey Ivanov
On Fri, 25 Apr 2025 20:15:04 GMT, Alisen Chung wrote: >> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Frame null-check before disposing the frame on the EDT > > test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 58: >

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]

2025-04-28 Thread Alexey Ivanov
On Fri, 25 Apr 2025 20:18:27 GMT, Alisen Chung wrote: >> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Frame null-check before disposing the frame on the EDT > > test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 44: >

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]

2025-04-25 Thread Alisen Chung
On Fri, 25 Apr 2025 18:59:35 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v7]

2025-04-25 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]

2025-04-25 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v6]

2025-04-25 Thread Alexey Ivanov
On Wed, 23 Apr 2025 21:05:06 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]

2025-04-25 Thread Alexey Ivanov
On Fri, 25 Apr 2025 18:59:35 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v8]

2025-04-25 Thread Anass Baya
On Fri, 25 Apr 2025 18:24:27 GMT, Alexey Ivanov wrote: >> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Frame null-check before disposing the frame on the EDT > > test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 62: >

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v4]

2025-04-25 Thread Anass Baya
On Wed, 23 Apr 2025 10:07:52 GMT, Alexey Ivanov wrote: >> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Copyright > > Changes requested by aivanov (Reviewer). Hello @aivanov-jdk, Thank you for your review. The code c

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v7]

2025-04-25 Thread Alexey Ivanov
On Thu, 24 Apr 2025 15:53:32 GMT, Anass Baya wrote: >> test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 63: >> >>> 61: if (frame != null) { >>> 62: SwingUtilities.invokeAndWait(() -> frame.dispose()); >>> 63: } >> >> The null-check should be on EDT

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v7]

2025-04-25 Thread Anass Baya
On Thu, 24 Apr 2025 15:20:08 GMT, Alexey Ivanov wrote: >> Anass Baya has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Put the frame in the centre of the screen. >> >>Co-authored-by: Alexey Ivanov >> - library regtesthelpers

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v7]

2025-04-25 Thread Alexey Ivanov
On Fri, 25 Apr 2025 18:35:09 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v6]

2025-04-23 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v5]

2025-04-23 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v4]

2025-04-23 Thread Alexey Ivanov
On Tue, 22 Apr 2025 16:11:28 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v4]

2025-04-22 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v2]

2025-04-15 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v3]

2025-04-15 Thread Anass Baya
> This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when closing > the frame by adding a Thread.sleep() in the

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java

2025-04-14 Thread Alexey Ivanov
On Mon, 14 Apr 2025 14:54:44 GMT, Anass Baya wrote: >> test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 51: >> >>> 49: >>> 50: public static void main(String[] args) throws Exception { >>> 51: robot = JRobot.getRobot(); >> >> You don't use any of `JRobot` features, just use t

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java

2025-04-14 Thread Alexey Ivanov
On Mon, 14 Apr 2025 14:36:26 GMT, Alexey Ivanov wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBo

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java

2025-04-14 Thread Alexey Ivanov
On Mon, 14 Apr 2025 13:50:54 GMT, Anass Baya wrote: > This test was designed to manually verify that clicking on the JComboBox when > the frame containing it is about to close does not cause an > IllegalStateException. > > The test allowed the tester extra time to click on the JComboBox when c

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java

2025-04-14 Thread Anass Baya
On Mon, 14 Apr 2025 14:40:46 GMT, Alexey Ivanov wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBo