Re: Help ship Clojure 1.9!

Before Clojure 1.9 is shipped, I would like to reiterate the appeal from many in the community to stop the terrible, permanent mistake that is *clojure.core/any?* For those who have not seen past emails on this topic, you may view the main threads here: -

Re: Help ship Clojure 1.9!

I've run into a behaviour change that was actually already present in alpha20 – with the CLJ-99 patch in place, {min,max}-key now return the first argument with the minimum/maximum key, whereas previously they returned the last such argument. The new behaviour seems like the more natural one, but

Re: Help ship Clojure 1.9!

We've been using 1.9 in a small app for a while with no issues. After upgrading schema to the latest version (with the PR above) I've also successfully run our larger codebase with 1.9. On Tuesday, October 3, 2017 at 4:41:14 AM UTC-7, stuart@gmail.com wrote: > > Hi Mark, > > I think this

Re: Help ship Clojure 1.9!

Hi Mark, I think this approach totally makes sense, and the alpha naming exists to inform this kind of decision-making. For libraries where the use of spec does not have to be user-facing, I am putting specs in separate (Clojure) namespaces, and loading them in such a way that they can coexist

Re: Help ship Clojure 1.9!

On Monday, October 2, 2017 at 3:16:55 PM UTC-5, Rob Nikander wrote: > > I get this when I switch from 1.8 to 1.9 beta, but maybe it's an issue > with the `core.match` library? > > WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: > clojure.tools.analyzer.utils, being

Re: Help ship Clojure 1.9!

I get this when I switch from 1.8 to 1.9 beta, but maybe it's an issue with the `core.match` library? WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.tools.analyzer.utils, being replaced by: #'clojure.tools.analyzer.utils/boolean? Rob On Thursday,

Re: Help ship Clojure 1.9!

On Mon, Oct 2, 2017 at 7:55 AM, Stuart Halloway wrote: > Hi David, > > Spec will be in alpha for a while. That is part of the point of it being a > separate library. Can you say more about what problems this is causing? > > Stu > > As a library maintainer, I am forced

Re: Help ship Clojure 1.9!

Hello Stu, On 02/10/17 16:55, Stuart Halloway wrote: > Spec will be in alpha for a while. That is part of the point of it being > a separate library. Can you say more about what problems this is causing? I don’t have any stakes in this so it’s better if I withdraw my question. I was (still am)

RE: Help ship Clojure 1.9!

ret Atwood From: clojure@googlegroups.com <clojure@googlegroups.com> on behalf of David Bürgin <dbuer...@gluet.ch> Sent: Saturday, September 30, 2017 1:52:47 AM To: clojure@googlegroups.com Subject: Re: Help ship Clojure 1.9! On 28/09/17 16:00, Stuart Halloway wrote: > Clojure

Re: Help ship Clojure 1.9!

Since spec is mainly a dependency of 1.9. to improve error reporting over 1.8 (correct me if I'm wrong), I'd like to point out this ticket again: https://dev.clojure.org/jira/browse/CLJ-2013 It solves what I determined the root cause of this report

Re: Help ship Clojure 1.9!

Hi David, Spec will be in alpha for a while. That is part of the point of it being a separate library. Can you say more about what problems this is causing? Stu On Sat, Sep 30, 2017 at 4:52 AM, David Bürgin wrote: > On 28/09/17 16:00, Stuart Halloway wrote: > > Clojure 1.9

Re: Help ship Clojure 1.9!

Other than spotting an issue with yada which involved upgrading aleph (https://github.com/juxt/yada/issues/199) and an issue with ClojureScript with was fixed on master I haven't encountered any problems. All our integration tests pass. Good luck with bringing Clojure 1.9.0 out the door! On

Re: Help ship Clojure 1.9!

On 28/09/17 16:00, Stuart Halloway wrote: > Clojure 1.9 has been quite stable throughout the alpha period, and we > now hope to release after a very short beta. Please test your existing > programs on the latest beta (see below), and respond on this thread ASAP > if you discover anything you

Re: Help ship Clojure 1.9!

Yes, clojurescript makes use of a previous experimental feature of tools.reader that allowed Infinity and -Infinity to be read as Double/POSITIVE_INFINITY and Double/NEGATIVE_INFINITY, without special casing how the compiler emitted infinity literals, as clojure previously printed them as

Re: Help ship Clojure 1.9!

And to maybe answer my own question, I guess it is https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/core.cljs#L988-L990 . On Fri, Sep 29, 2017 at 1:45 PM, Stuart Halloway wrote: > To be clear: we can certainly cut a new release of CLJS, I just

Re: Help ship Clojure 1.9!

To be clear: we can certainly cut a new release of CLJS, I just want to understand other options, if any. On Fri, Sep 29, 2017 at 1:38 PM, Stuart Halloway wrote: > Hi Aleš, Mark, > > Thanks for the reports! It isn't clear to me how a change to tools.reader > can fix a

Re: Help ship Clojure 1.9!

Hi Aleš, Mark, Thanks for the reports! It isn't clear to me how a change to tools.reader can fix a problem with the core hash function. Can somebody point me to the place in the Clojurescript code where this happens? Stu On Fri, Sep 29, 2017 at 11:13 AM, Aleš Roubíček wrote:

Re: Help ship Clojure 1.9!

The Cljs problem is easily solvable by referencing latest tools.reader: [org.clojure/clojurescript "1.9.908" :exclusions [org.clojure/tools.reader]] [org.clojure/tools.reader "1.1.0"] On Thursday, September 28, 2017 at 8:37:11 PM UTC+2, puzzler wrote: > > And to be clear, it doesn't only

Re: Help ship Clojure 1.9!

And to be clear, it doesn't only affect people who try to use ##Inf or ##NaN in their Clojurescript code. It affects all existing Clojurescript code, because running the Clojurescript compiler in a new version of Clojure causes all Clojurescript code to emit these ## characters directly into the

Re: Help ship Clojure 1.9!

On Thu, Sep 28, 2017 at 11:02 AM, Jeaye wrote: > This has been the only issue we've run into with 1.9.0-beta1 ( ticket is > here https://dev.clojure.org/jira/browse/CLJS-2352 ). On our back-end, > all tests are good, but we can't currently use beta1 (or alpha20) on the >

Re: Help ship Clojure 1.9!

Clojure 1.9 has been great for me so far. I think it's worth considering the problem Luke brought up regarding the REPL caught handler [1], especially since the compiler now checks macro specs. Having a slightly better knob for that might be nice, since it's an integration point. (This is not

Re: Help ship Clojure 1.9!

This has been the only issue we've run into with 1.9.0-beta1 ( ticket is here https://dev.clojure.org/jira/browse/CLJS-2352 ). On our back-end, all tests are good, but we can't currently use beta1 (or alpha20) on the front-end, since this issue causes CLJS to choke. I'm hoping that a new

Re: Help ship Clojure 1.9!

Thanks Beau! On Thu, Sep 28, 2017 at 1:06 PM, Beau Fabry wrote: > Identified an issue with prismatic/schema https:// > github.com/plumatic/schema/pull/399 > > On Thursday, September 28, 2017 at 9:18:52 AM UTC-7, Nathan Fisher wrote: >> >> Hi Stuart, >> >> Looks like any

Re: Help ship Clojure 1.9!

Identified an issue with prismatic/schema https://github.com/plumatic/schema/pull/399 On Thursday, September 28, 2017 at 9:18:52 AM UTC-7, Nathan Fisher wrote: > > Hi Stuart, > > Looks like any project using lein-cljsbuild will be affected. > > I forked and bumped the Clojure and ClojureScript

Re: Help ship Clojure 1.9!

Hi Stuart, Looks like any project using lein-cljsbuild will be affected. I forked and bumped the Clojure and ClojureScript version to latest and got the same error with their simple project: See Commit: https://github.com/nfisher/lein-cljsbuild/commit/5df5d3c5bb447b51a75abbbccdc72447814883a0

Re: Help ship Clojure 1.9!

Hi Nathan, I suspect that is the same as https://github.com/clojure/clojurescript/commit/89914d2ead964122f99e638edda0cd96d330cb66. I don't have a sense of how many CLJS project this is going to cascade into, or what all will be needed. Anyone? Stu On Thu, Sep 28, 2017 at 10:44 AM, Nathan Fisher

Re: Help ship Clojure 1.9!

Hi Stuart, Working to create a minimal test case but upgrading from alpha19 to beta1 seems to have broken lein-cljsbuild. I get the following error: >> snip >> *SEVERE: /Users/nathanfisher/workspace/mklpq/target/cljsbuild-compiler-0/cljs/core.js:3579: ERROR - Parse error. primary

Help ship Clojure 1.9!

Clojure 1.9 has been quite stable throughout the alpha period, and we now hope to release after a very short beta. Please test your existing programs on the latest beta (see below), and respond on this thread ASAP if you discover anything you believe to be a regression. Thanks! Stu ;; Clojure