This is fairly forward looking. Depending on the OS support for this sort of
thing, it's certainly desirable for users to want to say things like "send
queries to this server out this interface" however, I don't know of an OS that
does this without more configuration elsewhere on the system.
Do you expect this to run pre-systemd (precise or trusty)?
--
https://code.launchpad.net/~smoser/cloud-init/trunk.disable-clouddinit/+merge/287580
Your team cloud init development team is requested to review the proposed merge
of lp:~smoser/cloud-init/trunk.disable-clouddinit into lp:cloud-init.
handler looks fine, comments in line.
missing: doc/examples/cloud-config-spacewalk.txt
Diff comments:
> diff --git a/cloudinit/config/cc_spacewalk.py
> b/cloudinit/config/cc_spacewalk.py
> new file mode 100644
> index 000..d82cfbf
> --- /dev/null
> +++ b/cloudinit/config/cc_spacewalk.py
>
> - use arrays for each 'section' rather than content += . This allows better
> separation of the sections and also will perform better as long strings
> with += are slow.
+1 for better separation. I don't think there is significant difference:
For an 100-line eni (that's rather high for
Looks good. Could we add unittests for distro using apply_network, including
one without a _write_network so we can test that fallback logic?
Diff comments:
>
> === modified file 'tests/unittests/test_net.py'
> --- tests/unittests/test_net.py 2016-06-15 23:11:24 +
> +++
The errors:
flake8 runtests: commands[0] |
/var/lib/jenkins/slaves/jenkins-slave-4/workspace/cloud-init-ci/nodes/amd64/cloud-init-ci-2/.tox/flake8/bin/python
-m flake8 cloudinit/ tests/ tools/
cloudinit/sources/DataSourceDigitalOcean.py:23:1: H306 imports not in
alphabetical order
Ryan Harper has proposed merging ~raharper/cloud-init:net-dont-use-alias into
cloud-init:master.
Commit message:
Fix eni rendering of multiple IPs per interface
The iface:alias syntax for eni rendering is brittle with ipv6.
Replace it with using multiple iface stanzas with the same iface
The proposal to merge ~raharper/cloud-init:net-dont-use-alias into
cloud-init:master has been updated.
Commit Message changed to:
Fix eni rendering of multiple IPs per interface
The iface:alias syntax for eni rendering is brittle with ipv6.
Replace it with using multiple iface stanzas with
Ryan Harper has proposed merging
~raharper/cloud-init:cloud-init-wait-on-networkd into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1636912 in cloud-init: "systemd-networkd runs too late for
cloud-init.service (net)&quo
Diff comments:
> diff --git a/cloudinit/config/cc_apt_configure.py
> b/cloudinit/config/cc_apt_configure.py
> index 42c5641..76b8d64 100644
> --- a/cloudinit/config/cc_apt_configure.py
> +++ b/cloudinit/config/cc_apt_configure.py
> @@ -476,9 +477,13 @@ def convert_v2_to_v3_apt_format(oldcfg):
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_opennebula.py
> b/tests/unittests/test_datasource/test_opennebula.py
> index d796f03..339d8a4 100644
> --- a/tests/unittests/test_datasource/test_opennebula.py
> +++ b/tests/unittests/test_datasource/test_opennebula.py
> @@
Ryan Harper has proposed merging ~raharper/cloud-init:systemd_export_tz into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/307722
Export TZ environment variable
The proposal to merge ~raharper/cloud-init:fix-unittest-assert-called into
cloud-init:master has been updated.
Commit Message changed to:
unittests: fix use of mock 2.0 'assert_called' when running make check
Some of the new DigitalOcean unittests were written to use
'assert_called', which is
I'd like to see this merged.
Currently we see mixed timestamp formats in cloud-init.log:
2016-08-29 15:12:15,475 - __init__.py[DEBUG]: handling ssh with freq=None and
args=[]
Aug 29 15:12:15 p1 [CLOUDINIT] cloud-init-cfg[INFO]: cloud-init-cfg ['all',
'config']
The point in which the logging
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-blockdev-mapping.html
shows that it may be a list of dicts? Am I reading that right?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/310371
Your team cloud init development team is requested
On Tue, Nov 8, 2016 at 3:43 PM, Scott Moser wrote:
> when you provide it you can give a list of dicts... in the metadata
> service it must come back as a dictionary (the code we have does items() on
> it, so it can't be a list).
>
> see
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..693a091
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,109 @@
> +
> +Boot Stages
> +
> +In order to be able to provide the functionality
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..51e4815
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,121 @@
> +
> +Boot Stages
> +
> +In order to be able to provide the functionality
We should sync/link with a systemd but requiring systemd-networkd.service to
drop After=dbus.service ... nto sure if
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1636912 covers that on
the systemd side, without that, networkd/netplan enabled instances will break
if they want to mount
On Wed, Oct 19, 2016 at 9:09 AM, Scott Moser wrote:
> Please rebase.
>
> Ryan, will your log analyzer handle this change?
>
Yes, the analyzer is primarily interested in the event 'start' and 'finish'
messages; the log exceptions
aren't utilized for event tracking.
I'll
On Tue, Oct 18, 2016 at 2:49 PM, Scott Moser wrote:
> $ cat go.sh
> #!/bin/sh
> deps="
> apt cloud-guest-utils coreutils dash debconf e2fsprogs gnupg2 hostname
> ifupdown iproute2 locales lsb-release mount net-tools passwd procps sed
> ssh-import-id systemd udev
> "
> for dep
That won;t fix python interpreter from fstat'ing though
On Tue, Oct 18, 2016 at 2:51 PM, Scott Moser wrote:
> an alternative implementation of this would be for cloud-init to read TZ
> from os.environ, and if not set, then it could set it in os.environ to
> :/etc/localtime .
On Wed, Oct 19, 2016 at 8:52 AM, Ryan Harper <ryan.har...@canonical.com>
wrote:
>
>
> On Wed, Oct 19, 2016 at 8:04 AM, Scott Moser <smo...@ubuntu.com> wrote:
>
>> over all, looks good.
>> you dont have to clean up the handle, but if you see e
The proposal to merge ~raharper/cloud-init:snapuser-create into
cloud-init:master has been updated.
Description changed to:
Add support for snap create-user on Ubuntu Core images
Ubuntu Core images use the `snap create-user` to add users to a Ubuntu
Core system. Add support for creating snap
Diff comments:
> diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py
> index 26c0240..5005d69 100644
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -140,23 +141,97 @@ def apply_reporting_cfg(cfg):
> reporting.update_configuration(cfg.get('reporting'))
>
>
>
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index b802b03..10a8b6f 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -266,97 +258,92 @@ class
On Mon, Nov 21, 2016 at 10:32 AM, Scott Moser wrote:
> based on the findings above/my understanding, this should be equivalent to
> your suggested change:
>
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -694,4 +694,6 @@ def main(sysv_args=None):
>
>
> if
On Fri, Nov 4, 2016 at 4:08 AM, Scott Moser wrote:
> Are hyou sure it wouldn't fix it?
> changing os.environ should change the environment of the process that is
> running, which (I'd think) would have the same result. Unless python is
> doing all those stats before we could
t; +# vi: ts=4 expandtab
> +#
> +#Copyright (C) 2016 Canonical Ltd.
> +#
> +#Author: Ryan Harper <ryan.har...@canonical.com>
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU General Public License v
Should we update the unittest to test this listing for each of our Datasources?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/312732
Your team cloud init development team is requested to review the proposed merge
of ~smoser/cloud-init:bug/1645916-cloudsigma-local-ds
Diff comments:
> diff --git a/cloudinit/config/cc_mounts.py b/cloudinit/config/cc_mounts.py
> index 452c9e8..aa4e352 100644
> --- a/cloudinit/config/cc_mounts.py
> +++ b/cloudinit/config/cc_mounts.py
> @@ -423,37 +425,53 @@ def handle(_name, cfg, cloud, log, _args):
>
Ryan Harper has proposed merging ~raharper/cloud-init:bug-lp-1645644-ntp into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1645644 in cloud-init: "ntp not using expected servers"
https://bugs.launchpad.net/cloud-init/+b
The proposal to merge ~raharper/cloud-init:bug-lp-1645644-ntp into
cloud-init:master has been updated.
Description changed to:
cc_ntp: write template before installing and add service restart
On systems which installed ntp and specified servers or pools in the
config ntpd didn't notice the
Thanks for the input; I'll update.
Diff comments:
> diff --git a/doc/rtd/topics/network-config-format-eni.rst
> b/doc/rtd/topics/network-config-format-eni.rst
> new file mode 100644
> index 000..e4bcbe7
> --- /dev/null
> +++ b/doc/rtd/topics/network-config-format-eni.rst
> @@ -0,0 +1,14 @@
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321222
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321465
Your team cloud init development team is requested to review the proposed merge
of
Ryan Harper has proposed merging
~raharper/cloud-init:net-v2-dont-print-udevadm-commands into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321222
netplan
Ryan Harper has proposed merging ~raharper/cloud-init:fix-snap-user-doc into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321229
Add rtd entry for snap_config
Ryan Harper has proposed merging ~raharper/cloud-init:network-config-doc into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321397
doc: document network
Looks good! Some feedback in the integration test.
Diff comments:
> diff --git a/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> b/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> index 3cd28df..9b75d49 100644
> ---
Ryan Harper has proposed merging
~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/320291
cloudinit.net
RHEL/Centos docs say you *really* shouldn't modify the built-in ifcg-lo.cfg
unless you know what you're doing. It appears that you're affirming this (if
loopback: continue); We probably want to log a warning in case someone
*wanted* to render a specific loopback config.
If we did want to
On Fri, Mar 17, 2017 at 10:14 AM, Scott Moser wrote:
> So as it is here we're not writing that file (ifcfg-lo), and I think that
> is sane.
> we just assume that that is there and present, if not, it kind of falls in
> the range of "broken image"? that sound reasonable ?
>
Diff comments:
> diff --git a/cloudinit/distros/__init__.py b/cloudinit/distros/__init__.py
> index 803ac74..22ae998 100755
> --- a/cloudinit/distros/__init__.py
> +++ b/cloudinit/distros/__init__.py
> @@ -73,7 +73,7 @@ class Distro(object):
>
> def _supported_write_network_config(self,
The proposal to merge ~raharper/cloud-init:rebased-netconfig-v2-passthrough
into cloud-init:master has been updated.
Description changed to:
cloudinit.net: add network config v2 parsing and rendering
Network configuration version 2 format is implemented in a package
called netplan (nplan)[1]
Diff comments:
> diff --git a/cloudinit/version.py b/cloudinit/version.py
> index e61597d..3a28843 100644
> --- a/cloudinit/version.py
> +++ b/cloudinit/version.py
> @@ -9,6 +9,7 @@ __VERSION__ = "0.7.9"
> FEATURES = [
> # supports network config version 1
> 'NETWORK_CONFIG_V1',
Thanks for the review
Diff comments:
> diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py
> index 48ccec8..f77b1e3 100644
> --- a/cloudinit/distros/debian.py
> +++ b/cloudinit/distros/debian.py
> @@ -38,11 +39,16 @@ ENI_HEADER = """# This file is generated from information
>
fix "create add support" -> "add support" in the above message (or at least fix
in commit message).
Two comments below; generally looks good.
Diff comments:
> diff --git a/cloudinit/warnings.py b/cloudinit/warnings.py
> new file mode 100644
> index 000..a21794f
> --- /dev/null
> +++
The proposal to merge ~raharper/cloud-init:netconfig-v2-passthrough into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/319259
--
Your team cloud init development
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> old mode 100755
> new mode 100644
> index 1cf98ef..ff358c6
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -358,6 +386,8 @@ def get_interfaces_by_mac(devs=None):
>
Ryan Harper has proposed merging
~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1701420 in cloud-init: "Created by cloud-init comment being added on
every r
Ryan Harper has proposed merging
~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into
cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1686485 in cloud-init: "c
The proposal to merge
~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into
cloud-init:master has been updated.
Description changed to:
cc_ntp: fallback on timesyncd configuration if ntp is not installable
Some systems like Ubuntu-Core do not provide an ntp package for
Thanks for the review, I'll fix the issues you raised and push in an update.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 31ed64e..0b92a40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -185,19 +217,25 @@ def
Ryan Harper has proposed merging ~raharper/cloud-init:logging-gmtime into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/329122
Configure logging module to always use
Nice work. Couple of questions inline.
Diff comments:
> diff --git a/tests/unittests/test_handler/test_handler_landscape.py
> b/tests/unittests/test_handler/test_handler_landscape.py
> new file mode 100644
> index 000..d35ba60
> --- /dev/null
> +++
I believe we've already have one, I've linked the RHEL issue to it.
--
https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/328877
Your team cloud-init commiters is requested to review the proposed merge of
~rmccabe/cloud-init:dns_redirect_detect into cloud-init:master.
Thanks for the patch. I've a couple comments below.
Diff comments:
> diff --git a/cloudinit/config/cc_chef.py b/cloudinit/config/cc_chef.py
> index 02c70b1..94500b6 100644
> --- a/cloudinit/config/cc_chef.py
> +++ b/cloudinit/config/cc_chef.py
> @@ -302,12 +302,16 @@ def install_chef(cloud,
Ryan Harper has proposed merging ~raharper/cloud-init:update-features-doc into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/328992
doc:capabilities Update supported
Inline comment below
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_ec2.py
> b/tests/unittests/test_datasource/test_ec2.py
> new file mode 100644
> index 000..a5485ff
> --- /dev/null
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -0,0 +1,201 @@
> +# This file
Looks pretty solid. Just a few in-line comments/fixes
Diff comments:
> diff --git a/tests/cloud_tests/instances/kvm.py
> b/tests/cloud_tests/instances/kvm.py
> new file mode 100644
> index 000..c855e07
> --- /dev/null
> +++ b/tests/cloud_tests/instances/kvm.py
> @@ -0,0 +1,222 @@
> +# This
The proposal to merge ~raharper/cloud-init:curtin-centos into cloud-init:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
--
Your team cloud-init commiters is requested to
Not sure that's right (I Think it should be IPV6_GATEWAY0)
On Tue, Jul 18, 2017 at 4:09 PM, Scott Moser wrote:
> I pulled:
>
> Your-commit trunk-comt summary
> 8da074f831c d1e8eb73ac sysconfig: include GATEWAY value if set in subnet
>
> changes:
> i shorted lines in commit
Ryan Harper has proposed merging ~raharper/cloud-init:curtin-centos into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1687725 in cloud-init: "sysconfig render does not support type manual
subnets"
https://bugs.launchpad.net/cloud
The proposal to merge ~smoser/cloud-init:feature/curtin-centos3 into
cloud-init:master has been updated.
Commit Message changed to:
templatize systemd unit files for cross distro deltas
Under el7, cloud-init systemd files need some unit tweaks to ensure they
run at the right time. Pull in
Diff comments:
> diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py
> index ce3c10d..35d9a55 100644
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -372,6 +372,7 @@ def main_init(name, args):
> LOG.debug("[%s] %s is in local mode, will apply init modules
>
Ryan Harper has proposed merging ~raharper/cloud-init:fix-net-convert into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1685944 in cloud-init (Ubuntu): "tools/net-convert: fix argument order
for render_network_state&quo
The proposal to merge ~raharper/cloud-init:fix-net-convert into
cloud-init:master has been updated.
Description changed to:
tools/net-convert: fix argument order for render_network_state
We're calling Renderer.render_network_state() with incorrect args.
% PYTHONPATH=`pwd`
Ryan Harper has proposed merging ~raharper/cloud-init:bug-lp-1709180-v2-params
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1709180 in cloud-init: "cloud-init v2 yaml doesn't preserve bond/bridge
parameters when rendering&quo
Fix suggestions, rebased and updated.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/328427
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into
cloud-init:master.
Current Ubuntu (and Debian) images already include the C.UTF-8 locale.
Updating the default in cloud-init (for Ubuntu and Debian) means we can realize
a non-zero speed up during boot.
Building cloud-init from this branch, injecting it into an artful image and
comparing time spent in
Ryan Harper has proposed merging ~raharper/cloud-init:default-lang-c-utf8 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/329152
distro: allow distro to specify
Diff comments:
> diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py
> index abfb81f..b2904e8 100644
> --- a/cloudinit/distros/debian.py
> +++ b/cloudinit/distros/debian.py
> @@ -246,9 +250,17 @@ def apply_locale(locale, sys_path=LOCALE_CONF_FN,
> keyname='LANG'):
>
We should update the netplan unittest to include a vlan mac_address.
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324021
Your team cloud init development team is requested to review the proposed merge
of ~xnox/cloud-init:vlan-macaddress into cloud-init:master.
Generally looks fine, one question w.r.t confirming explict_dslist check
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
The proposal to merge
~raharper/cloud-init:eni-drop-rendering-systemd-link-files into
cloud-init:master has been updated.
Description changed to:
cloudinit.net: remove systemd link file writing from eni renderer
During the network v2 merge, we re-enabled rendering systemd .link files.
This
Other than trying to understand the comment about dropping blkdev command
(which I think still is present at line 13) it looks good.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..7aacae4 100644
> ---
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index db3c357..9def76d 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -289,19 +289,16 @@ class NetworkStateInterpreter(object):
>
Ryan Harper has proposed merging ~raharper/cloud-init:eni-bridge-multiline-keys
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/324702
Fix eni rendering for bridge
The proposal to merge ~raharper/cloud-init:eni-bridge-multiline-keys into
cloud-init:master has been updated.
Description changed to:
Fix eni rendering for bridge params which require repeating key for vals
There are a few bridge parameters which require repeating the key with each
value in
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index 29eb5dd..e1505b3 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -504,12 +488,35 @@ def check_partition_gpt_layout(device, layout):
>
Diff comments:
> diff --git a/tools/test-centos-run.sh b/tools/test-centos-run.sh
> new file mode 100755
> index 000..13cde62
> --- /dev/null
> +++ b/tools/test-centos-run.sh
> @@ -0,0 +1,47 @@
> +#!/bin/bash
do we want to run this under set -e ? I see a mix of error catching for some
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index 9e9c05a..1d92db0 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -692,53 +670,213 @@ class NetworkStateInterpreter(object):
> return subnets
>
Diff comments:
> diff --git a/cloudinit/net/netplan.py b/cloudinit/net/netplan.py
> index d7ddf0c..6754330 100644
> --- a/cloudinit/net/netplan.py
> +++ b/cloudinit/net/netplan.py
> @@ -119,8 +119,8 @@ def _extract_addresses(config, entry):
> entry.update({sn_type: True})
>
We need centos as the distro.variant value is used to set the default distro
user and gecos names.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325311
Your team cloud-init commiters is requested to review the proposed merge of
Ryan Harper has proposed merging ~raharper/cloud-init:redhat-fix-spec-systemd
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325402
Update redhat spec to use distro
Ryan Harper has proposed merging ~raharper/cloud-init:redhat-selinux-fixes into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325404
Fix a few selinux issues found
Ryan Harper has proposed merging ~raharper/cloud-init:pregen-locale into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325406
Check before attempting to regenerate
On Fri, May 5, 2017 at 8:21 AM, Scott Moser wrote:
> > From Ryan:
> > Some thoughts on this:
> >
> > 1) we don't want users who apt install cloud-init to also pull down
> python-
> > devel, gcc and have to compile the extension, so please don't change
> package
> > deps here
>
Some thoughts on this:
1) we don't want users who apt install cloud-init to also pull down
python-devel, gcc and have to compile the extension, so please don't change
package deps here
2) this is currently an issue for the tox/venv environment, so let's focus on
how to enable the SafeLoader
It doesn't look like you dropped blockdev as you say in your comment.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..7aacae4 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@
Hi Dusty,
Thank you for your contribution to cloud-init. Contributions to
cloud-init require the developer to have signed the Canonical Contributors
Agreement [1]. Your launchpad id is not currently listed as a member of
the contributor-agreement-canonical group [2].
Membership in that group
I've kept the regex filter as suggested and added unittests.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/330995
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:ds-ovf-use-util-find-devs-with into cloud-init:master.
As it turns out, two parallel instances of /bin/mount pointing to the same
device will cause one to fail; it appears that there is some sort of
locking/ref-counting during a mount operation that results in one of the two
mount processes getting EBUSY as a result.
This sort of race is
> As it turns out, two parallel instances of /bin/mount pointing
> to the same device will cause one to fail; it appears that there
> is some sort of locking/ref-counting during a mount operation
> that results in one of the two mount processes getting EBUSY as a result.
In particular, when we
I'm ok with the changes, though I would much prefer not using a string that's
11 times longer than 'all';
if we can shorten that sanely, I'm +1
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330384
Your team cloud-init commiters is requested to review the proposed
The proposal to merge ~raharper/cloud-init:ds-ovf-use-util-find-devs-with into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/330995
--
Your team cloud-init commiters
Ryan Harper has proposed merging
~raharper/cloud-init:ds-ovf-use-util-find-devs-with into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/330995
DataSourceOVF: use
On Wed, Oct 4, 2017 at 9:28 AM, Andrew Jorgensen
wrote:
> > In an exception path, I don't think this matters;
>
> Do I take this to mean it's okay as it is now, and you approve? Or would
> you like me to undo the change that Scott suggested before it gets merged?
>
That was
Ryan Harper has proposed merging
~raharper/cloud-init:azure-network-dont-config-sriov-devices into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1721579 in cloud-init: "azure: remove sriov device configuration"
https://bugs.lau
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> index 1a81a89..c389029 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@ -48,6 +54,7 @@ P_SEED_DIR = "var/lib/cloud/seed"
> P_DSID_CFG
1 - 100 of 393 matches
Mail list logo