Do you expect this to run pre-systemd (precise or trusty)?
--
https://code.launchpad.net/~smoser/cloud-init/trunk.disable-clouddinit/+merge/287580
Your team cloud init development team is requested to review the proposed merge
of lp:~smoser/cloud-init/trunk.disable-clouddinit into lp:cloud-init.
Diff comments:
>
> === modified file 'cloudinit/util.py'
> --- cloudinit/util.py 2016-03-03 23:16:13 +
> +++ cloudinit/util.py 2016-03-10 17:33:14 +
> @@ -2140,13 +2140,20 @@
> LOG.debug("did not find %s", dmi_key_path)
> return None
>
> -key_data = l
Diff comments:
> === modified file 'cloudinit/distros/rhel.py'
> --- cloudinit/distros/rhel.py 2015-06-02 20:27:57 +
> +++ cloudinit/distros/rhel.py 2016-06-14 17:59:09 +
> @@ -59,10 +61,16 @@
> # should only happen say once per instance...)
> self._runner = helpers.Run
This is fairly forward looking. Depending on the OS support for this sort of
thing, it's certainly desirable for users to want to say things like "send
queries to this server out this interface" however, I don't know of an OS that
does this without more configuration elsewhere on the system.
> - use arrays for each 'section' rather than content += . This allows better
> separation of the sections and also will perform better as long strings
> with += are slow.
+1 for better separation. I don't think there is significant difference:
For an 100-line eni (that's rather high for ty
Looks good. Could we add unittests for distro using apply_network, including
one without a _write_network so we can test that fallback logic?
Diff comments:
>
> === modified file 'tests/unittests/test_net.py'
> --- tests/unittests/test_net.py 2016-06-15 23:11:24 +
> +++ tests/unitte
The errors:
flake8 runtests: commands[0] |
/var/lib/jenkins/slaves/jenkins-slave-4/workspace/cloud-init-ci/nodes/amd64/cloud-init-ci-2/.tox/flake8/bin/python
-m flake8 cloudinit/ tests/ tools/
cloudinit/sources/DataSourceDigitalOcean.py:23:1: H306 imports not in
alphabetical order (cloudinit.uti
Ryan Harper has proposed merging ~raharper/cloud-init:fix-make-check into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/301176
Fix make check on master.
--
Your
handler looks fine, comments in line.
missing: doc/examples/cloud-config-spacewalk.txt
Diff comments:
> diff --git a/cloudinit/config/cc_spacewalk.py
> b/cloudinit/config/cc_spacewalk.py
> new file mode 100644
> index 000..d82cfbf
> --- /dev/null
> +++ b/cloudinit/config/cc_spacewalk.py
>
Ryan Harper has proposed merging ~raharper/cloud-init:add-ntp into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/301498
add ntp config module
Add support for
Ryan Harper has proposed merging ~raharper/cloud-init:snapuser-create into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1619393 in cloud-init: "cloud-init useradd/groupadd fails on
ubuntu-core-16 with readonly /etc/passwd&quo
Diff comments:
> diff --git a/cloudinit/config/cc_apt_configure.py
> b/cloudinit/config/cc_apt_configure.py
> index 42c5641..76b8d64 100644
> --- a/cloudinit/config/cc_apt_configure.py
> +++ b/cloudinit/config/cc_apt_configure.py
> @@ -476,9 +477,13 @@ def convert_v2_to_v3_apt_format(oldcfg):
>
ntp may also, though I know we wanted to have it setup early.
On Fri, Sep 9, 2016 at 8:40 AM, Scott Moser wrote:
> The proposal to merge ~smoser/cloud-init:bug/1576692 into
> cloud-init:master has been updated.
>
> Commit Message changed to:
>
> systemd: Better support package and upgrade.
>
> I
I'd like to see this merged.
Currently we see mixed timestamp formats in cloud-init.log:
2016-08-29 15:12:15,475 - __init__.py[DEBUG]: handling ssh with freq=None and
args=[]
Aug 29 15:12:15 p1 [CLOUDINIT] cloud-init-cfg[INFO]: cloud-init-cfg ['all',
'config']
The point in which the logging fo
I think it's highly useful to have a single logging mechanism for
cloud-init; I do like that cloud-init logs could also be redirected
(copied) to rsyslog for offbox config.
But I'm primarily interested in ensuring the the logs that cloud-init
writes out are formatted the same; and that we don't wai
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_opennebula.py
> b/tests/unittests/test_datasource/test_opennebula.py
> index d796f03..339d8a4 100644
> --- a/tests/unittests/test_datasource/test_opennebula.py
> +++ b/tests/unittests/test_datasource/test_opennebula.py
> @@ -233
The proposal to merge ~raharper/cloud-init:fix-unittest-assert-called into
cloud-init:master has been updated.
Description changed to:
unittests: fix use of mock 2.0 'assert_called' when running make check
Some of the new DigitalOcean unittests were written to use
'assert_called', which is only
The proposal to merge ~raharper/cloud-init:fix-unittest-assert-called into
cloud-init:master has been updated.
Commit Message changed to:
unittests: fix use of mock 2.0 'assert_called' when running make check
Some of the new DigitalOcean unittests were written to use
'assert_called', which is o
Ryan Harper has proposed merging
~raharper/cloud-init:fix-unittest-assert-called into cloud-init:master.
Commit message:
unittests: fix use of mock 2.0 'assert_called' when running make check
Some of the new DigitalOcean unittests were written to use
'assert_called', which
Ryan Harper has proposed merging ~raharper/cloud-init:systemd_export_tz into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/307722
Export TZ environment variable
t; +# vi: ts=4 expandtab
> +#
> +#Copyright (C) 2016 Canonical Ltd.
> +#
> +#Author: Ryan Harper
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU General Public License version 3, as
> +#published by
Ryan Harper has proposed merging ~raharper/cloud-init:fix-lp1619423 into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1619423 in cloud-init: "snappy does not include ssh-import-id preventing
cloud-init user-data from importin
I'm highly confused.
Our thread there in the bug was:
>> @ryan is there any reason why cloud-init does not actually depend on the
>> package if it needs it to be functional ?
>
>
>I believe it's part of the ubuntu-server seed, so it's expected to be part
>of the server image
>Or at least the clou
That won;t fix python interpreter from fstat'ing though
On Tue, Oct 18, 2016 at 2:51 PM, Scott Moser wrote:
> an alternative implementation of this would be for cloud-init to read TZ
> from os.environ, and if not set, then it could set it in os.environ to
> :/etc/localtime .
>
> Not sure which i
On Tue, Oct 18, 2016 at 2:49 PM, Scott Moser wrote:
> $ cat go.sh
> #!/bin/sh
> deps="
> apt cloud-guest-utils coreutils dash debconf e2fsprogs gnupg2 hostname
> ifupdown iproute2 locales lsb-release mount net-tools passwd procps sed
> ssh-import-id systemd udev
> "
> for dep in $deps; do
>ap
On Tue, Oct 18, 2016 at 3:03 PM, Ryan Harper
wrote:
>
>
> On Tue, Oct 18, 2016 at 2:49 PM, Scott Moser wrote:
>
>> $ cat go.sh
>> #!/bin/sh
>> deps="
>> apt cloud-guest-utils coreutils dash debconf e2fsprogs gnupg2 hostname
>> ifupdown iproute2 lo
/null
> > +++ b/cloudinit/config/cc_snap_config.py
> > @@ -0,0 +1,177 @@
> > +# vi: ts=4 expandtab
> > +#
> > +#Copyright (C) 2016 Canonical Ltd.
> > +#
> > +#Author: Ryan Harper
> > +#
> > +#This program is free software: you can redistri
On Wed, Oct 19, 2016 at 9:09 AM, Scott Moser wrote:
> Please rebase.
>
> Ryan, will your log analyzer handle this change?
>
Yes, the analyzer is primarily interested in the event 'start' and 'finish'
messages; the log exceptions
aren't utilized for event tracking.
I'll confirm.
>
> --
> http
On Wed, Oct 19, 2016 at 8:52 AM, Ryan Harper
wrote:
>
>
> On Wed, Oct 19, 2016 at 8:04 AM, Scott Moser wrote:
>
>> over all, looks good.
>> you dont have to clean up the handle, but if you see easy way to do that
>> that'd be nice.
>>
>> is
The proposal to merge ~raharper/cloud-init:snapuser-create into
cloud-init:master has been updated.
Description changed to:
Add support for snap create-user on Ubuntu Core images
Ubuntu Core images use the `snap create-user` to add users to a Ubuntu
Core system. Add support for creating snap u
Ryan Harper has proposed merging
~raharper/cloud-init:fix_cc_user_groups_normalize into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/309304
cc_users_groups: fix
On Fri, Nov 4, 2016 at 4:08 AM, Scott Moser wrote:
> Are hyou sure it wouldn't fix it?
> changing os.environ should change the environment of the process that is
> running, which (I'd think) would have the same result. Unless python is
> doing all those stats before we could set it (it may well
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-blockdev-mapping.html
shows that it may be a list of dicts? Am I reading that right?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/310371
Your team cloud init development team is requested
On Tue, Nov 8, 2016 at 3:43 PM, Scott Moser wrote:
> when you provide it you can give a list of dicts... in the metadata
> service it must come back as a dictionary (the code we have does items() on
> it, so it can't be a list).
>
> see http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-
> i
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..693a091
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,109 @@
> +
> +Boot Stages
> +
> +In order to be able to provide the functionality t
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..51e4815
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,121 @@
> +
> +Boot Stages
> +
> +In order to be able to provide the functionality t
We should sync/link with a systemd but requiring systemd-networkd.service to
drop After=dbus.service ... nto sure if
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1636912 covers that on
the systemd side, without that, networkd/netplan enabled instances will break
if they want to mount
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index b802b03..10a8b6f 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -266,97 +258,92 @@ class DataSourceAzureNet(sources.DataSour
On Mon, Nov 21, 2016 at 10:32 AM, Scott Moser wrote:
> based on the findings above/my understanding, this should be equivalent to
> your suggested change:
>
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -694,4 +694,6 @@ def main(sysv_args=None):
>
>
> if __name__ == '__main__'
On Tue, Nov 22, 2016 at 1:34 PM, Scott Moser wrote:
> I just pulled this, other than the formatter= change.
> we'll now log to file.
>
Great. With the use of journalctl -o short-precise, we can extract
high-res timestamps and events without the change.
>
> --
> https://code.launchpad.net/~har
Diff comments:
> diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py
> index 26c0240..5005d69 100644
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -140,23 +141,97 @@ def apply_reporting_cfg(cfg):
> reporting.update_configuration(cfg.get('reporting'))
>
>
>
Should we update the unittest to test this listing for each of our Datasources?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/312732
Your team cloud init development team is requested to review the proposed merge
of ~smoser/cloud-init:bug/1645916-cloudsigma-local-ds into
Diff comments:
> diff --git a/cloudinit/config/cc_mounts.py b/cloudinit/config/cc_mounts.py
> index 452c9e8..aa4e352 100644
> --- a/cloudinit/config/cc_mounts.py
> +++ b/cloudinit/config/cc_mounts.py
> @@ -423,37 +425,53 @@ def handle(_name, cfg, cloud, log, _args):
> cc_lines.append('\
Ryan Harper has proposed merging ~raharper/cloud-init:bug-lp-1645644-ntp into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1645644 in cloud-init: "ntp not using expected servers"
https://bugs.launchpad.net/cloud-init/+b
The proposal to merge ~raharper/cloud-init:bug-lp-1645644-ntp into
cloud-init:master has been updated.
Description changed to:
cc_ntp: write template before installing and add service restart
On systems which installed ntp and specified servers or pools in the
config ntpd didn't notice the upda
The proposal to merge ~raharper/cloud-init:net-dont-use-alias into
cloud-init:master has been updated.
Commit Message changed to:
Fix eni rendering of multiple IPs per interface
The iface:alias syntax for eni rendering is brittle with ipv6.
Replace it with using multiple iface stanzas with t
Ryan Harper has proposed merging ~raharper/cloud-init:net-dont-use-alias into
cloud-init:master.
Commit message:
Fix eni rendering of multiple IPs per interface
The iface:alias syntax for eni rendering is brittle with ipv6.
Replace it with using multiple iface stanzas with the same iface
The proposal to merge ~raharper/cloud-init:cloud-init-wait-on-networkd into
cloud-init:master has been updated.
Description changed to:
Cloud-init.service should run after networkd
Cloud-init.service should run after networkd has brought networking
online. If cloud-init.service does not run af
Ryan Harper has proposed merging
~raharper/cloud-init:cloud-init-wait-on-networkd into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1636912 in cloud-init: "systemd-networkd runs too late for
cloud-init.service (net)&quo
On Wed, Feb 22, 2017 at 8:10 AM, Scott Moser wrote:
> I'm ok with this, but have some thoughts... not sure what to do with them.
>
> I'm pretty sure other packages were fixed so that this could be fixed
> without issue. Ideally somehow the packaging of cloud-init indicates which
> work and which
fix "create add support" -> "add support" in the above message (or at least fix
in commit message).
Two comments below; generally looks good.
Diff comments:
> diff --git a/cloudinit/warnings.py b/cloudinit/warnings.py
> new file mode 100644
> index 000..a21794f
> --- /dev/null
> +++ b/clou
The proposal to merge ~raharper/cloud-init:netconfig-v2-passthrough into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/319259
--
Your team cloud init development team
Ryan Harper has proposed merging ~raharper/cloud-init:netconfig-v2-passthrough
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/319259
cloudinit.net: add v2
Thanks for the review
Diff comments:
> diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py
> index 48ccec8..f77b1e3 100644
> --- a/cloudinit/distros/debian.py
> +++ b/cloudinit/distros/debian.py
> @@ -38,11 +39,16 @@ ENI_HEADER = """# This file is generated from information
>
RHEL/Centos docs say you *really* shouldn't modify the built-in ifcg-lo.cfg
unless you know what you're doing. It appears that you're affirming this (if
loopback: continue); We probably want to log a warning in case someone
*wanted* to render a specific loopback config.
If we did want to supp
On Fri, Mar 17, 2017 at 10:14 AM, Scott Moser wrote:
> So as it is here we're not writing that file (ifcfg-lo), and I think that
> is sane.
> we just assume that that is there and present, if not, it kind of falls in
> the range of "broken image"? that sound reasonable ?
>
Yes, except that ther
Ryan Harper has proposed merging
~raharper/cloud-init:rebased-netconfig-v2-passthrough into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/320291
cloudinit.net
Diff comments:
> diff --git a/cloudinit/distros/__init__.py b/cloudinit/distros/__init__.py
> index 803ac74..22ae998 100755
> --- a/cloudinit/distros/__init__.py
> +++ b/cloudinit/distros/__init__.py
> @@ -73,7 +73,7 @@ class Distro(object):
>
> def _supported_write_network_config(self, n
I'm mostly done fixing up the small issues; one larger discussion to be had on
what to do about v2 passthrough and if we get v2 but need to render eni or
sysconfig.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/320291
Your team cloud init development team is requeste
The proposal to merge ~raharper/cloud-init:rebased-netconfig-v2-passthrough
into cloud-init:master has been updated.
Description changed to:
cloudinit.net: add network config v2 parsing and rendering
Network configuration version 2 format is implemented in a package
called netplan (nplan)[1] wh
Diff comments:
> diff --git a/cloudinit/version.py b/cloudinit/version.py
> index e61597d..3a28843 100644
> --- a/cloudinit/version.py
> +++ b/cloudinit/version.py
> @@ -9,6 +9,7 @@ __VERSION__ = "0.7.9"
> FEATURES = [
> # supports network config version 1
> 'NETWORK_CONFIG_V1',
Eith
Ryan Harper has proposed merging
~raharper/cloud-init:net-v2-dont-print-udevadm-commands into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321222
netplan
Ryan Harper has proposed merging ~raharper/cloud-init:fix-snap-user-doc into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321229
Add rtd entry for snap_config
Ryan Harper has proposed merging ~raharper/cloud-init:network-config-doc into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321397
doc: document network
Thanks for the input; I'll update.
Diff comments:
> diff --git a/doc/rtd/topics/network-config-format-eni.rst
> b/doc/rtd/topics/network-config-format-eni.rst
> new file mode 100644
> index 000..e4bcbe7
> --- /dev/null
> +++ b/doc/rtd/topics/network-config-format-eni.rst
> @@ -0,0 +1,14 @@
>
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321222
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321465
Your team cloud init development team is requested to review the proposed merge
of ~smoser/cloud-init:bug/cleanup-prints-in-netplan-renderer
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> old mode 100755
> new mode 100644
> index 1cf98ef..ff358c6
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -358,6 +386,8 @@ def get_interfaces_by_mac(devs=None):
> rais
Looks good! Some feedback in the integration test.
Diff comments:
> diff --git a/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> b/tests/cloud_tests/configs/examples/install_run_chef_recipes.yaml
> index 3cd28df..9b75d49 100644
> --- a/tests/cloud_tests/configs/examples/insta
The proposal to merge ~raharper/cloud-init:fix-net-convert into
cloud-init:master has been updated.
Description changed to:
tools/net-convert: fix argument order for render_network_state
We're calling Renderer.render_network_state() with incorrect args.
% PYTHONPATH=`pwd` ./tools/net-convert.p
Ryan Harper has proposed merging ~raharper/cloud-init:fix-net-convert into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1685944 in cloud-init (Ubuntu): "tools/net-convert: fix argument order
for render_network_state&quo
Some thoughts on this:
1) we don't want users who apt install cloud-init to also pull down
python-devel, gcc and have to compile the extension, so please don't change
package deps here
2) this is currently an issue for the tox/venv environment, so let's focus on
how to enable the SafeLoader li
On Fri, May 5, 2017 at 8:21 AM, Scott Moser wrote:
> > From Ryan:
> > Some thoughts on this:
> >
> > 1) we don't want users who apt install cloud-init to also pull down
> python-
> > devel, gcc and have to compile the extension, so please don't change
> package
> > deps here
>
> I don't follow th
This looks really good.
Would you be opposed to putting the infrastructure in one of the helper files
and have only the inputs/unittests in the test_dsidentify class?
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index 5254e18..f7cbb43 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -413,56 +412,71 @@ class DataSourceAzureNet(sources.DataSour
We should update the netplan unittest to include a vlan mac_address.
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324021
Your team cloud init development team is requested to review the proposed merge
of ~xnox/cloud-init:vlan-macaddress into cloud-init:master.
__
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index 29eb5dd..e1505b3 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -504,12 +488,35 @@ def check_partition_gpt_layout(device, layout):
>
Generally looks fine, one question w.r.t confirming explict_dslist check
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
>
Hrm, do we have a release-based (or even version-based) check here?
Presumable older images with snapd working/starting would continue to work.
Can we instead examine the installed version (via os's package system) and
infer the behavior? Or split this into two tests. one (is it installed) and
t
It doesn't look like you dropped blockdev as you say in your comment.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..7aacae4 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -73
Ryan Harper has proposed merging
~raharper/cloud-init:eni-drop-rendering-systemd-link-files into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/324675
cloudinit.net
The proposal to merge
~raharper/cloud-init:eni-drop-rendering-systemd-link-files into
cloud-init:master has been updated.
Description changed to:
cloudinit.net: remove systemd link file writing from eni renderer
During the network v2 merge, we re-enabled rendering systemd .link files.
This fil
Other than trying to understand the comment about dropping blkdev command
(which I think still is present at line 13) it looks good.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index e1505b3..7aacae4 100644
> --- a/cloudinit/config/cc_
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index db3c357..9def76d 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -289,19 +289,16 @@ class NetworkStateInterpreter(object):
> iface.update({
Ryan Harper has proposed merging ~raharper/cloud-init:eni-bridge-multiline-keys
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/324702
Fix eni rendering for bridge
The proposal to merge ~raharper/cloud-init:eni-bridge-multiline-keys into
cloud-init:master has been updated.
Description changed to:
Fix eni rendering for bridge params which require repeating key for vals
There are a few bridge parameters which require repeating the key with each
value in th
Diff comments:
> diff --git a/cloudinit/net/netplan.py b/cloudinit/net/netplan.py
> index d7ddf0c..6754330 100644
> --- a/cloudinit/net/netplan.py
> +++ b/cloudinit/net/netplan.py
> @@ -119,8 +119,8 @@ def _extract_addresses(config, entry):
> entry.update({sn_type: True})
>
Diff comments:
> diff --git a/tools/test-centos-run.sh b/tools/test-centos-run.sh
> new file mode 100755
> index 000..13cde62
> --- /dev/null
> +++ b/tools/test-centos-run.sh
> @@ -0,0 +1,47 @@
> +#!/bin/bash
do we want to run this under set -e ? I see a mix of error catching for some
thi
Diff comments:
> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index 9e9c05a..1d92db0 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -692,53 +670,213 @@ class NetworkStateInterpreter(object):
> return subnets
>
The code looks fine, but I'm slightly confused by the commit message.
Can you explain why we're using assert modulename? Possible mention in the code
as a comment as well.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/325274
Your team cloud-init commiters is requested
We need centos as the distro.variant value is used to set the default distro
user and gecos names.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325311
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/redhat-spec-imp
Ryan Harper has proposed merging ~raharper/cloud-init:redhat-fix-spec-systemd
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325402
Update redhat spec to use distro
Ryan Harper has proposed merging ~raharper/cloud-init:redhat-selinux-fixes into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325404
Fix a few selinux issues found
Ryan Harper has proposed merging ~raharper/cloud-init:pregen-locale into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325406
Check before attempting to regenerate
Diff comments:
> diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py
> index ce3c10d..35d9a55 100644
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -372,6 +372,7 @@ def main_init(name, args):
> LOG.debug("[%s] %s is in local mode, will apply init modules
>
That looks good.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/326373
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:azure_run_local into cloud-init:master.
___
Mailing list: h
Inline comment below
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_ec2.py
> b/tests/unittests/test_datasource/test_ec2.py
> new file mode 100644
> index 000..a5485ff
> --- /dev/null
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -0,0 +1,201 @@
> +# This file is
The proposal to merge ~raharper/cloud-init:curtin-centos into cloud-init:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
--
Your team cloud-init commiters is requested to r
Ryan Harper has proposed merging ~raharper/cloud-init:curtin-centos into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1687725 in cloud-init: "sysconfig render does not support type manual
subnets"
https://bugs.launchpad.net/cloud
Looks pretty solid. Just a few in-line comments/fixes
Diff comments:
> diff --git a/tests/cloud_tests/instances/kvm.py
> b/tests/cloud_tests/instances/kvm.py
> new file mode 100644
> index 000..c855e07
> --- /dev/null
> +++ b/tests/cloud_tests/instances/kvm.py
> @@ -0,0 +1,222 @@
> +# This
Not sure that's right (I Think it should be IPV6_GATEWAY0)
On Tue, Jul 18, 2017 at 4:09 PM, Scott Moser wrote:
> I pulled:
>
> Your-commit trunk-comt summary
> 8da074f831c d1e8eb73ac sysconfig: include GATEWAY value if set in subnet
>
> changes:
> i shorted lines in commit messages and made tox
1 - 100 of 445 matches
Mail list logo
