[GitHub] incubator-trafodion pull request #1304: [TRAFODION-2693]misleading error mes...

2017-11-18 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/1304 [TRAFODION-2693]misleading error message for 'get schemas' when _MD_ … …tables in hbase is not avialble You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-trafodion pull request #1200: change the release number on the mas...

2017-08-10 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/1200 change the release number on the master branch to indicate it is 2.3 change the release number on the master branch to indicate it is 2.3 You can merge this pull request into a Git

[GitHub] incubator-trafodion pull request #1183: [TRAFODION-2355] fix format in sql r...

2017-07-15 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/1183 [TRAFODION-2355] fix format in sql reference document a few typo fixes for R2.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafodion pull request #1055: [TRAFODION-2483] Trafodion treat '\'...

2017-04-10 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/1055#discussion_r110632142 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -1653,7 +1653,7 @@ char * ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int

[GitHub] incubator-trafodion pull request #1001: [TRAFODION-2522] Add WITH Clause

2017-03-18 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/1001#discussion_r106786268 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -6642,6 +6642,7 @@ sql-query is: | query-expr-and-order

[GitHub] incubator-trafodion pull request #990: [TRAFODION-2520] Add details for OLAP...

2017-03-06 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/990#discussion_r104580734 --- Diff: docs/sql_reference/src/asciidoc/_chapters/olap_functions.adoc --- @@ -461,8 +487,110 @@ FROM persnl.employee

[GitHub] incubator-trafodion pull request #895: [TRAFODION-2412]update sql reference ...

2016-12-26 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/895#discussion_r93874161 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc --- @@ -137,6 +137,74 @@ You can define specific default settings

[GitHub] incubator-trafodion pull request #887: [TRAFODION-2406] update sql reference...

2016-12-22 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/887 [TRAFODION-2406] update sql reference manual about INTERSECT/EXCEPT s… …yntax You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafodion pull request #883: [TRAFODION-2403] update sql reference...

2016-12-20 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/883 [TRAFODION-2403] update sql reference manual about REGEXP function You can merge this pull request into a Git repository by running: $ git pull https://github.com/traflm/incubator

[GitHub] incubator-trafodion pull request #879: [TRAFODION-2211] trafci can use histo...

2016-12-15 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/879#discussion_r92764647 --- Diff: core/conn/trafci/src/main/java/org/trafodion/ci/ConsoleReader.java --- @@ -172,7 +176,8 @@ public String readLine() throws

[GitHub] incubator-trafodion pull request #875: [TRAFODION-2379] update sql reference...

2016-12-14 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/875#discussion_r92414734 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -3584,6 +3586,47 @@ Start/Date Time/Shipped

[GitHub] incubator-trafodion pull request #875: [TRAFODION-2379] update sql reference...

2016-12-11 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/875 [TRAFODION-2379] update sql reference manual about group_concat function You can merge this pull request into a Git repository by running: $ git pull https://github.com/traflm

[GitHub] incubator-trafodion pull request #872: [TRAFODION-2285] Document TO_DATE, TO...

2016-12-08 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/872#discussion_r91538161 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -7523,7 +7526,139 @@ TIMESTAMPDIFF (SQL_TSI_WEEK

[GitHub] incubator-trafodion pull request #872: [TRAFODION-2285] Document TO_DATE, TO...

2016-12-08 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/872#discussion_r91537769 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -7523,7 +7526,139 @@ TIMESTAMPDIFF (SQL_TSI_WEEK

[GitHub] incubator-trafodion pull request #863: fix regression failures

2016-12-04 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/863 fix regression failures You can merge this pull request into a Git repository by running: $ git pull https://github.com/traflm/incubator-trafodion fixreg Alternatively you can

[GitHub] incubator-trafodion pull request #837: [TRAFODION-2355] document about IP ad...

2016-11-29 Thread traflm
Github user traflm closed the pull request at: https://github.com/apache/incubator-trafodion/pull/837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #859: [TRAFODION-2355] document about IP ad...

2016-11-29 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/859 [TRAFODION-2355] document about IP address/hashing functions this is a resbumit PR of PR 837: https://github.com/apache/incubator-trafodion/pull/837 Fix all code review comments

[GitHub] incubator-trafodion pull request #837: [TRAFODION-2355] document about IP ad...

2016-11-29 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/837#discussion_r90006694 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -3658,12 +3658,10 @@ IS_IPV4( expression

[GitHub] incubator-trafodion pull request #837: [TRAFODION-2355] document about IP ad...

2016-11-26 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/837#discussion_r89669735 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -3596,6 +3647,144 @@ SALES REP

[GitHub] incubator-trafodion pull request #842: [TRAFODION-2353] support of the regex...

2016-11-23 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/842#discussion_r89330936 --- Diff: core/sql/exp/exp_like.cpp --- @@ -477,6 +501,51 @@ ex_like_clause_base::processNulls(char *op_data[], CollHeap *heap, return

[GitHub] incubator-trafodion pull request #842: [TRAFODION-2353] support of the regex...

2016-11-23 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/842#discussion_r89322438 --- Diff: core/sql/regress/executor/EXPECTED002.SB --- @@ -6713,6 +6713,90 @@ s3100-90-40 >>drop table s

[GitHub] incubator-trafodion pull request #842: [TRAFODION-2353] support of the regex...

2016-11-23 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/842#discussion_r89322215 --- Diff: core/sql/exp/exp_like.cpp --- @@ -477,6 +501,51 @@ ex_like_clause_base::processNulls(char *op_data[], CollHeap *heap, return

[GitHub] incubator-trafodion pull request #842: [TRAFODION-2353] support of the regex...

2016-11-19 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/842 [TRAFODION-2353] support of the regexp operator This is a required feature to support basic Regular Expression in Trafodion. This work is following the design at https

[GitHub] incubator-trafodion pull request #839: [TRAFODION-2228]Add AES_ENCRYPT/AES_D...

2016-11-18 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/839#discussion_r88665877 --- Diff: core/sql/exp/exp_function.cpp --- @@ -8235,5 +8249,165 @@ ex_expr::exp_return_type ExFunctionIsIP::eval(char * op_data

[GitHub] incubator-trafodion pull request #833: jira 2227 : support json fuction - JS...

2016-11-14 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/833#discussion_r87950210 --- Diff: core/sql/parser/sqlparser.y --- @@ -33735,7 +33741,6 @@ nonreserved_func_word: TOK_ABS | TOK_FLOOR

[GitHub] incubator-trafodion pull request #834: [TRAFODION-2170] certain create table...

2016-11-14 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/834 [TRAFODION-2170] certain create table DDL will fail with core dump If the DDL has defined the total cluster key length greater than 2048, it will corrupt the memory and cause various

[GitHub] incubator-trafodion pull request #833: jira 2227 : support json fuction - JS...

2016-11-13 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/833#discussion_r87748375 --- Diff: core/sql/common/json.cpp --- @@ -0,0 +1,1139 @@ +#include "stringinfo.h" --- End diff -- Must add li

[GitHub] incubator-trafodion pull request #833: jira 2227 : support json fuction - JS...

2016-11-13 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/833#discussion_r87748920 --- Diff: core/sql/common/json.h --- @@ -0,0 +1,124 @@ +#ifndef JSON_H --- End diff -- license header is required --- If your

[GitHub] incubator-trafodion pull request #833: jira 2227 : support json fuction - JS...

2016-11-13 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/833#discussion_r87748856 --- Diff: core/sql/bin/SqlciErrors.txt --- @@ -3925,3 +3925,16 @@ $3~String1. 30047 Z 9 BEGINNER MAJOR DBADMIN NAR details. HexdRow

[GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...

2016-11-09 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/795#discussion_r8731 --- Diff: core/sql/optimizer/RelGrby.h --- @@ -152,6 +154,9 @@ class GroupByAgg : public RelExpr inline void setGroupExpr(ValueIdSet

[GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...

2016-11-08 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/795#discussion_r86994949 --- Diff: core/sql/optimizer/OptPhysRelExpr.cpp --- @@ -11814,10 +11814,22 @@ void SortGroupBy::addArrangementAndOrderRequirements

[GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...

2016-11-07 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/795#discussion_r86910814 --- Diff: core/sql/optimizer/RelGrby.h --- @@ -152,6 +154,9 @@ class GroupByAgg : public RelExpr inline void setGroupExpr(ValueIdSet

[GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...

2016-11-07 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/795#discussion_r86910844 --- Diff: core/sql/optimizer/OptPhysRelExpr.cpp --- @@ -11856,6 +11868,7 @@ SortGroupBy::synthPhysicalProperty(const Context* myContext

[GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...

2016-11-07 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/795#discussion_r86901737 --- Diff: core/sql/optimizer/OptPhysRelExpr.cpp --- @@ -11814,10 +11814,22 @@ void SortGroupBy::addArrangementAndOrderRequirements

[GitHub] incubator-trafodion pull request #812: revert the bad commit to install_loca...

2016-11-04 Thread traflm
Github user traflm closed the pull request at: https://github.com/apache/incubator-trafodion/pull/812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...

2016-11-03 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/813#discussion_r86476545 --- Diff: core/sql/exp/exp_clause.h --- @@ -203,7 +203,12 @@ class SQLEXP_LIB_FUNC ex_clause : public NAVersionedObject { FUNC_ISIP_ID

[GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...

2016-11-03 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/813#discussion_r86476582 --- Diff: core/sql/exp/exp_function.cpp --- @@ -7900,6 +7936,114 @@ ex_expr::exp_return_type ExFunctionInetNtoa::eval(char * op_data

[GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...

2016-11-03 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/813#discussion_r86476564 --- Diff: core/sql/exp/exp_function.cpp --- @@ -40,6 +40,10 @@ #include +#include +#include "openssl/md5.h"

[GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...

2016-11-03 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/813#discussion_r86476506 --- Diff: core/sql/parser/sqlparser.y --- @@ -9671,6 +9676,62 @@ misc_function : $$ = $2

[GitHub] incubator-trafodion pull request #813: [TRAFODION-2229] add Hashing function...

2016-11-03 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/813 [TRAFODION-2229] add Hashing functions to Trafodion Compatibility enhancement add new functions for MySQL: CRC32() Compute a cyclic redundancy check value MD5

[GitHub] incubator-trafodion pull request #810: [TRAFODION-2293] remove minor version...

2016-11-02 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/810#discussion_r86275214 --- Diff: core/sqf/sql/scripts/install_local_hadoop --- @@ -1554,7 +1554,7 @@ echo "$MY_LOCAL_SW_DIST/${HBAS

[GitHub] incubator-trafodion pull request #794: [TRAFODION-2317] Infrastructure for c...

2016-10-29 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/794#discussion_r85652605 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -1700,6 +1714,138 @@ char * ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int

[GitHub] incubator-trafodion pull request #795: [TRAFODION-2270] support ORDER BY in ...

2016-10-28 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/795 [TRAFODION-2270] support ORDER BY in PIVOT_GROUP/GROUP_CONCAT function to support ORDER BY in PIVOT_GROUP function, so as in GROUP_CONCAT function. The idea is to introduce

[GitHub] incubator-trafodion pull request #716: [TRAFDODION-2170] create table with t...

2016-09-24 Thread traflm
Github user traflm closed the pull request at: https://github.com/apache/incubator-trafodion/pull/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #716: [TRAFDODION-2170] create table with t...

2016-09-24 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/716#discussion_r80359621 --- Diff: core/sqf/src/tm/tmddlrequests.cpp --- @@ -40,14 +40,24 @@ JNIEXPORT jint JNICALL

[GitHub] incubator-trafodion pull request #715: [TRAFDODION-2170] create table with t...

2016-09-20 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/715 [TRAFDODION-2170] create table with too long key causing core dump when the given table DDL have key length greater than 2048, it will cause buffer overflow. This fix add a length

[GitHub] incubator-trafodion pull request #706: sql regression test executor test022 ...

2016-09-15 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/706 sql regression test executor test022 fix, min largeint On Linux platform, min 64 bit int value is -9223372036854775808. So the validation seems wrong. Try to fix it. You can merge

[GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo...

2016-09-15 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/703#discussion_r78925918 --- Diff: core/sql/exp/exp_function.cpp --- @@ -7724,5 +7753,354 @@ Lng32 ExFunctionExtractColumns::unpack (void * base, void * reallocator

[GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo...

2016-09-15 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/703#discussion_r78926677 --- Diff: core/sql/optimizer/SynthType.cpp --- @@ -1010,7 +1010,81 @@ const NAType *BuiltinFunction::synthesizeType() SQLChar

[GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo...

2016-09-15 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/703#discussion_r78925519 --- Diff: core/sql/exp/exp_function.cpp --- @@ -45,6 +45,11 @@ #include #include #include +/* +#include +#include

[GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo...

2016-09-15 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/703#discussion_r78926114 --- Diff: core/sql/exp/exp_function.cpp --- @@ -7724,5 +7753,354 @@ Lng32 ExFunctionExtractColumns::unpack (void * base, void * reallocator

[GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo...

2016-09-15 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/703#discussion_r78925378 --- Diff: core/sql/exp/exp_math_func.cpp --- @@ -348,7 +349,18 @@ ex_expr::exp_return_type ExFunctionMath::eval(char *op_data[], return

[GitHub] incubator-trafodion pull request #703: [TRAFODION-2208] function support: lo...

2016-09-14 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/703 [TRAFODION-2208] function support: log2,IS_IPV4,IS_IPV6 etc add a few new built-in functions (help to migrate application to/from MySQL) log2( ) inet_aton( ) inet_ntoa

[GitHub] incubator-trafodion pull request #693: Supporting OLAP function LEAD and LAG...

2016-09-10 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/693#discussion_r78278353 --- Diff: core/sql/parser/sqlparser.y --- @@ -780,6 +781,7 @@ static void enableMakeQuotedStringISO88591Mechanism() %token TOK_LAST_SYSKEY

[GitHub] incubator-trafodion pull request #672: [TRAFODION-2170] create table failure...

2016-09-10 Thread traflm
Github user traflm closed the pull request at: https://github.com/apache/incubator-trafodion/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #683: new spj of startwith and connectby

2016-09-02 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/683#discussion_r77372705 --- Diff: core/sql/lib_mgmt/src/main/java/org/trafodion/libmgmt/FileMgmt.java --- @@ -547,6 +558,64 @@ private static void checkFile(String fname

[GitHub] incubator-trafodion pull request #687: [TRAFODION-2202] in mode_special_4, s...

2016-09-02 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/687 [TRAFODION-2202] in mode_special_4, sequence function is broken when CQD mode_special_4 is 'on', the binder try to support Oracle sequence syntax as 'indentifier.nextval'. Binder

[GitHub] incubator-trafodion pull request #672: [TRAFODION-2170] create table failure...

2016-08-26 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/672#discussion_r76384092 --- Diff: core/sqf/src/tm/tmddlrequests.cpp --- @@ -39,13 +40,24 @@ JNIEXPORT void JNICALL

[GitHub] incubator-trafodion pull request #672: [TRAFODION-2170] create table failure...

2016-08-25 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/672 [TRAFODION-2170] create table failure when pk length is too long If the length of the primary key greater than 2048, Trafodion will have memory overrun issue and core dump

[GitHub] incubator-trafodion pull request #664: TRAFODION-2163 support MYSQL style fu...

2016-08-19 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/664 TRAFODION-2163 support MYSQL style function GROUP_CONCAT add new SQL syntax for pivot_group() so to allow same MySQL syntax. Also fix original pivot_group() issue and tested more

[GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...

2016-08-09 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/642#discussion_r74167537 --- Diff: core/sql/optimizer/EncodedKeyValue.cpp --- @@ -68,14 +68,22 @@ NAString * getMinMaxValue(TrafDesc * column, return NULL

[GitHub] incubator-trafodion pull request #639: [TRAFODION-2117] add SQL support of E...

2016-08-05 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/639#discussion_r73779962 --- Diff: core/sql/optimizer/RelExpr.cpp --- @@ -6630,6 +6630,23 @@ const NAString Intersect::getText() const

[GitHub] incubator-trafodion pull request #639: [TRAFODION-2117] add SQL support of E...

2016-08-05 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/639#discussion_r73779753 --- Diff: core/sql/optimizer/BindRelExpr.cpp --- @@ -3035,6 +3035,98 @@ RelExpr *Intersect::bindNode(BindWA *bindWA) // LCOV_EXCL_STOP

[GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...

2016-08-05 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/642#discussion_r73779661 --- Diff: core/sql/common/CharType.cpp --- @@ -1217,7 +1217,7 @@ void CharType::minMaxRepresentableValue(void* bufPtr, if (stringLiteral

[GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...

2016-08-05 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/642#discussion_r73779041 --- Diff: core/sql/optimizer/EncodedKeyValue.cpp --- @@ -69,7 +69,14 @@ NAString * getMinMaxValue(TrafDesc * column, Lng32 buflen

[GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...

2016-08-05 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/642#discussion_r73779028 --- Diff: core/sql/common/CharType.cpp --- @@ -1217,7 +1217,7 @@ void CharType::minMaxRepresentableValue(void* bufPtr, if (stringLiteral

[GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...

2016-08-05 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/642#discussion_r73778733 --- Diff: core/sql/common/CharType.cpp --- @@ -1217,7 +1217,7 @@ void CharType::minMaxRepresentableValue(void* bufPtr, if (stringLiteral

[GitHub] incubator-trafodion pull request #642: [TRAFODION-2119] create table report ...

2016-08-04 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/642 [TRAFODION-2119] create table report strange WARNING when using store… … by and allow_nullable_unique_key_constraint CQD You can merge this pull request into a Git repository

[GitHub] incubator-trafodion pull request #639: [TRAFODION-2117] add SQL support of E...

2016-08-04 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/639 [TRAFODION-2117] add SQL support of EXCEPT initial support of SQL syntax EXCEPT You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafodion pull request #633: [TRAFODION-2119] DDL warning/error if...

2016-08-03 Thread traflm
Github user traflm closed the pull request at: https://github.com/apache/incubator-trafodion/pull/633 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #635: fix regression test compGeneral TEST0...

2016-08-03 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/635 fix regression test compGeneral TEST001 Fix regression test case failure. Should be more carefully next time. You can merge this pull request into a Git repository by running

[GitHub] incubator-trafodion pull request #633: [TRAFODION-2119] DDL warning/error if...

2016-08-02 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/633#discussion_r73273946 --- Diff: core/sql/optimizer/EncodedKeyValue.cpp --- @@ -66,15 +66,22 @@ NAString * getMinMaxValue(desc_struct * column, if (NAColumn

[GitHub] incubator-trafodion pull request #633: [TRAFODION-2119] DDL warning/error if...

2016-08-01 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/633 [TRAFODION-2119] DDL warning/error if using store by on utf8 column If store by is used and the column is not set 'not null', there will be an extra null indicator header. So

[GitHub] incubator-trafodion pull request #630: [TRAFODION-2119] DDL warning/error if...

2016-07-30 Thread traflm
Github user traflm closed the pull request at: https://github.com/apache/incubator-trafodion/pull/630 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #623: [TRAFODION-2047] add support of SQL s...

2016-07-29 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/623#discussion_r72797920 --- Diff: core/sql/optimizer/BindRelExpr.cpp --- @@ -717,7 +717,7 @@ static ItemExpr *intersectColumns(const RETDesc , ItemExpr

[GitHub] incubator-trafodion pull request #623: [TRAFODION-2047] add support of SQL s...

2016-07-29 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/623#discussion_r72796626 --- Diff: core/sql/optimizer/BindRelExpr.cpp --- @@ -717,7 +717,7 @@ static ItemExpr *intersectColumns(const RETDesc , ItemExpr

[GitHub] incubator-trafodion pull request #623: [TRAFODION-2047] add support of SQL s...

2016-07-29 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/623#discussion_r72794212 --- Diff: core/sql/optimizer/BindRelExpr.cpp --- @@ -717,7 +717,7 @@ static ItemExpr *intersectColumns(const RETDesc , ItemExpr

[GitHub] incubator-trafodion pull request #629: fix regression test hive 005

2016-07-29 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/629 fix regression test hive 005 fix regression You can merge this pull request into a Git repository by running: $ git pull https://github.com/traflm/incubator-trafodion test005fix

[GitHub] incubator-trafodion pull request #623: [TRAFODION-2047] add support of SQL s...

2016-07-28 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/623 [TRAFODION-2047] add support of SQL syntax INTERSECT support of SQL syntax INTERSECT, INTERSECT DISTINCT not able to support INTERSECT ALL, which will raise an error. TPCDS

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-27 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72406115 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3676,6 +3680,76 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-26 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72367260 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3702,25 +3706,47 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-26 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72367234 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -86,6 +86,10 @@ #include "CmpMain.h" #define MAX_NODE_NAME 9

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-25 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72175128 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3676,6 +3676,54 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-25 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72174955 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3676,6 +3676,54 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-25 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72174731 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3676,6 +3676,54 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-25 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72054890 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3676,6 +3676,54 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-25 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72054597 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3676,6 +3676,54 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-25 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/618#discussion_r72054644 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -3676,6 +3676,54 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap

[GitHub] incubator-trafodion pull request #618: [TRAFODION-2121] add support of HIVE ...

2016-07-23 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/618 [TRAFODION-2121] add support of HIVE data type of DECIMAL support HIVE data type 'decimal' HIVE decimal => Trafodion decimal(10, 0) HIVE decimal(p,s) => Trafodion d

[GitHub] incubator-trafodion pull request #615: [TRAFODION-1605] sqstart hangs if uli...

2016-07-22 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/615#discussion_r71967210 --- Diff: core/sqf/sql/scripts/sqstart --- @@ -245,6 +245,39 @@ function checkKerberos { return 0 } +function checkUlimit

[GitHub] incubator-trafodion pull request #615: [TRAFODION-1605] sqstart hangs if uli...

2016-07-22 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/615#discussion_r71967162 --- Diff: core/sqf/sql/scripts/sqstart --- @@ -245,6 +245,39 @@ function checkKerberos { return 0 } +function checkUlimit

[GitHub] incubator-trafodion pull request #615: [TRAFODION-1605] sqstart hangs if uli...

2016-07-21 Thread traflm
GitHub user traflm opened a pull request: https://github.com/apache/incubator-trafodion/pull/615 [TRAFODION-1605] sqstart hangs if ulimits not correct add ulimit checking in sqstart if not proper setup as Trafodion installer does, print WARNING/ERROR This should only

[GitHub] incubator-trafodion pull request #597: [TRAFODION-1605] sqstart hangs if uli...

2016-07-21 Thread traflm
Github user traflm closed the pull request at: https://github.com/apache/incubator-trafodion/pull/597 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafodion pull request #597: [TRAFODION-1605] sqstart hangs if uli...

2016-07-21 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/597#discussion_r71720083 --- Diff: core/sqf/sql/scripts/sqstart --- @@ -245,6 +245,63 @@ function checkKerberos { return 0 } +function

[GitHub] incubator-trafodion pull request #597: [TRAFODION-1605] sqstart hangs if uli...

2016-07-21 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/597#discussion_r71719997 --- Diff: core/sqf/sql/scripts/sqstart --- @@ -245,6 +245,63 @@ function checkKerberos { return 0 } +function

[GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause

2016-07-17 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/577#discussion_r71083286 --- Diff: core/sql/parser/sqlparser.y --- @@ -14684,6 +14759,11 @@ optional_limit_spec : TOK_LIMIT NUMERIC_LITERAL_EXACT_NO_SCALE

[GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause

2016-07-15 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/577#discussion_r71058116 --- Diff: core/sql/parser/sqlparser.y --- @@ -7000,6 +7024,46 @@ rel_subquery_and_as_clause : rel_subquery as_clause

[GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause

2016-07-14 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/577#discussion_r70755998 --- Diff: core/sql/sqlcomp/parser.h --- @@ -261,6 +261,8 @@ ItemExpr *get_w_ItemExprTree(const NAWchar * str, NABoolean isHQCCacheable

[GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause

2016-07-13 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/577#discussion_r70736959 --- Diff: core/sql/parser/sqlparser.y --- @@ -14684,6 +14759,11 @@ optional_limit_spec : TOK_LIMIT NUMERIC_LITERAL_EXACT_NO_SCALE

[GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause

2016-07-13 Thread traflm
Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/577#discussion_r70620967 --- Diff: core/sql/parser/sqlparser.y --- @@ -14684,6 +14759,11 @@ optional_limit_spec : TOK_LIMIT NUMERIC_LITERAL_EXACT_NO_SCALE

  1   2   >