[GitHub] kaxil commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-20 Thread GitBox
kaxil commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/airflow/pull/4339#issuecomment-455978659 @feng-tao I agree it is not ideal. In the meantime, you can use this

[GitHub] feng-tao commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-20 Thread GitBox
feng-tao commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/airflow/pull/4339#issuecomment-455958627 And also why we rename www_rbac to www which causes all the git history missing?

[GitHub] zhongjiajie commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
zhongjiajie commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#issuecomment-455918953 @Fokko PTAL This is an automated message from the Apache Git

[GitHub] zhongjiajie commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None

2019-01-20 Thread GitBox
zhongjiajie commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None URL: https://github.com/apache/airflow/pull/4561#issuecomment-455918877 @Fokko PTAL This is an automated message from the Apache Git

[GitHub] zhongjiajie commented on issue #4560: [AIRFLOW-3733] Init variable i avoid raise NameError

2019-01-20 Thread GitBox
zhongjiajie commented on issue #4560: [AIRFLOW-3733] Init variable i avoid raise NameError URL: https://github.com/apache/airflow/pull/4560#issuecomment-455918822 @Fokko PTAL This is an automated message from the Apache Git

[GitHub] codecov-io commented on issue #4292: [AIRFLOW-2508] Handle non string types in Operators templatized fields

2019-01-20 Thread GitBox
codecov-io commented on issue #4292: [AIRFLOW-2508] Handle non string types in Operators templatized fields URL: https://github.com/apache/airflow/pull/4292#issuecomment-455914575 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4292?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-2876) Bump version of Tenacity

2019-01-20 Thread Diego Argueta (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747578#comment-16747578 ] Diego Argueta commented on AIRFLOW-2876: Someone tried that in [a

[GitHub] dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2019-01-20 Thread GitBox
dargueta edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/airflow/pull/3723#issuecomment-455650114 This isn't my PR, unfortunately. @Fokko could you fix the conflicts and change the pinning to `>= 4.11.0, <5.0`? ~I think 5.x will work

[jira] [Comment Edited] (AIRFLOW-2876) Bump version of Tenacity

2019-01-20 Thread Diego Argueta (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747578#comment-16747578 ] Diego Argueta edited comment on AIRFLOW-2876 at 1/20/19 10:56 PM: --

[GitHub] mik-laj commented on a change in pull request #2040: [AIRFLOW-808] - SqlToS3 Operator

2019-01-20 Thread GitBox
mik-laj commented on a change in pull request #2040: [AIRFLOW-808] - SqlToS3 Operator URL: https://github.com/apache/airflow/pull/2040#discussion_r249298533 ## File path: airflow/contrib/operators/sql_to_s3.py ## @@ -0,0 +1,114 @@ +# -*- coding: utf-8 -*- +# +# Licensed

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean

[GitHub] codecov-io edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
codecov-io edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-454963037 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4543?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
codecov-io edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-454963037 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4543?src=pr=h1) Report > Merging

[GitHub] alikemalocalan commented on a change in pull request #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting

2019-01-20 Thread GitBox
alikemalocalan commented on a change in pull request #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting URL: https://github.com/apache/airflow/pull/4460#discussion_r249297000 ## File path: airflow/contrib/hooks/azure_hdinsight_hook.py

[GitHub] alikemalocalan commented on a change in pull request #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting

2019-01-20 Thread GitBox
alikemalocalan commented on a change in pull request #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting URL: https://github.com/apache/airflow/pull/4460#discussion_r249297000 ## File path: airflow/contrib/hooks/azure_hdinsight_hook.py

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean

[GitHub] potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk edited a comment on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean

[GitHub] mik-laj commented on issue #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting

2019-01-20 Thread GitBox
mik-laj commented on issue #4460: [AIRFLOW-3604] Add Azure Hdinsight operators for creating cluster and submitting URL: https://github.com/apache/airflow/pull/4460#issuecomment-455904283 Could you complete the documentation? You should make changes to the files: ``docs/integration.rst``,

[GitHub] potiuk commented on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk commented on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455904301 @fokko -> --pull flag is a good idea. It won't change DockerHub build behaviour as they are always starting from a clean docker

[GitHub] diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-20 Thread GitBox
diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/airflow/pull/4339#issuecomment-455897948 I have a problem where the webserver keeps repeating "some workers are starting up, waiting...", and I think it might be

[GitHub] diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-20 Thread GitBox
diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/airflow/pull/4339#issuecomment-455897948 I have a problem where the webserver keeps repeating "some workers are starting up, waiting...", and I think it might be

[GitHub] diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-20 Thread GitBox
diederikwp edited a comment on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/airflow/pull/4339#issuecomment-455897948 I have a problem where the webserver keeps repeating "some workers are starting up, waiting...", and I think it might be

[GitHub] diederikwp commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB

2019-01-20 Thread GitBox
diederikwp commented on issue #4339: [AIRFLOW-3303] Deprecate old UI in favor of FAB URL: https://github.com/apache/airflow/pull/4339#issuecomment-455897948 I have a problem where the webserver keeps repeating "some workers are starting up, waiting...", and I think it might be because of

[GitHub] jmcarp commented on issue #4225: [AIRFLOW-3383] Rotate fernet keys.

2019-01-20 Thread GitBox
jmcarp commented on issue #4225: [AIRFLOW-3383] Rotate fernet keys. URL: https://github.com/apache/airflow/pull/4225#issuecomment-455896709 Thanks @ashb, updated the patch. This is an automated message from the Apache Git

[GitHub] codecov-io edited a comment on issue #4225: [AIRFLOW-3383] Rotate fernet keys.

2019-01-20 Thread GitBox
codecov-io edited a comment on issue #4225: [AIRFLOW-3383] Rotate fernet keys. URL: https://github.com/apache/airflow/pull/4225#issuecomment-441103479 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4225?src=pr=h1) Report > Merging

[GitHub] Fokko commented on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
Fokko commented on issue #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-455889389 @potiuk To recap my concern: When having an aggressive caching strategy, the container and the master repository might get out

[jira] [Commented] (AIRFLOW-2321) RBAC support from new UI's failing on OAuth authentication method

2019-01-20 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747510#comment-16747510 ] Tao Feng commented on AIRFLOW-2321: --- [~tronbabylove] , I think you could a doc and place it under

[GitHub] mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249288387 ## File path: airflow/models/connection.py ## @@ -109,22 +109,24 @@ def __init__(

[GitHub] mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249287388 ## File path: airflow/models/connection.py ## @@ -109,22 +109,24 @@ def __init__(

[GitHub] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r249287543 ## File path: Dockerfile ## @@ -16,26 +16,77 @@ FROM python:3.6-slim -COPY .

[GitHub] mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249287388 ## File path: airflow/models/connection.py ## @@ -109,22 +109,24 @@ def __init__(

[GitHub] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r249287385 ## File path: Dockerfile ## @@ -16,26 +16,77 @@ FROM python:3.6-slim -COPY .

[GitHub] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r249287296 ## File path: .dockerignore ## @@ -0,0 +1,23 @@ +# +# Licensed to the Apache Software

[GitHub] mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
mik-laj commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249287160 ## File path: airflow/models/connection.py ## @@ -109,22 +109,24 @@ def __init__(

[GitHub] potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#discussion_r249286978 ## File path: Dockerfile ## @@ -16,26 +16,77 @@ FROM python:3.6-slim -COPY .

[GitHub] potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249286124 ## File path: docs/howto/manage-connections.rst ## @@ -70,10 +70,15 @@ When referencing the

[GitHub] potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249286285 ## File path: docs/howto/manage-connections.rst ## @@ -151,6 +156,29 @@ Scopes (comma

[GitHub] potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249286548 ## File path: airflow/models/connection.py ## @@ -109,22 +109,24 @@ def __init__(

[GitHub] potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249286255 ## File path: docs/howto/manage-connections.rst ## @@ -70,10 +70,15 @@ When referencing the

[GitHub] potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249286113 ## File path: docs/howto/manage-connections.rst ## @@ -70,10 +70,15 @@ When referencing the

[GitHub] potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore

2019-01-20 Thread GitBox
potiuk commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases for schema with underscore URL: https://github.com/apache/airflow/pull/4523#discussion_r249286268 ## File path: docs/howto/manage-connections.rst ## @@ -151,6 +156,29 @@ Scopes (comma

[GitHub] codecov-io commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None

2019-01-20 Thread GitBox
codecov-io commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None URL: https://github.com/apache/airflow/pull/4561#issuecomment-455871039 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4561?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None

2019-01-20 Thread GitBox
codecov-io commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None URL: https://github.com/apache/airflow/pull/4561#issuecomment-455871038 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4561?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None

2019-01-20 Thread GitBox
codecov-io commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None URL: https://github.com/apache/airflow/pull/4561#issuecomment-455871040 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4561?src=pr=h1) Report > Merging

[GitHub] ron819 commented on issue #2906: [AIRFLOW-1956] Add parameter whether the navbar clock time is UTC

2019-01-20 Thread GitBox
ron819 commented on issue #2906: [AIRFLOW-1956] Add parameter whether the navbar clock time is UTC URL: https://github.com/apache/airflow/pull/2906#issuecomment-455867191 @Fokko @kaxil mind take a look? This is an automated

[GitHub] BrechtDeVlieger commented on issue #4553: [AIRFLOW-3541] Add Avro logical type conversion to bigquery hook

2019-01-20 Thread GitBox
BrechtDeVlieger commented on issue #4553: [AIRFLOW-3541] Add Avro logical type conversion to bigquery hook URL: https://github.com/apache/airflow/pull/4553#issuecomment-455856003 Why did the tests fail? This is an automated

[GitHub] zhongjiajie commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None

2019-01-20 Thread GitBox
zhongjiajie commented on issue #4561: [AIRFLOW-3734] Fix hql not run when partition is None URL: https://github.com/apache/airflow/pull/4561#issuecomment-455855813 I have a question, I want to use my local commit message as PR title, which should be ``` [AIRFLOW-3734] Fix hql not

[GitHub] codecov-io commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
codecov-io commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#issuecomment-455853850 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4535?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
codecov-io commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#issuecomment-455853851 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4535?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4560: [AIRFLOW-3733] init variable `i` ensure not raise NameError in hive_hooks to_csv function

2019-01-20 Thread GitBox
codecov-io commented on issue #4560: [AIRFLOW-3733] init variable `i` ensure not raise NameError in hive_hooks to_csv function URL: https://github.com/apache/airflow/pull/4560#issuecomment-455853545 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4560?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4560: [AIRFLOW-3733] init variable `i` ensure not raise NameError in hive_hooks to_csv function

2019-01-20 Thread GitBox
codecov-io edited a comment on issue #4560: [AIRFLOW-3733] init variable `i` ensure not raise NameError in hive_hooks to_csv function URL: https://github.com/apache/airflow/pull/4560#issuecomment-455853545 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4560?src=pr=h1) Report >

[GitHub] zhongjiajie opened a new pull request #4561: [AIRFLOW-3734] Correct load_file function while partition is None

2019-01-20 Thread GitBox
zhongjiajie opened a new pull request #4561: [AIRFLOW-3734] Correct load_file function while partition is None URL: https://github.com/apache/airflow/pull/4561 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#discussion_r249271047 ## File path: tests/contrib/hooks/test_ftp_hook.py ## @@ -115,7 +115,9 @@ def

[GitHub] zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#discussion_r249269795 ## File path: tests/contrib/hooks/test_ftp_hook.py ## @@ -125,5 +127,50 @@ def

[GitHub] OmerJog commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
OmerJog commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#discussion_r249269778 ## File path: tests/contrib/hooks/test_ftp_hook.py ## @@ -115,7 +115,9 @@ def

[GitHub] zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#discussion_r249269568 ## File path: tests/contrib/hooks/test_ftp_hook.py ## @@ -115,7 +115,9 @@ def

[GitHub] OmerJog commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
OmerJog commented on issue #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#issuecomment-455848526 Can someone restart the error test? It wasn't finished. @bolkedebruin you reviewed the previous PR. mind take a look at this?

[GitHub] OmerJog commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode

2019-01-20 Thread GitBox
OmerJog commented on a change in pull request #4535: [AIRFLOW-865] - Configure FTP connection mode URL: https://github.com/apache/airflow/pull/4535#discussion_r249268595 ## File path: tests/contrib/hooks/test_ftp_hook.py ## @@ -125,5 +127,50 @@ def