[airflow] branch main updated: Consolidate method names between Airflow Security Manager and FAB default (#18726)

2021-10-21 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6deebec Consolidate method names between

[GitHub] [airflow] jhtimmins merged pull request #18726: Consolidate method names between Airflow Security Manager and FAB default

2021-10-21 Thread GitBox
jhtimmins merged pull request #18726: URL: https://github.com/apache/airflow/pull/18726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a change in pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-21 Thread GitBox
uranusjr commented on a change in pull request #19097: URL: https://github.com/apache/airflow/pull/19097#discussion_r734249349 ## File path: airflow/models/dagrun.py ## @@ -526,6 +526,28 @@ def update_state( else: self.set_state(State.RUNNING) +

[GitHub] [airflow] steveyz-astro commented on a change in pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-21 Thread GitBox
steveyz-astro commented on a change in pull request #19097: URL: https://github.com/apache/airflow/pull/19097#discussion_r734242942 ## File path: airflow/models/dagrun.py ## @@ -526,6 +526,28 @@ def update_state( else: self.set_state(State.RUNNING) +

[GitHub] [airflow] uranusjr commented on pull request #19148: Crerate TI context with data interval compat layer

2021-10-21 Thread GitBox
uranusjr commented on pull request #19148: URL: https://github.com/apache/airflow/pull/19148#issuecomment-949302182 Tentatively adding this to 2.2.1 since this is a regression in 2.2.0, and the fix should not introduce any risk. -- This is an automated message from the Apache Git

[GitHub] [airflow] uranusjr opened a new pull request #19148: Crerate TI context with data interval compat layer

2021-10-21 Thread GitBox
uranusjr opened a new pull request #19148: URL: https://github.com/apache/airflow/pull/19148 Fix #19143. Old DAG runs created prior to 2.2 do not have a concrete data interval, but we still want to be able to add things to them with a consistent interface, so the context should use

[GitHub] [airflow] Nidesh-Arumugam opened a new issue #19147: Airflow 2.2 : Unable to start the server using Docker

2021-10-21 Thread GitBox
Nidesh-Arumugam opened a new issue #19147: URL: https://github.com/apache/airflow/issues/19147 ### Describe the issue with documentation https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html I followed the above documentation to setup airflow using docker.

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19146: ERROR - No module named 'celery_config' when triggering a separate task in Airflow on Docker

2021-10-21 Thread GitBox
boring-cyborg[bot] commented on issue #19146: URL: https://github.com/apache/airflow/issues/19146#issuecomment-949297765 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] alexey-rio opened a new issue #19146: ERROR - No module named 'celery_config' when triggering a separate task in Airflow on Docker

2021-10-21 Thread GitBox
alexey-rio opened a new issue #19146: URL: https://github.com/apache/airflow/issues/19146 ### Apache Airflow version 2.2.0 (latest released) ### Operating System public.ecr.aws/amazonlinux/amazonlinux (Docker) ### Versions of Apache Airflow Providers

[GitHub] [airflow] steveyz-astro commented on a change in pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-21 Thread GitBox
steveyz-astro commented on a change in pull request #19097: URL: https://github.com/apache/airflow/pull/19097#discussion_r734242942 ## File path: airflow/models/dagrun.py ## @@ -526,6 +526,28 @@ def update_state( else: self.set_state(State.RUNNING) +

[GitHub] [airflow] steveyz-astro commented on a change in pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-21 Thread GitBox
steveyz-astro commented on a change in pull request #19097: URL: https://github.com/apache/airflow/pull/19097#discussion_r734242942 ## File path: airflow/models/dagrun.py ## @@ -526,6 +526,28 @@ def update_state( else: self.set_state(State.RUNNING) +

[GitHub] [airflow] uranusjr commented on a change in pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-21 Thread GitBox
uranusjr commented on a change in pull request #19097: URL: https://github.com/apache/airflow/pull/19097#discussion_r734235605 ## File path: airflow/models/dagrun.py ## @@ -526,6 +526,28 @@ def update_state( else: self.set_state(State.RUNNING) +

[GitHub] [airflow] tnyz commented on pull request #18676: Update BigQueryCreateExternalTableOperator doc and parameters

2021-10-21 Thread GitBox
tnyz commented on pull request #18676: URL: https://github.com/apache/airflow/pull/18676#issuecomment-949282020 can someone with write access review and close this pr? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] steveyz-astro commented on a change in pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-21 Thread GitBox
steveyz-astro commented on a change in pull request #19097: URL: https://github.com/apache/airflow/pull/19097#discussion_r734228471 ## File path: airflow/models/dagrun.py ## @@ -526,6 +526,28 @@ def update_state( else: self.set_state(State.RUNNING) +

[GitHub] [airflow] jhtimmins commented on a change in pull request #18726: Consolidate method names between Airflow Security Manager and FAB default

2021-10-21 Thread GitBox
jhtimmins commented on a change in pull request #18726: URL: https://github.com/apache/airflow/pull/18726#discussion_r734226034 ## File path: airflow/www/fab_security/manager.py ## @@ -1347,20 +1345,20 @@ def _get_user_permission_view_menus( # include public role

[GitHub] [airflow] uranusjr commented on a change in pull request #19097: add detailed information to logging when a dag or a task finishes.

2021-10-21 Thread GitBox
uranusjr commented on a change in pull request #19097: URL: https://github.com/apache/airflow/pull/19097#discussion_r734225901 ## File path: airflow/models/dagrun.py ## @@ -526,6 +526,28 @@ def update_state( else: self.set_state(State.RUNNING) +

[GitHub] [airflow] edithturn commented on pull request #19124: Modify doc contributing

2021-10-21 Thread GitBox
edithturn commented on pull request #19124: URL: https://github.com/apache/airflow/pull/19124#issuecomment-949266044 yeah, that command builds the documentation successfully, and I can see any .rst file. There are just HTML and sh files on my browser. I could be doing something wrong

[GitHub] [airflow] uranusjr commented on pull request #19124: Modify doc contributing

2021-10-21 Thread GitBox
uranusjr commented on pull request #19124: URL: https://github.com/apache/airflow/pull/19124#issuecomment-949264216 It's the right command if it works for you; the command parsing logic is quite complicated (due to the several command layers) so I just make things up as I go myself. --

[GitHub] [airflow] uranusjr commented on pull request #19145: Add test for interval timetable catchup=False

2021-10-21 Thread GitBox
uranusjr commented on pull request #19145: URL: https://github.com/apache/airflow/pull/19145#issuecomment-949259737 ``` tests/models/test_cleartasks.py::TestClearTasks::test_clear_task_instances: assert 3 == 1 + where 3 = .max_tries

[GitHub] [airflow] edithturn commented on pull request #19124: Modify doc contributing

2021-10-21 Thread GitBox
edithturn commented on pull request #19124: URL: https://github.com/apache/airflow/pull/19124#issuecomment-949257548 @uranusjr wow, I see! I think this is the right command. Am I wrong? ./breeze build-docs -- --package-filter apache-airflow -- This is an automated message from

[GitHub] [airflow] uranusjr commented on pull request #19124: Modify doc contributing

2021-10-21 Thread GitBox
uranusjr commented on pull request #19124: URL: https://github.com/apache/airflow/pull/19124#issuecomment-949255848 I just use `./breeze build-docs --package-filter=apache-airflow` and open HTML files in `docs/_build` with a web brower, no extra plugins needed. -- This is an automated

[GitHub] [airflow] edithturn commented on pull request #19124: Modify doc contributing

2021-10-21 Thread GitBox
edithturn commented on pull request #19124: URL: https://github.com/apache/airflow/pull/19124#issuecomment-949253963 Thank you @potiuk @uranusjr, I fixed but now I am just having problems rendering my file .rst to see check if the changes are great. I installed two extensions on VSC:

[GitHub] [airflow] uranusjr commented on a change in pull request #18916: Add role export/import to cli tools

2021-10-21 Thread GitBox
uranusjr commented on a change in pull request #18916: URL: https://github.com/apache/airflow/pull/18916#discussion_r734206438 ## File path: tests/cli/commands/test_role_command.py ## @@ -81,3 +82,28 @@ def test_cli_list_roles(self): def

[GitHub] [airflow] github-actions[bot] commented on pull request #18916: Add role export/import to cli tools

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #18916: URL: https://github.com/apache/airflow/pull/18916#issuecomment-949251647 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command

2021-10-21 Thread GitBox
Bowrna commented on pull request #19100: URL: https://github.com/apache/airflow/pull/19100#issuecomment-949251437 @potiuk One of the static code checks is the spelling error. I have given the macOS version name as `Big Sur`, but the check wants me to fix the spelling for the below line

[GitHub] [airflow] uranusjr commented on a change in pull request #19145: Add test for interval timetable catchup=False

2021-10-21 Thread GitBox
uranusjr commented on a change in pull request #19145: URL: https://github.com/apache/airflow/pull/19145#discussion_r734198704 ## File path: airflow/timetables/interval.py ## @@ -205,14 +205,14 @@ def _skip_to_latest(self, earliest: Optional[DateTime]) -> DateTime:

[GitHub] [airflow] uranusjr commented on a change in pull request #19145: Add test for interval timetable catchup=False

2021-10-21 Thread GitBox
uranusjr commented on a change in pull request #19145: URL: https://github.com/apache/airflow/pull/19145#discussion_r734197435 ## File path: airflow/timetables/interval.py ## @@ -74,22 +74,22 @@ def next_dagrun_info( earliest = restriction.earliest if not

[GitHub] [airflow] uranusjr opened a new pull request #19145: Add test for interval timetable catchup=False

2021-10-21 Thread GitBox
uranusjr opened a new pull request #19145: URL: https://github.com/apache/airflow/pull/19145 Test case for #19130 + some minor fixes I missed earlier. cc @robinedwards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2021-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432763#comment-17432763 ] ASF GitHub Bot commented on AIRFLOW-5071: - nguyenmphu edited a comment on issue #10790: URL:

[GitHub] [airflow] nguyenmphu edited a comment on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was the

2021-10-21 Thread GitBox
nguyenmphu edited a comment on issue #10790: URL: https://github.com/apache/airflow/issues/10790#issuecomment-949189802 I found that in the code of `airflow/jobs/scheduler_job.py`: https://github.com/apache/airflow/blob/main/airflow/jobs/scheduler_job.py#L535 ``` python if

[GitHub] [airflow] nguyenmphu commented on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was the task k

2021-10-21 Thread GitBox
nguyenmphu commented on issue #10790: URL: https://github.com/apache/airflow/issues/10790#issuecomment-949189802 I found that in the code of `airflow/jobs/scheduler_job.py`: https://github.com/apache/airflow/blob/main/airflow/jobs/scheduler_job.py#L535 ``` python if

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2021-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432762#comment-17432762 ] ASF GitHub Bot commented on AIRFLOW-5071: - nguyenmphu commented on issue #10790: URL:

[GitHub] [airflow] lanms closed issue #19069: 2.2 Pythonoperator The task executed successfully, but was not marked as successful, resulting in increasing memory and eventually outage

2021-10-21 Thread GitBox
lanms closed issue #19069: URL: https://github.com/apache/airflow/issues/19069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Fix queued dag runs changes catchup=False behaviour (#19130)

2021-10-21 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 829f90a Fix queued dag runs changes

[GitHub] [airflow] uranusjr merged pull request #19130: Fix queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
uranusjr merged pull request #19130: URL: https://github.com/apache/airflow/pull/19130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr closed issue #18487: 2.1.3/4 queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
uranusjr closed issue #18487: URL: https://github.com/apache/airflow/issues/18487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #19130: Fix queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
uranusjr commented on pull request #19130: URL: https://github.com/apache/airflow/pull/19130#issuecomment-949142409 Since we're going to have 2.2.1 very soon, I'm going to merge this and work on tests separately to make sure we make the deadline. -- This is an automated message from the

[GitHub] [airflow] Acehaidrey commented on a change in pull request #18916: Add role export/import to cli tools

2021-10-21 Thread GitBox
Acehaidrey commented on a change in pull request #18916: URL: https://github.com/apache/airflow/pull/18916#discussion_r734144292 ## File path: tests/cli/commands/test_role_command.py ## @@ -81,3 +83,26 @@ def test_cli_list_roles(self): def

[GitHub] [airflow] Acehaidrey commented on a change in pull request #18916: Add role export/import to cli tools

2021-10-21 Thread GitBox
Acehaidrey commented on a change in pull request #18916: URL: https://github.com/apache/airflow/pull/18916#discussion_r734130130 ## File path: airflow/cli/commands/role_command.py ## @@ -42,3 +45,46 @@ def roles_create(args): for role_name in args.role:

[GitHub] [airflow] github-actions[bot] commented on pull request #16636: Added dashes to pod naming

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #16636: URL: https://github.com/apache/airflow/pull/16636#issuecomment-949090655 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] closed issue #16319: Scheduler fails with Airflow initdb not finishing

2021-10-21 Thread GitBox
github-actions[bot] closed issue #16319: URL: https://github.com/apache/airflow/issues/16319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #16319: Scheduler fails with Airflow initdb not finishing

2021-10-21 Thread GitBox
github-actions[bot] commented on issue #16319: URL: https://github.com/apache/airflow/issues/16319#issuecomment-949090679 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on issue #17612: function json_extract_path(json, unknown, unknown) does not exist during dag serialization

2021-10-21 Thread GitBox
github-actions[bot] commented on issue #17612: URL: https://github.com/apache/airflow/issues/17612#issuecomment-949090637 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] closed pull request #17891: Show error in UI when a DAG with same dag_id as another DAG is present

2021-10-21 Thread GitBox
github-actions[bot] closed pull request #17891: URL: https://github.com/apache/airflow/pull/17891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Acehaidrey commented on a change in pull request #18916: Add role export/import to cli tools

2021-10-21 Thread GitBox
Acehaidrey commented on a change in pull request #18916: URL: https://github.com/apache/airflow/pull/18916#discussion_r734124385 ## File path: airflow/cli/cli_parser.py ## @@ -694,6 +694,10 @@ def _check(value): help="Don't start the serve logs process along with the

[GitHub] [airflow] Acehaidrey commented on a change in pull request #18916: Add role export/import to cli tools

2021-10-21 Thread GitBox
Acehaidrey commented on a change in pull request #18916: URL: https://github.com/apache/airflow/pull/18916#discussion_r734124385 ## File path: airflow/cli/cli_parser.py ## @@ -694,6 +694,10 @@ def _check(value): help="Don't start the serve logs process along with the

[airflow] branch main updated (f5ad26d -> 3a93ad1)

2021-10-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from f5ad26d Fixup string concatenations (#19099) add 3a93ad1 Chart: Fix `extraEnvFrom` examples (#19144)

[GitHub] [airflow] jedcunningham merged pull request #19144: Chart: Fix `extraEnvFrom` examples

2021-10-21 Thread GitBox
jedcunningham merged pull request #19144: URL: https://github.com/apache/airflow/pull/19144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] blag commented on pull request #19099: Fixup string concatenations

2021-10-21 Thread GitBox
blag commented on pull request #19099: URL: https://github.com/apache/airflow/pull/19099#issuecomment-949062081 Thanks, cheers!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] jedcunningham commented on pull request #19099: Fixup string concatenations

2021-10-21 Thread GitBox
jedcunningham commented on pull request #19099: URL: https://github.com/apache/airflow/pull/19099#issuecomment-949061591 @blag, congrats on your first commit  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[airflow] branch main updated: Fixup string concatenations (#19099)

2021-10-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f5ad26d Fixup string concatenations

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19099: Fixup string concatenations

2021-10-21 Thread GitBox
boring-cyborg[bot] commented on pull request #19099: URL: https://github.com/apache/airflow/pull/19099#issuecomment-949061337 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] jedcunningham merged pull request #19099: Fixup string concatenations

2021-10-21 Thread GitBox
jedcunningham merged pull request #19099: URL: https://github.com/apache/airflow/pull/19099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj commented on issue #19080: Display DAGs dependencies in CLI

2021-10-21 Thread GitBox
mik-laj commented on issue #19080: URL: https://github.com/apache/airflow/issues/19080#issuecomment-949056412 Here is code that display DAG: https://github.com/apache/airflow/blob/9ad8d2e49fc3394f58c6b92e40e9d84ce37fb9e1/airflow/cli/commands/dag_command.py#L187-L228 Here is PR that

[GitHub] [airflow] github-actions[bot] commented on pull request #19144: Chart: Fix `extraEnvFrom` examples

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #19144: URL: https://github.com/apache/airflow/pull/19144#issuecomment-949053067 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] jedcunningham opened a new pull request #19144: Chart: Fix `extraEnvFrom` examples

2021-10-21 Thread GitBox
jedcunningham opened a new pull request #19144: URL: https://github.com/apache/airflow/pull/19144 The examples were broken as they were missing 2 spaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] ephraimbuddy commented on pull request #19130: Fix queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
ephraimbuddy commented on pull request #19130: URL: https://github.com/apache/airflow/pull/19130#issuecomment-949033748 > > My patch did not work for a case where the dag was paused and the file was edited to set the catchup to False > > Just to clarify the paused / editing step in

[airflow] branch main updated (34e586a -> 9ad8d2e)

2021-10-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 34e586a Add sensor default timeout config (#19119) add 9ad8d2e Update virtualenv guide to use correct

[GitHub] [airflow] potiuk merged pull request #19141: Update virtualenv guide to use correct constraints file

2021-10-21 Thread GitBox
potiuk merged pull request #19141: URL: https://github.com/apache/airflow/pull/19141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #19141: Update virtualenv guide to use correct constraints file

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #19141: URL: https://github.com/apache/airflow/pull/19141#issuecomment-949033046 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] nikie commented on issue #18304: User induced deadlock for DAGs with `depends_on_past`

2021-10-21 Thread GitBox
nikie commented on issue #18304: URL: https://github.com/apache/airflow/issues/18304#issuecomment-949030839 @uranusjr There is already a case when Airflow kills deadlocked dagruns:

[GitHub] [airflow] mik-laj commented on pull request #19139: Changing password as it gets masked across logs and causes issues

2021-10-21 Thread GitBox
mik-laj commented on pull request #19139: URL: https://github.com/apache/airflow/pull/19139#issuecomment-948994862 > this will fix one of the failing test cases from quarantined list Do you remember which one? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] kosteev commented on a change in pull request #18981: Fix bug in dataflow hook when no jobs are returned

2021-10-21 Thread GitBox
kosteev commented on a change in pull request #18981: URL: https://github.com/apache/airflow/pull/18981#discussion_r734036988 ## File path: tests/providers/google/cloud/hooks/test_dataflow.py ## @@ -1697,6 +1697,27 @@ def test_fetch_list_job_messages_responses(self):

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19143: TypeError: unsupported operand type(s) for +=: 'NoneType' and 'datetime.timedelta'

2021-10-21 Thread GitBox
boring-cyborg[bot] commented on issue #19143: URL: https://github.com/apache/airflow/issues/19143#issuecomment-948989008 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] andreychernih opened a new issue #19143: TypeError: unsupported operand type(s) for +=: 'NoneType' and 'datetime.timedelta'

2021-10-21 Thread GitBox
andreychernih opened a new issue #19143: URL: https://github.com/apache/airflow/issues/19143 ### Apache Airflow version 2.2.0 (latest released) ### Operating System Debian ### Versions of Apache Airflow Providers _No response_ ### Deployment

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19142: Update BaseOperator type hints for retry_delay, max_retry_delay, dag.

2021-10-21 Thread GitBox
boring-cyborg[bot] commented on pull request #19142: URL: https://github.com/apache/airflow/pull/19142#issuecomment-948981339 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] nikie opened a new pull request #19142: Update BaseOperator type hints for retry_delay, max_retry_delay, dag.

2021-10-21 Thread GitBox
nikie opened a new pull request #19142: URL: https://github.com/apache/airflow/pull/19142 ## Updates for `BaseOperator` type hints: * `retry_delay`, `max_retry_delay` can accept `float` seconds values which are converted into `timedelta` - reflect this in type hints and docstrings *

[GitHub] [airflow] o-nikolas opened a new pull request #19141: Update virtualenv guide to use correct constraints file

2021-10-21 Thread GitBox
o-nikolas opened a new pull request #19141: URL: https://github.com/apache/airflow/pull/19141 The constraints file that was used in the example code snippets is a constraints file for released versions (e.g.: airflow/constraints-main/constraints-3.6.txt). Which was leading to long

[GitHub] [airflow] potiuk commented on pull request #19124: Modify doc contributing

2021-10-21 Thread GitBox
potiuk commented on pull request #19124: URL: https://github.com/apache/airflow/pull/19124#issuecomment-948966581 Yep. It's good to verify and preview the .rst file in a renderer (for example IntelliJ and VScode have nice renderers). -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk closed issue #19134: Docker Compose not starting webserver

2021-10-21 Thread GitBox
potiuk closed issue #19134: URL: https://github.com/apache/airflow/issues/19134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #19134: Docker Compose not starting webserver

2021-10-21 Thread GitBox
potiuk commented on issue #19134: URL: https://github.com/apache/airflow/issues/19134#issuecomment-948964568 so why `mwaa-airflow-webserver-1` name ? Looks like a strange name to keep the "plain" airflow image in. * Did you follow precistly the instructions from

[GitHub] [airflow] khalidmammadov opened a new pull request #19139: Changing password as it gets masked across logs and causes issues

2021-10-21 Thread GitBox
khalidmammadov opened a new pull request #19139: URL: https://github.com/apache/airflow/pull/19139 Current postgres password gets masked during DB engine init and added to secret list and masked whenever mentioned in the logs. As it currently set to "airflow" it's converted to ***

[airflow] branch main updated (0a68506 -> 34e586a)

2021-10-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 0a68506 Update docstring to let users use `node_selector` (#19057) add 34e586a Add sensor default

[GitHub] [airflow] github-actions[bot] commented on pull request #19119: Add sensor default timeout config

2021-10-21 Thread GitBox
github-actions[bot] commented on pull request #19119: URL: https://github.com/apache/airflow/pull/19119#issuecomment-948937941 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] mik-laj closed issue #18878: Change the Sensors default timeout using airflow configs

2021-10-21 Thread GitBox
mik-laj closed issue #18878: URL: https://github.com/apache/airflow/issues/18878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj merged pull request #19119: Add sensor default timeout config

2021-10-21 Thread GitBox
mik-laj merged pull request #19119: URL: https://github.com/apache/airflow/pull/19119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on issue #18937: KubernetesExecutor: Log Server not running inside the worker pod

2021-10-21 Thread GitBox
jedcunningham commented on issue #18937: URL: https://github.com/apache/airflow/issues/18937#issuecomment-948937517 Glad you figured it out! Yeah the labels are used to determine which pods are used for a service, so sounds like you were accidentally sending web requests to your worker.

[GitHub] [airflow] jedcunningham closed issue #18937: KubernetesExecutor: Log Server not running inside the worker pod

2021-10-21 Thread GitBox
jedcunningham closed issue #18937: URL: https://github.com/apache/airflow/issues/18937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] robinedwards commented on pull request #19130: Fix queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
robinedwards commented on pull request #19130: URL: https://github.com/apache/airflow/pull/19130#issuecomment-948937103 > My patch did not work for a case where the dag was paused and the file was edited to set the catchup to False Just to clarify the paused / editing step in my

[GitHub] [airflow] mik-laj edited a comment on pull request #19119: Add sensor default timeout config

2021-10-21 Thread GitBox
mik-laj edited a comment on pull request #19119: URL: https://github.com/apache/airflow/pull/19119#issuecomment-948933965 @mariotaddeucci The `version_added` field is checked during the cherry-pick to the release branch by release manager. After a new version is released, we use [a

[GitHub] [airflow] robinedwards commented on a change in pull request #19130: Fix queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
robinedwards commented on a change in pull request #19130: URL: https://github.com/apache/airflow/pull/19130#discussion_r733984728 ## File path: airflow/timetables/interval.py ## @@ -81,9 +81,15 @@ def next_dagrun_info( return None start =

[GitHub] [airflow] mik-laj commented on pull request #19119: Add sensor default timeout config

2021-10-21 Thread GitBox
mik-laj commented on pull request #19119: URL: https://github.com/apache/airflow/pull/19119#issuecomment-948933965 @mariotaddeucci The `version_added` field is checked during the cherry-pick for the release branch by release manager. After a new version is released, we use [a

[GitHub] [airflow] nikie commented on issue #19138: BaseOperator type hints for retry_delay and max_retry_delay should reveal float option

2021-10-21 Thread GitBox
nikie commented on issue #19138: URL: https://github.com/apache/airflow/issues/19138#issuecomment-948923679 Is related to: #13086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] nikie opened a new issue #19138: BaseOperator type hints for retry_delay and max_retry_delay should reveal float option

2021-10-21 Thread GitBox
nikie opened a new issue #19138: URL: https://github.com/apache/airflow/issues/19138 ### Describe the issue with documentation `BaseOperator` type hints for `retry_delay` and `max_retry_delay` shows `timedelta` only, however the params also accept `float` seconds values. Also,

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19138: BaseOperator type hints for retry_delay and max_retry_delay should reveal float option

2021-10-21 Thread GitBox
boring-cyborg[bot] commented on issue #19138: URL: https://github.com/apache/airflow/issues/19138#issuecomment-948918916 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] diane-nguyen commented on issue #16844: Rest API: allow filtering DagRuns by state.

2021-10-21 Thread GitBox
diane-nguyen commented on issue #16844: URL: https://github.com/apache/airflow/issues/16844#issuecomment-948901516 Hello, I would like to work on this issue :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] josh-fell commented on pull request #19062: Static start_date and default arg cleanup for Microsoft providers example DAGs

2021-10-21 Thread GitBox
josh-fell commented on pull request #19062: URL: https://github.com/apache/airflow/pull/19062#issuecomment-948895784 @ephraimbuddy FYI - I've confirmed Azure system tests pass locally.

[GitHub] [airflow] uranusjr commented on issue #16844: Rest API: allow filtering DagRuns by state.

2021-10-21 Thread GitBox
uranusjr commented on issue #16844: URL: https://github.com/apache/airflow/issues/16844#issuecomment-948893985 cc @diane-nguyen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on issue #19108: REST API: allow filtering by state in Dag Runs queries

2021-10-21 Thread GitBox
uranusjr commented on issue #19108: URL: https://github.com/apache/airflow/issues/19108#issuecomment-948893592 I just realised this is a duplicate to #16844, so I'm going to close this one in favour of that earlier entry. A pull request (#16845) was filed against that issue but had

[GitHub] [airflow] uranusjr closed issue #19108: REST API: allow filtering by state in Dag Runs queries

2021-10-21 Thread GitBox
uranusjr closed issue #19108: URL: https://github.com/apache/airflow/issues/19108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] diane-nguyen commented on issue #19108: REST API: allow filtering by state in Dag Runs queries

2021-10-21 Thread GitBox
diane-nguyen commented on issue #19108: URL: https://github.com/apache/airflow/issues/19108#issuecomment-948889016 Hi, I would like to work on this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] uranusjr commented on a change in pull request #19130: Fix queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
uranusjr commented on a change in pull request #19130: URL: https://github.com/apache/airflow/pull/19130#discussion_r733934959 ## File path: airflow/timetables/interval.py ## @@ -81,9 +81,15 @@ def next_dagrun_info( return None start =

[GitHub] [airflow] josh-fell commented on a change in pull request #19079: use DefaultAzureCredential if login not provided for Data Factory

2021-10-21 Thread GitBox
josh-fell commented on a change in pull request #19079: URL: https://github.com/apache/airflow/pull/19079#discussion_r733934627 ## File path: airflow/providers/microsoft/azure/hooks/data_factory.py ## @@ -144,10 +144,13 @@ def get_conn(self) -> DataFactoryManagementClient:

[GitHub] [airflow] FurcyPin commented on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2021-10-21 Thread GitBox
FurcyPin commented on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-948858685 Hello, I think I ran into the same issue. ![2021-10-21-19:05:47](https://user-images.githubusercontent.com/6087587/138324724-d56b19d0-8dda-40e8-a62b-4b95f6155ba5.png)

[GitHub] [airflow] opendatakraken commented on issue #18937: KubernetesExecutor: Log Server not running inside the worker pod

2021-10-21 Thread GitBox
opendatakraken commented on issue #18937: URL: https://github.com/apache/airflow/issues/18937#issuecomment-948819703 Hi @jedcunningham the issue was with the labels! through copy/paste I had the same labels in the main (scheduler + webserver) pod and the worker one: ```

[GitHub] [airflow] aran3 commented on issue #9975: max_active_runs = 1 can still create multiple active execution runs

2021-10-21 Thread GitBox
aran3 commented on issue #9975: URL: https://github.com/apache/airflow/issues/9975#issuecomment-948817974 It is worth noting for anyone (such as us) that heavily relies on `max_active_runs=1` - that this still happens in 2.1.4 when using cli `dags trigger` command or

[GitHub] [airflow] potiuk commented on issue #19133: Unable to access Airflow UI (MWAA)

2021-10-21 Thread GitBox
potiuk commented on issue #19133: URL: https://github.com/apache/airflow/issues/19133#issuecomment-948815102 Indeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk closed issue #19133: Unable to access Airflow UI (MWAA)

2021-10-21 Thread GitBox
potiuk closed issue #19133: URL: https://github.com/apache/airflow/issues/19133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy commented on pull request #19130: Fix queued dag runs changes catchup=False behaviour

2021-10-21 Thread GitBox
ephraimbuddy commented on pull request #19130: URL: https://github.com/apache/airflow/pull/19130#issuecomment-948805838 > @ephraimbuddy is this different to the case you were working on/have a PR for? My patch did not work for a case where the dag was paused and the file was edited

[GitHub] [airflow] opendatakraken edited a comment on issue #18937: KubernetesExecutor: Log Server not running inside the worker pod

2021-10-21 Thread GitBox
opendatakraken edited a comment on issue #18937: URL: https://github.com/apache/airflow/issues/18937#issuecomment-948797752 Hi @jedcunningham many thanks for explaining the architecture. The main pod contains both the scheduler and the webserver containers plus some sidecar containers to

  1   2   3   >