[GitHub] [airflow] eladkal commented on a change in pull request #20160: 20139 - organize aws emr operators

2021-12-13 Thread GitBox
eladkal commented on a change in pull request #20160: URL: https://github.com/apache/airflow/pull/20160#discussion_r768394156 ## File path: airflow/providers/amazon/aws/sensors/emr.py ## @@ -0,0 +1,347 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[airflow] branch main updated (5011cb3 -> 181d60cd)

2021-12-13 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5011cb3 MyPy airflow/timetables fix (#20275) add 181d60cd Lazy Jinja2 context (#20217) No new revisions were

[GitHub] [airflow] uranusjr closed issue #20213: Context deprecation warnings when they aren't used

2021-12-13 Thread GitBox
uranusjr closed issue #20213: URL: https://github.com/apache/airflow/issues/20213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #20217: Lazy Jinja2 context

2021-12-13 Thread GitBox
uranusjr commented on pull request #20217: URL: https://github.com/apache/airflow/pull/20217#issuecomment-993235505 ``` tests/executors/test_dask_executor.py::TestDaskExecutor::test_dask_executor_functions: ValueError: The futures should have finished; there is probably an error

[GitHub] [airflow] uranusjr merged pull request #20217: Lazy Jinja2 context

2021-12-13 Thread GitBox
uranusjr merged pull request #20217: URL: https://github.com/apache/airflow/pull/20217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on issue #20139: Restructure Amazon provider operators files

2021-12-13 Thread GitBox
eladkal commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-993227095 > Since we are making these changes and going to be deprecating old operators in favor of new ones, it may be a good time to address some standardization issues as well? Two

[GitHub] [airflow] github-actions[bot] commented on pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table

2021-12-13 Thread GitBox
github-actions[bot] commented on pull request #20282: URL: https://github.com/apache/airflow/pull/20282#issuecomment-993183920 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] punit-zeta commented on issue #9134: Support Flink operator

2021-12-13 Thread GitBox
punit-zeta commented on issue #9134: URL: https://github.com/apache/airflow/issues/9134#issuecomment-993182963 Hi, @ChethanUK any update on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] kushsharma opened a new pull request #20282: Fix slow DAG deletion due to missing dag_id index for job table

2021-12-13 Thread GitBox
kushsharma opened a new pull request #20282: URL: https://github.com/apache/airflow/pull/20282 Fixes https://github.com/apache/airflow/issues/20249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] dstandish commented on a change in pull request #20224: Fix start date for following sensor reschedule

2021-12-13 Thread GitBox
dstandish commented on a change in pull request #20224: URL: https://github.com/apache/airflow/pull/20224#discussion_r768316019 ## File path: airflow/models/taskinstance.py ## @@ -1204,10 +1204,12 @@ def check_and_change_state_before_execution( # For reporting

[GitHub] [airflow] dstandish commented on a change in pull request #20224: Fix start date for following sensor reschedule

2021-12-13 Thread GitBox
dstandish commented on a change in pull request #20224: URL: https://github.com/apache/airflow/pull/20224#discussion_r768316019 ## File path: airflow/models/taskinstance.py ## @@ -1204,10 +1204,12 @@ def check_and_change_state_before_execution( # For reporting

[GitHub] [airflow] uranusjr commented on a change in pull request #20274: MyPy cant follow the logic for dynamic attribute existence in airflow/triggers

2021-12-13 Thread GitBox
uranusjr commented on a change in pull request #20274: URL: https://github.com/apache/airflow/pull/20274#discussion_r768316467 ## File path: airflow/triggers/temporal.py ## @@ -38,7 +38,7 @@ def __init__(self, moment: datetime.datetime): # Make sure it's in UTC

[GitHub] [airflow] dstandish commented on a change in pull request #20224: Fix start date for following sensor reschedule

2021-12-13 Thread GitBox
dstandish commented on a change in pull request #20224: URL: https://github.com/apache/airflow/pull/20224#discussion_r768316019 ## File path: airflow/models/taskinstance.py ## @@ -1204,10 +1204,12 @@ def check_and_change_state_before_execution( # For reporting

[GitHub] [airflow] github-actions[bot] commented on pull request #20281: Fix MyPy errors in `docs/exts`

2021-12-13 Thread GitBox
github-actions[bot] commented on pull request #20281: URL: https://github.com/apache/airflow/pull/20281#issuecomment-993156837 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] uranusjr commented on a change in pull request #20217: Lazy Jinja2 context

2021-12-13 Thread GitBox
uranusjr commented on a change in pull request #20217: URL: https://github.com/apache/airflow/pull/20217#discussion_r768307032 ## File path: airflow/utils/context.py ## @@ -124,6 +142,11 @@ def __reduce_ex__(self, protocol: int) -> Tuple[Any, ...]: items = [(key,

[GitHub] [airflow] josh-fell opened a new pull request #20281: Fix MyPy errors in `docs/exts`

2021-12-13 Thread GitBox
josh-fell opened a new pull request #20281: URL: https://github.com/apache/airflow/pull/20281 Related: #19891 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] dstandish commented on a change in pull request #20276: Split redshift cluster and redshift sql

2021-12-13 Thread GitBox
dstandish commented on a change in pull request #20276: URL: https://github.com/apache/airflow/pull/20276#discussion_r768301467 ## File path: airflow/providers/amazon/aws/hooks/redshift_sql.py ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] thesuperzapper commented on issue #20168: KubernetesExecutor reports missing dag_run.data_interval_start on airflow@2.2.1

2021-12-13 Thread GitBox
thesuperzapper commented on issue #20168: URL: https://github.com/apache/airflow/issues/20168#issuecomment-993126518 @potiuk to be clear, I put a warning after every `helm install` that tells users not to use the `extraPipPackages` in environments that are important. -- This is an

[GitHub] [airflow] josh-fell opened a new pull request #20280: Fix MyPy errors in `scripts/in_container`

2021-12-13 Thread GitBox
josh-fell opened a new pull request #20280: URL: https://github.com/apache/airflow/pull/20280 Related: #19891 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] ferruzzi edited a comment on issue #19641: EKSCreateNodegroupOperator - missing kwargs

2021-12-13 Thread GitBox
ferruzzi edited a comment on issue #19641: URL: https://github.com/apache/airflow/issues/19641#issuecomment-993113732 How do we feel about [this implementation](https://github.com/ferruzzi/airflow/tree/kwargs-kpo)? The required parameters are still there in named args, but if they are

[GitHub] [airflow] ferruzzi edited a comment on issue #19641: EKSCreateNodegroupOperator - missing kwargs

2021-12-13 Thread GitBox
ferruzzi edited a comment on issue #19641: URL: https://github.com/apache/airflow/issues/19641#issuecomment-993113732 How do we feel about this implementation? The required parameters are still there in named args, but if they are not passed, then it checks the operator_kwargs for their

[GitHub] [airflow] ferruzzi commented on issue #19641: EKSCreateNodegroupOperator - missing kwargs

2021-12-13 Thread GitBox
ferruzzi commented on issue #19641: URL: https://github.com/apache/airflow/issues/19641#issuecomment-993113732 How do we feel about this implementation? The required parameters are still there in named args, but if they are not passed, then it checks the operator_kwargs for their values.

[GitHub] [airflow] Acehaidrey edited a comment on pull request #20122: Allow users to input reasons when manually mark states.

2021-12-13 Thread GitBox
Acehaidrey edited a comment on pull request #20122: URL: https://github.com/apache/airflow/pull/20122#issuecomment-993011080 Hey @ashb or any other user. Mind sharing thoughts - we internally need to make some progress here and would like to know what the way forward is -- This is an

[GitHub] [airflow] josh-fell commented on a change in pull request #20271: Fix mypy airbyte provider errors

2021-12-13 Thread GitBox
josh-fell commented on a change in pull request #20271: URL: https://github.com/apache/airflow/pull/20271#discussion_r768263731 ## File path: airflow/providers/airbyte/sensors/airbyte.py ## @@ -54,7 +54,7 @@ def __init__( def poke(self, context: dict) -> bool:

[GitHub] [airflow] josh-fell edited a comment on pull request #19918: Fix mypy errors in example DAGs

2021-12-13 Thread GitBox
josh-fell edited a comment on pull request #19918: URL: https://github.com/apache/airflow/pull/19918#issuecomment-993073218 > @josh-fell - still waiting on this or shall we close it? I had a poorly-worded question to you and wanted to know what you had agreed to above. Is it OK to

[GitHub] [airflow] josh-fell commented on a change in pull request #20276: Split redshift cluster and redshift sql

2021-12-13 Thread GitBox
josh-fell commented on a change in pull request #20276: URL: https://github.com/apache/airflow/pull/20276#discussion_r768258674 ## File path: airflow/providers/amazon/aws/hooks/redshift_sql.py ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] ferruzzi edited a comment on issue #20139: Restructure Amazon provider operators files

2021-12-13 Thread GitBox
ferruzzi edited a comment on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-992932416 Hey cool initiative, I definitely agree with this plan! Sorry for the delay in response, I was enjoying a seaside cabin without internet last week. ️ I will take a

[GitHub] [airflow] josh-fell commented on pull request #19918: Fix mypy errors in example DAGs

2021-12-13 Thread GitBox
josh-fell commented on pull request #19918: URL: https://github.com/apache/airflow/pull/19918#issuecomment-993073218 > @josh-fell - still waiting on this or shall we close it? I had a poorly-worded question to you and wanted to know what you had agreed to above. Is it OK to move

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20277: Fix incorrect filename references

2021-12-13 Thread GitBox
boring-cyborg[bot] commented on pull request #20277: URL: https://github.com/apache/airflow/pull/20277#issuecomment-993072706 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] robertoea opened a new pull request #20277: Fix incorrect filename references

2021-12-13 Thread GitBox
robertoea opened a new pull request #20277: URL: https://github.com/apache/airflow/pull/20277 Minor typo corrections. I changed the filenames in the example folder structure instead of the later references to be consistent with the other examples in the documentation. ---

[GitHub] [airflow] potiuk commented on pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
potiuk commented on pull request #20272: URL: https://github.com/apache/airflow/pull/20272#issuecomment-993029175 Few statics to fix too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on a change in pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #20272: URL: https://github.com/apache/airflow/pull/20272#discussion_r768218705 ## File path: airflow/models/baseoperator.py ## @@ -578,6 +585,25 @@ def __init__( if end_date: self.end_date =

[GitHub] [airflow] github-actions[bot] commented on pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
github-actions[bot] commented on pull request #20272: URL: https://github.com/apache/airflow/pull/20272#issuecomment-993028494 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on a change in pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #20272: URL: https://github.com/apache/airflow/pull/20272#discussion_r768220328 ## File path: airflow/models/xcom.py ## @@ -408,8 +408,9 @@ def clear( execution_date: Optional[pendulum.DateTime] = None, dag_id:

[GitHub] [airflow] potiuk commented on a change in pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #20272: URL: https://github.com/apache/airflow/pull/20272#discussion_r768219924 ## File path: airflow/models/taskinstance.py ## @@ -1951,7 +1951,7 @@ def get_prev_ds_nodash() -> Optional[str]: 'yesterday_ds':

[GitHub] [airflow] potiuk commented on a change in pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #20272: URL: https://github.com/apache/airflow/pull/20272#discussion_r768218705 ## File path: airflow/models/baseoperator.py ## @@ -578,6 +585,25 @@ def __init__( if end_date: self.end_date =

[GitHub] [airflow] github-actions[bot] commented on pull request #17934: Add dags.gitSync.sshKeyCustomFile parameter to allow other SSH key sources

2021-12-13 Thread GitBox
github-actions[bot] commented on pull request #17934: URL: https://github.com/apache/airflow/pull/17934#issuecomment-993023949 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] closed issue #19136: Variable not found, causing broken DAGs, and cryptography error

2021-12-13 Thread GitBox
github-actions[bot] closed issue #19136: URL: https://github.com/apache/airflow/issues/19136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #19136: Variable not found, causing broken DAGs, and cryptography error

2021-12-13 Thread GitBox
github-actions[bot] commented on issue #19136: URL: https://github.com/apache/airflow/issues/19136#issuecomment-993023894 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed pull request #19157: fix "mismatch process ids" issue for the "run as user" case

2021-12-13 Thread GitBox
github-actions[bot] closed pull request #19157: URL: https://github.com/apache/airflow/pull/19157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a change in pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #20272: URL: https://github.com/apache/airflow/pull/20272#discussion_r768217117 ## File path: airflow/models/baseoperator.py ## @@ -567,6 +567,13 @@ def __init__( self.email = email self.email_on_retry =

[airflow] branch main updated (ed709b4 -> 5011cb3)

2021-12-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from ed709b4 MyPy cant follow the logic for dynamic atribute existence (#20274) add 5011cb3 MyPy

[GitHub] [airflow] potiuk merged pull request #20275: MyPy airflow/timetables fix

2021-12-13 Thread GitBox
potiuk merged pull request #20275: URL: https://github.com/apache/airflow/pull/20275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (1f8b3f9 -> ed709b4)

2021-12-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1f8b3f9 Chart: properly quote namespace names (#20266) add ed709b4 MyPy cant follow the logic for dynamic

[GitHub] [airflow] potiuk merged pull request #20274: MyPy cant follow the logic for dynamic attribute existence in airflow/triggers

2021-12-13 Thread GitBox
potiuk merged pull request #20274: URL: https://github.com/apache/airflow/pull/20274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #19914: Fix mypy errors in airflow utils

2021-12-13 Thread GitBox
potiuk commented on pull request #19914: URL: https://github.com/apache/airflow/pull/19914#issuecomment-993018074 All fixed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on a change in pull request #19914: Fix mypy errors in airflow utils

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #19914: URL: https://github.com/apache/airflow/pull/19914#discussion_r768211005 ## File path: airflow/utils/task_group.py ## @@ -115,10 +115,10 @@ def __init__( raise AirflowException("TaskGroup must have a

[GitHub] [airflow] subkanthi commented on a change in pull request #20271: Fix mypy airbyte provider errors

2021-12-13 Thread GitBox
subkanthi commented on a change in pull request #20271: URL: https://github.com/apache/airflow/pull/20271#discussion_r768208463 ## File path: airflow/providers/airbyte/hooks/airbyte.py ## @@ -71,7 +71,7 @@ def wait_for_job( raise AirflowException(f"Timeout:

[GitHub] [airflow] subkanthi commented on a change in pull request #20271: Fix mypy airbyte provider errors

2021-12-13 Thread GitBox
subkanthi commented on a change in pull request #20271: URL: https://github.com/apache/airflow/pull/20271#discussion_r768207839 ## File path: airflow/providers/airbyte/sensors/airbyte.py ## @@ -54,7 +54,7 @@ def __init__( def poke(self, context: dict) -> bool:

[GitHub] [airflow] Acehaidrey commented on pull request #20122: Allow users to input reasons when manually mark states.

2021-12-13 Thread GitBox
Acehaidrey commented on pull request #20122: URL: https://github.com/apache/airflow/pull/20122#issuecomment-993011080 Hey @ashb or any other user. Mind sharing thoughts - -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on a change in pull request #19914: Fix mypy errors in airflow utils

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #19914: URL: https://github.com/apache/airflow/pull/19914#discussion_r768205239 ## File path: airflow/utils/task_group.py ## @@ -115,10 +115,10 @@ def __init__( raise AirflowException("TaskGroup must have a

[GitHub] [airflow] dimon222 commented on a change in pull request #19726: Fix Volume/VolumeMount KPO DeprecationWarning

2021-12-13 Thread GitBox
dimon222 commented on a change in pull request #19726: URL: https://github.com/apache/airflow/pull/19726#discussion_r768204827 ## File path: airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py ## @@ -21,18 +21,16 @@ from kubernetes.client import

[GitHub] [airflow] potiuk commented on a change in pull request #19914: Fix mypy errors in airflow utils

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #19914: URL: https://github.com/apache/airflow/pull/19914#discussion_r768204714 ## File path: airflow/utils/email.py ## @@ -226,9 +228,9 @@ def send_mime_email( if smtp_starttls: conn.starttls()

[GitHub] [airflow] potiuk commented on a change in pull request #19914: Fix mypy errors in airflow utils

2021-12-13 Thread GitBox
potiuk commented on a change in pull request #19914: URL: https://github.com/apache/airflow/pull/19914#discussion_r76820 ## File path: airflow/utils/email.py ## @@ -226,9 +228,9 @@ def send_mime_email( if smtp_starttls: conn.starttls()

[GitHub] [airflow] dstandish opened a new pull request #20276: Split redshift cluster and redshift sql

2021-12-13 Thread GitBox
dstandish opened a new pull request #20276: URL: https://github.com/apache/airflow/pull/20276 The first redshift hook was for managing the cluster itself. Later a hook for _using_ the cluster was added to the same module. Better to separate these into distinct modules redshift_sql and

[airflow] branch main updated (433e029 -> 1f8b3f9)

2021-12-13 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 433e029 Fix MyPy Errors for Apache Drill provider. (#20268) add 1f8b3f9 Chart: properly quote namespace

[GitHub] [airflow] jedcunningham merged pull request #20266: Chart: properly quote namespace names

2021-12-13 Thread GitBox
jedcunningham merged pull request #20266: URL: https://github.com/apache/airflow/pull/20266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability

2021-12-13 Thread GitBox
Acehaidrey commented on pull request #20112: URL: https://github.com/apache/airflow/pull/20112#issuecomment-993005073 @bbovenzi when you recommend that format, `01:00:02` that is what it currently is. That is how the timedeltas look right now if I'm not mistaken. Unless you are looking

[GitHub] [airflow] khalidmammadov commented on issue #19891: Re-enable MyPy

2021-12-13 Thread GitBox
khalidmammadov commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-993003911 FYI: airflow/triggers and airflow/timetables are done #20274, #20275. Although trivial fixes.. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] jedcunningham commented on a change in pull request #19726: Fix Volume/VolumeMount KPO DeprecationWarning

2021-12-13 Thread GitBox
jedcunningham commented on a change in pull request #19726: URL: https://github.com/apache/airflow/pull/19726#discussion_r768197737 ## File path: airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py ## @@ -21,18 +21,16 @@ from kubernetes.client import

[GitHub] [airflow] pateash commented on issue #16911: Error in passing metadata to DataprocClusterCreateOperator

2021-12-13 Thread GitBox
pateash commented on issue #16911: URL: https://github.com/apache/airflow/issues/16911#issuecomment-99309 @nicolas-settembrini No Problem, you just have to generate config from all these arguments and then pass it to the **DataprocClusterCreateOperator** find more details in

[GitHub] [airflow] khalidmammadov opened a new pull request #20275: MyPy airflow/timetables fix

2021-12-13 Thread GitBox
khalidmammadov opened a new pull request #20275: URL: https://github.com/apache/airflow/pull/20275 Part of #19891 Completes: airflow/timetables --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] pateash edited a comment on issue #19098: Showing approximate Time remaining for next dag run in Airflow UI

2021-12-13 Thread GitBox
pateash edited a comment on issue #19098: URL: https://github.com/apache/airflow/issues/19098#issuecomment-992997461 ![image](https://user-images.githubusercontent.com/16856802/145901296-ac6b45f6-1039-40c2-a44d-d5d1920ea3f5.png)

[GitHub] [airflow] pateash commented on issue #19098: Showing approximate Time remaining for next dag run in Airflow UI

2021-12-13 Thread GitBox
pateash commented on issue #19098: URL: https://github.com/apache/airflow/issues/19098#issuecomment-992997461 ![image](https://user-images.githubusercontent.com/16856802/145901296-ac6b45f6-1039-40c2-a44d-d5d1920ea3f5.png)

[GitHub] [airflow] potiuk commented on pull request #20226: Fix cached_property MyPy declaration and related MyPy errors

2021-12-13 Thread GitBox
potiuk commented on pull request #20226: URL: https://github.com/apache/airflow/pull/20226#issuecomment-992996993 This one fixes a lot :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (64a902d -> 433e029)

2021-12-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 64a902d Fix MyPy Errors for Apache Druid provider. (#20270) add 433e029 Fix MyPy Errors for Apache Drill

[airflow] branch main updated (18a977c -> 64a902d)

2021-12-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 18a977c Fix mypy errors in `tests/utils` (#20093) add 64a902d Fix MyPy Errors for Apache Druid provider.

[GitHub] [airflow] potiuk merged pull request #20268: Fix MyPy Errors for Apache Drill provider.

2021-12-13 Thread GitBox
potiuk merged pull request #20268: URL: https://github.com/apache/airflow/pull/20268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #20270: Fix MyPy Errors for Apache Druid provider.

2021-12-13 Thread GitBox
potiuk merged pull request #20270: URL: https://github.com/apache/airflow/pull/20270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] khalidmammadov opened a new pull request #20274: MyPy cant follow the logic for dynamic attribute existence in airflow/triggers

2021-12-13 Thread GitBox
khalidmammadov opened a new pull request #20274: URL: https://github.com/apache/airflow/pull/20274 Part of #19891 MyPy complaining that offset field does not exists. The first condition is ensuring the second check does not fail. Hence ignoring This should complete MyPy

[GitHub] [airflow] pateash commented on pull request #20273: Showing approximate time remaining for next dag_run in Airflow

2021-12-13 Thread GitBox
pateash commented on pull request #20273: URL: https://github.com/apache/airflow/pull/20273#issuecomment-992991472 ![image](https://user-images.githubusercontent.com/16856802/145903054-dad6faf8-c29d-4938-8901-070ef8e93ec5.png)

[GitHub] [airflow] pateash commented on pull request #20273: Showing approximate time remaining for next dag_run in Airflow UI

2021-12-13 Thread GitBox
pateash commented on pull request #20273: URL: https://github.com/apache/airflow/pull/20273#issuecomment-992982739 ![image](https://user-images.githubusercontent.com/16856802/145901296-ac6b45f6-1039-40c2-a44d-d5d1920ea3f5.png)

[GitHub] [airflow] dimon222 commented on a change in pull request #19726: Fix Volume/VolumeMount KPO DeprecationWarning

2021-12-13 Thread GitBox
dimon222 commented on a change in pull request #19726: URL: https://github.com/apache/airflow/pull/19726#discussion_r768182727 ## File path: airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py ## @@ -21,18 +21,16 @@ from kubernetes.client import

[GitHub] [airflow] ashb commented on a change in pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
ashb commented on a change in pull request #20272: URL: https://github.com/apache/airflow/pull/20272#discussion_r768182550 ## File path: airflow/models/baseoperator.py ## @@ -567,6 +567,13 @@ def __init__( self.email = email self.email_on_retry =

[GitHub] [airflow] potiuk commented on pull request #19993: Update upgrading.rst with detailed code example of how to resolve post-upgrade warning

2021-12-13 Thread GitBox
potiuk commented on pull request #19993: URL: https://github.com/apache/airflow/pull/19993#issuecomment-992981765 Docs are failing - I think you need ot look at similar .rst files :) something like `.. note::` should do the trick -- This is an automated message from the Apache

[GitHub] [airflow] ashb commented on a change in pull request #20271: Fix mypy airbyte provider errors

2021-12-13 Thread GitBox
ashb commented on a change in pull request #20271: URL: https://github.com/apache/airflow/pull/20271#discussion_r768181906 ## File path: airflow/providers/airbyte/sensors/airbyte.py ## @@ -54,7 +54,7 @@ def __init__( def poke(self, context: dict) -> bool: hook

[GitHub] [airflow] ashb commented on a change in pull request #20271: Fix mypy airbyte provider errors

2021-12-13 Thread GitBox
ashb commented on a change in pull request #20271: URL: https://github.com/apache/airflow/pull/20271#discussion_r768181401 ## File path: airflow/providers/airbyte/hooks/airbyte.py ## @@ -46,12 +46,12 @@ class AirbyteHook(HttpHook): ERROR = "error" INCOMPLETE =

[GitHub] [airflow] pateash opened a new pull request #20273: Showing approximate time remaining for next dag_run in Airflow UI

2021-12-13 Thread GitBox
pateash opened a new pull request #20273: URL: https://github.com/apache/airflow/pull/20273 closes: #19098 ### Description It will be really helpful if we can add a dynamic message/tooltip which shows time remaining for next dagrun in UI. ### Use case/motivation

[GitHub] [airflow] ashb commented on a change in pull request #20271: Fix mypy airbyte provider errors

2021-12-13 Thread GitBox
ashb commented on a change in pull request #20271: URL: https://github.com/apache/airflow/pull/20271#discussion_r768180838 ## File path: airflow/providers/airbyte/hooks/airbyte.py ## @@ -71,7 +71,7 @@ def wait_for_job( raise AirflowException(f"Timeout: Airbyte

[GitHub] [airflow] jedcunningham commented on a change in pull request #20199: fix network policy issue for webserver and flowerui

2021-12-13 Thread GitBox
jedcunningham commented on a change in pull request #20199: URL: https://github.com/apache/airflow/pull/20199#discussion_r768179979 ## File path: chart/values.schema.json ## @@ -2158,12 +2158,12 @@ },

[GitHub] [airflow] adaezebestow commented on pull request #19993: Update upgrading.rst with detailed code example of how to resolve post-upgrade warning

2021-12-13 Thread GitBox
adaezebestow commented on pull request #19993: URL: https://github.com/apache/airflow/pull/19993#issuecomment-992980197 Hey @potiuk, I made an update specifying that the code suggestion is specific to Kubernetes. I tried unsuccessfully to reformat it into a note block. -- This is an

[GitHub] [airflow] ashb opened a new pull request #20272: Fix mypy typing for airflow/models and their tests

2021-12-13 Thread GitBox
ashb opened a new pull request #20272: URL: https://github.com/apache/airflow/pull/20272 The re-ordering of setting attributes in BaseOperator is because _something_ about that function (throwing the exceptions?) causes mypy to think that BaseOperator objects could be missing those

[GitHub] [airflow] potiuk commented on pull request #19918: Fix mypy errors in example DAGs

2021-12-13 Thread GitBox
potiuk commented on pull request #19918: URL: https://github.com/apache/airflow/pull/19918#issuecomment-992976084 @josh-fell - still waiting on this or shall we close it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on pull request #20268: Fix MyPy Errors for Apache Drill provider.

2021-12-13 Thread GitBox
potiuk commented on pull request #20268: URL: https://github.com/apache/airflow/pull/20268#issuecomment-992974809 Temporary error - reopened to rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk closed pull request #20268: Fix MyPy Errors for Apache Drill provider.

2021-12-13 Thread GitBox
potiuk closed pull request #20268: URL: https://github.com/apache/airflow/pull/20268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (7f297f6 -> 18a977c)

2021-12-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7f297f6 Use Viewer role as example public role (#19215) add 18a977c Fix mypy errors in `tests/utils` (#20093)

[GitHub] [airflow] potiuk merged pull request #20093: Fix mypy errors in `tests/utils`

2021-12-13 Thread GitBox
potiuk merged pull request #20093: URL: https://github.com/apache/airflow/pull/20093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #19993: Update upgrading.rst with detailed code example of how to resolve post-upgrade warning

2021-12-13 Thread GitBox
potiuk commented on pull request #19993: URL: https://github.com/apache/airflow/pull/19993#issuecomment-992972049 Can we get update on that one :) @adaezebestow ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] subkanthi opened a new pull request #20271: Fix mypy airbyte provider errors

2021-12-13 Thread GitBox
subkanthi opened a new pull request #20271: URL: https://github.com/apache/airflow/pull/20271 Related: #19891 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on issue #16299: SageMakerTrainingOperator gets ThrottlingException when listing training jobs

2021-12-13 Thread GitBox
potiuk commented on issue #16299: URL: https://github.com/apache/airflow/issues/16299#issuecomment-992967176 > otherwise i don't understand how some basic stuff that is not working properly is not handled. There is not much to understand. Airflow has almost 1900 contributors. Some

[GitHub] [airflow] github-actions[bot] commented on pull request #20270: Fix MyPy Errors for Apache Druid provider.

2021-12-13 Thread GitBox
github-actions[bot] commented on pull request #20270: URL: https://github.com/apache/airflow/pull/20270#issuecomment-992961171 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] subkanthi commented on issue #19891: Re-enable MyPy

2021-12-13 Thread GitBox
subkanthi commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-992959692 Looking at airflow/providers/airbyte -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] kazanzhy edited a comment on issue #19891: Re-enable MyPy

2021-12-13 Thread GitBox
kazanzhy edited a comment on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-991367061 Fix mypy in * airflow/providers/apache/beam - want to take * airflow/providers/apache/drill - #20268 * airflow/providers/apache/druid - #20270 *

[GitHub] [airflow] kazanzhy opened a new pull request #20270: Fix MyPy Errors for Apache Druid provider.

2021-12-13 Thread GitBox
kazanzhy opened a new pull request #20270: URL: https://github.com/apache/airflow/pull/20270 Fix MyPy Errors for Apache Druid provider. related: #19891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] ashb commented on issue #19891: Re-enable MyPy

2021-12-13 Thread GitBox
ashb commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-992959259 I'm looking at airflow/models and tests/models -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] ferruzzi commented on issue #20139: Restructure Amazon provider operators files

2021-12-13 Thread GitBox
ferruzzi commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-992954308 @eladkal Since we are making these changes and going to be deprecating old operators in favor of new ones, it may be a good time to address some standardization issues as

[GitHub] [airflow] github-actions[bot] commented on pull request #20268: Fix MyPy Errors for Apache Drill provider.

2021-12-13 Thread GitBox
github-actions[bot] commented on pull request #20268: URL: https://github.com/apache/airflow/pull/20268#issuecomment-992953163 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] pierrejeambrun edited a comment on issue #18641: Refactor OpsgenieAlertHook to official python sdk

2021-12-13 Thread GitBox
pierrejeambrun edited a comment on issue #18641: URL: https://github.com/apache/airflow/issues/18641#issuecomment-992754704 Hello @eladkal and @Arun-kc, There hasn't been much activity lately and I wanted to give this one a try, I hope you don't mind guys. You can find a

[GitHub] [airflow] pierrejeambrun edited a comment on issue #18641: Refactor OpsgenieAlertHook to official python sdk

2021-12-13 Thread GitBox
pierrejeambrun edited a comment on issue #18641: URL: https://github.com/apache/airflow/issues/18641#issuecomment-992754704 Hello @eladkal and @Arun-kc, There hasn't been much activity lately and I wanted to give this one a try, I hope you don't mind guys. You can find a

[GitHub] [airflow] potiuk commented on issue #19891: Re-enable MyPy

2021-12-13 Thread GitBox
potiuk commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-992952058 I already have a PR for that @khalidmammadov #19914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   3   4   >