[GitHub] [airflow] ashb commented on a diff in pull request #22332: Events Timetable

2022-04-04 Thread GitBox
ashb commented on code in PR #22332: URL: https://github.com/apache/airflow/pull/22332#discussion_r842372445 ## airflow/timetables/events.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] eladkal commented on issue #22731: Fix the order that tasks are displayed in Grid view

2022-04-04 Thread GitBox
eladkal commented on issue #22731: URL: https://github.com/apache/airflow/issues/22731#issuecomment-1088266869 i wonder if https://github.com/apache/airflow/issues/13044 share same root cause? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] eladkal commented on issue #22549: Status of testing of Apache Airflow 2.2.5rc3

2022-04-04 Thread GitBox
eladkal commented on issue #22549: URL: https://github.com/apache/airflow/issues/22549#issuecomment-1088266376 Closing since 2.2.5 was released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] eladkal closed issue #22549: Status of testing of Apache Airflow 2.2.5rc3

2022-04-04 Thread GitBox
eladkal closed issue #22549: Status of testing of Apache Airflow 2.2.5rc3 URL: https://github.com/apache/airflow/issues/22549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22744: double escape backslash in json

2022-04-04 Thread GitBox
boring-cyborg[bot] commented on PR #22744: URL: https://github.com/apache/airflow/pull/22744#issuecomment-1088262794 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] karunpoudel opened a new pull request, #22744: double escape backslash in json

2022-04-04 Thread GitBox
karunpoudel opened a new pull request, #22744: URL: https://github.com/apache/airflow/pull/22744 closes: #22702 double escape backslash in json so that it is interpreted correctly by JS --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] hankehly commented on issue #22708: Rewrite Airflow CLI commands with Click

2022-04-04 Thread GitBox
hankehly commented on issue #22708: URL: https://github.com/apache/airflow/issues/22708#issuecomment-1088192436 @blag I will take `celery` and `cheat_sheet` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] wyattshapiro commented on pull request #18615: fix template string passed to env_vars when using render_template_as_native_obj for Kubernetes Pod Operator and add Tests

2022-04-04 Thread GitBox
wyattshapiro commented on PR #18615: URL: https://github.com/apache/airflow/pull/18615#issuecomment-1088189781 Commenting so this fix doesn't get stale! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] hankehly commented on issue #22174: Support log download in task log view

2022-04-04 Thread GitBox
hankehly commented on issue #22174: URL: https://github.com/apache/airflow/issues/22174#issuecomment-1088187355 @euccas @mik-laj I can take this if you don't mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] collinmcnulty commented on pull request #22332: Events Timetable

2022-04-04 Thread GitBox
collinmcnulty commented on PR #22332: URL: https://github.com/apache/airflow/pull/22332#issuecomment-1088167847 What this looks like in the UI ![Screen Shot 2022-04-04 at 8 00 39

[GitHub] [airflow] pingzh opened a new pull request, #22743: Assert run_as_user in test_localtaskjob_heartbeat

2022-04-04 Thread GitBox
pingzh opened a new pull request, #22743: URL: https://github.com/apache/airflow/pull/22743 since https://github.com/apache/airflow/compare/main...pingzh:pingzh-assert-run-as-user?expand=1#diff-9ab60a212a536338d53065bf8542ef72473ce7ec99f4b2c35fb22b6d1b876c4bR148 depends on the

[GitHub] [airflow] pingzh commented on a diff in pull request #21877: AIP-45 Remove dag parsing in airflow run local

2022-04-04 Thread GitBox
pingzh commented on code in PR #21877: URL: https://github.com/apache/airflow/pull/21877#discussion_r842247464 ## airflow/models/taskinstance.py: ## @@ -710,6 +670,26 @@ def mark_success_url(self): "=success" ) +def current_pid(self) -> str: Review

[GitHub] [airflow] hankehly commented on issue #22336: `airflow dags backfill` command doesn't propagate DagRun conf attribute if the DagRun already exists

2022-04-04 Thread GitBox
hankehly commented on issue #22336: URL: https://github.com/apache/airflow/issues/22336#issuecomment-1088149845 @nominee1997 I haven't looked through the code, but the cli docs show a `--reset-dagruns` flag that may be useful for this purpose. Have you experimented with this? > If

[GitHub] [airflow] hankehly commented on issue #22473: Connections import and export should also support ".yml" file extensions

2022-04-04 Thread GitBox
hankehly commented on issue #22473: URL: https://github.com/apache/airflow/issues/22473#issuecomment-1088145793 @jackemuk @potiuk I will take this if no one minds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] github-actions[bot] closed issue #21007: Run task - crashed

2022-04-04 Thread GitBox
github-actions[bot] closed issue #21007: Run task - crashed URL: https://github.com/apache/airflow/issues/21007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] github-actions[bot] commented on issue #21007: Run task - crashed

2022-04-04 Thread GitBox
github-actions[bot] commented on issue #21007: URL: https://github.com/apache/airflow/issues/21007#issuecomment-1088140677 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #21106: Fix StatD timing metric units

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #21106: URL: https://github.com/apache/airflow/pull/21106#issuecomment-1088140583 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #21560: Add template_fields and constructor parameters to displaying

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #21560: URL: https://github.com/apache/airflow/pull/21560#issuecomment-1088140525 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #21650: Return string type if picking is disabled

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #21650: URL: https://github.com/apache/airflow/pull/21650#issuecomment-1088140472 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] github-actions[bot] commented on pull request #21666: Change upgrade to init

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #21666: URL: https://github.com/apache/airflow/pull/21666#issuecomment-1088140433 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] eprj453 commented on a diff in pull request #22711: Fix Localexecutor's parallelism option

2022-04-04 Thread GitBox
eprj453 commented on code in PR #22711: URL: https://github.com/apache/airflow/pull/22711#discussion_r842229817 ## airflow/executors/local_executor.py: ## @@ -349,7 +349,7 @@ def start(self) -> None: self.workers_active = 0 self.impl = (

[GitHub] [airflow] houqp commented on pull request #22701: Fixed backfill interference with scheduler

2022-04-04 Thread GitBox
houqp commented on PR #22701: URL: https://github.com/apache/airflow/pull/22701#issuecomment-1088106992 @potiuk test added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] github-actions[bot] commented on pull request #22092: Find Pod Before Cleanup In KubernetesPodOperator Execution

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #22092: URL: https://github.com/apache/airflow/pull/22092#issuecomment-1088100387 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[airflow] branch constraints-main updated: Updating constraints. Build id:2092763581

2022-04-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 6c4dd19e1f Updating

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22676: Fix helm name override

2022-04-04 Thread GitBox
jedcunningham commented on code in PR #22676: URL: https://github.com/apache/airflow/pull/22676#discussion_r842161743 ## chart/values.schema.json: ## @@ -799,8 +799,8 @@ "x-docsSection": "Airflow", "default": null, "examples": [ -

[GitHub] [airflow] houqp commented on a diff in pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-04 Thread GitBox
houqp commented on code in PR #22699: URL: https://github.com/apache/airflow/pull/22699#discussion_r842193390 ## airflow/models/dag.py: ## @@ -2347,6 +2352,19 @@ def create_dagrun( creating_job_id=creating_job_id, data_interval=data_interval,

[GitHub] [airflow] houqp commented on a diff in pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-04 Thread GitBox
houqp commented on code in PR #22699: URL: https://github.com/apache/airflow/pull/22699#discussion_r842193253 ## airflow/models/dag.py: ## @@ -2347,6 +2352,19 @@ def create_dagrun( creating_job_id=creating_job_id, data_interval=data_interval,

[GitHub] [airflow] mik-laj commented on a diff in pull request #22284: Move the database configuration to a new section

2022-04-04 Thread GitBox
mik-laj commented on code in PR #22284: URL: https://github.com/apache/airflow/pull/22284#discussion_r842181809 ## chart/templates/_helpers.yaml: ## @@ -44,13 +44,21 @@ If release name contains chart name it will be used as a full name. name: {{ template

[GitHub] [airflow] mik-laj commented on a diff in pull request #22284: Move the database configuration to a new section

2022-04-04 Thread GitBox
mik-laj commented on code in PR #22284: URL: https://github.com/apache/airflow/pull/22284#discussion_r842180703 ## chart/templates/_helpers.yaml: ## @@ -44,13 +44,21 @@ If release name contains chart name it will be used as a full name. name: {{ template

[GitHub] [airflow] bbovenzi opened a new pull request, #22742: Improve selection rerenders

2022-04-04 Thread GitBox
bbovenzi opened a new pull request, #22742: URL: https://github.com/apache/airflow/pull/22742 When creating a context provider for what task instance or dag run was selected, it broke some of the memoization and too many components were rerendering whenever a user clicked on a new

[GitHub] [airflow] ashb opened a new pull request, #22741: Show tasks in grid view based on topological sort.

2022-04-04 Thread GitBox
ashb opened a new pull request, #22741: URL: https://github.com/apache/airflow/pull/22741 This takes the existing topological sort that existed on a DAG and moves it down to TaskGroup. In order to do this (and not have duplicated sort) the existing sort on DAG is re-implemented

[airflow] branch improve-grid-data created (now de2d5c380e)

2022-04-04 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch improve-grid-data in repository https://gitbox.apache.org/repos/asf/airflow.git at de2d5c380e Improve selection rerenders This branch includes the following new commits: new

[airflow] 01/01: Improve selection rerenders

2022-04-04 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch improve-grid-data in repository https://gitbox.apache.org/repos/asf/airflow.git commit de2d5c380e25e233bbc1b1be2945c9e241f8d6d6 Author: Brent Bovenzi AuthorDate: Mon Apr 4 18:08:23 2022 -0400

[airflow] branch main updated: Unvendor cgroupspy (#22736)

2022-04-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f2bdce47df Unvendor cgroupspy (#22736) f2bdce47df

[GitHub] [airflow] potiuk merged pull request #22736: Unvendor cgroupspy

2022-04-04 Thread GitBox
potiuk merged PR #22736: URL: https://github.com/apache/airflow/pull/22736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] michaelmicheal commented on a diff in pull request #22092: Find Pod Before Cleanup In KubernetesPodOperator Execution

2022-04-04 Thread GitBox
michaelmicheal commented on code in PR #22092: URL: https://github.com/apache/airflow/pull/22092#discussion_r842172165 ## tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py: ## @@ -776,7 +811,7 @@ def test_previous_pods_ignored_for_reattached(self):

[GitHub] [airflow] dstandish commented on issue #22684: Kubernetes client returns completed pod instead of running ones

2022-04-04 Thread GitBox
dstandish commented on issue #22684: URL: https://github.com/apache/airflow/issues/22684#issuecomment-1088053778 yeah @jedcunningham @potiuk it seems that adding this change (_always_ patching) causes tests to fail because they don't expect the "already checked" label

[GitHub] [airflow] potiuk commented on pull request #22740: Switch to `pipx` as the only installation Breeze2 method

2022-04-04 Thread GitBox
potiuk commented on PR #22740: URL: https://github.com/apache/airflow/pull/22740#issuecomment-1088053260 cc: @Bowrna @edithturn - > one more thing before the prime time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on pull request #22740: Switch to `pipx` as the only installation Breeze2 method

2022-04-04 Thread GitBox
potiuk commented on PR #22740: URL: https://github.com/apache/airflow/pull/22740#issuecomment-1088052284 Hey @uranusjr - it's about the time we switch to the new Breeze and after trying various behaviours, I think the idea of only using `pipx` for installation that you advoceated for is

[GitHub] [airflow] dstandish commented on issue #22684: Kubernetes client returns completed pod instead of running ones

2022-04-04 Thread GitBox
dstandish commented on issue #22684: URL: https://github.com/apache/airflow/issues/22684#issuecomment-1088051924 @potiuk i plan to "fix" this (see https://github.com/apache/airflow/pull/22734) but that said, (and the the reason i that in quotes is...) this does not appear to be a

[GitHub] [airflow] potiuk opened a new pull request, #22740: Switch to `pipx` as the only installation Breeze2 method

2022-04-04 Thread GitBox
potiuk opened a new pull request, #22740: URL: https://github.com/apache/airflow/pull/22740 Switching Breeze2 to only use `pipx` for installation of Breeze2 due to problems it might cause for autocompletion if entrypoint is not avaiable on PATH. --- **^ Add meaningful

[GitHub] [airflow] MatrixManAtYrService commented on issue #22561: Mapped task is not expanded when mapped against a literal

2022-04-04 Thread GitBox
MatrixManAtYrService commented on issue #22561: URL: https://github.com/apache/airflow/issues/22561#issuecomment-1088039171 I ran into this a second time, except this time I was also getting: ``` sqlalchemy.exc.IntegrityError: (sqlite3.IntegrityError) FOREIGN KEY constraint failed

[airflow] branch constraints-main updated: Updating constraints. Build id:2092485957

2022-04-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new f8c0abfdb0 Updating

[GitHub] [airflow] eladkal closed issue #15952: DockerOperator tries to push bytes to XCom, fails to serialize

2022-04-04 Thread GitBox
eladkal closed issue #15952: DockerOperator tries to push bytes to XCom, fails to serialize URL: https://github.com/apache/airflow/issues/15952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] eladkal commented on issue #15952: DockerOperator tries to push bytes to XCom, fails to serialize

2022-04-04 Thread GitBox
eladkal commented on issue #15952: URL: https://github.com/apache/airflow/issues/15952#issuecomment-1088035262 Great  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22092: Find Pod Before Cleanup In KubernetesPodOperator Execution

2022-04-04 Thread GitBox
jedcunningham commented on code in PR #22092: URL: https://github.com/apache/airflow/pull/22092#discussion_r842154969 ## tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py: ## @@ -211,7 +211,7 @@ def test_find_pod_labels(self): do_xcom_push=False,

[GitHub] [airflow] kurtqq commented on pull request #21942: Improve ElasticsearchTaskHandler

2022-04-04 Thread GitBox
kurtqq commented on PR #21942: URL: https://github.com/apache/airflow/pull/21942#issuecomment-1088029267 This is a very needed fix. What is the status of the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22739: Raise exception if src file does not exist while using LocalFilesystemToGCSOperator

2022-04-04 Thread GitBox
boring-cyborg[bot] commented on PR #22739: URL: https://github.com/apache/airflow/pull/22739#issuecomment-1088022109 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] gitstart opened a new pull request, #22739: Raise exception if src file does not exist while using LocalFilesystemToGCSOperator

2022-04-04 Thread GitBox
gitstart opened a new pull request, #22739: URL: https://github.com/apache/airflow/pull/22739 closes: #22705 This PR provides an exception if the src file does not exist while copying file from src to dest using the LocalFilesystemToGCSOperator. --- **^ Add meaningful

[airflow] branch main updated: Docs: Fix example usage for `AzureCosmosDocumentSensor` (#22735)

2022-04-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d3976d9b20 Docs: Fix example usage for

[GitHub] [airflow] kaxil merged pull request #22735: Docs: Fix example usage for `AzureCosmosDocumentSensor`

2022-04-04 Thread GitBox
kaxil merged PR #22735: URL: https://github.com/apache/airflow/pull/22735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] michaelmicheal commented on a diff in pull request #22092: Find Pod Before Cleanup In KubernetesPodOperator Execution

2022-04-04 Thread GitBox
michaelmicheal commented on code in PR #22092: URL: https://github.com/apache/airflow/pull/22092#discussion_r842133286 ## tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py: ## @@ -211,7 +211,7 @@ def test_find_pod_labels(self): do_xcom_push=False,

[GitHub] [airflow] pierrejeambrun commented on pull request #22671: Support for sorting DAGs in the web UI

2022-04-04 Thread GitBox
pierrejeambrun commented on PR #22671: URL: https://github.com/apache/airflow/pull/22671#issuecomment-1088001036 `nullslast` func is creating a syntax error (sqlalchemy) with `mysql`. An alternative as `order_by(column.is_(None), column)` is creating a syntax on `mssql`. I am

[GitHub] [airflow] MatrixManAtYrService commented on issue #22626: The command 'airflow dags test' is deadlocking tasks using AIP-42 features with the PythonVirtualenvOperator

2022-04-04 Thread GitBox
MatrixManAtYrService commented on issue #22626: URL: https://github.com/apache/airflow/issues/22626#issuecomment-1088000204 Same thing with DockerOperator ```python3 from airflow.decorators import dag from airflow.operators.docker_operator import DockerOperator from datetime

[GitHub] [airflow] m1racoli opened a new issue, #22738: Webserver doesn't mask rendered fields for pending tasks

2022-04-04 Thread GitBox
m1racoli opened a new issue, #22738: URL: https://github.com/apache/airflow/issues/22738 ### Apache Airflow version 2.2.5 (latest released) ### What happened When triggering a new dagrun the webserver will not mask secrets in the rendered fields for that dagrun's tasks

[GitHub] [airflow] MatrixManAtYrService commented on issue #15952: DockerOperator tries to push bytes to XCom, fails to serialize

2022-04-04 Thread GitBox
MatrixManAtYrService commented on issue #15952: URL: https://github.com/apache/airflow/issues/15952#issuecomment-1087989165 @eladkal It appears to have been fixed: ``` ❯ pip freeze | grep apache-airflow apache-airflow==2.2.5 apache-airflow-providers-docker==2.5.2

[GitHub] [airflow] vincbeck opened a new pull request, #22737: Deprecate S3PrefixSensor

2022-04-04 Thread GitBox
vincbeck opened a new pull request, #22737: URL: https://github.com/apache/airflow/pull/22737 Deprecate `S3PrefixSensor` and use `S3KeySensor` instead. ## Why deprecating `S3PrefixSensor`? `S3PrefixSensor` and `S3KeySensor` are doing pretty much the same thing so to avoid

[GitHub] [airflow] github-actions[bot] commented on pull request #22712: Add support for topologySpreadConstraints to Helm Chart

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #22712: URL: https://github.com/apache/airflow/pull/22712#issuecomment-1087963251 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22092: Find Pod Before Cleanup In KubernetesPodOperator Execution

2022-04-04 Thread GitBox
jedcunningham commented on code in PR #22092: URL: https://github.com/apache/airflow/pull/22092#discussion_r842091082 ## tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py: ## @@ -211,7 +211,7 @@ def test_find_pod_labels(self): do_xcom_push=False,

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22735: Docs: Fix example usage for `AzureCosmosDocumentSensor`

2022-04-04 Thread GitBox
jedcunningham commented on code in PR #22735: URL: https://github.com/apache/airflow/pull/22735#discussion_r842087495 ## airflow/providers/microsoft/azure/sensors/cosmos.py: ## @@ -31,12 +31,12 @@ class AzureCosmosDocumentSensor(BaseSensorOperator): .. code-block:: -

[GitHub] [airflow] github-actions[bot] commented on pull request #22735: Docs: Fix example usage for `AzureCosmosDocumentSensor`

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #22735: URL: https://github.com/apache/airflow/pull/22735#issuecomment-1087950577 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] collinmcnulty commented on a diff in pull request #22332: Events Timetable

2022-04-04 Thread GitBox
collinmcnulty commented on code in PR #22332: URL: https://github.com/apache/airflow/pull/22332#discussion_r842084405 ## airflow/timetables/events.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[airflow] branch clean-grid-data updated: Improve selection rerenders

2022-04-04 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch clean-grid-data in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/clean-grid-data by this push: new 9f1f7d19f1 Improve

[GitHub] [airflow] collinmcnulty commented on a diff in pull request #22332: Events Timetable

2022-04-04 Thread GitBox
collinmcnulty commented on code in PR #22332: URL: https://github.com/apache/airflow/pull/22332#discussion_r842082450 ## airflow/timetables/events.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] potiuk commented on pull request #22685: Fix processor cleanup on DagFileProcessorManager

2022-04-04 Thread GitBox
potiuk commented on PR #22685: URL: https://github.com/apache/airflow/pull/22685#issuecomment-1087932139 I guess fixing static checks and tests failing since you asked. But I think GitHub already told you so by all the notificaitons and you can see it in the red status of the PR. --

[GitHub] [airflow] ashb commented on a diff in pull request #22332: Events Timetable

2022-04-04 Thread GitBox
ashb commented on code in PR #22332: URL: https://github.com/apache/airflow/pull/22332#discussion_r842067721 ## airflow/timetables/events.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] ashb commented on a diff in pull request #22332: Events Timetable

2022-04-04 Thread GitBox
ashb commented on code in PR #22332: URL: https://github.com/apache/airflow/pull/22332#discussion_r842068258 ## airflow/timetables/events.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] pcolladosoto commented on pull request #22685: Fix processor cleanup on DagFileProcessorManager

2022-04-04 Thread GitBox
pcolladosoto commented on PR #22685: URL: https://github.com/apache/airflow/pull/22685#issuecomment-1087929858 Hi @potiuk! Is there anything else that needs to be done on my end? 樂 Thanks for your time! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] michaelmicheal commented on pull request #22092: Find Pod Before Cleanup In KubernetesPodOperator Execution

2022-04-04 Thread GitBox
michaelmicheal commented on PR #22092: URL: https://github.com/apache/airflow/pull/22092#issuecomment-1087927819 @potiuk @jedcunningham Is it possible to get approval to run all the CI workflows? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] houqp commented on pull request #22698: support dag serialization with custom ti_deps rules

2022-04-04 Thread GitBox
houqp commented on PR #22698: URL: https://github.com/apache/airflow/pull/22698#issuecomment-1087910743 I remember during the initial implementation, @ashb mentioned it was introduced to reduce serialized DAG size. But good to double check with him :) > I believe this one allows

[GitHub] [airflow] github-actions[bot] commented on pull request #22736: Unvendor cgroupspy

2022-04-04 Thread GitBox
github-actions[bot] commented on PR #22736: URL: https://github.com/apache/airflow/pull/22736#issuecomment-1087910198 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the

[GitHub] [airflow] houqp commented on pull request #22701: Fixed backfill interference with scheduler

2022-04-04 Thread GitBox
houqp commented on PR #22701: URL: https://github.com/apache/airflow/pull/22701#issuecomment-1087904184 > Why do you change states to NONE ? Were the tests wrong to create dagruns in RUNNING state in those tests. Yeah, we think it's a bug to allow running backfill against an active

[GitHub] [airflow] potiuk opened a new pull request, #22736: Unvendor cgroupspy

2022-04-04 Thread GitBox
potiuk opened a new pull request, #22736: URL: https://github.com/apache/airflow/pull/22736 The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible. We can remove vendoring done as of #22209 #22208 #2207 #22206 Discussion and links: *

[GitHub] [airflow] kaxil opened a new pull request, #22735: Docs: Fix example usage for `AzureCosmosDocumentSensor`

2022-04-04 Thread GitBox
kaxil opened a new pull request, #22735: URL: https://github.com/apache/airflow/pull/22735 **Before**: https://user-images.githubusercontent.com/8811558/161610535-3f636c3d-e78b-467a-962f-573a8e66e7e1.png;> **After**:

[GitHub] [airflow] dstandish opened a new pull request, #22734: KubernetesPodOperator should patch "already checked" always

2022-04-04 Thread GitBox
dstandish opened a new pull request, #22734: URL: https://github.com/apache/airflow/pull/22734 When not configured to delete pods, at end of task execution the current behavior is to patch the pod as "already checked", but only if pod not successful. We should also patch when successful

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #22679: Expand mapped tasks at DagRun.Veriy_integrity

2022-04-04 Thread GitBox
ephraimbuddy commented on code in PR #22679: URL: https://github.com/apache/airflow/pull/22679#discussion_r842009931 ## airflow/models/dagrun.py: ## @@ -839,25 +839,43 @@ def task_filter(task: "Operator") -> bool: if hook_is_noop: -def

[GitHub] [airflow] gkarg commented on issue #21087: KubernetesJobWatcher failing on HTTP 410 errors, jobs stuck in scheduled state

2022-04-04 Thread GitBox
gkarg commented on issue #21087: URL: https://github.com/apache/airflow/issues/21087#issuecomment-1087870738 > I have the same issue. > > Looks like it is happening, because they are now(don't know from which version) handling 410 error on kubernetes library side, there is one retry

[GitHub] [airflow] eladkal commented on pull request #22391: Update the redshift sql operator to accept multiple sql statements

2022-04-04 Thread GitBox
eladkal commented on PR #22391: URL: https://github.com/apache/airflow/pull/22391#issuecomment-1087869349 I think we should revive https://github.com/apache/airflow/pull/17329 It should solve the missing functionality from the root. Then it would be very easy to add it for

[GitHub] [airflow] eladkal commented on issue #15670: Pod overrides not working

2022-04-04 Thread GitBox
eladkal commented on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-1087863430 @Jaxing can you please check if the issue still happens with latest Airflow/Kubernetes provider? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] 2ps commented on issue #17127: Airflow 2.1.0 with Schedulers HA Failing

2022-04-04 Thread GitBox
2ps commented on issue #17127: URL: https://github.com/apache/airflow/issues/17127#issuecomment-1087862702 [This solution worked for us](https://stackoverflow.com/questions/70433532/run-airflow-ha-scheduler-as-systemd-services) -- we use mysql 8.0.21, and switching to mysqlclient isntead

[GitHub] [airflow] eladkal commented on issue #15952: DockerOperator tries to push bytes to XCom, fails to serialize

2022-04-04 Thread GitBox
eladkal commented on issue #15952: URL: https://github.com/apache/airflow/issues/15952#issuecomment-1087861981 @MatrixManAtYrService can you check if the issue still reproducible with latest docker provider? There were some fixes related to Xcoms -- This is an automated message from

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #22679: Expand mapped tasks at DagRun.Veriy_integrity

2022-04-04 Thread GitBox
ephraimbuddy commented on code in PR #22679: URL: https://github.com/apache/airflow/pull/22679#discussion_r842009931 ## airflow/models/dagrun.py: ## @@ -839,25 +839,43 @@ def task_filter(task: "Operator") -> bool: if hook_is_noop: -def

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #22679: Expand mapped tasks at DagRun.Veriy_integrity

2022-04-04 Thread GitBox
ephraimbuddy commented on code in PR #22679: URL: https://github.com/apache/airflow/pull/22679#discussion_r842009713 ## airflow/models/dagrun.py: ## @@ -839,25 +839,43 @@ def task_filter(task: "Operator") -> bool: if hook_is_noop: -def

[GitHub] [airflow] ashb commented on a diff in pull request #22679: Expand mapped tasks at DagRun.Veriy_integrity

2022-04-04 Thread GitBox
ashb commented on code in PR #22679: URL: https://github.com/apache/airflow/pull/22679#discussion_r841996761 ## airflow/models/dagrun.py: ## @@ -839,25 +839,43 @@ def task_filter(task: "Operator") -> bool: if hook_is_noop: -def create_ti_mapping(task:

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ 583f4122f137d10fa0891e39d9cf1c626a2b2b7e 

2022-04-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/gh-pages by this push: new 3b97cba44 Deploying to gh-pages

[airflow-site] branch main updated: Update changelog date for Apache Airflow 2.2.5 (#571)

2022-04-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 583f4122f Update changelog date for

[GitHub] [airflow-site] ephraimbuddy merged pull request #571: Update changelog date for Apache Airflow 2.2.5

2022-04-04 Thread GitBox
ephraimbuddy merged PR #571: URL: https://github.com/apache/airflow-site/pull/571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow-site] 01/01: Update changelog date for Apache Airflow 2.2.5

2022-04-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch update-2.2.5-changelog in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit e99ca602af01f94a50405d85c2c55fbb7a0f5619 Author: Ephraim Anierobi AuthorDate: Mon Apr 4

[airflow-site] branch update-2.2.5-changelog updated (03eba384f -> e99ca602a)

2022-04-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch update-2.2.5-changelog in repository https://gitbox.apache.org/repos/asf/airflow-site.git discard 03eba384f Update changelog date for Apache Airflow 2.2.5 add 0376d4822 Announce

[airflow-site] branch update-2.2.5-changelog created (now 03eba384f)

2022-04-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch update-2.2.5-changelog in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 03eba384f Update changelog date for Apache Airflow 2.2.5 This branch includes the

[airflow-site] 01/01: Update changelog date for Apache Airflow 2.2.5

2022-04-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch update-2.2.5-changelog in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 03eba384f769912124bb0e5890e8c1a28a9b20f4 Author: Ephraim Anierobi AuthorDate: Mon Apr 4

[GitHub] [airflow] jedcunningham commented on issue #22684: Kubernetes client returns completed pod instead of running ones

2022-04-04 Thread GitBox
jedcunningham commented on issue #22684: URL: https://github.com/apache/airflow/issues/22684#issuecomment-1087807901 Spotted the issue. We should apply the "already checked" label regardless of the pod state in `cleanup` (also in the `else`, not just in the `if`):

[GitHub] [airflow] dstandish commented on pull request #22607: Enable use of custom conn extra fields without prefix

2022-04-04 Thread GitBox
dstandish commented on PR #22607: URL: https://github.com/apache/airflow/pull/22607#issuecomment-1087785963 > Needs rebase (FAB upgrade) ok done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] dstandish commented on pull request #22086: [FEATURE] KPO add optional K8S hook

2022-04-04 Thread GitBox
dstandish commented on PR #22086: URL: https://github.com/apache/airflow/pull/22086#issuecomment-1087781513 I am currently in progress on it @raphaelauv and raised discussion on dev list about the approach with respect to deprecations. -- This is an automated message from the Apache Git

[GitHub] [airflow] dstandish commented on issue #22684: Kubernetes client returns completed pod instead of running ones

2022-04-04 Thread GitBox
dstandish commented on issue #22684: URL: https://github.com/apache/airflow/issues/22684#issuecomment-1087780415 This is an interesting case. I'm not sure what should really be the behavior here, because KPO was designed to reattach to pods. @MioNok have you considered setting

[GitHub] [airflow] raphaelauv commented on pull request #22086: [FEATURE] KPO add optional K8S hook

2022-04-04 Thread GitBox
raphaelauv commented on PR #22086: URL: https://github.com/apache/airflow/pull/22086#issuecomment-1087779377 @dstandish what do you think ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] josh-fell commented on issue #22730: dbt Cloud Provider only works for Multi-tenant instances

2022-04-04 Thread GitBox
josh-fell commented on issue #22730: URL: https://github.com/apache/airflow/issues/22730#issuecomment-1087779296 @ernestoongaro All yours! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] dstandish commented on issue #22684: Kubernetes client returns completed pod instead of running ones

2022-04-04 Thread GitBox
dstandish commented on issue #22684: URL: https://github.com/apache/airflow/issues/22684#issuecomment-1087775847 lemme see here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch v2-2-stable updated: Update Airflow 2.2.5 release date on Changelog (#22732)

2022-04-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-2-stable in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v2-2-stable by this push: new 718e44037e Update Airflow

[GitHub] [airflow] ephraimbuddy merged pull request #22732: Update Airflow 2.2.5 release date on Changelog

2022-04-04 Thread GitBox
ephraimbuddy merged PR #22732: URL: https://github.com/apache/airflow/pull/22732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >