[GitHub] [airflow] uranusjr commented on pull request #33242: Index optimized fast path to avoid slower groupby queryplan

2023-08-14 Thread via GitHub
uranusjr commented on PR #33242: URL: https://github.com/apache/airflow/pull/33242#issuecomment-1678457291 I think we need a test case to cover the one DAG case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[airflow] 06/07: Fix eager upgrade failures for canary builds (#33395)

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 119407d81990e61a1983b287234f5806d70efdf0 Author: Jarek Potiuk AuthorDate: Mon Aug 14 22:09:52 2023 +0200

[airflow] 05/07: Restore `--builder` command for cache building (#33387)

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit bade0efeb9efa59fe92c35b1f253bb932170d7c0 Author: Jarek Potiuk AuthorDate: Mon Aug 14 11:26:44 2023 +0200

[airflow] 04/07: Add better instructions to constraint files (#33367)

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit f170861c4315846ffcda3a885f5e3dbb737b136b Author: Jarek Potiuk AuthorDate: Mon Aug 14 17:59:26 2023 +0200

[airflow] branch v2-7-test updated (66072ce433 -> 206699d059)

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit 66072ce433 fixup! Update RELEASE_NOTES.rst new 21ecb41ff6 Bring back the decision buttons on DAG

[airflow] 01/07: Bring back the decision buttons on DAG trigger (#33394)

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 21ecb41ff6a06a4d9fb34a96b5ef1fb469e7b4f0 Author: Ephraim Anierobi AuthorDate: Mon Aug 14 21:58:53 2023

[airflow] 07/07: fixup! Update RELEASE_NOTES.rst

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 206699d059264b3c2ed5c7bb67e2960f4e592998 Author: Ephraim Anierobi AuthorDate: Mon Aug 14 12:16:57 2023

[GitHub] [airflow] Taragolis commented on a diff in pull request #32919: Fix `link_names` parameter not being passed to hook in `SlackWebhookOperator`

2023-08-14 Thread via GitHub
Taragolis commented on code in PR #32919: URL: https://github.com/apache/airflow/pull/32919#discussion_r1294197241 ## airflow/providers/slack/operators/slack_webhook.py: ## @@ -169,6 +169,6 @@ def execute(self, context: Context) -> None: username=self.username,

[airflow] branch main updated: Enable D205 Support (#33398)

2023-08-14 Thread ferruzzi
This is an automated email from the ASF dual-hosted git repository. ferruzzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a1e42f6626 Enable D205 Support (#33398)

[GitHub] [airflow] ferruzzi merged pull request #33398: Enable D205 Support

2023-08-14 Thread via GitHub
ferruzzi merged PR #33398: URL: https://github.com/apache/airflow/pull/33398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #33309: Limit connection resources used in mapped tasks

2023-08-14 Thread via GitHub
uranusjr commented on PR #33309: URL: https://github.com/apache/airflow/pull/33309#issuecomment-1678419127 I’m having second thoughts. If this works, why can’t we just pass the `session` all the way from `_run_raw_task` into `render_template_fields` instead? The fact we could not do this

[GitHub] [airflow] ferruzzi commented on pull request #33398: Enable D205 Support

2023-08-14 Thread via GitHub
ferruzzi commented on PR #33398: URL: https://github.com/apache/airflow/pull/33398#issuecomment-1678407852 > Yay! I appreciate the reviews and suggestions you gave along the way! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] ferruzzi opened a new pull request, #33398: Enable D205 Support

2023-08-14 Thread via GitHub
ferruzzi opened a new pull request, #33398: URL: https://github.com/apache/airflow/pull/33398 Part of https://github.com/apache/airflow/issues/10742 D205 asserts that all docstrings must have a one-line summary ending in a period. If there is more than one sentence then there must be

[airflow] branch main updated: D205 Support - Stragglers (#33301)

2023-08-14 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9bf68adfa0 D205 Support - Stragglers (#33301)

[GitHub] [airflow] uranusjr merged pull request #33301: D205 Support - Stragglers

2023-08-14 Thread via GitHub
uranusjr merged PR #33301: URL: https://github.com/apache/airflow/pull/33301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a diff in pull request #33397: Remove `supports_ad_hoc_ti_run` from executor API

2023-08-14 Thread via GitHub
uranusjr commented on code in PR #33397: URL: https://github.com/apache/airflow/pull/33397#discussion_r1294139049 ## airflow/executors/base_executor.py: ## @@ -104,7 +104,6 @@ class BaseExecutor(LoggingMixin): :param parallelism: how many jobs should run at one time. Set

[GitHub] [airflow] Owen-CH-Leung commented on a diff in pull request #33306: Add istio test, use curl /quitquitquit to exit sidecar, and some othe…

2023-08-14 Thread via GitHub
Owen-CH-Leung commented on code in PR #33306: URL: https://github.com/apache/airflow/pull/33306#discussion_r1294127625 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -508,17 +522,21 @@ def await_container_completion(self, pod: V1Pod, container_name: str) ->

[GitHub] [airflow] github-actions[bot] commented on pull request #28525: Add CloudRunExecuteJobOperator

2023-08-14 Thread via GitHub
github-actions[bot] commented on PR #28525: URL: https://github.com/apache/airflow/pull/28525#issuecomment-1678253724 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[GitHub] [airflow] alexbegg commented on pull request #33359: Allow init_command in MySQL provider

2023-08-14 Thread via GitHub
alexbegg commented on PR #33359: URL: https://github.com/apache/airflow/pull/33359#issuecomment-1678234288 > It's quite ok to add an init_command when you initilalize the Hook - and with sql operator you can pass such parameter via hook_params, so that DAG authors could modify it.

[GitHub] [airflow] alexbegg commented on pull request #33359: Allow init_command in MySQL provider

2023-08-14 Thread via GitHub
alexbegg commented on PR #33359: URL: https://github.com/apache/airflow/pull/33359#issuecomment-1678224612 Ok, this is changed to a `MySqlHook` param now, and the PR description is updated -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] hussein-awala commented on a diff in pull request #33397: Remove `supports_ad_hoc_ti_run` from executor API

2023-08-14 Thread via GitHub
hussein-awala commented on code in PR #33397: URL: https://github.com/apache/airflow/pull/33397#discussion_r1294051849 ## airflow/executors/base_executor.py: ## @@ -104,7 +104,6 @@ class BaseExecutor(LoggingMixin): :param parallelism: how many jobs should run at one time.

[airflow] branch constraints-main updated: Updating constraints. Github run id:5860872471

2023-08-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 0dd87f3c9c Updating

[GitHub] [airflow] o-nikolas commented on pull request #33397: Remove `supports_ad_hoc_ti_run` from executor API

2023-08-14 Thread via GitHub
o-nikolas commented on PR #33397: URL: https://github.com/apache/airflow/pull/33397#issuecomment-1678195062 CC @bbovenzi @jedcunningham -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] o-nikolas opened a new pull request, #33397: Remove `supports_ad_hoc_ti_run` from executor API

2023-08-14 Thread via GitHub
o-nikolas opened a new pull request, #33397: URL: https://github.com/apache/airflow/pull/33397 The run task instance capability was removed from the Airflow UI and API in #29706 but the base executor interface and subclasses which support it was not updated. ![Screenshot from

[GitHub] [airflow] shubham22 commented on issue #21867: Retry for TaskGroup

2023-08-14 Thread via GitHub
shubham22 commented on issue #21867: URL: https://github.com/apache/airflow/issues/21867#issuecomment-1678147105 > I'd say retrying task groups is much closer to "Setup/teardown" than "notifications/listeners". And I know how much time it was spend on discussing the edge cases on

[GitHub] [airflow] functicons commented on pull request #33274: Add parameter sftp_prefetch to SFTPToGCSOperator

2023-08-14 Thread via GitHub
functicons commented on PR #33274: URL: https://github.com/apache/airflow/pull/33274#issuecomment-1678140336 Check failures have been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] o-nikolas commented on pull request #32256: Add Dataplex Data Quality operators.

2023-08-14 Thread via GitHub
o-nikolas commented on PR #32256: URL: https://github.com/apache/airflow/pull/32256#issuecomment-1678135612 Passes if I run the test with pytest in a breeze env though. So, I'm not quite sure yet what the issue is. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] o-nikolas commented on pull request #32256: Add Dataplex Data Quality operators.

2023-08-14 Thread via GitHub
o-nikolas commented on PR #32256: URL: https://github.com/apache/airflow/pull/32256#issuecomment-1678132479 Our internal CI has been failing since this PR was merged: ![Screenshot from 2023-08-14

[airflow] branch main updated: Add `deferrable` option to `LambdaCreateFunctionOperator` (#33327)

2023-08-14 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4d99705f69 Add `deferrable` option to

[GitHub] [airflow] vincbeck merged pull request #33327: Add `deferrable` option to `LambdaCreateFunctionOperator`

2023-08-14 Thread via GitHub
vincbeck merged PR #33327: URL: https://github.com/apache/airflow/pull/33327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #21867: Retry for TaskGroup

2023-08-14 Thread via GitHub
potiuk commented on issue #21867: URL: https://github.com/apache/airflow/issues/21867#issuecomment-1678064429 I think it's more @shubham22 - this is why I pointed it out as well. Just the level of comments up here and the need to show diagrams to explain the complexity is enough to

[airflow] branch main updated: Bring back the decision buttons on DAG trigger (#33394)

2023-08-14 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8cc68e244b Bring back the decision buttons

[GitHub] [airflow] jedcunningham merged pull request #33394: Bring back the decision buttons on DAG trigger

2023-08-14 Thread via GitHub
jedcunningham merged PR #33394: URL: https://github.com/apache/airflow/pull/33394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (35b18306a4 -> 08565dcb8b)

2023-08-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 35b18306a4 Fix DagFileProcessor interfering with dags outside its ``processor_subdir`` (#33357) add 08565dcb8b

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33388: Fix config description for base_log_folder

2023-08-14 Thread via GitHub
boring-cyborg[bot] commented on PR #33388: URL: https://github.com/apache/airflow/pull/33388#issuecomment-1678034846 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

[airflow] branch main updated (3857d3399c -> 35b18306a4)

2023-08-14 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 3857d3399c Fix eager upgrade failures for canary builds (#33395) add 35b18306a4 Fix DagFileProcessor

[GitHub] [airflow] potiuk merged pull request #33388: Fix config description for base_log_folder

2023-08-14 Thread via GitHub
potiuk merged PR #33388: URL: https://github.com/apache/airflow/pull/33388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] pierrejeambrun merged pull request #33357: Fix DagFileProcessor interfering with dags outside its ``processor_subdir``

2023-08-14 Thread via GitHub
pierrejeambrun merged PR #33357: URL: https://github.com/apache/airflow/pull/33357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #33388: Fix config description for base_log_folder

2023-08-14 Thread via GitHub
potiuk commented on PR #33388: URL: https://github.com/apache/airflow/pull/33388#issuecomment-1678034691 Yes. Sounds right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] pierrejeambrun commented on pull request #33357: Fix DagFileProcessor interfering with dags outside its ``processor_subdir``

2023-08-14 Thread via GitHub
pierrejeambrun commented on PR #33357: URL: https://github.com/apache/airflow/pull/33357#issuecomment-1678034553 Comment was adressed, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] functicons commented on pull request #33274: Add parameter sftp_prefetch to SFTPToGCSOperator

2023-08-14 Thread via GitHub
functicons commented on PR #33274: URL: https://github.com/apache/airflow/pull/33274#issuecomment-1678009297 @potiuk @ahidalgob could you give me a pointer on what the [static checks failure](https://github.com/apache/airflow/actions/runs/5827097545/job/15825732773?pr=33274) is about?

[airflow] branch main updated (b8cdd284dd -> 3857d3399c)

2023-08-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b8cdd284dd Add better instructions to constraint files (#33367) add 3857d3399c Fix eager upgrade failures for

[GitHub] [airflow] potiuk merged pull request #33395: Fix eager upgrade failures for canary builds

2023-08-14 Thread via GitHub
potiuk merged PR #33395: URL: https://github.com/apache/airflow/pull/33395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch fix-eager-upgrade-ci-failures updated (c51cde00da -> 63dbe54e0c)

2023-08-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch fix-eager-upgrade-ci-failures in repository https://gitbox.apache.org/repos/asf/airflow.git omit c51cde00da Fix eager upgrade failures for canary builds new 63dbe54e0c Fix eager upgrade

[airflow] 01/01: Fix eager upgrade failures for canary builds

2023-08-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch fix-eager-upgrade-ci-failures in repository https://gitbox.apache.org/repos/asf/airflow.git commit 63dbe54e0ceeac09ffcb06951cf8e178c9157a9d Author: Jarek Potiuk AuthorDate: Mon Aug 14 21:50:51

[GitHub] [airflow] potiuk opened a new pull request, #33395: Fix eager upgrade failures for canary builds

2023-08-14 Thread via GitHub
potiuk opened a new pull request, #33395: URL: https://github.com/apache/airflow/pull/33395 The canary builds continued failing after fixing aibotocore dependency limit. This was because the main build is now using "empty" eager upgrade requirements which override the embedded aiobotocore

[airflow] 01/01: Fix eager upgrade failures for canary builds

2023-08-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch fix-eager-upgrade-ci-failures in repository https://gitbox.apache.org/repos/asf/airflow.git commit c51cde00dad357655db56efd2c49c506c4400d18 Author: Jarek Potiuk AuthorDate: Mon Aug 14 21:50:51

[airflow] branch fix-eager-upgrade-ci-failures created (now c51cde00da)

2023-08-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch fix-eager-upgrade-ci-failures in repository https://gitbox.apache.org/repos/asf/airflow.git at c51cde00da Fix eager upgrade failures for canary builds This branch includes the following

[GitHub] [airflow] hussein-awala commented on pull request #33388: Fix config description for base_log_folder

2023-08-14 Thread via GitHub
hussein-awala commented on PR #33388: URL: https://github.com/apache/airflow/pull/33388#issuecomment-1677954152 @potiuk could you check it, just to be sure before merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] ephraimbuddy opened a new pull request, #33394: Bring back the decision buttons on DAG trigger

2023-08-14 Thread via GitHub
ephraimbuddy opened a new pull request, #33394: URL: https://github.com/apache/airflow/pull/33394 When show_trigger_form_if_no_params is set to True, the decision buttons to trigger with or without config should be shown just like we had it in 2.6.3 ![Screenshot 2023-08-14 at 20 11

[GitHub] [airflow] ananth-sabhapathi commented on issue #29897: Import error of new dags cannot be show on web ui for common users

2023-08-14 Thread via GitHub
ananth-sabhapathi commented on issue #29897: URL: https://github.com/apache/airflow/issues/29897#issuecomment-1677889928 Yes, @potiuk . Still we have this issue.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #33357: Fix DagFileProcessor interfering with dags outside its ``processor_subdir``

2023-08-14 Thread via GitHub
pierrejeambrun commented on code in PR #33357: URL: https://github.com/apache/airflow/pull/33357#discussion_r1293809443 ## airflow/models/dag.py: ## @@ -3555,16 +3555,26 @@ def set_is_paused(self, is_paused: bool, including_subdags: bool = True, session def

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #33357: Fix DagFileProcessor interfering with dags outside its ``processor_subdir``

2023-08-14 Thread via GitHub
pierrejeambrun commented on code in PR #33357: URL: https://github.com/apache/airflow/pull/33357#discussion_r1293809443 ## airflow/models/dag.py: ## @@ -3555,16 +3555,26 @@ def set_is_paused(self, is_paused: bool, including_subdags: bool = True, session def

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #33327: Add `deferrable` option to `LambdaCreateFunctionOperator`

2023-08-14 Thread via GitHub
vandonr-amz commented on code in PR #33327: URL: https://github.com/apache/airflow/pull/33327#discussion_r1293757825 ## airflow/providers/amazon/aws/operators/lambda_function.py: ## @@ -117,6 +144,13 @@ def execute(self, context: Context): return

[airflow] branch openlineage-do-not-redact-proxy updated (1663fd409e -> 40cbbdc924)

2023-08-14 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a change to branch openlineage-do-not-redact-proxy in repository https://gitbox.apache.org/repos/asf/airflow.git discard 1663fd409e openlineage: do not try to redact Proxy objects from deprecated config

[airflow] 01/01: openlineage: do not try to redact Proxy objects from deprecated config

2023-08-14 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a commit to branch openlineage-do-not-redact-proxy in repository https://gitbox.apache.org/repos/asf/airflow.git commit 40cbbdc9244804b412f04d70fef4c6c9e611b484 Author: Maciej Obuchowski AuthorDate: Mon Aug

[GitHub] [airflow] ephraimbuddy commented on issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3

2023-08-14 Thread via GitHub
ephraimbuddy commented on issue #33392: URL: https://github.com/apache/airflow/issues/33392#issuecomment-1677710963 > Thanks for the report. This has already been addressed and the main reason why we cancelled RC1 voting and we are going to have RC2. @potiuk , this seems different.

[GitHub] [airflow] potiuk commented on a diff in pull request #33309: Limit connection resources used in mapped tasks

2023-08-14 Thread via GitHub
potiuk commented on code in PR #33309: URL: https://github.com/apache/airflow/pull/33309#discussion_r1293735818 ## airflow/cli/commands/task_command.py: ## @@ -634,6 +635,12 @@ def task_test(args, dag: DAG | None = None) -> None: session.delete(ti.dag_run)

[GitHub] [airflow] potiuk commented on a diff in pull request #33309: Limit connection resources used in mapped tasks

2023-08-14 Thread via GitHub
potiuk commented on code in PR #33309: URL: https://github.com/apache/airflow/pull/33309#discussion_r1293729443 ## airflow/cli/commands/task_command.py: ## @@ -634,6 +635,12 @@ def task_test(args, dag: DAG | None = None) -> None: session.delete(ti.dag_run)

[GitHub] [airflow] ferruzzi commented on a diff in pull request #33301: D205 Support - Stragglers

2023-08-14 Thread via GitHub
ferruzzi commented on code in PR #33301: URL: https://github.com/apache/airflow/pull/33301#discussion_r1293728068 ## airflow/utils/setup_teardown.py: ## @@ -181,7 +181,10 @@ def _push_tasks(cls, operator: AbstractOperator | list[AbstractOperator], setup: @classmethod

[airflow] branch openlineage_fix_getting_dates_from_tis deleted (was d0cf447b89)

2023-08-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch openlineage_fix_getting_dates_from_tis in repository https://gitbox.apache.org/repos/asf/airflow.git was d0cf447b89 openlineage: defensively check for provided datetimes in listener

[GitHub] [airflow] vatsrahul1001 opened a new issue, #33392: Setting AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS = True redirecting to trigger form for every DAG instead of giving an option

2023-08-14 Thread via GitHub
vatsrahul1001 opened a new issue, #33392: URL: https://github.com/apache/airflow/issues/33392 ### Apache Airflow version 2.7.0rc1 ### What happened While Testing [PR](https://github.com/apache/airflow/pull/33351), i noticed after setting

[airflow] 02/02: openlineage: do not try to redact Proxy objects from deprecated config

2023-08-14 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a commit to branch openlineage-do-not-redact-proxy in repository https://gitbox.apache.org/repos/asf/airflow.git commit 1663fd409e937badf1bbace407920bed58826e3b Author: Maciej Obuchowski AuthorDate: Mon Aug

[airflow] branch openlineage-do-not-redact-proxy created (now 1663fd409e)

2023-08-14 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a change to branch openlineage-do-not-redact-proxy in repository https://gitbox.apache.org/repos/asf/airflow.git at 1663fd409e openlineage: do not try to redact Proxy objects from deprecated config

[airflow] 01/02: openlineage: don't run task instance listener in executor

2023-08-14 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a commit to branch openlineage-do-not-redact-proxy in repository https://gitbox.apache.org/repos/asf/airflow.git commit 1018746970e80506ca0e9e4f6358837335496418 Author: Maciej Obuchowski AuthorDate: Sun Aug

[airflow] 01/01: Merge branch 'main' into openlineage_dont_run_tis_executor

2023-08-14 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a commit to branch openlineage_dont_run_tis_executor in repository https://gitbox.apache.org/repos/asf/airflow.git commit 9cf049c471df34b9d27eba073b0ae1545276382c Merge: 62aec10394 b8cdd284dd Author: Maciej

[airflow] branch openlineage_dont_run_tis_executor updated (62aec10394 -> 9cf049c471)

2023-08-14 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a change to branch openlineage_dont_run_tis_executor in repository https://gitbox.apache.org/repos/asf/airflow.git from 62aec10394 openlineage: don't run task instance listener in executor add

[GitHub] [airflow] uranusjr commented on a diff in pull request #33309: Limit connection resources used in mapped tasks

2023-08-14 Thread via GitHub
uranusjr commented on code in PR #33309: URL: https://github.com/apache/airflow/pull/33309#discussion_r1293681019 ## airflow/cli/commands/task_command.py: ## @@ -634,6 +635,12 @@ def task_test(args, dag: DAG | None = None) -> None: session.delete(ti.dag_run)

[GitHub] [airflow] Dippatel98 commented on a diff in pull request #32846: Adding Support for Google Cloud's Data Pipelines Run Operator

2023-08-14 Thread via GitHub
Dippatel98 commented on code in PR #32846: URL: https://github.com/apache/airflow/pull/32846#discussion_r1293680430 ## docs/apache-airflow-providers-google/operators/cloud/datapipeline.rst: ## @@ -0,0 +1,60 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [airflow] joshowen commented on a diff in pull request #33242: Index optimized fast path to avoid slower groupby queryplan

2023-08-14 Thread via GitHub
joshowen commented on code in PR #33242: URL: https://github.com/apache/airflow/pull/33242#discussion_r1293671824 ## airflow/models/dag.py: ## @@ -2925,21 +2925,44 @@ def bulk_write_to_db( # Skip these queries entirely if no DAGs can be scheduled to save time.

[airflow] branch main updated: Add better instructions to constraint files (#33367)

2023-08-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b8cdd284dd Add better instructions to constraint

[GitHub] [airflow] potiuk merged pull request #33367: Add better instructions to constraint files

2023-08-14 Thread via GitHub
potiuk merged PR #33367: URL: https://github.com/apache/airflow/pull/33367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] fgalind1 commented on pull request #31066: Support naming customization on helm chart resources

2023-08-14 Thread via GitHub
fgalind1 commented on PR #31066: URL: https://github.com/apache/airflow/pull/31066#issuecomment-1677566653 I've just rebased as it had conflicts with a merge changed on the output-commands-hash.txt. Would you mind approving the workflows again pls? -- This is an automated message from

[GitHub] [airflow] eladkal commented on a diff in pull request #33219: Added Amazon SageMaker Notebook hook and operators

2023-08-14 Thread via GitHub
eladkal commented on code in PR #33219: URL: https://github.com/apache/airflow/pull/33219#discussion_r1293631985 ## airflow/providers/amazon/aws/hooks/sagemaker_notebook.py: ## Review Comment: So we shouldn't have `sagemake_notebook.py` -- This is an automated message

[GitHub] [airflow] vincbeck commented on pull request #33219: Added Amazon SageMaker Notebook hook and operators

2023-08-14 Thread via GitHub
vincbeck commented on PR #33219: URL: https://github.com/apache/airflow/pull/33219#issuecomment-1677548212 > Updated the PR with the suggested changes, except the file location for the operator. Open to feedback on whether to integrate into the existing sageMaker file, or leave as-is.

[GitHub] [airflow] ellisms commented on pull request #33219: Added Amazon SageMaker Notebook hook and operators

2023-08-14 Thread via GitHub
ellisms commented on PR #33219: URL: https://github.com/apache/airflow/pull/33219#issuecomment-1677545694 Updated the PR with the suggested changes, except the file location for the operator. Open to feedback on whether to integrate into the existing sageMaker file, or leave as-is. --

[GitHub] [airflow] ellisms commented on a diff in pull request #33219: Added Amazon SageMaker Notebook hook and operators

2023-08-14 Thread via GitHub
ellisms commented on code in PR #33219: URL: https://github.com/apache/airflow/pull/33219#discussion_r1293625104 ## airflow/providers/amazon/aws/operators/sagemaker_notebook.py: ## @@ -0,0 +1,287 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ellisms commented on a diff in pull request #33219: Added Amazon SageMaker Notebook hook and operators

2023-08-14 Thread via GitHub
ellisms commented on code in PR #33219: URL: https://github.com/apache/airflow/pull/33219#discussion_r1293620987 ## airflow/providers/amazon/aws/hooks/sagemaker_notebook.py: ## @@ -0,0 +1,153 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ellisms commented on a diff in pull request #33219: Added Amazon SageMaker Notebook hook and operators

2023-08-14 Thread via GitHub
ellisms commented on code in PR #33219: URL: https://github.com/apache/airflow/pull/33219#discussion_r1293619346 ## airflow/providers/amazon/aws/hooks/sagemaker_notebook.py: ## @@ -0,0 +1,153 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] vchiapaikeo commented on issue #32698: Triggerer Timeout Checks Cause Deadlocks when Multiple Scheduler Replicas Running at Peak

2023-08-14 Thread via GitHub
vchiapaikeo commented on issue #32698: URL: https://github.com/apache/airflow/issues/32698#issuecomment-1677503057 So it turns out that this issue actually stemmed from something completely unrelated. Our team will post a discussion / issue about that later. Long story short, we were using

[GitHub] [airflow] vchiapaikeo commented on pull request #33172: Skip trigger timeout check on occasional db deadlocks

2023-08-14 Thread via GitHub
vchiapaikeo commented on PR #33172: URL: https://github.com/apache/airflow/pull/33172#issuecomment-1677501450 So it turns out that this issue actually stemmed from something completely unrelated. Our team will post a discussion / issue about that later. Long story short, we were using

[GitHub] [airflow] vchiapaikeo closed pull request #33172: Skip trigger timeout check on occasional db deadlocks

2023-08-14 Thread via GitHub
vchiapaikeo closed pull request #33172: Skip trigger timeout check on occasional db deadlocks URL: https://github.com/apache/airflow/pull/33172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] amoghrajesh commented on pull request #19659: Mounted airflow_local_settings in helm jobs.

2023-08-14 Thread via GitHub
amoghrajesh commented on PR #19659: URL: https://github.com/apache/airflow/pull/19659#issuecomment-1677461819 This is an interesting issue. Picking it up so that I can complete it :). Do you mind @freget? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kolfild26 opened a new issue, #33391: SlackAPIPostOperator enhancement

2023-08-14 Thread via GitHub
kolfild26 opened a new issue, #33391: URL: https://github.com/apache/airflow/issues/33391 ### Description I would like to suggest changes in `SlackAPIPostOperator`. SlackAPIPostOperator is supposed to send message to Slack. Now, there is no responce left after the execution

[airflow] 01/01: fixup! Update RELEASE_NOTES.rst

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 66072ce43336276c0680e5e1d00d4f8575902121 Author: Ephraim Anierobi AuthorDate: Mon Aug 14 12:16:57 2023

[GitHub] [airflow] ephraimbuddy opened a new pull request, #33390: Sync v2-7-stable with v2-7-test to release 2.7.0

2023-08-14 Thread via GitHub
ephraimbuddy opened a new pull request, #33390: URL: https://github.com/apache/airflow/pull/33390 Time for `2.7.0rc2` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch constraints-2-7 updated: Updating constraints. Github run id:5856605767

2023-08-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-7 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-7 by this push: new 43a2d46249 Updating

[airflow] branch v2-7-test updated (56cc894a8e -> 66072ce433)

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git discard 56cc894a8e fixup! Update RELEASE_NOTES.rst new 66072ce433 fixup! Update RELEASE_NOTES.rst This

[GitHub] [airflow] amoghrajesh commented on pull request #25882: Prevent `KubernetesPodOperator` from finding pods with the wrong name

2023-08-14 Thread via GitHub
amoghrajesh commented on PR #25882: URL: https://github.com/apache/airflow/pull/25882#issuecomment-1677446052 Did this make it in? What is blocking it? I can take it to completion if nobody is working on it actively @XD-DENG -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] andylamp commented on pull request #32867: Sanitize the conn_id to disallow potential script execution

2023-08-14 Thread via GitHub
andylamp commented on PR #32867: URL: https://github.com/apache/airflow/pull/32867#issuecomment-1677421916 Great, thanks for the tips - I will try to work this out soon enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk commented on pull request #32867: Sanitize the conn_id to disallow potential script execution

2023-08-14 Thread via GitHub
potiuk commented on PR #32867: URL: https://github.com/apache/airflow/pull/32867#issuecomment-1677416839 > great @potiuk, thanks for the tip I will try to work this out. Does WTForms also handle CLI validation? Nope. But it's not needed, really - it's enough to raise exception in

[GitHub] [airflow] andylamp commented on pull request #32867: Sanitize the conn_id to disallow potential script execution

2023-08-14 Thread via GitHub
andylamp commented on PR #32867: URL: https://github.com/apache/airflow/pull/32867#issuecomment-1677411863 great @potiuk, thanks for the tip I will try to work this out. Does WTForms also handle CLI validation? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] uranusjr commented on a diff in pull request #33242: Index optimized fast path to avoid slower groupby queryplan

2023-08-14 Thread via GitHub
uranusjr commented on code in PR #33242: URL: https://github.com/apache/airflow/pull/33242#discussion_r1293530440 ## airflow/models/dag.py: ## @@ -2925,21 +2925,44 @@ def bulk_write_to_db( # Skip these queries entirely if no DAGs can be scheduled to save time.

[GitHub] [airflow] vincbeck commented on pull request #33044: Move methods from security managers to `FabAirflowSecurityManagerOverride`

2023-08-14 Thread via GitHub
vincbeck commented on PR #33044: URL: https://github.com/apache/airflow/pull/33044#issuecomment-1677406937 Totally understandable  No worries @potiuk. I just resolved the conflicts. If you can review it, that would be awesome 拾 -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on pull request #32867: Sanitize the conn_id to disallow potential script execution

2023-08-14 Thread via GitHub
potiuk commented on PR #32867: URL: https://github.com/apache/airflow/pull/32867#issuecomment-1677405653 > I looked at the usage of the `Connection` class and I saw that it is in [views.py process_form, L4643](https://github.com/apache/airflow/blob/main/airflow/www/views.py#L4654) as well

[airflow] 01/01: fixup! Update RELEASE_NOTES.rst

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 56cc894a8e37fac1a79e597a8d4b47766dba4a5b Author: Ephraim Anierobi AuthorDate: Mon Aug 14 12:16:57 2023

[airflow] branch v2-7-test updated (adfc7b8424 -> 56cc894a8e)

2023-08-14 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git discard adfc7b8424 fixup! Update RELEASE_NOTES.rst new 56cc894a8e fixup! Update RELEASE_NOTES.rst This

[GitHub] [airflow] kolfild26 commented on issue #33373: TimeDeltaSensor suggestion

2023-08-14 Thread via GitHub
kolfild26 commented on issue #33373: URL: https://github.com/apache/airflow/issues/33373#issuecomment-1677351121 @potiuk > TimeSensor ... You can do it with JINJA even now if you wish yes, that's what i actually do. Originally I didn't think of the time sensor change, but it

[GitHub] [airflow] karakanb commented on issue #33066: Unknown error in KubernetesJobWatcher. Failing

2023-08-14 Thread via GitHub
karakanb commented on issue #33066: URL: https://github.com/apache/airflow/issues/33066#issuecomment-1677347999 I am already on 1.27.2 and the issue is still there unfortunately. I guess this has nothing to do with Airflow then, I'll close the issue. -- This is an automated message from

[GitHub] [airflow] karakanb closed issue #33066: Unknown error in KubernetesJobWatcher. Failing

2023-08-14 Thread via GitHub
karakanb closed issue #33066: Unknown error in KubernetesJobWatcher. Failing URL: https://github.com/apache/airflow/issues/33066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

  1   2   >