[GitHub] [airflow] potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-15 Thread GitBox
potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-511298402 @ashb -> Few more (really last I think) small updates. I run some tests extensively on Linux and fixed all the problems

[GitHub] [airflow] chaimt commented on issue #4633: AIRFLOW-3791: Dataflow - Support check status if pipeline spans on multiple jobs

2019-07-15 Thread GitBox
chaimt commented on issue #4633: AIRFLOW-3791: Dataflow - Support check status if pipeline spans on multiple jobs URL: https://github.com/apache/airflow/pull/4633#issuecomment-511320024 @Fokko - can we merge this? This is an

[GitHub] [airflow] ashb commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-15 Thread GitBox
ashb commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#issuecomment-511346942 ``` == 56) FAIL: test_default_retries

[GitHub] [airflow] ashb commented on issue #5470: [AIRFLOW-4298] Stop Scheduler repeatedly warning "connection invalidated"

2019-07-15 Thread GitBox
ashb commented on issue #5470: [AIRFLOW-4298] Stop Scheduler repeatedly warning "connection invalidated" URL: https://github.com/apache/airflow/pull/5470#issuecomment-511365066 @techalchemy Ah no, no one had made that explicitly clear. The idea with this change was to try and remove the

[GitHub] [airflow] msumit commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-15 Thread GitBox
msumit commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#issuecomment-511292189 @ashb @milton0825 after mocking the tests are passing on my local, but still failing on Travis. Any further suggestions?

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-15 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303363631 ## File path: Dockerfile ## @@ -398,6 +398,10 @@ WORKDIR ${AIRFLOW_SOURCES} ENV

[GitHub] [airflow] ashb commented on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-15 Thread GitBox
ashb commented on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#issuecomment-511355065 Good work btw @jmcarp -- this has been on my wish list for a while! 

[jira] [Resolved] (AIRFLOW-4903) Unpinned Flask version causes dependency conflicts

2019-07-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4903. Resolution: Duplicate > Unpinned Flask version causes dependency conflicts >

[jira] [Created] (AIRFLOW-4956) LocalTaskJob heartbeat can create spamming log

2019-07-15 Thread Kevin Yang (JIRA)
Kevin Yang created AIRFLOW-4956: --- Summary: LocalTaskJob heartbeat can create spamming log Key: AIRFLOW-4956 URL: https://issues.apache.org/jira/browse/AIRFLOW-4956 Project: Apache Airflow

[GitHub] [airflow] mik-laj commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core

2019-07-15 Thread GitBox
mik-laj commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core URL: https://github.com/apache/airflow/pull/5587#discussion_r303360263 ## File path: airflow/www/app.py ## @@ -80,8 +80,7 @@ def create_app(config=None, session=None,

[GitHub] [airflow] benvit92 commented on issue #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load

2019-07-15 Thread GitBox
benvit92 commented on issue #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load URL: https://github.com/apache/airflow/pull/3880#issuecomment-511308543 Hello there, we are updating from Airflow 1.10.0 to 1.10.3 and this PR adds a check like the following: ```

[GitHub] [airflow] ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core URL: https://github.com/apache/airflow/pull/5587#discussion_r303357251 ## File path: airflow/www/app.py ## @@ -80,8 +80,7 @@ def create_app(config=None, session=None,

[GitHub] [airflow] ashb commented on a change in pull request #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI URL: https://github.com/apache/airflow/pull/5573#discussion_r303369121 ## File path: airflow/www/templates/airflow/variable_edit.html ## @@ -0,0 +1,28 @@ +{# + Licensed to

[GitHub] [airflow] ashb commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming URL: https://github.com/apache/airflow/pull/5589#discussion_r303379011 ## File path: airflow/jobs/base_job.py ## @@ -192,7 +192,7 @@ def heartbeat(self):

[GitHub] [airflow] ashb commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming URL: https://github.com/apache/airflow/pull/5589#discussion_r303381221 ## File path: airflow/jobs/local_task_job.py ## @@ -103,16 +100,8 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#discussion_r303376074 ## File path: tests/contrib/operators/test_ssh_operator.py ## @@ -87,15 +86,15 @@

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-15 Thread GitBox
ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511359474 Yeah, cos of the repeated parsing it would warn again and again in the scheduler/dag parsing logs :( I wonder if it is

[jira] [Commented] (AIRFLOW-4955) Enforce Connections & Pools

2019-07-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885097#comment-16885097 ] Ash Berlin-Taylor commented on AIRFLOW-4955: This is an interesting idea! As a short

[GitHub] [airflow] ashb commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303387547 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core URL: https://github.com/apache/airflow/pull/5587#discussion_r303365013 ## File path: airflow/bin/cli.py ## @@ -1043,7 +1043,7 @@ def serve_logs(args): flask_app =

[GitHub] [airflow] ashb commented on a change in pull request #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#discussion_r303376692 ## File path: tests/test_utils/config.py ## @@ -0,0 +1,53 @@ +# -*- coding: utf-8

[GitHub] [airflow] ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core URL: https://github.com/apache/airflow/pull/5587#discussion_r303358083 ## File path: airflow/bin/cli.py ## @@ -1043,7 +1043,7 @@ def serve_logs(args): flask_app =

[GitHub] [airflow] mik-laj commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core

2019-07-15 Thread GitBox
mik-laj commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core URL: https://github.com/apache/airflow/pull/5587#discussion_r303358421 ## File path: airflow/bin/cli.py ## @@ -1043,7 +1043,7 @@ def serve_logs(args): flask_app =

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-15 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303360995 ## File path: Dockerfile ## @@ -398,6 +398,10 @@ WORKDIR ${AIRFLOW_SOURCES} ENV

[GitHub] [airflow] KevinYang21 opened a new pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

2019-07-15 Thread GitBox
KevinYang21 opened a new pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming URL: https://github.com/apache/airflow/pull/5589 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4956) LocalTaskJob heartbeat can create spamming log

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885065#comment-16885065 ] ASF GitHub Bot commented on AIRFLOW-4956: - KevinYang21 commented on pull request #5589:

[jira] [Created] (AIRFLOW-4957) Rename tests/test_utils/* to not look like tests

2019-07-15 Thread Ash Berlin-Taylor (JIRA)
Ash Berlin-Taylor created AIRFLOW-4957: -- Summary: Rename tests/test_utils/* to not look like tests Key: AIRFLOW-4957 URL: https://issues.apache.org/jira/browse/AIRFLOW-4957 Project: Apache

[GitHub] [airflow] KevinYang21 commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

2019-07-15 Thread GitBox
KevinYang21 commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming URL: https://github.com/apache/airflow/pull/5589#discussion_r303386644 ## File path: airflow/jobs/local_task_job.py ## @@ -103,16 +100,8 @@ def

[jira] [Commented] (AIRFLOW-137) Airflow does not respect 'max_active_runs' when task from multiple dag runs cleared

2019-07-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885098#comment-16885098 ] Ash Berlin-Taylor commented on AIRFLOW-137: --- [~michaelkyriacou] Clearing and backfill are two

[GitHub] [airflow] potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-15 Thread GitBox
potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-511302782 @ashb -> also in the latest commit, I moved the docs generation to test phase. It is now more than docs - it's also

[GitHub] [airflow] ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5587: [AIRFLOW-4953] Remove unused variables in core URL: https://github.com/apache/airflow/pull/5587#discussion_r303356426 ## File path: airflow/bin/cli.py ## @@ -1043,7 +1043,7 @@ def serve_logs(args): flask_app =

[GitHub] [airflow] ashb commented on a change in pull request #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

2019-07-15 Thread GitBox
ashb commented on a change in pull request #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI URL: https://github.com/apache/airflow/pull/5573#discussion_r303369336 ## File path: airflow/www/templates/airflow/variable_edit.html ## @@ -0,0 +1,28 @@ +{# + Licensed to

[GitHub] [airflow] ashb commented on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-15 Thread GitBox
ashb commented on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#issuecomment-511354668 Could you also fix up

[jira] [Created] (AIRFLOW-4958) Documentation issue with cron schedule_interval

2019-07-15 Thread Brian King (JIRA)
Brian King created AIRFLOW-4958: --- Summary: Documentation issue with cron schedule_interval Key: AIRFLOW-4958 URL: https://issues.apache.org/jira/browse/AIRFLOW-4958 Project: Apache Airflow

[GitHub] [airflow] ashb commented on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables.

2019-07-15 Thread GitBox
ashb commented on issue #5569: [AIRFLOW-4936] Add context manager to set temporary config variables. URL: https://github.com/apache/airflow/pull/5569#issuecomment-511354968 And a couple more: ``` $ pt -e "@.*patch.*conf" ./tests/models/test_connection.py 39:

[GitHub] [airflow] KevinYang21 commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

2019-07-15 Thread GitBox
KevinYang21 commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming URL: https://github.com/apache/airflow/pull/5589#discussion_r303386106 ## File path: airflow/jobs/base_job.py ## @@ -192,7 +192,7 @@ def heartbeat(self):

[GitHub] [airflow] ashb commented on issue #4821: [AIRFLOW-3998] Use nested commands in cli.

2019-07-15 Thread GitBox
ashb commented on issue #4821: [AIRFLOW-3998] Use nested commands in cli. URL: https://github.com/apache/airflow/pull/4821#issuecomment-511366789 Sorry @jmcarp, I was in inbox hell and didn't see the ping, and it's conflicted again. I'm happy with this change now and the AIP is passed so

[jira] [Resolved] (AIRFLOW-4830) Timezone ignored if default_args used for multiple dags

2019-07-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4830. Resolution: Duplicate > Timezone ignored if default_args used for multiple dags

[jira] [Commented] (AIRFLOW-4959) Add hql template support for DataProcHiveOperator

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885140#comment-16885140 ] ASF GitHub Bot commented on AIRFLOW-4959: - Fokko commented on pull request #5591: AIRFLOW-4959:

[jira] [Commented] (AIRFLOW-4797) Zombie detection and killing is not deterministic

2019-07-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885213#comment-16885213 ] ASF subversion and git services commented on AIRFLOW-4797: -- Commit

[GitHub] [airflow] ashb commented on issue #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions

2019-07-15 Thread GitBox
ashb commented on issue #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions URL: https://github.com/apache/airflow/pull/5386#issuecomment-511408834 Going to close this PR for now as the messages it prints will likely be too long and will make a mess of the UI. Sorry. It'll

[GitHub] [airflow] ashb closed pull request #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions

2019-07-15 Thread GitBox
ashb closed pull request #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions URL: https://github.com/apache/airflow/pull/5386 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] Fokko opened a new pull request #5591: AIRFLOW-4959: Add .hql support for the DataProcHiveOperator

2019-07-15 Thread GitBox
Fokko opened a new pull request #5591: AIRFLOW-4959: Add .hql support for the DataProcHiveOperator URL: https://github.com/apache/airflow/pull/5591 Make sure you have checked _all_ steps below. By default, my IDEA does not support Hive syntax highlighting on `.q` files. I would

[jira] [Created] (AIRFLOW-4959) Add hql template support for DataProcHiveOperator

2019-07-15 Thread Fokko Driesprong (JIRA)
Fokko Driesprong created AIRFLOW-4959: - Summary: Add hql template support for DataProcHiveOperator Key: AIRFLOW-4959 URL: https://issues.apache.org/jira/browse/AIRFLOW-4959 Project: Apache Airflow

[jira] [Commented] (AIRFLOW-4961) SQL Error when writing Task Failure (using CockroachDB)

2019-07-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885266#comment-16885266 ] Ash Berlin-Taylor commented on AIRFLOW-4961: We probably don't care about sub-second

svn commit: r34886 - /dev/airflow/1.10.4rc3/

2019-07-15 Thread ash
Author: ash Date: Mon Jul 15 14:18:27 2019 New Revision: 34886 Log: Add artefacts for Airflow 1.10.4rc3 Added: dev/airflow/1.10.4rc3/ dev/airflow/1.10.4rc3/apache-airflow-1.10.4rc3-bin.tar.gz (with props) dev/airflow/1.10.4rc3/apache-airflow-1.10.4rc3-bin.tar.gz.asc

[jira] [Created] (AIRFLOW-4961) Error when writing Task

2019-07-15 Thread Fahran Wallace (JIRA)
Fahran Wallace created AIRFLOW-4961: --- Summary: Error when writing Task Key: AIRFLOW-4961 URL: https://issues.apache.org/jira/browse/AIRFLOW-4961 Project: Apache Airflow Issue Type: Bug

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

2019-07-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885270#comment-16885270 ] ASF subversion and git services commented on AIRFLOW-4911: -- Commit

[jira] [Commented] (AIRFLOW-4884) Roll up import_errors in UI

2019-07-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885268#comment-16885268 ] ASF subversion and git services commented on AIRFLOW-4884: -- Commit

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

2019-07-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885269#comment-16885269 ] ASF subversion and git services commented on AIRFLOW-4911: -- Commit

[jira] [Commented] (AIRFLOW-4797) Zombie detection and killing is not deterministic

2019-07-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885271#comment-16885271 ] ASF subversion and git services commented on AIRFLOW-4797: -- Commit

[GitHub] [airflow] codecov-io edited a comment on issue #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules

2019-07-15 Thread GitBox
codecov-io edited a comment on issue #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules URL: https://github.com/apache/airflow/pull/5590#issuecomment-511383488 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5590?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-15 Thread GitBox
ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511393939 Okay I tried out my idea and it works with one caveat. If you define a custom operator and _don't_ decorate with

[GitHub] [airflow] ashb commented on issue #5592: [AIRFLOW-4867] check if table exists before creating

2019-07-15 Thread GitBox
ashb commented on issue #5592: [AIRFLOW-4867] check if table exists before creating URL: https://github.com/apache/airflow/pull/5592#issuecomment-511449557 The "up" migration for this table drops those two tables. Do you know how you ended up with this migration being recorded as applied

[jira] [Created] (AIRFLOW-4960) Create OpenFaaS Sensor

2019-07-15 Thread Itai Yaffe (JIRA)
Itai Yaffe created AIRFLOW-4960: --- Summary: Create OpenFaaS Sensor Key: AIRFLOW-4960 URL: https://issues.apache.org/jira/browse/AIRFLOW-4960 Project: Apache Airflow Issue Type: Improvement

[jira] [Updated] (AIRFLOW-4961) SQL Error when writing Task Failure

2019-07-15 Thread Fahran Wallace (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fahran Wallace updated AIRFLOW-4961: Description: We're running Airflow against CockroachDB (which is designed to be

[jira] [Updated] (AIRFLOW-4961) SQL Error when writing Task Failure

2019-07-15 Thread Fahran Wallace (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fahran Wallace updated AIRFLOW-4961: Summary: SQL Error when writing Task Failure (was: Error when writing Task) > SQL Error

[jira] [Updated] (AIRFLOW-4961) SQL Error when writing Task Failure (using CockroachDB)

2019-07-15 Thread Fahran Wallace (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fahran Wallace updated AIRFLOW-4961: Summary: SQL Error when writing Task Failure (using CockroachDB) (was: SQL Error when

[jira] [Commented] (AIRFLOW-4867) Cannot downgrade drop_user_and_chart migration script

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885320#comment-16885320 ] ASF GitHub Bot commented on AIRFLOW-4867: - dszakallas commented on pull request #5592:

[jira] [Resolved] (AIRFLOW-4942) Drop six.next

2019-07-15 Thread Fokko Driesprong (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-4942. --- Resolution: Fixed Fix Version/s: 2.0.0 > Drop six.next > - > >

[jira] [Closed] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

2019-07-15 Thread dungnguyen (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dungnguyen closed AIRFLOW-4921. --- Resolution: Fixed Thanks for looking at this issue. Confirmed that it's working with 1.10.4rc2, I

[jira] [Commented] (AIRFLOW-4748) dagbag exception catching does not print a stack trace

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885244#comment-16885244 ] ASF GitHub Bot commented on AIRFLOW-4748: - ashb commented on pull request #5386: AIRFLOW-4748

[GitHub] [airflow] mik-laj commented on a change in pull request #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules

2019-07-15 Thread GitBox
mik-laj commented on a change in pull request #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules URL: https://github.com/apache/airflow/pull/5590#discussion_r303400470 ## File path: docs/conf.py ## @@ -236,7 +236,8 @@ 'mongodb':

[GitHub] [airflow] ashb merged pull request #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules

2019-07-15 Thread GitBox
ashb merged pull request #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules URL: https://github.com/apache/airflow/pull/5590 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] codecov-io commented on issue #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules

2019-07-15 Thread GitBox
codecov-io commented on issue #5590: [AIRFLOW-XXX] Disable intersphinx loading of `requests` modules URL: https://github.com/apache/airflow/pull/5590#issuecomment-511383488 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5590?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-137) Airflow does not respect 'max_active_runs' when task from multiple dag runs cleared

2019-07-15 Thread Michael Kyriacou (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885227#comment-16885227 ] Michael Kyriacou commented on AIRFLOW-137: -- Thanks [~ash], however I am aware of this. Prior to

[jira] [Updated] (AIRFLOW-4961) SQL Error when writing Task Failure (using CockroachDB)

2019-07-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4961: --- Affects Version/s: (was: 1.10.5) (was: 1.10.4) >

[GitHub] [airflow] dszakallas opened a new pull request #5592: [AIRFLOW-4867] migration script should check if table exists

2019-07-15 Thread GitBox
dszakallas opened a new pull request #5592: [AIRFLOW-4867] migration script should check if table exists URL: https://github.com/apache/airflow/pull/5592 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following

[GitHub] [airflow] dimberman commented on issue #5481: [AIRFLOW-4851] Refactor K8S codebase with k8s API models

2019-07-15 Thread GitBox
dimberman commented on issue #5481: [AIRFLOW-4851] Refactor K8S codebase with k8s API models URL: https://github.com/apache/airflow/pull/5481#issuecomment-511480075 @davlum I think this looks great. It will make it easier for us to keep up with the k8s API changes/features user request us

[jira] [Commented] (AIRFLOW-4924) Loading DAGs asynchronously in Airflow webserver

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885436#comment-16885436 ] ASF GitHub Bot commented on AIRFLOW-4924: - coufon commented on pull request #5594:

[GitHub] [airflow] milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-15 Thread GitBox
milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511499886 @ashb I think actually that is the expected behavior right? Operators not decorated with `apply_default` will not apply

[GitHub] [airflow] coufon commented on issue #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver

2019-07-15 Thread GitBox
coufon commented on issue #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver URL: https://github.com/apache/airflow/pull/5594#issuecomment-511521781 > Thanks. Well done. I will look at it more closely in the near future, but now I would like to point out that we only

[GitHub] [airflow] fahran opened a new pull request #5593: [AIRFLOW-4961] Prevent cast when writing TaskFail model to DB

2019-07-15 Thread GitBox
fahran opened a new pull request #5593: [AIRFLOW-4961] Prevent cast when writing TaskFail model to DB URL: https://github.com/apache/airflow/pull/5593 When writing a task failure record, convert 'duration' decimal value -> an int before persistence, to remove reliance on the database

[jira] [Commented] (AIRFLOW-4961) SQL Error when writing Task Failure (using CockroachDB)

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885368#comment-16885368 ] ASF GitHub Bot commented on AIRFLOW-4961: - fahran commented on pull request #5593:

[GitHub] [airflow] Fokko commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill

2019-07-15 Thread GitBox
Fokko commented on issue #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5498#issuecomment-511473203 My best guess would be @KevinYang21, otherwise @mistercrunch 

[GitHub] [airflow] eeshugerman commented on a change in pull request #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

2019-07-15 Thread GitBox
eeshugerman commented on a change in pull request #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI URL: https://github.com/apache/airflow/pull/5573#discussion_r303527698 ## File path: airflow/www/templates/airflow/variable_edit.html ## @@ -0,0 +1,28 @@ +{# +

[jira] [Commented] (AIRFLOW-4961) SQL Error when writing Task Failure (using CockroachDB)

2019-07-15 Thread Fahran Wallace (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885399#comment-16885399 ] Fahran Wallace commented on AIRFLOW-4961: - [~ash] yep, that works too, and is a bit neater.

[jira] [Comment Edited] (AIRFLOW-4584) Error when using ssh operateur to execute a sh script from an remote server

2019-07-15 Thread W Hasnaoui (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882915#comment-16882915 ] W Hasnaoui edited comment on AIRFLOW-4584 at 7/15/19 5:35 PM: -- Hi [~ash],

[jira] [Commented] (AIRFLOW-4724) Make params dict to be templated for operators

2019-07-15 Thread Srivignessh Pacham Sri Srinivasan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885444#comment-16885444 ] Srivignessh Pacham Sri Srinivasan commented on AIRFLOW-4724: I am

[GitHub] [airflow] mik-laj edited a comment on issue #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver

2019-07-15 Thread GitBox
mik-laj edited a comment on issue #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver URL: https://github.com/apache/airflow/pull/5594#issuecomment-511513081 Thanks. Well done. I will look at it more closely in the near future, but now I would like to point out that

[GitHub] [airflow] potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-15 Thread GitBox
potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303576669 ## File path: Dockerfile ## @@ -398,6 +398,10 @@ WORKDIR ${AIRFLOW_SOURCES} ENV

[GitHub] [airflow] codecov-io commented on issue #5595: [AIRFLOW-4962] Fix Werkzeug v0.15 deprecation notice for DispatcherMi…

2019-07-15 Thread GitBox
codecov-io commented on issue #5595: [AIRFLOW-4962] Fix Werkzeug v0.15 deprecation notice for DispatcherMi… URL: https://github.com/apache/airflow/pull/5595#issuecomment-511525842 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5595?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5595: [AIRFLOW-4962] Fix Werkzeug v0.15 deprecation notice for DispatcherMi…

2019-07-15 Thread GitBox
codecov-io edited a comment on issue #5595: [AIRFLOW-4962] Fix Werkzeug v0.15 deprecation notice for DispatcherMi… URL: https://github.com/apache/airflow/pull/5595#issuecomment-511525842 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5595?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

2019-07-15 Thread GitBox
ashb commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI URL: https://github.com/apache/airflow/pull/5573#issuecomment-511477370 Ah yeah, just add a comment in AIRFLOW-310 pointing at AIRFLOW-4929 then please.

[jira] [Comment Edited] (AIRFLOW-4593) Memory leak in Airflow scheduler

2019-07-15 Thread Grant Nicholas (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885411#comment-16885411 ] Grant Nicholas edited comment on AIRFLOW-4593 at 7/15/19 5:01 PM: -- +1

[jira] [Commented] (AIRFLOW-4593) Memory leak in Airflow scheduler

2019-07-15 Thread Grant Nicholas (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885411#comment-16885411 ] Grant Nicholas commented on AIRFLOW-4593: - +1 on here. We upgraded airflow  from 1.10.0 to

[GitHub] [airflow] msumit commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config

2019-07-15 Thread GitBox
msumit commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config URL: https://github.com/apache/airflow/pull/5570#issuecomment-511492468 @ashb tried `importlib.reload` as well, but unfortunately, it's not working as well. Should we just skip the failing test?

[GitHub] [airflow] dszakallas edited a comment on issue #5592: [AIRFLOW-4867] check if table exists before creating

2019-07-15 Thread GitBox
dszakallas edited a comment on issue #5592: [AIRFLOW-4867] check if table exists before creating URL: https://github.com/apache/airflow/pull/5592#issuecomment-511451534 I updated the airflow version from 1.10.2 to 1.10.4b2. I didn't do any manual migrations. initdb should have taken care

[GitHub] [airflow] codecov-io commented on issue #5592: [AIRFLOW-4867] check if table exists before creating

2019-07-15 Thread GitBox
codecov-io commented on issue #5592: [AIRFLOW-4867] check if table exists before creating URL: https://github.com/apache/airflow/pull/5592#issuecomment-511462870 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5592?src=pr=h1) Report > Merging

[GitHub] [airflow] milton0825 closed pull request #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-15 Thread GitBox
milton0825 closed pull request #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-4941) default_args not applied when dag is assigned to task through setter

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885437#comment-16885437 ] ASF GitHub Bot commented on AIRFLOW-4941: - milton0825 commented on pull request #5574:

[jira] [Created] (AIRFLOW-4962) Fix Werkzeug v0.15 deprecation notice for DispatcherMiddleware import

2019-07-15 Thread Nathaniel Ritholtz (JIRA)
Nathaniel Ritholtz created AIRFLOW-4962: --- Summary: Fix Werkzeug v0.15 deprecation notice for DispatcherMiddleware import Key: AIRFLOW-4962 URL: https://issues.apache.org/jira/browse/AIRFLOW-4962

[jira] [Commented] (AIRFLOW-4962) Fix Werkzeug v0.15 deprecation notice for DispatcherMiddleware import

2019-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885455#comment-16885455 ] ASF GitHub Bot commented on AIRFLOW-4962: - nritholtz commented on pull request #5595:

[GitHub] [airflow] mik-laj commented on a change in pull request #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver

2019-07-15 Thread GitBox
mik-laj commented on a change in pull request #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver URL: https://github.com/apache/airflow/pull/5594#discussion_r303581952 ## File path: airflow/dag/stringified_dags.py ## @@ -0,0 +1,137 @@ +# -*- coding:

[GitHub] [airflow] coufon opened a new pull request #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver

2019-07-15 Thread GitBox
coufon opened a new pull request #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver URL: https://github.com/apache/airflow/pull/5594 ### Jira - [(/)] My PR addresses the following issues: - [Airflow

[GitHub] [airflow] nritholtz opened a new pull request #5595: [AIRFLOW-4962] Fix Werkzeug v0.15 deprecation notice for DispatcherMi…

2019-07-15 Thread GitBox
nritholtz opened a new pull request #5595: [AIRFLOW-4962] Fix Werkzeug v0.15 deprecation notice for DispatcherMi… URL: https://github.com/apache/airflow/pull/5595 …ddleware import Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the

[GitHub] [airflow] mik-laj edited a comment on issue #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver

2019-07-15 Thread GitBox
mik-laj edited a comment on issue #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver URL: https://github.com/apache/airflow/pull/5594#issuecomment-511513081 Thanks. Good job. I will look at it more closely in the near future, but now I would like to point out that we

[GitHub] [airflow] nuclearpinguin commented on issue #5461: [AIRFLOW-4835] Refactor render_template

2019-07-15 Thread GitBox
nuclearpinguin commented on issue #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#issuecomment-511574298 I just wanted to suggest that maybe after your refactor the files could be remove from the todo list. If there's only few errors left

[GitHub] [airflow] Fokko commented on a change in pull request #4633: AIRFLOW-3791: Dataflow - Support check status if pipeline spans on multiple jobs

2019-07-15 Thread GitBox
Fokko commented on a change in pull request #4633: AIRFLOW-3791: Dataflow - Support check status if pipeline spans on multiple jobs URL: https://github.com/apache/airflow/pull/4633#discussion_r303654687 ## File path: airflow/contrib/hooks/gcp_dataflow_hook.py ## @@ -47,58

[GitHub] [airflow] Fokko commented on a change in pull request #4633: AIRFLOW-3791: Dataflow - Support check status if pipeline spans on multiple jobs

2019-07-15 Thread GitBox
Fokko commented on a change in pull request #4633: AIRFLOW-3791: Dataflow - Support check status if pipeline spans on multiple jobs URL: https://github.com/apache/airflow/pull/4633#discussion_r303655507 ## File path: airflow/contrib/hooks/gcp_dataflow_hook.py ## @@ -47,58

  1   2   >