[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860558487 I have not found such an example of how to do this, as in Perfect or DVC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860558123 @potiuk then another question is, can we configure that the current default parameters are displayed in this UI window, with which the DAG will be launched? -- This is an

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
boring-cyborg[bot] commented on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860585785 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] RichBr87 opened a new issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
RichBr87 opened a new issue #16432: URL: https://github.com/apache/airflow/issues/16432 **Description** Following the useful feature of tags with https://airflow.apache.org/docs/apache-airflow/2.0.0/howto/add-dag-tags.html it would be great if there was an option here to choose

[GitHub] [airflow] eladkal commented on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
eladkal commented on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860592819 Not sure if it's small thing as you mention. Tags are just test that is taken from the DAG definition. It's not attribute that created from the UI and has configuration like

[GitHub] [airflow] eladkal edited a comment on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
eladkal edited a comment on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860592819 Not sure if it's small thing as you mention. Tags are just text that is taken from the DAG definition. It's not attribute that created from the UI and has configuration

[GitHub] [airflow] eladkal edited a comment on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
eladkal edited a comment on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860592819 Not sure if it's small thing as you mention. Tags are just text that is taken from the DAG definition. It's not resource that created in the system and has configuration

[GitHub] [airflow] eladkal commented on pull request #16050: Update Boto3 API calls in ECSOperator

2021-06-14 Thread GitBox
eladkal commented on pull request #16050: URL: https://github.com/apache/airflow/pull/16050#issuecomment-860597239 @scottypate can you rebase? it will most likely solve the CI build issue -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] github-actions[bot] commented on pull request #16405: More documentation update for June providers release

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16405: URL: https://github.com/apache/airflow/pull/16405#issuecomment-860642352 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] eladkal commented on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
eladkal commented on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860642353 I assume you mean something like: `with models.DAG(dag_id="A", ...,tags=[('critical', RED)) as dag:` I don't think this can be a solution as in you might also

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16434: Properly handle HTTP header 'Referrer-Policy'

2021-06-14 Thread GitBox
boring-cyborg[bot] commented on issue #16434: URL: https://github.com/apache/airflow/issues/16434#issuecomment-860673070 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] frank-fischer-by opened a new issue #16434: Properly handle HTTP header 'Referrer-Policy'

2021-06-14 Thread GitBox
frank-fischer-by opened a new issue #16434: URL: https://github.com/apache/airflow/issues/16434 **Description** Properly set [HTTP Security Header `Referrer-Policy`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy) instead of relying on browser or

[GitHub] [airflow] uranusjr commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
uranusjr commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r650787593 ## File path: setup.cfg ## @@ -156,6 +156,9 @@ install_requires = typing-extensions>=3.7.4;python_version<"3.8" unicodecsv>=0.14.1

[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860561089 I want to take out all the potentially changeable parameters in the UI so that we can change them if needed. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
potiuk commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860561321 The Template for this config is not there, but this is a nice feature to add. If you want to add template - then by all means create a feature request (just make sure you follow

[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860561346 take out = edited to config params -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] uranusjr commented on issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
uranusjr commented on issue #16431: URL: https://github.com/apache/airflow/issues/16431#issuecomment-860579095 I’ve always found the current layout unintuitive. Maybe we can add a single list item under *Apache Airflow* that says `apache-airflow` like the provider packages? That would be

[GitHub] [airflow] uranusjr edited a comment on issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
uranusjr edited a comment on issue #16431: URL: https://github.com/apache/airflow/issues/16431#issuecomment-860579095 I’ve always found the current layout unintuitive. Maybe we can add a single list item under *Apache Airflow* that says *Apache Airflow* like the provider packages? That

[airflow] branch main updated (4752fb3 -> 943292b)

2021-06-14 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4752fb3 Fix issue with parsing error logs in the KPO (#15638) add 943292b Queue tasks with higher priority and

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15210: Queue tasks with higher priority and earlier execution_date first.

2021-06-14 Thread GitBox
boring-cyborg[bot] commented on pull request #15210: URL: https://github.com/apache/airflow/pull/15210#issuecomment-860614313 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] ashb closed issue #15171: scheduler does not apply ordering when querying which task instances to queue

2021-06-14 Thread GitBox
ashb closed issue #15171: URL: https://github.com/apache/airflow/issues/15171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] ashb merged pull request #15210: Queue tasks with higher priority and earlier execution_date first.

2021-06-14 Thread GitBox
ashb merged pull request #15210: URL: https://github.com/apache/airflow/pull/15210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] malthe commented on issue #16286: SFTPHook cannot download large files

2021-06-14 Thread GitBox
malthe commented on issue #16286: URL: https://github.com/apache/airflow/issues/16286#issuecomment-860623530 @potiuk what about https://github.com/ParallelSSH/parallel-ssh#sftp – ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] ashb commented on issue #16286: SFTPHook cannot download large files

2021-06-14 Thread GitBox
ashb commented on issue #16286: URL: https://github.com/apache/airflow/issues/16286#issuecomment-860638926 I'd probably caution against introducing twisted -- with Python 3.6/3.7+ the built in asyncio can do most of twisted without the need for a large external dependency. -- This is

[GitHub] [airflow] ephraimbuddy commented on pull request #16401: Add 'queued' state to DagRun

2021-06-14 Thread GitBox
ephraimbuddy commented on pull request #16401: URL: https://github.com/apache/airflow/pull/16401#issuecomment-860708590 ![dagrun-state](https://user-images.githubusercontent.com/4122866/121904603-3dd64700-cd21-11eb-9c10-efb3fefcb611.PNG) -- This is an automated message from the

[GitHub] [airflow] uranusjr commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
uranusjr commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r650767364 ## File path: airflow/utils/timeout.py ## @@ -22,12 +22,43 @@ from airflow.utils.platform import IS_WINDOWS from airflow.exceptions import

[GitHub] [airflow] ashb commented on pull request #15247: Infinite pools: Make their `total_slots` be `maxint`-like instead of `-1`

2021-06-14 Thread GitBox
ashb commented on pull request #15247: URL: https://github.com/apache/airflow/pull/15247#issuecomment-860613536 I have rebased to latest main, hopefully that should fix the 404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk commented on issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
potiuk commented on issue #16431: URL: https://github.com/apache/airflow/issues/16431#issuecomment-860618961 Better indeed. Would you like to make PR with that change ? That might be a nice first contribution and it is very simple to do - just follow this link

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650878667 ## File path: airflow/jobs/local_task_job.py ## @@ -151,16 +147,16 @@ def signal_handler(signum, frame): self.on_kill() def

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650878310 ## File path: airflow/jobs/local_task_job.py ## @@ -151,16 +147,16 @@ def signal_handler(signum, frame): self.on_kill() def

[GitHub] [airflow] malthe edited a comment on issue #16286: SFTPHook cannot download large files

2021-06-14 Thread GitBox
malthe edited a comment on issue #16286: URL: https://github.com/apache/airflow/issues/16286#issuecomment-860623530 @potiuk what about https://github.com/ParallelSSH/parallel-ssh#sftp – ? See also https://github.com/ParallelSSH/parallel-ssh#why-this-library: > Because other

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650881572 ## File path: tests/jobs/test_local_task_job.py ## @@ -513,16 +514,10 @@ def task_function(ti): assert task_terminated_externally.value

[GitHub] [airflow] ashb commented on issue #12728: KubePodOperator sometimes fails with `Unable to parse string [failed]`

2021-06-14 Thread GitBox
ashb commented on issue #12728: URL: https://github.com/apache/airflow/issues/12728#issuecomment-860645013 @timgriffiths Just merged now, so this should be included in the June providers release which @potiuk Is going to start preparing soon (this week I think?) -- This is an automated

[GitHub] [airflow] potiuk commented on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
potiuk commented on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860644506 This could be done as a config entry in Airflow. On one hand it is not ideal (because users would not be able to modify it) but on the other hand since the tags are anyhow

[GitHub] [airflow] ashb commented on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
ashb commented on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860644347 If we were going to do it I think managing the colour of the tags should be done outside of the Dag file as Elad suggests -- This is an automated message from the Apache Git

[GitHub] [airflow] kaxil commented on a change in pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16420: URL: https://github.com/apache/airflow/pull/16420#discussion_r651005548 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -143,6 +143,7 @@ def __init__(self, *args, **kwargs) -> None: self.schema =

[GitHub] [airflow] potiuk commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
potiuk commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860552392 For the future @paantya, please use GitHub discussions for similar questions, not issues. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
potiuk commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860617511 If you want to start on PR, there is no need to create Feature request at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650881572 ## File path: tests/jobs/test_local_task_job.py ## @@ -513,16 +514,10 @@ def task_function(ti): assert task_terminated_externally.value

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650882443 ## File path: tests/jobs/test_local_task_job.py ## @@ -686,6 +679,71 @@ def test_fast_follow( if scheduler_job.processor_agent:

[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860738211 Go discussion on whether this should be a user-defined parameter that could be over-written. The idea was for managed airflow providers (Astronomer, AWS), they

[GitHub] [airflow] uranusjr commented on pull request #16352: DagRun.date_interval_start and date_interval_start

2021-06-14 Thread GitBox
uranusjr commented on pull request #16352: URL: https://github.com/apache/airflow/pull/16352#issuecomment-860749604 Is it possible to supply two API schemas for the endpoint? I want to allow both supplying `execution_date` *or* `data_interval_[start|end]`, but not both. And is there a way

[GitHub] [airflow] potiuk closed issue #16429: API to set the state of the task instance to the specified state (airflow-1.10.11)

2021-06-14 Thread GitBox
potiuk closed issue #16429: URL: https://github.com/apache/airflow/issues/16429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] potiuk commented on issue #16429: API to set the state of the task instance to the specified state (airflow-1.10.11)

2021-06-14 Thread GitBox
potiuk commented on issue #16429: URL: https://github.com/apache/airflow/issues/16429#issuecomment-860564871 Aiflow 1.10 reaches end-of-life June 17 (in 3 days). Currently we are in the mode of implementing only critical fixes to 1.10. I heartly recommend to migrate to Airflow 2 at

[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860565017 I will try to arrange it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] peter-gergely-horvath commented on issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
peter-gergely-horvath commented on issue #16431: URL: https://github.com/apache/airflow/issues/16431#issuecomment-860584910 I could imagine something like this, with "Read the documentation" being a link to the corresponding sub-page:

[GitHub] [airflow] potiuk commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
potiuk commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r650834156 ## File path: airflow/task/task_runner/base_task_runner.py ## @@ -141,7 +143,7 @@ def run_command(self, run_with=None):

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650882901 ## File path: tests/models/test_taskinstance.py ## @@ -514,6 +515,37 @@ def raise_skip_exception(): ti.run() assert

[GitHub] [airflow] github-actions[bot] commented on pull request #16433: We don't need to build against Python 2.7 or 3.5 anymore

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16433: URL: https://github.com/apache/airflow/pull/16433#issuecomment-860649126 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on issue #16286: SFTPHook cannot download large files

2021-06-14 Thread GitBox
potiuk commented on issue #16286: URL: https://github.com/apache/airflow/issues/16286#issuecomment-860650099 Agree with @ashb . Parallel-ssh looks better as well. Seems rather popular from the number of forks, has very little number of dependencies (gevent, python-ssh2). Not super active

[GitHub] [airflow] kaxil commented on pull request #16414: Clean Markdown with dedent to respect indents

2021-06-14 Thread GitBox
kaxil commented on pull request #16414: URL: https://github.com/apache/airflow/pull/16414#issuecomment-860656166 @uranusjr Can you create a Github Issue to switch the markdown library to [markdown-it-py](https://github.com/executablebooks/markdown-it-py) ? :) -- This is an automated

[GitHub] [airflow] ephraimbuddy commented on pull request #16352: DagRun.date_interval_start and date_interval_start

2021-06-14 Thread GitBox
ephraimbuddy commented on pull request #16352: URL: https://github.com/apache/airflow/pull/16352#issuecomment-860746684 > > Oh, we'll need to add these to the OpenAPI defn too. > > Yeah, I’m working on it, the `post_dag_run` endpoint also needs updating. How should we handle

[GitHub] [airflow] yyhecust opened a new issue #16429: API to set the state of the task instance to the specified state (airflow-1.10.11)

2021-06-14 Thread GitBox
yyhecust opened a new issue #16429: URL: https://github.com/apache/airflow/issues/16429 **Description** we need a feature where we can set the state of the task instance to the specified state. **Use case / motivation** In my application, some task instances have been

[GitHub] [airflow] potiuk commented on issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
potiuk commented on issue #16431: URL: https://github.com/apache/airflow/issues/16431#issuecomment-860554977 Could you please propose a better solution @peter-gergely-horvath ? Maybe find a few examples of other sites where things are more intutitive? I think we are so used to it, that we

[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860555091 @potiuk As I understand it, this can only be used in the operator template field, but not in python code, passing parameters to models. Or did I get it wrong? and do you have an

[GitHub] [airflow] uranusjr commented on issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
uranusjr commented on issue #16431: URL: https://github.com/apache/airflow/issues/16431#issuecomment-860581758 Something like this ![image](https://user-images.githubusercontent.com/605277/121879359-55242d00-cd3f-11eb-84c0-4626529f356f.png) -- This is an automated message

[GitHub] [airflow] RichBr87 commented on issue #16432: Colour options for tags on DAGS

2021-06-14 Thread GitBox
RichBr87 commented on issue #16432: URL: https://github.com/apache/airflow/issues/16432#issuecomment-860610870 Apologies I meant small as in a small change to request, not that the work would be small. I'm not fully technical, so please excuse the following - The tags on Airflow 2.0 (not

[GitHub] [airflow] jdahlbaek commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
jdahlbaek commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860543201 We're experiencing both of the above issues in the tree view. Additionally, on my mobile device, I'm unable to get the web ui to show the tree at all. On desktops, some trial

[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860556828 Do you have an example of passing these values as arguments to Python code? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
potiuk commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860556892 It's triggering DAG run. Those are parameters for the whole DAG to run. You can use those parameters in your DAG definition to pass them to any underlying operators: The

[GitHub] [airflow] potiuk commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
potiuk commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r650820411 ## File path: airflow/__main__.py ## @@ -34,6 +35,15 @@ def main(): os.environ['KRB5CCNAME'] = conf.get('kerberos', 'ccache')

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650880747 ## File path: airflow/jobs/local_task_job.py ## @@ -78,16 +79,11 @@ def _execute(self): def signal_handler(signum, frame):

[GitHub] [airflow] potiuk commented on issue #12728: KubePodOperator sometimes fails with `Unable to parse string [failed]`

2021-06-14 Thread GitBox
potiuk commented on issue #12728: URL: https://github.com/apache/airflow/issues/12728#issuecomment-860646109 Today! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [airflow] ashb commented on pull request #15247: Infinite pools: Make their `total_slots` be `maxint`-like instead of `-1`

2021-06-14 Thread GitBox
ashb commented on pull request #15247: URL: https://github.com/apache/airflow/pull/15247#issuecomment-860680288 Damnit pymsql: > TypeError: unsupported operand type(s) for -: 'float' and 'decimal.Decimal' -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] uranusjr edited a comment on pull request #16352: DagRun.date_interval_start and date_interval_start

2021-06-14 Thread GitBox
uranusjr edited a comment on pull request #16352: URL: https://github.com/apache/airflow/pull/16352#issuecomment-860749604 Is it possible to supply two API schemas for the endpoint? I want to allow supplying either `execution_date` or `data_interval_[start|end]`, but not both. And if I do

[GitHub] [airflow] potiuk closed issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
potiuk closed issue #16430: URL: https://github.com/apache/airflow/issues/16430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] potiuk commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
potiuk commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860552037 It's already suported in 2.0 https://airflow.apache.org/docs/apache-airflow/stable/dag-run.html#using-ui -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
boring-cyborg[bot] commented on issue #16431: URL: https://github.com/apache/airflow/issues/16431#issuecomment-860551796 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] peter-gergely-horvath opened a new issue #16431: Documentation landing page links in the section headers are hard to find

2021-06-14 Thread GitBox
peter-gergely-horvath opened a new issue #16431: URL: https://github.com/apache/airflow/issues/16431 **Apache Airflow version**: N/A - current documentation **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): N/A **Environment**:

[GitHub] [airflow] paantya commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860568791 @potiuk for PR i need creat new issue "Feature request"? or create https://github.com/apache/airflow/pulls? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] kaxil commented on pull request #15210: Queue tasks with higher priority and earlier execution_date first.

2021-06-14 Thread GitBox
kaxil commented on pull request #15210: URL: https://github.com/apache/airflow/pull/15210#issuecomment-860620521 Well done @ginevragaudioso  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

2021-06-14 Thread GitBox
ephraimbuddy commented on a change in pull request #16301: URL: https://github.com/apache/airflow/pull/16301#discussion_r650880028 ## File path: airflow/models/taskinstance.py ## @@ -1311,12 +1311,6 @@ def _run_finished_callback(self, error: Optional[Union[str, Exception]] =

[GitHub] [airflow] Gurulhu commented on issue #16313: cryptography.fernet.InvalidToken when attempting to access connections

2021-06-14 Thread GitBox
Gurulhu commented on issue #16313: URL: https://github.com/apache/airflow/issues/16313#issuecomment-860709591 @jedcunningham I'm not the OP but I'm encountering the exact same issue. I'm running the official helm chart (http://airflow.apache.org/docs/helm-chart/stable/index.html) on

[GitHub] [airflow] uranusjr commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
uranusjr commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r650763917 ## File path: airflow/utils/timeout.py ## @@ -22,12 +22,43 @@ from airflow.utils.platform import IS_WINDOWS from airflow.exceptions import

[GitHub] [airflow] houqp commented on pull request #16411: generate go client with latest openapi generator template

2021-06-14 Thread GitBox
houqp commented on pull request #16411: URL: https://github.com/apache/airflow/pull/16411#issuecomment-860515736 @msumit @potiuk version updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
boring-cyborg[bot] commented on issue #16430: URL: https://github.com/apache/airflow/issues/16430#issuecomment-860549548 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] paantya opened a new issue #16430: Specify New Parameters

2021-06-14 Thread GitBox
paantya opened a new issue #16430: URL: https://github.com/apache/airflow/issues/16430 When is it planned to support changing in UI the default startup DAG parameters to be used in python code? something like perfect has:

[GitHub] [airflow] potiuk commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
potiuk commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r650821324 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -33,6 +33,10 @@ # subfolder in a code repository. This path must be absolute.

[GitHub] [airflow] kaxil commented on issue #14168: add InfluxdbHook

2021-06-14 Thread GitBox
kaxil commented on issue #14168: URL: https://github.com/apache/airflow/issues/14168#issuecomment-860630479 @subkanthi go for it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] ashb opened a new pull request #16433: We don't need to build against Python 2.7 or 3.5 anymore

2021-06-14 Thread GitBox
ashb opened a new pull request #16433: URL: https://github.com/apache/airflow/pull/16433 Airflow 1.10 has reached end of life on June 17th 2021, so we can tidy up our build scripts and not have to build these versions anymore Do not merge before June 17th 2021 -- This is an

[GitHub] [airflow] kaxil commented on a change in pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16420: URL: https://github.com/apache/airflow/pull/16420#discussion_r651001979 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -143,6 +143,7 @@ def __init__(self, *args, **kwargs) -> None: self.schema =

[GitHub] [airflow] dimonchik-suvorov commented on a change in pull request #16089: [#16087]: Backfill shouldn't interfere with scheduled run fix

2021-06-14 Thread GitBox
dimonchik-suvorov commented on a change in pull request #16089: URL: https://github.com/apache/airflow/pull/16089#discussion_r651016401 ## File path: tests/jobs/test_scheduler_job.py ## @@ -2364,9 +2370,6 @@ def test_dagrun_root_fail_unfinished(self): )

[GitHub] [airflow] uranusjr opened a new issue #16435: Switch Markdown engine to markdown-it-py

2021-06-14 Thread GitBox
uranusjr opened a new issue #16435: URL: https://github.com/apache/airflow/issues/16435 Copying from #16414: The current Markdown engine does not support [fenced code blocks](https://python-markdown.github.io/extensions/fenced_code_blocks/), so it still won’t work after this

[GitHub] [airflow] ephraimbuddy commented on pull request #16352: DagRun.date_interval_start and date_interval_start

2021-06-14 Thread GitBox
ephraimbuddy commented on pull request #16352: URL: https://github.com/apache/airflow/pull/16352#issuecomment-860782292 > Is it possible to supply two API schemas for the endpoint? I want to allow supplying either `execution_date` or `data_interval_[start|end]`, but not both. And if I do

[GitHub] [airflow] potiuk commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
potiuk commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860789423 Fine for me. Happy to merge it as is before I start releasing providers today :) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] bbovenzi commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860929449 Noted. Still looking into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] bbovenzi removed a comment on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi removed a comment on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860929449 Noted. Still looking into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860868813 Yes -- The hook is where it should happen where the param is unchangeable by the consumer. For managed providers, they can then override it when they go to push

[GitHub] [airflow] uranusjr commented on pull request #16414: Clean Markdown with dedent to respect indents

2021-06-14 Thread GitBox
uranusjr commented on pull request #16414: URL: https://github.com/apache/airflow/pull/16414#issuecomment-860762458 Done in #16435. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860784508 We will want to keep the Airflow tag standardized, so I would not want to include the version. Ultimately, this is what we need the code to look like when we

[GitHub] [airflow] github-actions[bot] commented on pull request #16410: Use resource and action names.

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16410: URL: https://github.com/apache/airflow/pull/16410#issuecomment-860853160 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] fjmacagno commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
fjmacagno commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860882166 > @fjmacagno @syedshameersarwar Does this happen when the auto-refresh is on, or whenever? Whenever -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] bbovenzi commented on issue #16249: Fully functional DAG Dependencies Graph view

2021-06-14 Thread GitBox
bbovenzi commented on issue #16249: URL: https://github.com/apache/airflow/issues/16249#issuecomment-860837020 @ManiBharataraju That looks great! I am more than happy to help you out with javascript. Feel free to message me on the airflow slack channel to figure out how to get this

[GitHub] [airflow] potiuk commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
potiuk commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860841495 > I think, it should be connection parameter, environment parameter or fixed constant (preferred by me). Now we require changes to the DAG file, so very few people will be

[GitHub] [airflow] bryce-lewis opened a new pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
bryce-lewis opened a new pull request #16436: URL: https://github.com/apache/airflow/pull/16436 Added a connection doc for the ElasticSearch connection. Added links inside the ElasticSearch module doc strings for user to have access to the ElasticSearch connection doc. -- This is

[GitHub] [airflow] bbovenzi commented on issue #16367: Tree view shown incorrect dag runs

2021-06-14 Thread GitBox
bbovenzi commented on issue #16367: URL: https://github.com/apache/airflow/issues/16367#issuecomment-860879602 Just replicated this one. It is an issue with the auto-refresh. Working on a fix now. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
potiuk commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860893008 Can you change it please then @sfc-gh-madkins ? because the default is now in the Operator. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] bbovenzi opened a new pull request #16437: Add num_runs query param for tree refresh

2021-06-14 Thread GitBox
bbovenzi opened a new pull request #16437: URL: https://github.com/apache/airflow/pull/16437 Add `num_runs` as a meta field to add to the tree refresh request Closes #16367 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] bbovenzi edited a comment on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi edited a comment on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860835673 @jdahlbaek We don't support mobile screen sizes. But let me look into the rest of these concerns and see what's going on. -- This is an automated message from the Apache

[GitHub] [airflow] Gurulhu commented on issue #16313: cryptography.fernet.InvalidToken when attempting to access connections

2021-06-14 Thread GitBox
Gurulhu commented on issue #16313: URL: https://github.com/apache/airflow/issues/16313#issuecomment-860768457 I think I found what the issue might be: Inspecting the code it fails at [password

  1   2   3   4   5   6   >