[GitHub] [airflow] mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-19 Thread GitBox
mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r267204856 ## File path: airflow/contrib/operators/opsgenie_alert_operator.py ## @@ -0,0 +1,142 @@ +# -*- co

[jira] [Commented] (AIRFLOW-4109) Airflow kubernetes executor set the fernet key

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796857#comment-16796857 ] ASF GitHub Bot commented on AIRFLOW-4109: - stijndehaes commented on pull reques

[jira] [Closed] (AIRFLOW-4109) Airflow kubernetes executor set the fernet key

2019-03-19 Thread Stijn De Haes (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stijn De Haes closed AIRFLOW-4109. -- Resolution: Won't Fix > Airflow kubernetes executor set the fernet key >

[GitHub] [airflow] stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

2019-03-19 Thread GitBox
stijndehaes commented on issue #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931#issuecomment-474709840 Ok had some time to think about it. You are right we don't need to add support for this for airflow. But at t

[GitHub] [airflow] mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

2019-03-19 Thread GitBox
mik-laj commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474709801 Hi. You should not implement your own security mechanisms when it is not required. Look how you can achieve a similar effect, but us

[GitHub] [airflow] stijndehaes closed pull request #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th…

2019-03-19 Thread GitBox
stijndehaes closed pull request #4931: [AIRFLOW-4109] Added support for passing the airflow fernet key to th… URL: https://github.com/apache/airflow/pull/4931 This is an automated message from the Apache Git Service. To resp

[jira] [Resolved] (AIRFLOW-4123) Add Exception handling for _change_state method in K8 Executor

2019-03-19 Thread Anand (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anand resolved AIRFLOW-4123. Resolution: Fixed > Add Exception handling for _change_state method in K8 Executor >

[GitHub] [airflow] Gaurav589 commented on issue #4338: [AIRFLOW-3172] Fix error creation dag link

2019-03-19 Thread GitBox
Gaurav589 commented on issue #4338: [AIRFLOW-3172] Fix error creation dag link URL: https://github.com/apache/airflow/pull/4338#issuecomment-474697165 File "/usr/lib/python3/dist-packages/jinja2/_compat.py", line 37, in reraise raise value.with_traceback(tb) File "/usr/local/li

[GitHub] [airflow] galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef…

2019-03-19 Thread GitBox
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef… URL: https://github.com/apache/airflow/pull/4772#issuecomment-474695251 @ashb can I understand reasoning behind that, why we want to test that now? None of the tests were testing outp

[jira] [Commented] (AIRFLOW-4123) Add Exception handling for _change_state method in K8 Executor

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796817#comment-16796817 ] ASF GitHub Bot commented on AIRFLOW-4123: - dimberman commented on pull request

[jira] [Commented] (AIRFLOW-4123) Add Exception handling for _change_state method in K8 Executor

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796818#comment-16796818 ] ASF subversion and git services commented on AIRFLOW-4123: -- Co

[GitHub] [airflow] dimberman merged pull request #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

2019-03-19 Thread GitBox
dimberman merged pull request #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941 This is an automated message from the Apache Git Service. To respon

[jira] [Updated] (AIRFLOW-4130) Enhance hook of HivePartitionSensor

2019-03-19 Thread Noah (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noah updated AIRFLOW-4130: -- Description: h2. Backgrounds HivePartitionSensor is useful to wait a partition to be completed. HivePartiti

[GitHub] [airflow] milton0825 commented on issue #4946: [AIRFLOW-4118] instrument DagRun duration

2019-03-19 Thread GitBox
milton0825 commented on issue #4946: [AIRFLOW-4118] instrument DagRun duration URL: https://github.com/apache/airflow/pull/4946#issuecomment-474681782 PTAL @feng-tao @Fokko tests passed on local CI: https://travis-ci.org/milton0825/airflow/builds/508680332 ---

[jira] [Created] (AIRFLOW-4130) Enhance hook of HivePartitionSensor

2019-03-19 Thread Noah (JIRA)
Noah created AIRFLOW-4130: - Summary: Enhance hook of HivePartitionSensor Key: AIRFLOW-4130 URL: https://issues.apache.org/jira/browse/AIRFLOW-4130 Project: Apache Airflow Issue Type: New Feature

[GitHub] [airflow] milton0825 commented on issue #4898: [AIRFLOW-XXXX] how to setup simple test env with mysql

2019-03-19 Thread GitBox
milton0825 commented on issue #4898: [AIRFLOW-] how to setup simple test env with mysql URL: https://github.com/apache/airflow/pull/4898#issuecomment-474672943 Originally I put it in the how-to guide but @mik-laj suggest that I should put it in the contribute.md --

[GitHub] [airflow] codecov-io commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files

2019-03-19 Thread GitBox
codecov-io commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files URL: https://github.com/apache/airflow/pull/4947#issuecomment-474670207 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4947?src=pr&el=h1) Report > Merging [#4947](https:

[GitHub] [airflow] feng-tao commented on issue #4898: [AIRFLOW-XXXX] how to setup simple test env with mysql

2019-03-19 Thread GitBox
feng-tao commented on issue #4898: [AIRFLOW-] how to setup simple test env with mysql URL: https://github.com/apache/airflow/pull/4898#issuecomment-474667928 Any specific reason that this doc is in contribution.md not in the howto(https://github.com/apache/airflow/tree/master/docs/howt

[jira] [Commented] (AIRFLOW-4106) Instrument starving tasks in pool

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796738#comment-16796738 ] ASF GitHub Bot commented on AIRFLOW-4106: - feng-tao commented on pull request #

[jira] [Commented] (AIRFLOW-4106) Instrument starving tasks in pool

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796739#comment-16796739 ] ASF subversion and git services commented on AIRFLOW-4106: -- Co

[jira] [Resolved] (AIRFLOW-4106) Instrument starving tasks in pool

2019-03-19 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-4106. --- Resolution: Fixed Fix Version/s: 1.10.3 > Instrument starving tasks in pool > --

[GitHub] [airflow] feng-tao merged pull request #4927: [AIRFLOW-4106] instrument starving tasks in pool

2019-03-19 Thread GitBox
feng-tao merged pull request #4927: [AIRFLOW-4106] instrument starving tasks in pool URL: https://github.com/apache/airflow/pull/4927 This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Resolved] (AIRFLOW-4122) Remove chain function in airflow.utils

2019-03-19 Thread Tao Feng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng resolved AIRFLOW-4122. --- Resolution: Fixed > Remove chain function in airflow.utils > --

[GitHub] [airflow] zhongjiajie commented on issue #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
zhongjiajie commented on issue #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940#issuecomment-474659482 @feng-tao thanks. This is an automated message from the Apache Git Service. To

[GitHub] [airflow] codecov-io edited a comment on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

2019-03-19 Thread GitBox
codecov-io edited a comment on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941#issuecomment-474257350 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4941?src=pr&el=h1) Report > Merging [#4941](h

[jira] [Commented] (AIRFLOW-4122) Remove chain function in airflow.utils

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796715#comment-16796715 ] ASF GitHub Bot commented on AIRFLOW-4122: - feng-tao commented on pull request #

[jira] [Commented] (AIRFLOW-4122) Remove chain function in airflow.utils

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796717#comment-16796717 ] ASF subversion and git services commented on AIRFLOW-4122: -- Co

[jira] [Commented] (AIRFLOW-4122) Remove chain function in airflow.utils

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796716#comment-16796716 ] ASF subversion and git services commented on AIRFLOW-4122: -- Co

[GitHub] [airflow] feng-tao merged pull request #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
feng-tao merged pull request #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [airflow] feng-tao commented on issue #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
feng-tao commented on issue #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940#issuecomment-474659183 LGTM This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [airflow] zhongjiajie commented on issue #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
zhongjiajie commented on issue #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940#issuecomment-474658226 @feng-tao I change `UPDATING.md` and skip CI, PTAL thanks. This is an automated

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
zhongjiajie commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940#discussion_r267164811 ## File path: UPDATING.md ## @@ -24,6 +24,11 @@ assists users migrating to a new version. ## Airflow Mast

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
zhongjiajie commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940#discussion_r267164655 ## File path: UPDATING.md ## @@ -24,6 +24,11 @@ assists users migrating to a new version. ## Airflow Mast

[GitHub] [airflow] feng-tao commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
feng-tao commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940#discussion_r267163296 ## File path: UPDATING.md ## @@ -24,6 +24,11 @@ assists users migrating to a new version. ## Airflow Master

[GitHub] [airflow] feng-tao commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function

2019-03-19 Thread GitBox
feng-tao commented on a change in pull request #4940: [AIRFLOW-4122] Remove chain function URL: https://github.com/apache/airflow/pull/4940#discussion_r267163273 ## File path: UPDATING.md ## @@ -24,6 +24,11 @@ assists users migrating to a new version. ## Airflow Master

[GitHub] [airflow] dimberman commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

2019-03-19 Thread GitBox
dimberman commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941#issuecomment-474655058 @feng-tao Ahh good point! I've rerun the one failing test (this one seems to be around minikube not working cor

[GitHub] [airflow] XD-DENG commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files

2019-03-19 Thread GitBox
XD-DENG commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files URL: https://github.com/apache/airflow/pull/4947#issuecomment-474651753 I have the same impression as @kaxil , because we did encounter this issue in the releasing process of 1.10.2.

[GitHub] [airflow] kaxil commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files

2019-03-19 Thread GitBox
kaxil commented on issue #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files URL: https://github.com/apache/airflow/pull/4947#issuecomment-474648784 This is strange as it was resolved as a part of https://github.com/apache/airflow/pull/3687 https://github

[GitHub] [airflow] jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267152200 ## File path: airflow/models/connection.py ## @@ -251,6 +251,7 @@ def get_hook(self):

[GitHub] [airflow] jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267152078 ## File path: airflow/models/__init__.py ## @@ -4290,7 +4291,13 @@ def setdefault(cls, key, def

[GitHub] [airflow] jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267149990 ## File path: airflow/models/__init__.py ## @@ -3051,8 +3052,8 @@ def __init__( )

[GitHub] [airflow] jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267148079 ## File path: airflow/models/__init__.py ## @@ -2065,44 +2061,45 @@ class derived from this one

[GitHub] [airflow] codecov-io commented on issue #4948: [AIRFLOW-4129] Escape HTML in generated tooltips (#4944)

2019-03-19 Thread GitBox
codecov-io commented on issue #4948: [AIRFLOW-4129] Escape HTML in generated tooltips (#4944) URL: https://github.com/apache/airflow/pull/4948#issuecomment-474634025 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4948?src=pr&el=h1) Report > Merging [#4948](https://codecov.io/gh/

[GitHub] [airflow] milton0825 commented on a change in pull request #4889: [AIRFLOW-4057] statsd should escape invalid characters

2019-03-19 Thread GitBox
milton0825 commented on a change in pull request #4889: [AIRFLOW-4057] statsd should escape invalid characters URL: https://github.com/apache/airflow/pull/4889#discussion_r267144768 ## File path: airflow/stats.py ## @@ -0,0 +1,124 @@ +# -*- coding: utf-8 -*- +# +# Licensed

[jira] [Commented] (AIRFLOW-3977) Incorrect example about the interaction between skipped tasks and trigger rules in documentation.

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796635#comment-16796635 ] ASF subversion and git services commented on AIRFLOW-3977: -- Co

[GitHub] [airflow] milton0825 commented on a change in pull request #4889: [AIRFLOW-4057] statsd should escape invalid characters

2019-03-19 Thread GitBox
milton0825 commented on a change in pull request #4889: [AIRFLOW-4057] statsd should escape invalid characters URL: https://github.com/apache/airflow/pull/4889#discussion_r267142933 ## File path: airflow/stats.py ## @@ -0,0 +1,124 @@ +# -*- coding: utf-8 -*- +# +# Licensed

[jira] [Commented] (AIRFLOW-3875) simplify SlackWebhookHook code and change docstring

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796630#comment-16796630 ] ASF subversion and git services commented on AIRFLOW-3875: -- Co

[jira] [Commented] (AIRFLOW-3636) Fix a test introduced in PR #4425

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796638#comment-16796638 ] ASF subversion and git services commented on AIRFLOW-3636: -- Co

[jira] [Commented] (AIRFLOW-3881) Correct hive_hook to_csv row number

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796631#comment-16796631 ] ASF subversion and git services commented on AIRFLOW-3881: -- Co

[jira] [Commented] (AIRFLOW-2511) Subdag failed by scheduler deadlock

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796633#comment-16796633 ] ASF subversion and git services commented on AIRFLOW-2511: -- Co

[jira] [Commented] (AIRFLOW-3734) function `load_file` will not run if param `partition` is None

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796628#comment-16796628 ] ASF subversion and git services commented on AIRFLOW-3734: -- Co

[jira] [Commented] (AIRFLOW-1784) SKIPPED status is being cascading wrongly

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796636#comment-16796636 ] ASF subversion and git services commented on AIRFLOW-1784: -- Co

[jira] [Commented] (AIRFLOW-3623) Support download log file from UI

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796637#comment-16796637 ] ASF subversion and git services commented on AIRFLOW-3623: -- Co

[jira] [Commented] (AIRFLOW-3962) Scheduler throwing an exception while creating dag_run for a dag which doesn't contain any task

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796632#comment-16796632 ] ASF subversion and git services commented on AIRFLOW-3962: -- Co

[jira] [Commented] (AIRFLOW-3733) raise NameError if hql result had no record

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796629#comment-16796629 ] ASF subversion and git services commented on AIRFLOW-3733: -- Co

[jira] [Commented] (AIRFLOW-2715) Dataflow template operator dosenot support region parameter

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796627#comment-16796627 ] ASF subversion and git services commented on AIRFLOW-2715: -- Co

[jira] [Commented] (AIRFLOW-3977) Incorrect example about the interaction between skipped tasks and trigger rules in documentation.

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796634#comment-16796634 ] ASF subversion and git services commented on AIRFLOW-3977: -- Co

[jira] [Updated] (AIRFLOW-4070) AirflowException on repeated dependencies prevents automated dependencies

2019-03-19 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4070: --- Fix Version/s: (was: 2.0.0) 1.10.3 > AirflowException on rep

[jira] [Resolved] (AIRFLOW-4124) Add get table and get location of table to AWS Glue Hook

2019-03-19 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4124. Resolution: Fixed > Add get table and get location of table to AWS Glue Hook > --

[jira] [Commented] (AIRFLOW-4124) Add get table and get location of table to AWS Glue Hook

2019-03-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796624#comment-16796624 ] ASF subversion and git services commented on AIRFLOW-4124: -- Co

[jira] [Commented] (AIRFLOW-4124) Add get table and get location of table to AWS Glue Hook

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796623#comment-16796623 ] ASF GitHub Bot commented on AIRFLOW-4124: - ashb commented on pull request #4942

[jira] [Updated] (AIRFLOW-4124) Add get table and get location of table to AWS Glue Hook

2019-03-19 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4124: --- Fix Version/s: 1.10.3 > Add get table and get location of table to AWS Glue Hook >

[GitHub] [airflow] ashb merged pull request #4942: [AIRFLOW-4124] add get_table and get_table_location in aws_glue_hook and tests

2019-03-19 Thread GitBox
ashb merged pull request #4942: [AIRFLOW-4124] add get_table and get_table_location in aws_glue_hook and tests URL: https://github.com/apache/airflow/pull/4942 This is an automated message from the Apache Git Service. To res

[GitHub] [airflow] ashb commented on a change in pull request #4889: [AIRFLOW-4057] statsd should escape invalid characters

2019-03-19 Thread GitBox
ashb commented on a change in pull request #4889: [AIRFLOW-4057] statsd should escape invalid characters URL: https://github.com/apache/airflow/pull/4889#discussion_r267139899 ## File path: airflow/stats.py ## @@ -0,0 +1,124 @@ +# -*- coding: utf-8 -*- +# +# Licensed to th

[GitHub] [airflow] mans2singh commented on issue #4887: [AIRFLOW-4055] Add AWS SQS Sensor

2019-03-19 Thread GitBox
mans2singh commented on issue #4887: [AIRFLOW-4055] Add AWS SQS Sensor URL: https://github.com/apache/airflow/pull/4887#issuecomment-474626878 @zhongjiajie - I've updated the code based on your comments. Please let me know if you have additional advice. Thanks ---

[GitHub] [airflow] ashb commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

2019-03-19 Thread GitBox
ashb commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941#issuecomment-474626813 @dimberman Not sure if you have perms in Jira yet, but when merging a PR please also mark the issue as Resolved (not

[GitHub] [airflow] ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267138726 ## File path: airflow/models/__init__.py ## @@ -3051,8 +3052,8 @@ def __init__( )

[GitHub] [airflow] ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267139140 ## File path: airflow/models/connection.py ## @@ -251,6 +251,7 @@ def get_hook(self): el

[GitHub] [airflow] ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267139037 ## File path: airflow/models/__init__.py ## @@ -4290,7 +4291,13 @@ def setdefault(cls, key, defau

[GitHub] [airflow] ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
ashb commented on a change in pull request #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#discussion_r267138457 ## File path: airflow/models/__init__.py ## @@ -2065,44 +2061,45 @@ class derived from this one r

[GitHub] [airflow] milton0825 commented on issue #4898: [AIRFLOW-XXXX] how to setup simple test env with mysql

2019-03-19 Thread GitBox
milton0825 commented on issue #4898: [AIRFLOW-] how to setup simple test env with mysql URL: https://github.com/apache/airflow/pull/4898#issuecomment-474625399 PTAL @mik-laj This is an automated message from the Apache G

[GitHub] [airflow] codecov-io commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

2019-03-19 Thread GitBox
codecov-io commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474624216 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4944?src=pr&el=h1) Report > Merging [#4944](https://codecov.io/gh/apache/a

[GitHub] [airflow] jmcarp commented on issue #4926: [AIRFLOW-4104] Add type annotations to common classes.

2019-03-19 Thread GitBox
jmcarp commented on issue #4926: [AIRFLOW-4104] Add type annotations to common classes. URL: https://github.com/apache/airflow/pull/4926#issuecomment-474623618 WDYT @ashb @feng-tao @Fokko? This makes almost no changes to the code--it's almost all annotations. -

[jira] [Commented] (AIRFLOW-3706) Tooltip Display Issue for a Task Instance

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796611#comment-16796611 ] ASF GitHub Bot commented on AIRFLOW-3706: - ashb commented on pull request #4947

[jira] [Commented] (AIRFLOW-4129) Escape HTML in tooltips

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796616#comment-16796616 ] ASF GitHub Bot commented on AIRFLOW-4129: - ashb commented on pull request #4948

[GitHub] [airflow] ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

2019-03-19 Thread GitBox
ashb commented on issue #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944#issuecomment-474623766 I have also created a second PR targeting the v1-10-stable branch. This is

[GitHub] [airflow] ashb commented on issue #4948: [AIRFLOW-4129] Escape HTML in generated tooltips (#4944)

2019-03-19 Thread GitBox
ashb commented on issue #4948: [AIRFLOW-4129] Escape HTML in generated tooltips (#4944) URL: https://github.com/apache/airflow/pull/4948#issuecomment-474623830 Please approve (if you are happy with this) but don't merge please. --

[GitHub] [airflow] ashb opened a new pull request #4948: [AIRFLOW-4129] Escape HTML in generated tooltips (#4944)

2019-03-19 Thread GitBox
ashb opened a new pull request #4948: [AIRFLOW-4129] Escape HTML in generated tooltips (#4944) URL: https://github.com/apache/airflow/pull/4948 Make sure you have checked _all_ steps below. ### Jira https://issues.apache.org/jira/browse/AIRFLOW-4129 ### Description E

[GitHub] [airflow] ashb opened a new pull request #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files

2019-03-19 Thread GitBox
ashb opened a new pull request #4947: [AIRFLOW-3706] Fix tooltip max-width by correcting ordering of CSS files URL: https://github.com/apache/airflow/pull/4947 Make sure you have checked _all_ steps below. ### Jira https://issues.apache.org/jira/browse/AIRFLOW-3706 ###

[jira] [Updated] (AIRFLOW-3706) Tooltip Display Issue for a Task Instance

2019-03-19 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3706: --- Fix Version/s: (was: 1.10.2) 1.10.3 > Tooltip Display Issue

[jira] [Commented] (AIRFLOW-4118) Instrument dagrun duration

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796608#comment-16796608 ] ASF GitHub Bot commented on AIRFLOW-4118: - milton0825 commented on pull request

[GitHub] [airflow] milton0825 opened a new pull request #4946: [AIRFLOW-4118] instrument DagRun duration

2019-03-19 Thread GitBox
milton0825 opened a new pull request #4946: [AIRFLOW-4118] instrument DagRun duration URL: https://github.com/apache/airflow/pull/4946 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/brow

[jira] [Reopened] (AIRFLOW-3706) Tooltip Display Issue for a Task Instance

2019-03-19 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-3706: Assignee: Ash Berlin-Taylor This was never resolved in 1.10.2 > Tooltip Displa

[jira] [Resolved] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asgeir Berland resolved AIRFLOW-4127. - Resolution: Fixed Fix Version/s: 2.0.0 PR fix in https://github.com/apache/airfl

[jira] [Work stopped] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-4127 stopped by Asgeir Berland. --- > Azure Container Instance Hook _get_instance_view bug > ---

[jira] [Work started] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-4127 started by Asgeir Berland. --- > Azure Container Instance Hook _get_instance_view bug > ---

[jira] [Commented] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796603#comment-16796603 ] ASF GitHub Bot commented on AIRFLOW-4127: - Trollgeir commented on pull request

[GitHub] [airflow] Trollgeir opened a new pull request #4945: [AIRFLOW-4127] _get_instance_view returns instance view

2019-03-19 Thread GitBox
Trollgeir opened a new pull request #4945: [AIRFLOW-4127] _get_instance_view returns instance view URL: https://github.com/apache/airflow/pull/4945 ### Jira https://issues.apache.org/jira/browse/AIRFLOW-4127 ### Description Simple bugfix for method `_get_instance_view`

[jira] [Assigned] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asgeir Berland reassigned AIRFLOW-4127: --- Assignee: Asgeir Berland > Azure Container Instance Hook _get_instance_view bug >

[jira] [Resolved] (AIRFLOW-4110) XSS issue with Search in Webserver

2019-03-19 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4110. Resolution: Duplicate > XSS issue with Search in Webserver >

[jira] [Commented] (AIRFLOW-4129) Escape HTML in tooltips

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796596#comment-16796596 ] ASF GitHub Bot commented on AIRFLOW-4129: - ashb commented on pull request #4944

[GitHub] [airflow] ashb opened a new pull request #4944: [AIRFLOW-4129] Escape HTML in generated tooltips

2019-03-19 Thread GitBox
ashb opened a new pull request #4944: [AIRFLOW-4129] Escape HTML in generated tooltips URL: https://github.com/apache/airflow/pull/4944 Many of these properties aren't user generated, but it is better to be safe Make sure you have checked _all_ steps below. ### Jira http

[jira] [Created] (AIRFLOW-4129) Escape HTML in tooltips

2019-03-19 Thread Ash Berlin-Taylor (JIRA)
Ash Berlin-Taylor created AIRFLOW-4129: -- Summary: Escape HTML in tooltips Key: AIRFLOW-4129 URL: https://issues.apache.org/jira/browse/AIRFLOW-4129 Project: Apache Airflow Issue Type: Bu

[jira] [Created] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread Asgeir Berland (JIRA)
Asgeir Berland created AIRFLOW-4127: --- Summary: Azure Container Instance Hook _get_instance_view bug Key: AIRFLOW-4127 URL: https://issues.apache.org/jira/browse/AIRFLOW-4127 Project: Apache Airflow

[jira] [Updated] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asgeir Berland updated AIRFLOW-4127: Description: Code: [https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/

[GitHub] [airflow] feng-tao edited a comment on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

2019-03-19 Thread GitBox
feng-tao edited a comment on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941#issuecomment-474612856 @dimberman , I think as a committer, we could restart / trigger individual test(e.g only the failed test)

[GitHub] [airflow] feng-tao commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

2019-03-19 Thread GitBox
feng-tao commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941#issuecomment-474612856 @dimberman , I think as a committer, we could restart individual test(e.g only the failed test) instead of doing

[GitHub] [airflow] dimberman commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 …

2019-03-19 Thread GitBox
dimberman commented on issue #4941: [AIRFLOW-4123] Add Exception handling for _change_state method in K8 … URL: https://github.com/apache/airflow/pull/4941#issuecomment-474612454 @feng-tao I now have the squash + merge ability. I'm gonna re-run the tests and if/when they pass I'll merge (f

[jira] [Created] (AIRFLOW-4128) Timezone transferring in macro doesn't work

2019-03-19 Thread Takako Ohshima (JIRA)
Takako Ohshima created AIRFLOW-4128: --- Summary: Timezone transferring in macro doesn't work Key: AIRFLOW-4128 URL: https://issues.apache.org/jira/browse/AIRFLOW-4128 Project: Apache Airflow

[jira] [Updated] (AIRFLOW-4127) Azure Container Instance Hook _get_instance_view bug

2019-03-19 Thread Asgeir Berland (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Asgeir Berland updated AIRFLOW-4127: Description: Code: [https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/

  1   2   3   >