Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-04-03 Thread via GitHub
jalengg commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1550940677 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str:

Re: [PR] Add method to get metadata from GCS blob in GCSHook [airflow]

2024-04-03 Thread via GitHub
jalengg commented on code in PR #38398: URL: https://github.com/apache/airflow/pull/38398#discussion_r1550939930 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1006,6 +1006,27 @@ def get_md5hash(self, bucket_name: str, object_name: str) -> str:

Re: [I] Simplify metrics handling [airflow]

2024-04-03 Thread via GitHub
ferruzzi commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2036209180 I think the easiest answer would be to convert the existing metrics tags dicts to ordereddicts, then in the stated_logger module you can join them and know they'll always be the

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
pankajkoti commented on PR #38702: URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036187771 cc: @alexott -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix broken task_log_prefix_template by adding it to FileTaskHandler itself. [airflow]

2024-04-03 Thread via GitHub
pankajkoti commented on PR #38709: URL: https://github.com/apache/airflow/pull/38709#issuecomment-2036179806 > I've verified this with S3 yet. Will check on others today Thanks @abhishekbhakat . GCP and Azure would be similar to S3. For Elasticsearch, I have detailed one of the ways

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
subham611 commented on PR #38702: URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036157949 @Lee-W All tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix broken task_log_prefix_template by adding it to FileTaskHandler itself. [airflow]

2024-04-03 Thread via GitHub
abhishekbhakat commented on PR #38709: URL: https://github.com/apache/airflow/pull/38709#issuecomment-2036152775 I've verified this with S3 yet. Will check on others today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Simplify metrics handling [airflow]

2024-04-03 Thread via GitHub
Jack-R-lantern commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2036137372 please assign me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on code in PR #38702: URL: https://github.com/apache/airflow/pull/38702#discussion_r1550840261 ## docs/apache-airflow-providers-databricks/operators/run_now.rst: ## @@ -45,6 +45,7 @@ All other parameters are optional and described in documentation for

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on code in PR #38702: URL: https://github.com/apache/airflow/pull/38702#discussion_r1550840261 ## docs/apache-airflow-providers-databricks/operators/run_now.rst: ## @@ -45,6 +45,7 @@ All other parameters are optional and described in documentation for

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1550835906 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -115,10 +124,52 @@ def poke(self, context: Context) -> bool: return False +def

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
subham611 commented on PR #38702: URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036102203 Fixed UTs and tested locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Deferrable mode for Custom Training Job operators [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on code in PR #38584: URL: https://github.com/apache/airflow/pull/38584#discussion_r1550831852 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -920,9 +1042,98 @@ def on_kill(self) -> None: if self.hook:

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on PR #38702: URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036098125 > @Lee-W Where can I see test failure logs? Scroll down a bit. You should be able to find it here. I just approved the CI run

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
subham611 commented on PR #38702: URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036087689 @Lee-W Where can I see test failure logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
subham611 commented on code in PR #38702: URL: https://github.com/apache/airflow/pull/38702#discussion_r1550790198 ## tests/providers/databricks/operators/test_databricks.py: ## @@ -1397,6 +1397,70 @@ def test_exec_failure_if_job_id_not_found(self, db_mock_class):

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on PR #38702: URL: https://github.com/apache/airflow/pull/38702#issuecomment-2036021639 I just noticed the test is failing. We might need your help to resolve it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Adds cancel previous run parameter [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on code in PR #38702: URL: https://github.com/apache/airflow/pull/38702#discussion_r1550766818 ## tests/providers/databricks/operators/test_databricks.py: ## @@ -1397,6 +1397,70 @@ def test_exec_failure_if_job_id_not_found(self, db_mock_class):

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-04-03 Thread via GitHub
boring-cyborg[bot] commented on PR #38732: URL: https://github.com/apache/airflow/pull/38732#issuecomment-2035996519 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-04-03 Thread via GitHub
RodrigoGanancia opened a new pull request, #38732: URL: https://github.com/apache/airflow/pull/38732 closes: #37451 This bug adresses a visual issue occuring when attempting to mark task states as Failed or Sucess, or when using clear button without the 'can edit

Re: [PR] Amazon Bedrock -Model Customization Jobs [airflow]

2024-04-03 Thread via GitHub
ferruzzi commented on code in PR #38693: URL: https://github.com/apache/airflow/pull/38693#discussion_r1550689743 ## airflow/providers/amazon/aws/waiters/bedrock.json: ## Review Comment: Added some. I think they about cover it. Let me know what you think. -- This is

Re: [PR] Fix triggerer race condition in HA setting [airflow]

2024-04-03 Thread via GitHub
Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1550668109 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,140 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword

Re: [PR] Add k8s recommended labels [airflow]

2024-04-03 Thread via GitHub
github-actions[bot] closed pull request #34735: Add k8s recommended labels URL: https://github.com/apache/airflow/pull/34735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] bump open api image to v7.3.0 [airflow]

2024-04-03 Thread via GitHub
github-actions[bot] closed pull request #34805: bump open api image to v7.3.0 URL: https://github.com/apache/airflow/pull/34805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat(helm): Add `enable` property to metric-exporter sidecar [airflow]

2024-04-03 Thread via GitHub
github-actions[bot] closed pull request #35633: feat(helm): Add `enable` property to metric-exporter sidecar URL: https://github.com/apache/airflow/pull/35633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] EksPodOperator doesn't work with deferrable=True [airflow]

2024-04-03 Thread via GitHub
github-actions[bot] commented on issue #38280: URL: https://github.com/apache/airflow/issues/38280#issuecomment-2035836753 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [PR] Fix triggerer race condition in HA setting [airflow]

2024-04-03 Thread via GitHub
Lioscro commented on PR #38666: URL: https://github.com/apache/airflow/pull/38666#issuecomment-2035826125 Could have sworn I ran pre-commit already... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix triggerer race condition in HA setting [airflow]

2024-04-03 Thread via GitHub
Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1550657716 ## tests/jobs/test_triggerer_job.py: ## @@ -309,6 +309,140 @@ def test_update_trigger_with_triggerer_argument_change( assert "got an unexpected keyword

Re: [PR] Fix triggerer race condition in HA setting [airflow]

2024-04-03 Thread via GitHub
Lioscro commented on code in PR #38666: URL: https://github.com/apache/airflow/pull/38666#discussion_r1550656016 ## airflow/jobs/triggerer_job_runner.py: ## @@ -672,6 +672,17 @@ def update_triggers(self, requested_trigger_ids: set[int]):

[PR] DB tess are now moved to a single, separate workflow [airflow]

2024-04-03 Thread via GitHub
potiuk opened a new pull request, #38731: URL: https://github.com/apache/airflow/pull/38731 This one wil group all the DB tests together in separate, foldable section - which will save some real estate in github actions. Those tess were never considered as separate and having single

Re: [PR] Fix inital value for _batch_id attribute in livy operator [airflow]

2024-04-03 Thread via GitHub
mateuslatrova commented on PR #38628: URL: https://github.com/apache/airflow/pull/38628#issuecomment-2035812370 Hi! I was also working on issue #37898 , and one of the requirements the author mentioned was: > "The Livy operator should fail due to a timeout, and simultaneously, it

Re: [I] cannot start 'airflow standalone'; pendulum.tz.timezone(tz) -> TypeError [airflow]

2024-04-03 Thread via GitHub
Taragolis commented on issue #38714: URL: https://github.com/apache/airflow/issues/38714#issuecomment-2035807101 > pendulum==3.0.0 Airflow before 2.8.1 doesn't support pendulum 3 Please consider to use provided constraints for appropriate version of Airflow(see [Installation

Re: [I] cannot start 'airflow standalone'; pendulum.tz.timezone(tz) -> TypeError [airflow]

2024-04-03 Thread via GitHub
Taragolis closed issue #38714: cannot start 'airflow standalone'; pendulum.tz.timezone(tz) -> TypeError URL: https://github.com/apache/airflow/issues/38714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Amazon Bedrock -Model Customization Jobs [airflow]

2024-04-03 Thread via GitHub
ferruzzi commented on code in PR #38693: URL: https://github.com/apache/airflow/pull/38693#discussion_r1550640629 ## airflow/providers/amazon/aws/waiters/bedrock.json: ## Review Comment: You know what, I'll admit that the fact that some are combined into

Re: [PR] Amazon Bedrock -Model Customization Jobs [airflow]

2024-04-03 Thread via GitHub
Taragolis commented on code in PR #38693: URL: https://github.com/apache/airflow/pull/38693#discussion_r1550638175 ## airflow/providers/amazon/aws/waiters/bedrock.json: ## Review Comment: > We don't test the waiters for other services TBH we test it, if we skip some

Re: [I] Fix remaining `PT012` pytest checks: `pytest-raises-with-multiple-statements` [airflow]

2024-04-03 Thread via GitHub
potiuk commented on issue #38270: URL: https://github.com/apache/airflow/issues/38270#issuecomment-2035795843 Cool! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Fix remaining `PT012` pytest checks: `pytest-raises-with-multiple-statements` [airflow]

2024-04-03 Thread via GitHub
potiuk closed issue #38270: Fix remaining `PT012` pytest checks: `pytest-raises-with-multiple-statements` URL: https://github.com/apache/airflow/issues/38270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-04-03 Thread via GitHub
hussein-awala commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2035794498 You can check https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst to fix the static checks. -- This is an automated message from the Apache

[PR] Better cleanup `LazyDictWithCache` and `ProviderManager` [airflow]

2024-04-03 Thread via GitHub
Taragolis opened a new pull request, #38730: URL: https://github.com/apache/airflow/pull/38730 This changes most attempt to fix cleanup ProviderManager, which I guess only use in tests. Right now it might keep some values between the test as result it might not unwrap

(airflow) branch main updated: bump uv to 0.1.28 (#38690)

2024-04-03 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6c217ae342 bump uv to 0.1.28 (#38690)

Re: [PR] bump uv to 0.1.28 [airflow]

2024-04-03 Thread via GitHub
hussein-awala merged PR #38690: URL: https://github.com/apache/airflow/pull/38690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) 01/01: The dev0 suffix should only be applied in main (#38727)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 0dee402a7065cc8017ac16f3b95e76f5efa18924 Author: Jarek Potiuk AuthorDate: Thu Apr 4 01:07:56 2024 +0200 The

(airflow) branch v2-9-test updated (182b584545 -> 0dee402a70)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git discard 182b584545 The dev0 suffix should only be applied in main new 0dee402a70 The dev0 suffix should only be

(airflow) branch main updated (f142e9ba4e -> 0f7f2fa6a2)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f142e9ba4e Add support for OrbStack in breeze (#38725) add 0f7f2fa6a2 The dev0 suffix should only be applied in

Re: [PR] The dev0 suffix should only be applied in main [airflow]

2024-04-03 Thread via GitHub
potiuk merged PR #38727: URL: https://github.com/apache/airflow/pull/38727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] The dev0 suffix should only be applied in main [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38727: URL: https://github.com/apache/airflow/pull/38727#issuecomment-2035719986 One more last change to get PROD builds for FAB working in v2-9-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fix grid header rendering [airflow]

2024-04-03 Thread via GitHub
bbovenzi commented on PR #38720: URL: https://github.com/apache/airflow/pull/38720#issuecomment-2035690515 Before: (note how we're looking at the summary of mapped tasks) https://github.com/apache/airflow/assets/4600967/b7c8a236-c2c1-4b29-be8a-8ca63ca3c11f;> After:

(airflow) branch v2-9-test updated: The dev0 suffix should only be applied in main

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v2-9-test by this push: new 182b584545 The dev0 suffix should only

[PR] The dev0 suffix should only be applied in main [airflow]

2024-04-03 Thread via GitHub
potiuk opened a new pull request, #38727: URL: https://github.com/apache/airflow/pull/38727 For production build we should apply the package prefix depending on branch we are in. In main we apply dev0 suffix for development, but in the release branch we should not apply the suffix.

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-04-03 Thread via GitHub
idantepper commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2035666372 hello, after having some issues with my developing environment now everything is done also added the change that hussein recommended. thanks -- This is an automated

(airflow) branch main updated: Add support for OrbStack in breeze (#38725)

2024-04-03 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f142e9ba4e Add support for OrbStack in

Re: [PR] Add support for OrbStack in breeze [airflow]

2024-04-03 Thread via GitHub
jedcunningham merged PR #38725: URL: https://github.com/apache/airflow/pull/38725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix minor typo in Breeze cheatsheet [airflow]

2024-04-03 Thread via GitHub
jscheffl merged PR #38692: URL: https://github.com/apache/airflow/pull/38692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Fix minor typo in Breeze cheatsheet (#38692)

2024-04-03 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 10db7d543a Fix minor typo in Breeze cheatsheet

Re: [PR] Fix grid header rendering [airflow]

2024-04-03 Thread via GitHub
jscheffl commented on PR #38720: URL: https://github.com/apache/airflow/pull/38720#issuecomment-2035592900 From code and description I do not see and understand where the problem is - therefore it is hard for me to understand where and what is fixed. Maybe I am still to noob in the UI

Re: [PR] Clean up the exception handler when run_as_user is the airflow user [airflow]

2024-04-03 Thread via GitHub
boring-cyborg[bot] commented on PR #38726: URL: https://github.com/apache/airflow/pull/38726#issuecomment-2035551194 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Clean up the exception handler when run_as_user is the airflow user [airflow]

2024-04-03 Thread via GitHub
squingo44 opened a new pull request, #38726: URL: https://github.com/apache/airflow/pull/38726 During the heartbeat check, the `local_task_job_runner` performs a check on the job's PID and raises an exception if it doesn't match what it expects. In the case that the

Re: [PR] Add support for OrbStack in breeze [airflow]

2024-04-03 Thread via GitHub
ashb commented on PR #38725: URL: https://github.com/apache/airflow/pull/38725#issuecomment-2035530322 Orbstack is magic in how quick it makes things feel - especially Kube resources. I don't get how it's possible! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add support for OrbStack in breeze [airflow]

2024-04-03 Thread via GitHub
jedcunningham commented on PR #38725: URL: https://github.com/apache/airflow/pull/38725#issuecomment-2035520234 > BTW. Docker Desktop **just** introduce a resource saving mode which looks promising :) I always have at least 1 container running, so it doesn't help my specific

(airflow) branch main updated (e2cf24f4d6 -> c65ebdac32)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e2cf24f4d6 Remove FAB provider from "chicken-egg" providers. (#38698) add c65ebdac32 Update providers metadata

Re: [PR] Update providers metadata 2024-04-03 [airflow]

2024-04-03 Thread via GitHub
potiuk merged PR #38706: URL: https://github.com/apache/airflow/pull/38706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add support for OrbStack in breeze [airflow]

2024-04-03 Thread via GitHub
jedcunningham commented on PR #38725: URL: https://github.com/apache/airflow/pull/38725#issuecomment-2035518912 My favorite feature so far: k8s services are exposed automatically. No more `kubectl port-forward`ing constantly  -- This is an automated message from the Apache Git Service.

Re: [PR] Add support for OrbStack in breeze [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38725: URL: https://github.com/apache/airflow/pull/38725#issuecomment-2035517809 BTW. Docker Desktop **just** introduce a resource saving mode which looks promising :) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add support for OrbStack in breeze [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38725: URL: https://github.com/apache/airflow/pull/38725#issuecomment-2035516331 Nice. Must check it one day :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update providers metadata 2024-04-03 [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38706: URL: https://github.com/apache/airflow/pull/38706#issuecomment-2035512569 :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(airflow) branch v2-9-test updated (e7fa4fb8d9 -> 048518fd45)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git from e7fa4fb8d9 Extract checkout target commit to a composite action (#38682) new 037effd0d7 Drop pre-release

(airflow) 01/04: Drop pre-release specification from pre-installed provider versions (#38703)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 037effd0d76e32a0af5e0c309133f8aa15f41f7b Author: Jarek Potiuk AuthorDate: Wed Apr 3 16:30:46 2024 +0200 Drop

(airflow) 02/04: Fix few nits in tag-providers command (#38705)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit be98e4593cbb4dd01acf0b89320db168fddd5227 Author: Jarek Potiuk AuthorDate: Wed Apr 3 16:30:10 2024 +0200 Fix

(airflow) 04/04: Remove FAB provider from "chicken-egg" providers. (#38698)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 048518fd45437238511a1fc205d5e5a3774cdcbb Author: Jarek Potiuk AuthorDate: Wed Apr 3 22:20:14 2024 +0200 Remove

(airflow) 03/04: Remove obtain postgres APT repo signing key from mysql install script (#38700)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-9-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 99a64c4e827d9fad33b122f225f97dc2816b2d60 Author: Andrey Anshin AuthorDate: Wed Apr 3 18:36:45 2024 +0400

(airflow) branch main updated (17eaf8eae3 -> e2cf24f4d6)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 17eaf8eae3 Resolve `PT012` in `SFTP` provider tests (#38518) add e2cf24f4d6 Remove FAB provider from

Re: [PR] Remove FAB provider from "chicken-egg" providers. [airflow]

2024-04-03 Thread via GitHub
potiuk merged PR #38698: URL: https://github.com/apache/airflow/pull/38698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add support for orbstack in breeze [airflow]

2024-04-03 Thread via GitHub
jedcunningham opened a new pull request, #38725: URL: https://github.com/apache/airflow/pull/38725 I've moved away from Docker Desktop to Orbstack. So far everything seems to be working just fine, so I'd like to make it easier for others to use orbstack without mangling their docker

Re: [I] Ensure teardown doesn't run until all other tasks complete [airflow]

2024-04-03 Thread via GitHub
jscheffl commented on issue #29332: URL: https://github.com/apache/airflow/issues/29332#issuecomment-2035502056 Can you please double-check the documentation in https://airflow.apache.org/docs/apache-airflow/stable/howto/setup-and-teardown.html#setup-and-teardown ? The setup task in your

Re: [I] Fix remaining `PT012` pytest checks: `pytest-raises-with-multiple-statements` [airflow]

2024-04-03 Thread via GitHub
shahar1 commented on issue #38270: URL: https://github.com/apache/airflow/issues/38270#issuecomment-2035490374 And we're done :) Good job everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]

2024-04-03 Thread via GitHub
potiuk closed pull request #38525: Fix message raised on excepion in SFTP deferrable operator URL: https://github.com/apache/airflow/pull/38525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035485085 Fixed in https://github.com/apache/airflow/pull/38518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035484684 臘 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(airflow) branch main updated: Resolve `PT012` in `SFTP` provider tests (#38518)

2024-04-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 17eaf8eae3 Resolve `PT012` in `SFTP` provider

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-04-03 Thread via GitHub
potiuk merged PR #38518: URL: https://github.com/apache/airflow/pull/38518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38518: URL: https://github.com/apache/airflow/pull/38518#issuecomment-2035482917 臘 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Add hook_params to template_fields for BaseSQLOperator-related Operators [airflow]

2024-04-03 Thread via GitHub
odaneau-astro opened a new pull request, #38724: URL: https://github.com/apache/airflow/pull/38724 This PR adds `hook_params` to `template_fields` for all Operators inheriting from BaseSQLOperator. This change is necessary to pass DAG related attributes as query tags

Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]

2024-04-03 Thread via GitHub
shahar1 commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035454759 > Needs rebase and solving conflict though :) Oh woops, I did it in mine: #38518 Sorry for the confusion -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]

2024-04-03 Thread via GitHub
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035452511 Needs rebase and solving conflict though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]

2024-04-03 Thread via GitHub
shahar1 commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035446961 > > > Ah I see we also have #38518 with the same changes @shahar1 - do you want to proceed with yours? > > > > > > I prefer so :) > > @Bowrna no worries, feel free to

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-04-03 Thread via GitHub
shahar1 commented on code in PR #38518: URL: https://github.com/apache/airflow/pull/38518#discussion_r1550356533 ## tests/providers/sftp/triggers/test_sftp.py: ## @@ -175,13 +175,10 @@ async def test_sftp_trigger_run_trigger_failure_state(self, mock_get_files_by_pa

(airflow) branch main updated: Restore airflow_local_settings after the `test_should_use_configured_log_name` (#38722)

2024-04-03 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 40c70e3d03 Restore airflow_local_settings after

Re: [PR] Restore airflow_local_settings after the `test_should_use_configured_log_name` [airflow]

2024-04-03 Thread via GitHub
Taragolis merged PR #38722: URL: https://github.com/apache/airflow/pull/38722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

2024-04-03 Thread via GitHub
zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550311342 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

2024-04-03 Thread via GitHub
eladkal commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550301331 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

2024-04-03 Thread via GitHub
zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550297987 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] NeptuneStopDbClusterOperator - Handle invalid cluster states [airflow]

2024-04-03 Thread via GitHub
ellisms commented on code in PR #38287: URL: https://github.com/apache/airflow/pull/38287#discussion_r1550288490 ## airflow/providers/amazon/aws/operators/neptune.py: ## @@ -174,17 +253,91 @@ def __init__( self.delay = waiter_delay self.max_attempts =

Re: [PR] NeptuneStopDbClusterOperator - Handle invalid cluster states [airflow]

2024-04-03 Thread via GitHub
ellisms commented on code in PR #38287: URL: https://github.com/apache/airflow/pull/38287#discussion_r1550287756 ## airflow/providers/amazon/aws/operators/neptune.py: ## @@ -81,17 +85,86 @@ def __init__( self.delay = waiter_delay self.max_attempts =

Re: [PR] NeptuneStopDbClusterOperator - Handle invalid cluster states [airflow]

2024-04-03 Thread via GitHub
ellisms commented on PR #38287: URL: https://github.com/apache/airflow/pull/38287#issuecomment-2035343869 @eladkal Not yet, just getting back into the office. Working on making the suggested changes. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix SparkKubernetesOperator when using initContainers [airflow]

2024-04-03 Thread via GitHub
eladkal commented on PR #38119: URL: https://github.com/apache/airflow/pull/38119#issuecomment-2035340046 @ShelRoman kind reminder, can you please add tests to cover this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] NeptuneStopDbClusterOperator - Handle invalid cluster states [airflow]

2024-04-03 Thread via GitHub
eladkal commented on PR #38287: URL: https://github.com/apache/airflow/pull/38287#issuecomment-2035336034 @ellisms is the PR ready for re-review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(airflow) branch main updated (9b2d7cb712 -> 537e0e695b)

2024-04-03 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9b2d7cb712 Reorder OpenAPI Spec tags alphabetically (#38717) add 537e0e695b docs: add timeout description to

Re: [PR] docs: add timeout description to DockerOperator. [airflow]

2024-04-03 Thread via GitHub
eladkal merged PR #38710: URL: https://github.com/apache/airflow/pull/38710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Amazon Bedrock -Model Customization Jobs [airflow]

2024-04-03 Thread via GitHub
ferruzzi commented on code in PR #38693: URL: https://github.com/apache/airflow/pull/38693#discussion_r1550257495 ## airflow/providers/amazon/aws/waiters/bedrock.json: ## Review Comment: I'm not sure about this one. We don't test the waiters for other services and it's

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

2024-04-03 Thread via GitHub
eladkal commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550265521 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

  1   2   3   >