Re: [PR] Activate RUF015 that checks for unnecessary iterable allocation for first element [airflow]

2024-04-11 Thread via GitHub
uranusjr commented on code in PR #38949: URL: https://github.com/apache/airflow/pull/38949#discussion_r1562049749 ## dev/perf/scheduler_dag_execution_timing.py: ## @@ -79,8 +79,7 @@ def change_state(self, key, state, info=None): if not run: import

Re: [PR] Fix try_number handling when db isolation enabled [airflow]

2024-04-11 Thread via GitHub
dstandish commented on code in PR #38943: URL: https://github.com/apache/airflow/pull/38943#discussion_r1562047896 ## airflow/models/dagrun.py: ## @@ -650,7 +650,6 @@ def get_task_instance( ) @staticmethod -@internal_api_call Review Comment: Basis for

Re: [PR] Fix try_number handling when db isolation enabled [airflow]

2024-04-11 Thread via GitHub
dstandish commented on code in PR #38943: URL: https://github.com/apache/airflow/pull/38943#discussion_r1562046802 ## airflow/models/taskinstance.py: ## @@ -539,7 +539,7 @@ def _refresh_from_db( task_instance.end_date = ti.end_date task_instance.duration =

Re: [PR] Fix try_number handling when db isolation enabled [airflow]

2024-04-11 Thread via GitHub
uranusjr commented on code in PR #38943: URL: https://github.com/apache/airflow/pull/38943#discussion_r1562045467 ## airflow/models/taskinstance.py: ## @@ -539,7 +539,7 @@ def _refresh_from_db( task_instance.end_date = ti.end_date task_instance.duration =

Re: [PR] Fix try_number handling when db isolation enabled [airflow]

2024-04-11 Thread via GitHub
uranusjr commented on code in PR #38943: URL: https://github.com/apache/airflow/pull/38943#discussion_r1562044901 ## airflow/models/dagrun.py: ## @@ -650,7 +650,6 @@ def get_task_instance( ) @staticmethod -@internal_api_call Review Comment: cc @vincbeck

Re: [PR] Don't queue runs on DatasetEvent for disabled DAGs [airflow]

2024-04-11 Thread via GitHub
uranusjr commented on PR #38891: URL: https://github.com/apache/airflow/pull/38891#issuecomment-2050995652 The catchup flag still affects time-based scheduling (and only that). I’ll call that out explicitly in the fragment. -- This is an automated message from the Apache Git Service. To

Re: [I] Unable to mock Variable in python unittest [airflow]

2024-04-11 Thread via GitHub
aritra24 closed issue #38944: Unable to mock Variable in python unittest URL: https://github.com/apache/airflow/issues/38944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Remove unnecessary nginx redirect rule from reverse proxy documentation [airflow]

2024-04-11 Thread via GitHub
scottlimmer opened a new pull request, #38953: URL: https://github.com/apache/airflow/pull/38953 Remove redirect rule for flower config as per https://airflow.apache.org/docs/apache-airflow/stable/security/flower.html#flower-url-prefix --- **^ Add

Re: [I] Unable to mock Variable in python unittest [airflow]

2024-04-11 Thread via GitHub
aritra24 commented on issue #38944: URL: https://github.com/apache/airflow/issues/38944#issuecomment-2050983951 Closing this issue in that case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Remove unnecessary nginx redirect rule from reverse proxy documentation [airflow]

2024-04-11 Thread via GitHub
boring-cyborg[bot] commented on PR #38953: URL: https://github.com/apache/airflow/pull/38953#issuecomment-2050981803 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

Re: [PR] Don't queue runs on DatasetEvent for disabled DAGs [airflow]

2024-04-11 Thread via GitHub
eladkal commented on PR #38891: URL: https://github.com/apache/airflow/pull/38891#issuecomment-2050975597 > I decided to not consider catchup at all here, and make the behavior change as simple as possible. A news fragment has been added to note the breaking change. What does it

Re: [PR] KPO xcom sidecar PodDefault usage [airflow]

2024-04-11 Thread via GitHub
dirrao commented on code in PR #38951: URL: https://github.com/apache/airflow/pull/38951#discussion_r1561968503 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -42,7 +42,7 @@ from airflow.exceptions import AirflowException, AirflowProviderDeprecationWarning

Re: [I] Retry if failed from queued should be separate from try_number [airflow]

2024-04-11 Thread via GitHub
Bowrna commented on issue #38304: URL: https://github.com/apache/airflow/issues/38304#issuecomment-2050826701 > The thing is that task_instance is not created yet because ... the task is in the queue. So what needs to happen is that the whole logic should happen in scheduler - becuase it's

Re: [I] DatabricksSQLOperator struggles with parsing the data [airflow]

2024-04-11 Thread via GitHub
github-actions[bot] commented on issue #36838: URL: https://github.com/apache/airflow/issues/36838#issuecomment-2050747458 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [I] EksPodOperator doesn't work with deferrable=True [airflow]

2024-04-11 Thread via GitHub
github-actions[bot] commented on issue #38280: URL: https://github.com/apache/airflow/issues/38280#issuecomment-2050747410 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] EksPodOperator doesn't work with deferrable=True [airflow]

2024-04-11 Thread via GitHub
github-actions[bot] closed issue #38280: EksPodOperator doesn't work with deferrable=True URL: https://github.com/apache/airflow/issues/38280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Apply sqlalchemy2 stubs [airflow]

2024-04-11 Thread via GitHub
hussein-awala commented on PR #38942: URL: https://github.com/apache/airflow/pull/38942#issuecomment-2050693402 > I tried, but I think I overused cast and TYPE_CHEKING. Personally, I have no issue with that, this casting improves the dev experience and helps to use the IDE

Re: [PR] Apply sqlalchemy2 stubs [airflow]

2024-04-11 Thread via GitHub
hussein-awala commented on code in PR #38942: URL: https://github.com/apache/airflow/pull/38942#discussion_r1561837881 ## airflow/cli/commands/task_command.py: ## @@ -97,7 +97,7 @@ def _get_dag_run( dag: DAG, create_if_necessary: CreateIfNecessary,

Re: [PR] Activate RUF019 that checks for unnecessary key check [airflow]

2024-04-11 Thread via GitHub
Taragolis commented on code in PR #38950: URL: https://github.com/apache/airflow/pull/38950#discussion_r1561836489 ## airflow/providers/google/cloud/hooks/bigquery.py: ## @@ -2849,7 +2849,7 @@ def next(self) -> list | None: return None

Re: [PR] Use default_factory instead of calling the method in dataclass [airflow]

2024-04-11 Thread via GitHub
Taragolis commented on PR #38948: URL: https://github.com/apache/airflow/pull/38948#issuecomment-2050671774 AFAIK it is exact the opposite, default values assigned exactly once, as well as module imports exactly once, if do not count manual reload through importlib or clear sys.modules

Re: [PR] KPO xcom sidecar PodDefault usage [airflow]

2024-04-11 Thread via GitHub
jedcunningham commented on code in PR #38951: URL: https://github.com/apache/airflow/pull/38951#discussion_r1561823263 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -42,7 +42,7 @@ from airflow.exceptions import AirflowException,

[PR] KPO xcom sidecar PodDefault usage [airflow]

2024-04-11 Thread via GitHub
jedcunningham opened a new pull request, #38951: URL: https://github.com/apache/airflow/pull/38951 We should use the same, non deprecated, version of PodDefaults for the xcom sidecar when creating and reading xcom. -- This is an automated message from the Apache Git Service. To respond

[PR] Activate RUF019 that checks for unnecessary key check [airflow]

2024-04-11 Thread via GitHub
hussein-awala opened a new pull request, #38950: URL: https://github.com/apache/airflow/pull/38950 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Activate RUF006 rule to detect dangling asyncio tasks [airflow]

2024-04-11 Thread via GitHub
hussein-awala opened a new pull request, #38947: URL: https://github.com/apache/airflow/pull/38947 This rule is useful to detect the asyncio tasks which are created without setting their reference to a variable because this could lead to unexpected results like removing them by GC. --

Re: [PR] inherit key "verify" from env into session so that kv_client can read it properly [airflow]

2024-04-11 Thread via GitHub
chz8494 commented on PR #38614: URL: https://github.com/apache/airflow/pull/38614#issuecomment-2050612522 @hussein-awala can someone review and suggest if tests good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fix try_number handling when db isolation enabled [airflow]

2024-04-11 Thread via GitHub
dstandish commented on PR #38943: URL: https://github.com/apache/airflow/pull/38943#issuecomment-2050592083 this, dealing, as it does, with try_number, is a weird one, so i'm gonna let it go overnight to see if @uranusjr @potiuk @jedcunningham want to give it a look -- This is an

Re: [PR] Do not log event when using db isolation [airflow]

2024-04-11 Thread via GitHub
dstandish closed pull request #38906: Do not log event when using db isolation URL: https://github.com/apache/airflow/pull/38906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Make default_action_log an RPC function [airflow]

2024-04-11 Thread via GitHub
dstandish opened a new pull request, #38946: URL: https://github.com/apache/airflow/pull/38946 To use RPC, we need to accept a session, which is provided by the RPC call handler. But, the action log callback system may already be forwarding a session, so to avoid a collision, I have made

(airflow) branch main updated (725c568e73 -> 4a3caa2e35)

2024-04-11 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 725c568e73 fix(airbyte/hooks): add schema and port to prevent InvalidURL error (#38860) add 4a3caa2e35 Amazon

Re: [PR] Amazon Bedrock - System Test Fixes [airflow]

2024-04-11 Thread via GitHub
vincbeck merged PR #38945: URL: https://github.com/apache/airflow/pull/38945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Suppress jaydebeapi.Error when setAutoCommit or getAutoCommit is unsupported by JDBC driver [airflow]

2024-04-11 Thread via GitHub
dabla commented on code in PR #38707: URL: https://github.com/apache/airflow/pull/38707#discussion_r1561754471 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -111,6 +112,15 @@ def fetch_one_handler(cursor) -> list[tuple] | None: return None +@contextmanager

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
dabla commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050548933 > I told you adding local imports is **really** not a good idea - those imports are needed elsewhere (in unit tests where they are mocked). Yeah saw it too, moved them at top of

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
dabla commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050548094 > Surely, but we have the same problem with common code. If we add it today, it's only going to be really usable 10 months from now. because providers are importing stuff from earlier

Re: [PR] Amazon Bedrock - System Test Fixes [airflow]

2024-04-11 Thread via GitHub
ferruzzi commented on PR #38945: URL: https://github.com/apache/airflow/pull/38945#issuecomment-2050510573 @vincbeck - Feel free to review and merge at your convenience -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Amazon Bedrock - System Test Fixes [airflow]

2024-04-11 Thread via GitHub
ferruzzi opened a new pull request, #38945: URL: https://github.com/apache/airflow/pull/38945 Hardcoded region names caused an issue since the dashboard pipeline runs in a different region. Also tweaked some variable names to try to be a little more clear. --- **^

Re: [I] Full screen mode for Logs, Graph, Code etc.. [airflow]

2024-04-11 Thread via GitHub
bbovenzi commented on issue #33012: URL: https://github.com/apache/airflow/issues/33012#issuecomment-2050500574 We also made the filter bar collapsible: https://github.com/apache/airflow/pull/38296 Im going to improve the UX of it for 2.9.1 but yes, this is done. -- This is an

Re: [I] Full screen mode for Logs, Graph, Code etc.. [airflow]

2024-04-11 Thread via GitHub
bbovenzi closed issue #33012: Full screen mode for Logs, Graph, Code etc.. URL: https://github.com/apache/airflow/issues/33012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(airflow) branch main updated (f87772f52a -> 725c568e73)

2024-04-11 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f87772f52a Fix dag run selection (#38941) add 725c568e73 fix(airbyte/hooks): add schema and port to prevent

Re: [PR] fix(airbyte/hooks): add schema and port to prevent InvalidURL error [airflow]

2024-04-11 Thread via GitHub
boring-cyborg[bot] commented on PR #38860: URL: https://github.com/apache/airflow/pull/38860#issuecomment-2050497441 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [I] `AirbyteTriggerSyncOperator` does not work on deferrable mode [airflow]

2024-04-11 Thread via GitHub
eladkal closed issue #37449: `AirbyteTriggerSyncOperator` does not work on deferrable mode URL: https://github.com/apache/airflow/issues/37449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix(airbyte/hooks): add schema and port to prevent InvalidURL error [airflow]

2024-04-11 Thread via GitHub
eladkal merged PR #38860: URL: https://github.com/apache/airflow/pull/38860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Fix dag run selection (#38941)

2024-04-11 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f87772f52a Fix dag run selection (#38941)

Re: [I] You cannot see newer DAG runs if you open a link to a specific DAG run [UI Bug] [New as of 2.9.0?] [airflow]

2024-04-11 Thread via GitHub
eladkal closed issue #38939: You cannot see newer DAG runs if you open a link to a specific DAG run [UI Bug] [New as of 2.9.0?] URL: https://github.com/apache/airflow/issues/38939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fix dag run selection [airflow]

2024-04-11 Thread via GitHub
eladkal merged PR #38941: URL: https://github.com/apache/airflow/pull/38941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Unable to mock Variable in python unittest [airflow]

2024-04-11 Thread via GitHub
ivanwakeup commented on issue #38944: URL: https://github.com/apache/airflow/issues/38944#issuecomment-2050438532 I think i found the issue. lowercase `my_test_var` instead of `MY_TEST_VAR` in the variable definition causes airflow to not pickup the value. changing this fixes it. --

Re: [PR] Suppress jaydebeapi.Error when setAutoCommit or getAutoCommit is unsupported by JDBC driver [airflow]

2024-04-11 Thread via GitHub
Taragolis commented on code in PR #38707: URL: https://github.com/apache/airflow/pull/38707#discussion_r1561583638 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -111,6 +112,15 @@ def fetch_one_handler(cursor) -> list[tuple] | None: return None

Re: [PR] Pass through more parameters to AzureBlobFileSystem to mirror handlin… [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38747: URL: https://github.com/apache/airflow/pull/38747#issuecomment-2050400684 Tests failing, I am afraid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050393302 I told you adding local imports is **really** not a good idea - those imports are needed elsewhere (in unit tests where they are mocked). -- This is an automated message from the

Re: [PR] Always use the executemany method when inserting rows in DbApiHook as it's way much faster [airflow]

2024-04-11 Thread via GitHub
uranusjr commented on code in PR #38715: URL: https://github.com/apache/airflow/pull/38715#discussion_r1561554648 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -550,47 +557,48 @@ def insert_rows( :param commit_every: The maximum number of rows to insert in one

(airflow) branch improve-warning-system updated (f75f498d45 -> 0c26326f04)

2024-04-11 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch improve-warning-system in repository https://gitbox.apache.org/repos/asf/airflow.git omit f75f498d45 Add group based on where warnings raised add 0c26326f04 Add group based on where

Re: [PR] Always use the executemany method when inserting rows in DbApiHook as it's way much faster [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38715: URL: https://github.com/apache/airflow/pull/38715#issuecomment-2050377843 > Also wondering why these tests are failing as those are unrelated with my changes (I think): I'd say it's a side-effect of another test that probably interact with caplog in a

(airflow) branch improve-warning-system updated (35b4fd406b -> f75f498d45)

2024-04-11 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch improve-warning-system in repository https://gitbox.apache.org/repos/asf/airflow.git omit 35b4fd406b Change capture warnings output format to the JSON add cdc7f19b57 Add retry logic

Re: [PR] Fix `SAWarning` 'Coercing Subquery object into a select() for use in IN()' [airflow]

2024-04-11 Thread via GitHub
Taragolis merged PR #38926: URL: https://github.com/apache/airflow/pull/38926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (cd88ddb4f1 -> 05ba268d05)

2024-04-11 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from cd88ddb4f1 Limit redis image to 7.2 in sample docker-compose.yaml (#38938) add 05ba268d05 Fix `SAWarning`

Re: [PR] Always use the executemany method when inserting rows in DbApiHook as it's way much faster [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38715: URL: https://github.com/apache/airflow/pull/38715#issuecomment-2050337696 I re-run it. Seems like intermittent error because of broken docker on GitHub Runner. Happens. `docker: Error response from daemon: unauthorized: authentication required.` --

Re: [PR] Always use the executemany method when inserting rows in DbApiHook as it's way much faster [airflow]

2024-04-11 Thread via GitHub
dabla commented on PR #38715: URL: https://github.com/apache/airflow/pull/38715#issuecomment-2050338045 Also wondering why these tests are failing as those are unrelated with my changes (I think): ``` ___ TestWasbBlobSensorTrigger.test_waiting_for_blob

(airflow) branch main updated: Limit redis image to 7.2 in sample docker-compose.yaml (#38938)

2024-04-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cd88ddb4f1 Limit redis image to 7.2 in sample

Re: [PR] Limit redis image to 7.2 in sample docker-compose.yaml [airflow]

2024-04-11 Thread via GitHub
potiuk merged PR #38938: URL: https://github.com/apache/airflow/pull/38938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] Unable to mock Variable in python unittest [airflow]

2024-04-11 Thread via GitHub
ivanwakeup opened a new issue, #38944: URL: https://github.com/apache/airflow/issues/38944 ### What do you see as an issue? The airflow Best Practices documentation page suggests using `unittest.mock.patch` along with setting `os.environ` values to mock Variables and Connections.

Re: [I] Unable to mock Variable in python unittest [airflow]

2024-04-11 Thread via GitHub
boring-cyborg[bot] commented on issue #38944: URL: https://github.com/apache/airflow/issues/38944#issuecomment-2050324177 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

Re: [PR] Pass through more parameters to AzureBlobFileSystem to mirror handlin… [airflow]

2024-04-11 Thread via GitHub
tomrutter commented on PR #38747: URL: https://github.com/apache/airflow/pull/38747#issuecomment-2050318290 Checked tests and linting pass, and rebased to latest main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fix try_number handling when db isolation enabled [airflow]

2024-04-11 Thread via GitHub
dstandish commented on code in PR #38943: URL: https://github.com/apache/airflow/pull/38943#discussion_r1561498670 ## airflow/models/dagrun.py: ## @@ -650,7 +650,6 @@ def get_task_instance( ) @staticmethod -@internal_api_call Review Comment: this is a

Re: [PR] Fix error when setting try_number from TaskInstancePydantic [airflow]

2024-04-11 Thread via GitHub
dstandish commented on PR #38907: URL: https://github.com/apache/airflow/pull/38907#issuecomment-2050307736 closing in favor of #38943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix error when setting try_number from TaskInstancePydantic [airflow]

2024-04-11 Thread via GitHub
dstandish closed pull request #38907: Fix error when setting try_number from TaskInstancePydantic URL: https://github.com/apache/airflow/pull/38907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Fix try_number handling when db isolation enabled [airflow]

2024-04-11 Thread via GitHub
dstandish opened a new pull request, #38943: URL: https://github.com/apache/airflow/pull/38943 There was an error in the refresh_from_db code, and because of try_number inconsistency, the same run was going into two different log files. There is some ugliness here, but some ugliness is

Re: [I] You cannot see newer DAG runs if you open a link to a specific DAG run [UI Bug] [New as of 2.9.0?] [airflow]

2024-04-11 Thread via GitHub
Rafnel commented on issue #38939: URL: https://github.com/apache/airflow/issues/38939#issuecomment-2050306084 Awesome, thank you all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix(airbyte/hooks): add schema and port to prevent InvalidURL error [airflow]

2024-04-11 Thread via GitHub
josix commented on PR #38860: URL: https://github.com/apache/airflow/pull/38860#issuecomment-2050283042 Hi @hussein-awala thanks for the advise, I've added the test for it. PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] on_failure_callback is not called when task is manually marked as failed [airflow]

2024-04-11 Thread via GitHub
FFCMSouza commented on issue #38935: URL: https://github.com/apache/airflow/issues/38935#issuecomment-2050273127 I saw that on version 1.9.0, thats already a different type of exception for this cases. I believe that the following change could be made to fix that behavior: `

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
dabla commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050266922 @potiuk FYI: I've also deleted the apache-airflow-providers-msgraph package under pypi -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
dabla commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050247170 > > But if you confirm this is fine then no problem I will do it like this :) > > Yes. We do it in a number of other places - you already looked at it. > > > couldn't we

(airflow) branch main updated (f3ab31de97 -> c25d346adf)

2024-04-11 Thread ferruzzi
This is an automated email from the ASF dual-hosted git repository. ferruzzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f3ab31de97 Use `model_dump` instead of `dict` for serialize Pydantic V2 model (#38933) add c25d346adf Amazon

Re: [PR] Amazon Bedrock - Model Throughput Provisioning [airflow]

2024-04-11 Thread via GitHub
ferruzzi merged PR #38850: URL: https://github.com/apache/airflow/pull/38850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Apply sqlalchemy2 stubs [airflow]

2024-04-11 Thread via GitHub
phi-friday opened a new pull request, #38942: URL: https://github.com/apache/airflow/pull/38942 [Mypy / Pep-484 Support for ORM Mappings](https://docs.sqlalchemy.org/en/20/orm/extensions/mypy.html) To support 1.4 and 2.x simultaneously, it seems best to use

[PR] Fix dag run selection [airflow]

2024-04-11 Thread via GitHub
bbovenzi opened a new pull request, #38941: URL: https://github.com/apache/airflow/pull/38941 Fixes: https://github.com/apache/airflow/issues/38939 We added logic to change the date filters for the grid data when the selected run_id was out of range. But that created its own issue

Re: [I] Add a Reset Password button under Security > List Users > Edit user [airflow]

2024-04-11 Thread via GitHub
aritra24 commented on issue #37030: URL: https://github.com/apache/airflow/issues/37030#issuecomment-2050205856 @poorvirohidekar I believe it's part of the [Flask app

(airflow) branch main updated (55b251f849 -> f3ab31de97)

2024-04-11 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 55b251f849 Replace also "-" in providers compatibility check specification (#38936) add f3ab31de97 Use

Re: [PR] Use `model_dump` instead of `dict` for serialize Pydantic V2 model [airflow]

2024-04-11 Thread via GitHub
Taragolis merged PR #38933: URL: https://github.com/apache/airflow/pull/38933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] You cannot see newer DAG runs if you open a link to a specific DAG run [UI Bug] [New as of 2.9.0?] [airflow]

2024-04-11 Thread via GitHub
eladkal commented on issue #38939: URL: https://github.com/apache/airflow/issues/38939#issuecomment-2050171659 cc @bbovenzi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050167395 > But if you confirm this is fine then no problem I will do it like this :) Yes. We do it in a number of other places - you already looked at it. > couldn't we adapt the

Re: [I] Status of testing Providers that were prepared on April 10, 2024 [airflow]

2024-04-11 Thread via GitHub
dabla commented on issue #38904: URL: https://github.com/apache/airflow/issues/38904#issuecomment-2050164510 Just tested [#38528](https://github.com/apache/airflow/pull/38528) and I confirm it is working with ODBC as well as JDBC. -- This is an automated message from the Apache Git

[PR] Graph view improvements [airflow]

2024-04-11 Thread via GitHub
bbovenzi opened a new pull request, #38940: URL: https://github.com/apache/airflow/pull/38940 The text was getting cut off too many times for graph view nodes. The zoomed out version was also hard to read. Before:

[I] You cannot see newer DAG runs if you open a link to a specific DAG run [UI Bug] [New as of 2.9.0?] [airflow]

2024-04-11 Thread via GitHub
Rafnel opened a new issue, #38939: URL: https://github.com/apache/airflow/issues/38939 ### Apache Airflow version 2.9.0 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When I click on a specific DAG run in a DAG, then

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
dabla commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050135785 > Some more explanation: This is what compatiblity checks are doing basically - they try to import the providers in airflow 2.6.0 so if you import anything that is missing, they should

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
dabla commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050133314 > > Now I'm getting this [errors](https://github.com/apache/airflow/actions/runs/8648788861/job/23713776144?pr=38111#step:10:2621) probably something else needs to be changed/excluded so

Re: [PR] Refactor: Directly pass HttpOperator `data` and `json` arguments to requests and aiohttp params [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38512: URL: https://github.com/apache/airflow/pull/38512#issuecomment-2050130140 No need to apologise :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Replace also "-" in providers compatibility check specification [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38936: URL: https://github.com/apache/airflow/pull/38936#issuecomment-2050129139 5 approvals for 1-line change in < 2 hours. The key is to have as small changes as possible :) -- This is an automated message from the Apache Git Service. To respond to the message,

(airflow) branch main updated: Replace also "-" in providers compatibility check specification (#38936)

2024-04-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 55b251f849 Replace also "-" in providers

Re: [PR] Replace also "-" in providers compatibility check specification [airflow]

2024-04-11 Thread via GitHub
potiuk merged PR #38936: URL: https://github.com/apache/airflow/pull/38936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Suppress jaydebeapi.Error when setAutoCommit or getAutoCommit is unsupported by JDBC driver [airflow]

2024-04-11 Thread via GitHub
potiuk commented on code in PR #38707: URL: https://github.com/apache/airflow/pull/38707#discussion_r1561336492 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -111,6 +112,15 @@ def fetch_one_handler(cursor) -> list[tuple] | None: return None +@contextmanager

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050116244 Some more explanation: This is what compatiblity checks are doing basically - they try to import the providers in airflow 2.6.0 so if you import anything that is missing, they should

Re: [PR] Adding MSGraphOperator in Microsoft Azure provider [airflow]

2024-04-11 Thread via GitHub
potiuk commented on PR #38111: URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050112072 > Now I'm getting this [errors](https://github.com/apache/airflow/actions/runs/8648788861/job/23713776144?pr=38111#step:10:2621) probably something else needs to be changed/excluded so

Re: [PR] Refactor: Directly pass HttpOperator `data` and `json` arguments to requests and aiohttp params [airflow]

2024-04-11 Thread via GitHub
gazev commented on PR #38512: URL: https://github.com/apache/airflow/pull/38512#issuecomment-2050099970 > Does the other PR fixes the same thing? If so - close it. If not - change yours to add new things. Why do you need to ask me :) ? Seems pretty straightforward? I am really sorry

Re: [PR] Refactor: Directly pass HttpOperator `data` and `json` arguments to requests and aiohttp params [airflow]

2024-04-11 Thread via GitHub
gazev closed pull request #38512: Refactor: Directly pass HttpOperator `data` and `json` arguments to requests and aiohttp params URL: https://github.com/apache/airflow/pull/38512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Status of testing Providers that were prepared on April 10, 2024 [airflow]

2024-04-11 Thread via GitHub
e-galan commented on issue #38904: URL: https://github.com/apache/airflow/issues/38904#issuecomment-2050067169 #37969 is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Limit redis image to 7.2 in sample docker-compose.yaml [airflow]

2024-04-11 Thread via GitHub
Taragolis opened a new pull request, #38938: URL: https://github.com/apache/airflow/pull/38938 It is sample docker compose and we not recommend to use it into the Production, however seems like this is popular among end users to use it (or part of it) into their production.

Re: [PR] Validate dbt `trigger_reason` field to be less than 255 characters [airflow]

2024-04-11 Thread via GitHub
dirrao commented on code in PR #38896: URL: https://github.com/apache/airflow/pull/38896#discussion_r1561276010 ## airflow/providers/dbt/cloud/operators/dbt.py: ## @@ -128,6 +130,7 @@ def execute(self, context: Context): self.trigger_reason = (

Re: [PR] Add example DAG to demostrate emitting approaches [airflow]

2024-04-11 Thread via GitHub
uranusjr commented on code in PR #38821: URL: https://github.com/apache/airflow/pull/38821#discussion_r1561252215 ## airflow/example_dags/example_dataset_event_extra.py: ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] FIX bug duplicated add base_folder to oss_remote_log_location in oss_wri… [airflow]

2024-04-11 Thread via GitHub
dirrao commented on code in PR #38917: URL: https://github.com/apache/airflow/pull/38917#discussion_r1561246812 ## airflow/providers/alibaba/cloud/log/oss_task_handler.py: ## @@ -172,7 +172,7 @@ def oss_write(self, log, remote_log_location, append=True) -> bool: """

Re: [PR] Change capture warnings output format to the JSON [airflow]

2024-04-11 Thread via GitHub
Taragolis commented on PR #38905: URL: https://github.com/apache/airflow/pull/38905#issuecomment-2049994033 Covert to draft for avoid accidentally merge I have a plan to change a bit what we store into output file Pytest output format, e.g. where warning raised airflow, providers,

Re: [I] Components stuck waiting on migrations [airflow]

2024-04-11 Thread via GitHub
boring-cyborg[bot] commented on issue #38937: URL: https://github.com/apache/airflow/issues/38937#issuecomment-2049980172 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

  1   2   3   >