[GitHub] kaxil commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
kaxil commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227292903 ## File path: airflow/example_dags/tutorial.py ## @@ -95,7 +98,7 @@ depends_on_past=False,

[jira] [Commented] (AIRFLOW-3244) Introduce offset on the execution date for data assessment

2018-10-23 Thread Alberto Anceschi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660436#comment-16660436 ] Alberto Anceschi commented on AIRFLOW-3244: --- Hi [~ashb], thank you. Do you know when the new

[GitHub] ashb commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2018-10-23 Thread GitBox
ashb commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible URL: https://github.com/apache/incubator-airflow/pull/2460#issuecomment-432165003 Yeah this would be great to have! To be clear: the implementation should live in the model (as you have in

[jira] [Commented] (AIRFLOW-520) Show Airflow version on web page

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660330#comment-16660330 ] ASF GitHub Bot commented on AIRFLOW-520: kaxil closed pull request #4072: [AIRFLOW-520] Fix

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227299817 ## File path: tests/plugins/test_plugin.py ## @@ -67,17 +68,39 @@ def

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227299952 ## File path: tests/plugins/test_plugin.py ## @@ -58,7 +59,7 @@ def

[GitHub] kaxil closed pull request #4072: [AIRFLOW-520] Fix Version Info in Flask UI

2018-10-23 Thread GitBox
kaxil closed pull request #4072: [AIRFLOW-520] Fix Version Info in Flask UI URL: https://github.com/apache/incubator-airflow/pull/4072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227300064 ## File path: docs/plugins.rst ## @@ -170,3 +191,16 @@ definitions in

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227300342 ## File path: docs/plugins.rst ## @@ -170,3 +191,16 @@ definitions in

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227300479 ## File path: docs/plugins.rst ## @@ -170,3 +191,16 @@ definitions in

[GitHub] chronitis opened a new pull request #4084: [AIRFLOW-3205] Support multipart uploads to GCS

2018-10-23 Thread GitBox
chronitis opened a new pull request #4084: [AIRFLOW-3205] Support multipart uploads to GCS URL: https://github.com/apache/incubator-airflow/pull/4084 Cloud Storage supports resumable/multipart uploads for large files, which can be used to avoid limitations on the size of a single HTTP

[jira] [Commented] (AIRFLOW-3205) GCS: Support multipart upload

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660406#comment-16660406 ] ASF GitHub Bot commented on AIRFLOW-3205: - chronitis opened a new pull request #4084:

[jira] [Commented] (AIRFLOW-3244) Introduce offset on the execution date for data assessment

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660409#comment-16660409 ] Ash Berlin-Taylor commented on AIRFLOW-3244: Not commenting on the whole feature request:

[jira] [Comment Edited] (AIRFLOW-2925) gcp dataflow hook doesn't show traceback

2018-10-23 Thread Iuliia Volkova (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660422#comment-16660422 ] Iuliia Volkova edited comment on AIRFLOW-2925 at 10/23/18 10:44 AM:

[GitHub] BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227332668 ## File path: airflow/example_dags/tutorial.py ## @@ -95,7 +98,7 @@ depends_on_past=False,

[jira] [Commented] (AIRFLOW-2925) gcp dataflow hook doesn't show traceback

2018-10-23 Thread Iuliia Volkova (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660422#comment-16660422 ] Iuliia Volkova commented on AIRFLOW-2925: - [~jackjack10] What do you mean? It shows the full

[jira] [Updated] (AIRFLOW-3244) Introduce offset on the execution date for data settlement

2018-10-23 Thread Alberto Anceschi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Anceschi updated AIRFLOW-3244: -- Summary: Introduce offset on the execution date for data settlement (was: Introduce

[GitHub] kaxil commented on issue #4083: Airflow 3211

2018-10-23 Thread GitBox
kaxil commented on issue #4083: Airflow 3211 URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432168224 cc @fenglu-g This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (AIRFLOW-3244) Introduce offset on the execution date for data assessment

2018-10-23 Thread Alberto Anceschi (JIRA)
Alberto Anceschi created AIRFLOW-3244: - Summary: Introduce offset on the execution date for data assessment Key: AIRFLOW-3244 URL: https://issues.apache.org/jira/browse/AIRFLOW-3244 Project:

[GitHub] ron819 commented on a change in pull request #4075: [AIRFLOW-502] BashOperator success/failure conditions not documented

2018-10-23 Thread GitBox
ron819 commented on a change in pull request #4075: [AIRFLOW-502] BashOperator success/failure conditions not documented URL: https://github.com/apache/incubator-airflow/pull/4075#discussion_r227330074 ## File path: airflow/operators/bash_operator.py ## @@ -49,6 +49,16 @@

[GitHub] kaxil commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
kaxil commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227292628 ## File path: airflow/example_dags/example_xcom.py ## @@ -63,12 +61,21 @@ def puller(**kwargs):

[jira] [Commented] (AIRFLOW-3244) Introduce offset on the execution date for data assessment

2018-10-23 Thread Daniel Lamblin (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660420#comment-16660420 ] Daniel Lamblin commented on AIRFLOW-3244: - For context from a slack conversation: Alberto is

[GitHub] ashb commented on a change in pull request #4083: Airflow 3211

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4083: Airflow 3211 URL: https://github.com/apache/incubator-airflow/pull/4083#discussion_r227303887 ## File path: airflow/contrib/hooks/gcp_dataproc_hook.py ## @@ -33,12 +33,82 @@ def __init__(self, dataproc_api, project_id, job,

[jira] [Comment Edited] (AIRFLOW-2925) gcp dataflow hook doesn't show traceback

2018-10-23 Thread Iuliia Volkova (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660422#comment-16660422 ] Iuliia Volkova edited comment on AIRFLOW-2925 at 10/23/18 10:46 AM:

[GitHub] xnuinside commented on issue #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load

2018-10-23 Thread GitBox
xnuinside commented on issue #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load URL: https://github.com/apache/incubator-airflow/pull/3880#issuecomment-432197482 @kaxil, great ) thank you This is an

[GitHub] gglanzani commented on issue #3563: [AIRFLOW-2698] Simplify Kerberos code

2018-10-23 Thread GitBox
gglanzani commented on issue #3563: [AIRFLOW-2698] Simplify Kerberos code URL: https://github.com/apache/incubator-airflow/pull/3563#issuecomment-432202708 @Ron819 I'm waiting for an ok here This is an automated message from

[jira] [Created] (AIRFLOW-3245) resolve_template_files not processing lists

2018-10-23 Thread Marcin Szymanski (JIRA)
Marcin Szymanski created AIRFLOW-3245: - Summary: resolve_template_files not processing lists Key: AIRFLOW-3245 URL: https://issues.apache.org/jira/browse/AIRFLOW-3245 Project: Apache Airflow

[jira] [Resolved] (AIRFLOW-520) Show Airflow version on web page

2018-10-23 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-520. Resolution: Fixed > Show Airflow version on web page > > >

[jira] [Commented] (AIRFLOW-520) Show Airflow version on web page

2018-10-23 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660331#comment-16660331 ] Kaxil Naik commented on AIRFLOW-520: Resolved by

[GitHub] ashb commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
ashb commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432170898 This PR seems sensible - though I would have fixed this by changing your deploy process to not kill your

[GitHub] ultrabug commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2018-10-23 Thread GitBox
ultrabug commented on issue #2460: [AIRFLOW-1424] make the next execution date of DAGs visible URL: https://github.com/apache/incubator-airflow/pull/2460#issuecomment-432186899 OK @ashb I understand your precision and since you're a member of the project I'll work on this and update this

[GitHub] BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227332346 ## File path: airflow/example_dags/example_xcom.py ## @@ -63,12 +61,21 @@ def puller(**kwargs):

[jira] [Updated] (AIRFLOW-2925) gcp dataflow hook doesn't show traceback

2018-10-23 Thread Iuliia Volkova (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iuliia Volkova updated AIRFLOW-2925: Attachment: Screen Shot 2018-10-23 at 1.40.43 PM.png > gcp dataflow hook doesn't show

[GitHub] ashb commented on issue #4085: [AIRFLOW-3112] Fix SFTPHook deprecated option check

2018-10-23 Thread GitBox
ashb commented on issue #4085: [AIRFLOW-3112] Fix SFTPHook deprecated option check URL: https://github.com/apache/incubator-airflow/pull/4085#issuecomment-432297476 This change seems to make the tests fail with `SSHException: No hostkey for host localhost found.` so we might probably

[jira] [Updated] (AIRFLOW-3137) Make ProxyFix middleware optional

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3137: --- Fix Version/s: 1.10.1 > Make ProxyFix middleware optional >

[jira] [Resolved] (AIRFLOW-2744) RBAC app doesn't integrate plugins (blueprints etc)

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-2744. Resolution: Fixed Fix Version/s: 1.10.1 2.0.0 > RBAC

[jira] [Commented] (AIRFLOW-2744) RBAC app doesn't integrate plugins (blueprints etc)

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660917#comment-16660917 ] ASF GitHub Bot commented on AIRFLOW-2744: - ashb closed pull request #4036: [AIRFLOW-2744] Allow

[GitHub] ashb closed pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb closed pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] XD-DENG commented on a change in pull request #4084: [AIRFLOW-3205] Support multipart uploads to GCS

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4084: [AIRFLOW-3205] Support multipart uploads to GCS URL: https://github.com/apache/incubator-airflow/pull/4084#discussion_r227433513 ## File path: airflow/contrib/hooks/gcs_hook.py ## @@ -191,6 +193,15 @@ def upload(self,

[GitHub] XD-DENG commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227443694 ## File path: airflow/example_dags/example_xcom.py ## @@ -63,12 +61,21 @@ def puller(**kwargs):

[GitHub] XD-DENG commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227443694 ## File path: airflow/example_dags/example_xcom.py ## @@ -63,12 +61,21 @@ def puller(**kwargs):

[GitHub] ashb commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r227446767 ## File path: airflow/contrib/operators/aws_glue_job_operator.py ## @@ -0,0 +1,78

[GitHub] jj-ian commented on a change in pull request #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
jj-ian commented on a change in pull request #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#discussion_r227418264 ## File path: airflow/contrib/hooks/gcp_dataproc_hook.py ## @@ -33,12

[GitHub] Fokko commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-10-23 Thread GitBox
Fokko commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r227428171 ## File path: airflow/contrib/hooks/aws_glue_job_hook.py ## @@ -0,0 +1,129 @@ +#

[GitHub] XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo URL: https://github.com/apache/incubator-airflow/pull/4050#discussion_r227456884 ## File path: airflow/task/task_runner/base_task_runner.py ## @@

[GitHub] XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo URL: https://github.com/apache/incubator-airflow/pull/4050#discussion_r227456773 ## File path: airflow/task/task_runner/base_task_runner.py ## @@

[GitHub] jj-ian commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
jj-ian commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432312293 @fenglu-g Hi Feng, this is the fix I emailed you about on February 27, 2018 with the subject line "Airflow

[GitHub] Fokko commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
Fokko commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227462786 ## File path: airflow/example_dags/example_http_operator.py ## @@ -89,10 +94,7 @@

[jira] [Commented] (AIRFLOW-2976) pipy docker dependency broken

2018-10-23 Thread Matthew Donovan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660879#comment-16660879 ] Matthew Donovan commented on AIRFLOW-2976: -- Gerardo, do you mind if I take this ticket?   >

[GitHub] Fokko commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
Fokko commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227462237 ## File path: airflow/example_dags/example_xcom.py ## @@ -63,12 +61,21 @@ def puller(**kwargs):

[jira] [Updated] (AIRFLOW-1163) Add support for x-forwarded-* headers to support access behind AWS ELB

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-1163: --- Fix Version/s: 1.10.1 Summary: Add support for x-forwarded-* headers to

[jira] [Commented] (AIRFLOW-2976) pipy docker dependency broken

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660912#comment-16660912 ] Ash Berlin-Taylor commented on AIRFLOW-2976: I think the change in AIRFLOW-3203 fixes this

[GitHub] victornoel commented on issue #3983: [AIRFLOW-3137] Make ProxyFix middleware optional.

2018-10-23 Thread GitBox
victornoel commented on issue #3983: [AIRFLOW-3137] Make ProxyFix middleware optional. URL: https://github.com/apache/incubator-airflow/pull/3983#issuecomment-432320344 @ashb thanks for the quick answer! This is an

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227415995 ## File path: docs/plugins.rst ## @@ -170,3 +191,16 @@ definitions in

[GitHub] jj-ian commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
jj-ian commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432277828 Hi @ashb, thank you for the review. I see what you mean, but we wanted to ensure that Airflow keeps track

[GitHub] jj-ian edited a comment on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
jj-ian edited a comment on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432277828 Hi @ashb, thank you for the review. I see what you mean, but we wanted to ensure that Airflow keeps

[GitHub] XD-DENG commented on issue #4080: [AIRFLOW-XXX] Make hmsclient import optional

2018-10-23 Thread GitBox
XD-DENG commented on issue #4080: [AIRFLOW-XXX] Make hmsclient import optional URL: https://github.com/apache/incubator-airflow/pull/4080#issuecomment-432284133 Hi @gseva , as long as it's a code change, a JIRA ticket would be needed.

[GitHub] ckljohn commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook

2018-10-23 Thread GitBox
ckljohn commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook URL: https://github.com/apache/incubator-airflow/pull/3945#discussion_r227436616 ## File path: airflow/contrib/hooks/sftp_hook.py ## @@ -39,32 +42,66 @@ class

[GitHub] codecov-io edited a comment on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
codecov-io edited a comment on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#issuecomment-429043686 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4036?src=pr=h1) Report >

[jira] [Commented] (AIRFLOW-2976) pipy docker dependency broken

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660909#comment-16660909 ] Ash Berlin-Taylor commented on AIRFLOW-2976: I think this one has been fixed. Let me dig

[GitHub] codecov-io commented on issue #4086: [AIRFLOW-3245] fix list processing in resolve_template_files

2018-10-23 Thread GitBox
codecov-io commented on issue #4086: [AIRFLOW-3245] fix list processing in resolve_template_files URL: https://github.com/apache/incubator-airflow/pull/4086#issuecomment-432321357 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4086?src=pr=h1) Report > Merging

[GitHub] Gwildor commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook

2018-10-23 Thread GitBox
Gwildor commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook URL: https://github.com/apache/incubator-airflow/pull/3945#discussion_r227419886 ## File path: airflow/contrib/hooks/sftp_hook.py ## @@ -39,32 +42,66 @@ class

[jira] [Commented] (AIRFLOW-999) Support for Redis database

2018-10-23 Thread Pawel Graczyk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660852#comment-16660852 ] Pawel Graczyk commented on AIRFLOW-999: --- Not sure if the way to go is to reopen this issue or to

[GitHub] ms32035 opened a new pull request #4086: [AIRFLOW-3245] fix list processing in resolve_template_files

2018-10-23 Thread GitBox
ms32035 opened a new pull request #4086: [AIRFLOW-3245] fix list processing in resolve_template_files URL: https://github.com/apache/incubator-airflow/pull/4086 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[GitHub] XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo URL: https://github.com/apache/incubator-airflow/pull/4050#discussion_r227456884 ## File path: airflow/task/task_runner/base_task_runner.py ## @@

[GitHub] XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo URL: https://github.com/apache/incubator-airflow/pull/4050#discussion_r227456773 ## File path: airflow/task/task_runner/base_task_runner.py ## @@

[GitHub] victornoel commented on issue #3983: [AIRFLOW-3137] Make ProxyFix middleware optional.

2018-10-23 Thread GitBox
victornoel commented on issue #3983: [AIRFLOW-3137] Make ProxyFix middleware optional. URL: https://github.com/apache/incubator-airflow/pull/3983#issuecomment-432309617 @jmcarp will this fix (as well as #3580) be included in airflow 1.10.1? And do you know when it will hapen? Thanks!

[GitHub] Gwildor commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook

2018-10-23 Thread GitBox
Gwildor commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook URL: https://github.com/apache/incubator-airflow/pull/3945#discussion_r227414129 ## File path: airflow/contrib/hooks/sftp_hook.py ## @@ -39,32 +42,66 @@ class

[GitHub] ashb commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook

2018-10-23 Thread GitBox
ashb commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook URL: https://github.com/apache/incubator-airflow/pull/3945#discussion_r227416784 ## File path: airflow/contrib/hooks/sftp_hook.py ## @@ -39,32 +42,66 @@ class

[GitHub] ashb commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#issuecomment-432294040 Tests failed due to flake8 style violation: > ./tests/plugins/test_plugin.py:96:33: E261 at least two

[GitHub] XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo URL: https://github.com/apache/incubator-airflow/pull/4050#discussion_r227457679 ## File path: airflow/task/task_runner/base_task_runner.py ## @@

[GitHub] XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo URL: https://github.com/apache/incubator-airflow/pull/4050#discussion_r227457818 ## File path: airflow/task/task_runner/base_task_runner.py ## @@

[jira] [Updated] (AIRFLOW-2744) RBAC app doesn't integrate plugins (blueprints etc)

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-2744: --- Affects Version/s: (was: 2.0.0) 1.10.0 > RBAC app

[GitHub] oliviersm199 commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
oliviersm199 commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#issuecomment-432263881 Made the requested changes. This is

[GitHub] Fokko commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-10-23 Thread GitBox
Fokko commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r227428837 ## File path: airflow/contrib/operators/aws_glue_job_operator.py ## @@ -0,0 +1,82

[GitHub] Fokko commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-10-23 Thread GitBox
Fokko commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r227427882 ## File path: airflow/contrib/hooks/aws_glue_job_hook.py ## @@ -0,0 +1,130 @@ +#

[GitHub] oelesinsc24 commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-10-23 Thread GitBox
oelesinsc24 commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r227439879 ## File path: airflow/contrib/operators/aws_glue_job_operator.py ## @@ -0,0

[GitHub] XD-DENG commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
XD-DENG commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227443694 ## File path: airflow/example_dags/example_xcom.py ## @@ -63,12 +61,21 @@ def puller(**kwargs):

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227449187 ## File path: tests/plugins/test_plugin.py ## @@ -67,17 +68,40 @@ def

[jira] [Comment Edited] (AIRFLOW-999) Support for Redis database

2018-10-23 Thread Pawel Graczyk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660852#comment-16660852 ] Pawel Graczyk edited comment on AIRFLOW-999 at 10/23/18 3:45 PM: - Not

[GitHub] ashb commented on issue #3983: [AIRFLOW-3137] Make ProxyFix middleware optional.

2018-10-23 Thread GitBox
ashb commented on issue #3983: [AIRFLOW-3137] Make ProxyFix middleware optional. URL: https://github.com/apache/incubator-airflow/pull/3983#issuecomment-432314896 @victornoel I've just marked them for inclusion in 1.10.1 so we don't forget. Most accurate I can offer on timings is "we're

[GitHub] ashb edited a comment on issue #2369: [AIRFLOW-1159] upgrading to docker >2.0

2018-10-23 Thread GitBox
ashb edited a comment on issue #2369: [AIRFLOW-1159] upgrading to docker >2.0 URL: https://github.com/apache/incubator-airflow/pull/2369#issuecomment-432333700 Fixed by #4049 or #3407 This is an automated message from the

[jira] [Commented] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-10-23 Thread holdenk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661000#comment-16661000 ] holdenk commented on AIRFLOW-2192: -- I did a WIP PR

[jira] [Commented] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660997#comment-16660997 ] ASF GitHub Bot commented on AIRFLOW-2192: - holdenk opened a new pull request #4087:

[jira] [Commented] (AIRFLOW-2288) Source tarball should not extract to root

2018-10-23 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660971#comment-16660971 ] Ash Berlin-Taylor commented on AIRFLOW-2288: 1.9: {code} $ http

[jira] [Commented] (AIRFLOW-2192) Don't authenticate on Google Authentication

2018-10-23 Thread holdenk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660978#comment-16660978 ] holdenk commented on AIRFLOW-2192: -- A bit more poking leads me to

[GitHub] fenglu-g commented on a change in pull request #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
fenglu-g commented on a change in pull request #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#discussion_r227528926 ## File path: airflow/contrib/hooks/gcp_dataproc_hook.py ## @@ -33,12

[GitHub] fenglu-g commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
fenglu-g commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432382653 @jj-ian left one comment, PTAL. Thanks for the PR, this is going to be very useful.

[GitHub] BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs

2018-10-23 Thread GitBox
BasPH commented on a change in pull request #4071: [AIRFLOW-3237] Refactor example DAGs URL: https://github.com/apache/incubator-airflow/pull/4071#discussion_r227535268 ## File path: airflow/example_dags/example_xcom.py ## @@ -63,12 +61,21 @@ def puller(**kwargs):

[GitHub] oliviersm199 commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

2018-10-23 Thread GitBox
oliviersm199 commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links. URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r227421519 ## File path: docs/plugins.rst ## @@ -170,3 +191,16 @@ definitions

[jira] [Commented] (AIRFLOW-3112) Align SFTP hook with SSH hook

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660750#comment-16660750 ] ASF GitHub Bot commented on AIRFLOW-3112: - Gwildor opened a new pull request #4085:

[GitHub] Gwildor commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook

2018-10-23 Thread GitBox
Gwildor commented on a change in pull request #3945: [AIRFLOW-3112] Make SFTP hook to inherit SSH hook URL: https://github.com/apache/incubator-airflow/pull/3945#discussion_r227425550 ## File path: airflow/contrib/hooks/sftp_hook.py ## @@ -39,32 +42,66 @@ class

[GitHub] Gwildor opened a new pull request #4085: [AIRFLOW-3112] Fix SFTPHook deprecated option check

2018-10-23 Thread GitBox
Gwildor opened a new pull request #4085: [AIRFLOW-3112] Fix SFTPHook deprecated option check URL: https://github.com/apache/incubator-airflow/pull/4085 It was checking the deprecated ignore_hostkey_verification option and setting the correct no_host_key_check option, but the ignore_*

[GitHub] ashb commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r227430458 ## File path: airflow/contrib/hooks/aws_glue_job_hook.py ## @@ -0,0 +1,129 @@ +#

[GitHub] ashb commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
ashb commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432280227 Yeah, I can see this being useful. I don't know enough about GCP/DataProc in Airflow to review this further,

[GitHub] ashb commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow

2018-10-23 Thread GitBox
ashb commented on a change in pull request #4068: [AIRFLOW-2310]: Add AWS Glue Job Compatibility to Airflow URL: https://github.com/apache/incubator-airflow/pull/4068#discussion_r227446695 ## File path: airflow/contrib/hooks/aws_glue_job_hook.py ## @@ -0,0 +1,125 @@ +#

[jira] [Commented] (AIRFLOW-3245) resolve_template_files not processing lists

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660865#comment-16660865 ] ASF GitHub Bot commented on AIRFLOW-3245: - ms32035 opened a new pull request #4086:

[GitHub] jj-ian commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart

2018-10-23 Thread GitBox
jj-ian commented on issue #4083: [AIRFLOW-3211] Reattach to GCP Dataproc jobs upon Airflow restart URL: https://github.com/apache/incubator-airflow/pull/4083#issuecomment-432311655 @ashb No worries and thank you! Oh, and the fix also helps in cases where the task fails for some other

[jira] [Commented] (AIRFLOW-2976) pipy docker dependency broken

2018-10-23 Thread Matthew Donovan (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660950#comment-16660950 ] Matthew Donovan commented on AIRFLOW-2976: -- Yep, 3203 fixes this. > pipy docker dependency

[jira] [Commented] (AIRFLOW-2288) Source tarball should not extract to root

2018-10-23 Thread holdenk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660951#comment-16660951 ] holdenk commented on AIRFLOW-2288: -- I downloaded

  1   2   >