[GitHub] [beam] iemejia commented on issue #10974: [BEAM-9384] Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types

2020-02-26 Thread GitBox
iemejia commented on issue #10974: [BEAM-9384] Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types URL: https://github.com/apache/beam/pull/10974#issuecomment-591833541 Run JavaPortabilityApi PreCommit

[GitHub] [beam] iemejia commented on issue #10974: [BEAM-9384] Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types

2020-02-26 Thread GitBox
iemejia commented on issue #10974: [BEAM-9384] Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types URL: https://github.com/apache/beam/pull/10974#issuecomment-591833469 Run Java PreCommit This is an

[GitHub] [beam] iemejia commented on a change in pull request #10974: [BEAM-9384] Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types

2020-02-26 Thread GitBox
iemejia commented on a change in pull request #10974: [BEAM-9384] Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types URL: https://github.com/apache/beam/pull/10974#discussion_r384960299 ## File path:

[GitHub] [beam] mwalenia commented on issue #10961: [BEAM-9258] Add integration test for Cloud DLP

2020-02-26 Thread GitBox
mwalenia commented on issue #10961: [BEAM-9258] Add integration test for Cloud DLP URL: https://github.com/apache/beam/pull/10961#issuecomment-591830855 R: @aaltay cc: @kamilwu This is an automated message from the

[GitHub] [beam] sunjincheng121 removed a comment on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-26 Thread GitBox
sunjincheng121 removed a comment on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#issuecomment-591809987 Run Python PreCommit

[GitHub] [beam] sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-26 Thread GitBox
sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#issuecomment-591830495 Run Python PreCommit

[GitHub] [beam] alexvanboxel opened a new pull request #10984: [BEAM-9394] DynamicMessage handling of empty map violates schema null…

2020-02-26 Thread GitBox
alexvanboxel opened a new pull request #10984: [BEAM-9394] DynamicMessage handling of empty map violates schema null… URL: https://github.com/apache/beam/pull/10984 DynamicMessage handling of empty map violates schema nullability Fixed the handling of empty maps. It runned NULL, but

[GitHub] [beam] reuvenlax opened a new pull request #10983: [BEAM-9393] Support schemas in state API

2020-02-26 Thread GitBox
reuvenlax opened a new pull request #10983: [BEAM-9393] Support schemas in state API URL: https://github.com/apache/beam/pull/10983 Add schema inference for types used in the state API. Add state overrides for Row types. Disable Coder inference for Row types, as we should

[GitHub] [beam] sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-26 Thread GitBox
sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#issuecomment-591809987 Run Python PreCommit

[GitHub] [beam] sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10

2020-02-26 Thread GitBox
sunjincheng121 commented on issue #10945: [BEAM-9295] Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10 URL: https://github.com/apache/beam/pull/10945#issuecomment-591810030 Run Java PreCommit This

[GitHub] [beam] pabloem commented on issue #10968: [BEAM-9381] Adding display data to BoundedSource SDF

2020-02-26 Thread GitBox
pabloem commented on issue #10968: [BEAM-9381] Adding display data to BoundedSource SDF URL: https://github.com/apache/beam/pull/10968#issuecomment-591808874 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384893543 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel edited a comment on issue #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-26 Thread GitBox
rohdesamuel edited a comment on issue #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#issuecomment-591758520 R: @robertwb Hey Robert, I think this is good to review. Please review for content, I haven't had the time to add better comments

[GitHub] [beam] rohdesamuel commented on issue #10497: [BEAM-8335] Add the ReverseTestStream

2020-02-26 Thread GitBox
rohdesamuel commented on issue #10497: [BEAM-8335] Add the ReverseTestStream URL: https://github.com/apache/beam/pull/10497#issuecomment-591758520 Hey Robert, I think this is good to review. Please review for content, I haven't had the time to add better comments yet (also still needs

[GitHub] [beam] rohdesamuel commented on issue #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on issue #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#issuecomment-591758254 Hey Robert, you'll notice that this implementation is quite different than what we talked about. When going

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384892436 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384892289 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384892377 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384892342 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384892102 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384891918 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner.

2020-02-26 Thread GitBox
rohdesamuel commented on a change in pull request #10915: [BEAM-8335] Add PCollection to DataFrame logic for InteractiveRunner. URL: https://github.com/apache/beam/pull/10915#discussion_r384891956 ## File path: sdks/python/apache_beam/runners/interactive/utils.py ## @@

[GitHub] [beam] rohdesamuel commented on issue #10982: Fix Multi TestStream assertion errors

2020-02-26 Thread GitBox
rohdesamuel commented on issue #10982: Fix Multi TestStream assertion errors URL: https://github.com/apache/beam/pull/10982#issuecomment-591752376 CC: @lukecwik This is an automated message from the Apache Git Service. To

[GitHub] [beam] rohdesamuel commented on issue #10982: Fix Multi TestStream assertion errors

2020-02-26 Thread GitBox
rohdesamuel commented on issue #10982: Fix Multi TestStream assertion errors URL: https://github.com/apache/beam/pull/10982#issuecomment-591752255 R: @aaltay This is an automated message from the Apache Git Service. To

[GitHub] [beam] rohdesamuel opened a new pull request #10982: Fix Multi TestStream assertion errors

2020-02-26 Thread GitBox
rohdesamuel opened a new pull request #10982: Fix Multi TestStream assertion errors URL: https://github.com/apache/beam/pull/10982 Change-Id: Ibbd99867c9bc96aaa7ca9d3f2874f3b1e75c2f98 Fixes failures from:

[GitHub] [beam] rohdesamuel commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
rohdesamuel commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591747015 > I see this error in the logs: > > 17:01:54 > assert

[GitHub] [beam] aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591746886 I see this error in the logs: 17:01:54 > assert

[GitHub] [beam] udim commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
udim commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591745730 LGTM, tests already failing here: https://builds.apache.org/job/beam_PreCommit_Python_Cron/2443/

[GitHub] [beam] udim edited a comment on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
udim edited a comment on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591741341 This change may have broken precommits:

[GitHub] [beam] udim commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
udim commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591741341 I believe this change may have broken precommits:

[GitHub] [beam] udim edited a comment on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
udim edited a comment on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591741341 This change may have broken precommits:

[GitHub] [beam] tvalentyn commented on issue #10932: [BEAM-8487] Handle nested forward references

2020-02-26 Thread GitBox
tvalentyn commented on issue #10932: [BEAM-8487] Handle nested forward references URL: https://github.com/apache/beam/pull/10932#issuecomment-591739717 LGTM, thank you. This is an automated message from the Apache Git

[GitHub] [beam] udim commented on a change in pull request #10932: [BEAM-8487] Handle nested forward references

2020-02-26 Thread GitBox
udim commented on a change in pull request #10932: [BEAM-8487] Handle nested forward references URL: https://github.com/apache/beam/pull/10932#discussion_r384873795 ## File path: sdks/python/apache_beam/typehints/native_type_compatibility.py ## @@ -163,8 +163,14 @@ def

[GitHub] [beam] pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-26 Thread GitBox
pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#issuecomment-591735822 Run Python 3.5 PostCommit This is an automated

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591735657 @robertwb I don't think the test failures are my fault because they were passing before I rebased onto master...

[GitHub] [beam] lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384867760 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[GitHub] [beam] lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384867042 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -185,6 +200,37 @@

[GitHub] [beam] lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384868638 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[GitHub] [beam] lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384868736 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[GitHub] [beam] lukecwik commented on issue #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
lukecwik commented on issue #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#issuecomment-591733789 > Looks good. I'd like to see at least one smoke test. There are validates runner unbounded source tests which will all be converted

[GitHub] [beam] pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-26 Thread GitBox
pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#issuecomment-591731930 Run Python 3.7 PostCommit This is an automated

[GitHub] [beam] pabloem commented on issue #10968: [BEAM-9381] Adding display data to BoundedSource SDF

2020-02-26 Thread GitBox
pabloem commented on issue #10968: [BEAM-9381] Adding display data to BoundedSource SDF URL: https://github.com/apache/beam/pull/10968#issuecomment-591731834 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-26 Thread GitBox
pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#issuecomment-591731506 Retest this please This is an automated message

[GitHub] [beam] lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
lukecwik commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384866125 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[beam] branch master updated: Fix formatting

2020-02-26 Thread pabloem
This is an automated email from the ASF dual-hosted git repository. pabloem pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new d52d92f Fix formatting new 860131b Merge

[GitHub] [beam] pabloem merged pull request #10981: Fix formatting

2020-02-26 Thread GitBox
pabloem merged pull request #10981: Fix formatting URL: https://github.com/apache/beam/pull/10981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384851813 ## File path: runners/portability/java/src/main/java/org/apache/beam/runners/portability/PortableRunner.java

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384849942 ## File path:

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384853321 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -547,21 +601,22 @@ def

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384853099 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -377,34 +436,33 @@ def

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384850669 ## File path:

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384851171 ## File path:

[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384853067 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -331,22 +389,23 @@ def

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591716771 Run Python PreCommit This is an automated message from the Apache Git Service.

[beam] branch master updated (079317d -> 4a25aa0)

2020-02-26 Thread robertwb
This is an automated email from the ASF dual-hosted git repository. robertwb pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 079317d Merge pull request #10901 from [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

[GitHub] [beam] robertwb merged pull request #10655: [BEAM-8618] Tear down unused DoFns periodically in Python SDK harness.

2020-02-26 Thread GitBox
robertwb merged pull request #10655: [BEAM-8618] Tear down unused DoFns periodically in Python SDK harness. URL: https://github.com/apache/beam/pull/10655 This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] boyuanzz commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
boyuanzz commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384846699 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[GitHub] [beam] boyuanzz commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
boyuanzz commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384840768 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -185,6 +200,37 @@

[GitHub] [beam] robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners. URL: https://github.com/apache/beam/pull/10951#discussion_r384848033 ## File path: sdks/python/apache_beam/transforms/combiners_test.py ## @@ -470,6 +470,9

[GitHub] [beam] pabloem commented on issue #10981: Fix formatting

2020-02-26 Thread GitBox
pabloem commented on issue #10981: Fix formatting URL: https://github.com/apache/beam/pull/10981#issuecomment-591713226 r: @udim This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pabloem opened a new pull request #10981: Fix formatting

2020-02-26 Thread GitBox
pabloem opened a new pull request #10981: Fix formatting URL: https://github.com/apache/beam/pull/10981 This will fix yapf tests Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] bumblebee-coming commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.

2020-02-26 Thread GitBox
bumblebee-coming commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners. URL: https://github.com/apache/beam/pull/10951#discussion_r384845501 ## File path: sdks/python/apache_beam/transforms/combiners_test.py ## @@ -470,6

[GitHub] [beam] pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-26 Thread GitBox
pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#issuecomment-591710321 Run Python 3.7 PostCommit This is an automated

[GitHub] [beam] pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK

2020-02-26 Thread GitBox
pabloem commented on issue #10979: [BEAM-8841] Support writing data to BigQuery via Avro in Python SDK URL: https://github.com/apache/beam/pull/10979#issuecomment-591707480 retest this please This is an automated message

[GitHub] [beam] pabloem commented on issue #10968: [BEAM-9381] Adding display data to BoundedSource SDF

2020-02-26 Thread GitBox
pabloem commented on issue #10968: [BEAM-9381] Adding display data to BoundedSource SDF URL: https://github.com/apache/beam/pull/10968#issuecomment-591706858 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11

2020-02-26 Thread GitBox
pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384837638 ## File path: runners/google-cloud-dataflow-java/examples/build.gradle ## @@ -97,6 +97,42

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384836306 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect

[GitHub] [beam] pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11

2020-02-26 Thread GitBox
pawelpasterz commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384834326 ## File path: runners/google-cloud-dataflow-java/examples/build.gradle ## @@ -97,6 +97,42

[beam] branch master updated (8658b95 -> 079317d)

2020-02-26 Thread pabloem
This is an automated email from the ASF dual-hosted git repository. pabloem pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 8658b95 fix breakage (#10934) add 079317d Merge pull request #10901 from [BEAM-8965] Remove duplicate

[GitHub] [beam] pabloem merged pull request #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem merged pull request #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901 This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591699695 thanks @bobingm This is an automated

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591699495 I see. Thanks for pointing that out. This is

[GitHub] [beam] mf2199 edited a comment on issue #8457: [BEAM-3342] Create a Cloud Bigtable IO connector for Python

2020-02-26 Thread GitBox
mf2199 edited a comment on issue #8457: [BEAM-3342] Create a Cloud Bigtable IO connector for Python URL: https://github.com/apache/beam/pull/8457#issuecomment-590610828 @chamikaramj PTAL. The long standing issue now seems to be resolved. The reason was the namespace conflict between the

[GitHub] [beam] robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384826746 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[GitHub] [beam] robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384820354 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[GitHub] [beam] robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper

2020-02-26 Thread GitBox
robertwb commented on a change in pull request #10897: [BEAM-2939] Java UnboundedSource SDF wrapper URL: https://github.com/apache/beam/pull/10897#discussion_r384793593 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ## @@ -375,4 +422,361 @@

[GitHub] [beam] kennknowles commented on a change in pull request #10878: Implement precommit portability test to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10878: Implement precommit portability test to run on java 11 URL: https://github.com/apache/beam/pull/10878#discussion_r384828402 ## File path: runners/google-cloud-dataflow-java/examples/build.gradle ## @@ -97,6 +97,42

[GitHub] [beam] bobingm commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
bobingm commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591688753 @pabloem the failure is not caused by this PR.

[GitHub] [beam] chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591685577 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache

[GitHub] [beam] kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#discussion_r384811574 ## File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow_Java11.groovy

[GitHub] [beam] kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#discussion_r384811829 ## File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow_Java11.groovy

[GitHub] [beam] kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on a change in pull request #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#discussion_r384811472 ## File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow_Java11.groovy

[GitHub] [beam] kennknowles commented on issue #10882: Implement java precommit dataflow examples tests to run on java 11

2020-02-26 Thread GitBox
kennknowles commented on issue #10882: Implement java precommit dataflow examples tests to run on java 11 URL: https://github.com/apache/beam/pull/10882#issuecomment-591681112 Sorry - got this mixed up with a similar PR and lost track.

[beam] branch master updated (d577e41 -> 8658b95)

2020-02-26 Thread altay
This is an automated email from the ASF dual-hosted git repository. altay pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from d577e41 Merge pull request #10964: Make logger naming consistent with Apache Beam LOG standard add 8658b95 fix

[GitHub] [beam] aaltay merged pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay merged pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934 This is an automated message from the

[GitHub] [beam] pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
pabloem commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591680118 thanks @bobingm ! Looks good to me. Can you fix the formatting issues, and I'll merge?

[GitHub] [beam] aaltay commented on a change in pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay commented on a change in pull request #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#discussion_r384809280 ## File path: sdks/python/apache_beam/pipeline.py ##

[GitHub] [beam] chadrik edited a comment on issue #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik edited a comment on issue #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#issuecomment-591610348 Down to 79 errors! Btw, mypy may have revealed some legitimate errors in a recent change: ```

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384807421 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect

[GitHub] [beam] chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes

2020-02-26 Thread GitBox
chadrik commented on a change in pull request #10822: [BEAM-7746] Minor typing updates / fixes URL: https://github.com/apache/beam/pull/10822#discussion_r384807421 ## File path: sdks/python/apache_beam/transforms/external_java.py ## @@ -37,18 +39,19 @@ # Protect

[GitHub] [beam] aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled

2020-02-26 Thread GitBox
aaltay commented on issue #10934: [BEAM-9322] [BEAM-1833] Broke some people, setting the default to have the experiment be disabled URL: https://github.com/apache/beam/pull/10934#issuecomment-591677820 > @aaltay Even though I prefer a proper fix, being pragmatic is important. This still

[GitHub] [beam] pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672844 cc: @henryken This is an automated message from the Apache

[GitHub] [beam] pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
pabloem commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672889 fyi henry This is an automated message from the Apache Git

[GitHub] [beam] iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672678 Thanks Pablo! This is an automated message from the Apache

[GitHub] [beam] iemejia merged pull request #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
iemejia merged pull request #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard

2020-02-26 Thread GitBox
iemejia commented on issue #10964: Make logger naming consistent with Apache Beam LOG standard URL: https://github.com/apache/beam/pull/10964#issuecomment-591672273 This build has failed at least 10 times on unrelated flake tests I am going to merge it eagerly, if anything ends up broken

[beam] branch master updated (4e35fb6 -> d577e41)

2020-02-26 Thread iemejia
This is an automated email from the ASF dual-hosted git repository. iemejia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git. from 4e35fb6 Merge pull request #10796 from Refine access level for `sdks/java/extensions/protobuf` add 67ad5ce

[GitHub] [beam] iht commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read

2020-02-26 Thread GitBox
iht commented on issue #9852: [BEAM-8458] Add option to set temp dataset in BigQueryIO.Read URL: https://github.com/apache/beam/pull/9852#issuecomment-591668641 Thank you! This is an automated message from the Apache Git

[GitHub] [beam] iemejia commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor

2020-02-26 Thread GitBox
iemejia commented on issue #10901: [BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor URL: https://github.com/apache/beam/pull/10901#issuecomment-591667294 retest this please This is an automated

[GitHub] [beam] chamikaramj commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

2020-02-26 Thread GitBox
chamikaramj commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r384729053 ## File path:

  1   2   >