[GitHub] [calcite] jinxing64 commented on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

jinxing64 commented on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#issuecomment-558965998 According to title convention in Calcite, we shouldn't include 'fix' ~ > if (null) is not compiling in CoalesceImplementor ?

[calcite] branch master updated (eb71946 -> 33157f4)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from eb71946 [CALCITE-3141] Slow tests are not run in continuous integration add 33157f4 [CALCITE-3512] Query

[GitHub] [calcite] danny0405 closed pull request #1592: [CALCITE-3512] Query fails when comparing Time/TimeStamp types

danny0405 closed pull request #1592: [CALCITE-3512] Query fails when comparing Time/TimeStamp types URL: https://github.com/apache/calcite/pull/1592 This is an automated message from the Apache Git Service. To respond to

[calcite] 02/02: [CALCITE-3141] Slow tests are not run in continuous integration

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit eb71946c843b3dc9618a2c128dcaa9bf52afe9c7 Author: Stamatis Zampetakis AuthorDate: Thu Jul 18 20:18:57 2019 +0200

[calcite] 01/02: [CALCITE-3140] Multiple failures when executing slow tests

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 6ad3f9a97b2c68ad9b08e9f6099ce9c5e1fd9a80 Author: Stamatis Zampetakis AuthorDate: Fri Jul 19 16:00:06 2019 +0200

[GitHub] [calcite] zabetak merged pull request #1375: [CALCITE-3140][CALCITE-3141] Failures in slow tests & CI

zabetak merged pull request #1375: [CALCITE-3140][CALCITE-3141] Failures in slow tests & CI URL: https://github.com/apache/calcite/pull/1375 This is an automated message from the Apache Git Service. To respond to the

[calcite] branch master updated (07c1efb -> eb71946)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 07c1efb [CALCITE-3534] Support parse(unparse) alien system non-standard data type new 6ad3f9a

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

XuQianJin-Stars commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r351104656 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisServerMini.java ## @@ -0,0

[GitHub] [calcite] DonnyZone commented on a change in pull request #1593: [CALCITE-3513] Unify TableFunction implementor's NullPolicy and its behavior

DonnyZone commented on a change in pull request #1593: [CALCITE-3513] Unify TableFunction implementor's NullPolicy and its behavior URL: https://github.com/apache/calcite/pull/1593#discussion_r351069104 ## File path: core/src/test/java/org/apache/calcite/test/TableFunctionTest.java

[GitHub] [calcite] xy2953396112 edited a comment on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup

xy2953396112 edited a comment on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup URL: https://github.com/apache/calcite/pull/1573#issuecomment-558579210 > @xy2953396112 Thanks. The change doesn't match with the title. You also changed for MS

[GitHub] [calcite] amaliujia edited a comment on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

amaliujia edited a comment on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#issuecomment-558748948 Can we change this title to maybe "Fix if (null) is not compiling in CoalesceImplementor" to make title more

[GitHub] [calcite] vlsi commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter

vlsi commented on a change in pull request #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#discussion_r351008300 ## File path: redis/src/main/java/org/apache/calcite/adapter/redis/RedisServerMini.java ## @@ -0,0 +1,121 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1604: [CALCITE-3521] CalciteSystemProperty failed to load config file

hsyuan commented on a change in pull request #1604: [CALCITE-3521] CalciteSystemProperty failed to load config file URL: https://github.com/apache/calcite/pull/1604#discussion_r35046 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

amaliujia commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r350991581 ## File path:

[GitHub] [calcite] amaliujia commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

amaliujia commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r350991581 ## File path:

[GitHub] [calcite] xndai commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

xndai commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#discussion_r350990730 ## File path:

[GitHub] [calcite] amaliujia commented on a change in pull request #1593: [CALCITE-3513] Unify TableFunction implementor's NullPolicy and its behavior

amaliujia commented on a change in pull request #1593: [CALCITE-3513] Unify TableFunction implementor's NullPolicy and its behavior URL: https://github.com/apache/calcite/pull/1593#discussion_r350987066 ## File path: core/src/test/java/org/apache/calcite/test/TableFunctionTest.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1593: [CALCITE-3513] Unify TableFunction implementor's NullPolicy and its behavior

amaliujia commented on a change in pull request #1593: [CALCITE-3513] Unify TableFunction implementor's NullPolicy and its behavior URL: https://github.com/apache/calcite/pull/1593#discussion_r350985168 ## File path: core/src/test/java/org/apache/calcite/test/TableFunctionTest.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

hsyuan commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r350957819 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

hsyuan commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r350955938 ## File path:

[GitHub] [calcite] amaliujia commented on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

amaliujia commented on issue #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#issuecomment-558748948 Can we change this title to maybe "Fix if (null) is not compiling in CoalesceImplementor" to make PR more specific?

[GitHub] [calcite] amaliujia commented on a change in pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

amaliujia commented on a change in pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#discussion_r350895613 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCalcTest.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

amaliujia commented on a change in pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#discussion_r350895613 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCalcTest.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#discussion_r350892843 ## File path:

[GitHub] [calcite] jinxing64 commented on issue #1495: [CALCITE-3399] Field-pruning for set operators (except UNION ALL) changes query semantics

jinxing64 commented on issue #1495: [CALCITE-3399] Field-pruning for set operators (except UNION ALL) changes query semantics URL: https://github.com/apache/calcite/pull/1495#issuecomment-558621156 ping for review This is an

[GitHub] [calcite] jinxing64 commented on issue #1560: [CALCITE-3478] Reconstructure of materialized view tests

jinxing64 commented on issue #1560: [CALCITE-3478] Reconstructure of materialized view tests URL: https://github.com/apache/calcite/pull/1560#issuecomment-558618881 Hi ~ committers ~ I rebased this patch and resolved the conflicts ~ It's great if you can take some time and help

[GitHub] [calcite] jinxing64 commented on a change in pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor

jinxing64 commented on a change in pull request #1605: [CALCITE-3536] Wrong semantics in CoalesceImplementor URL: https://github.com/apache/calcite/pull/1605#discussion_r350714234 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCoalesceFunction.java ## @@

[GitHub] [calcite] xy2953396112 commented on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup

xy2953396112 commented on issue #1573: [CALCITE-3496] Hive dialect and MS SQL dialect support with cube and with rollup URL: https://github.com/apache/calcite/pull/1573#issuecomment-558579210 > @xy2953396112 Thanks. The change doesn't match with the title. You also changed for MS SQL.

[GitHub] [calcite] rubenada commented on a change in pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi…

rubenada commented on a change in pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi… URL: https://github.com/apache/calcite/pull/1576#discussion_r350608699 ## File path: core/src/test/resources/sql/join.iq ## @@ -200,7 +200,7 @@

[GitHub] [calcite] vlsi commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

vlsi commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#discussion_r350602849 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1375: [CALCITE-3140][CALCITE-3141] Failures in slow tests & CI

zabetak commented on a change in pull request #1375: [CALCITE-3140][CALCITE-3141] Failures in slow tests & CI URL: https://github.com/apache/calcite/pull/1375#discussion_r350593309 ## File path: .github/workflows/main.yml ## @@ -15,7 +16,17 @@ on: #