[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-08 Thread GitBox
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1640#discussion_r355286469 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ##

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-08 Thread GitBox
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1640#discussion_r355286596 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@

[GitHub] [calcite] chunweilei commented on issue #1565: [CALCITE-3481] Support convert TableFunctionScan to SqlNode

2019-12-08 Thread GitBox
chunweilei commented on issue #1565: [CALCITE-3481] Support convert TableFunctionScan to SqlNode URL: https://github.com/apache/calcite/pull/1565#issuecomment-563055108 LGTM. This is an automated message from the Apache Git

[GitHub] [calcite] DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

2019-12-08 Thread GitBox
DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation URL: https://github.com/apache/calcite/pull/1347#discussion_r355251665 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] [calcite] DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

2019-12-08 Thread GitBox
DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation URL: https://github.com/apache/calcite/pull/1347#discussion_r355250676 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

2019-12-08 Thread GitBox
DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation URL: https://github.com/apache/calcite/pull/1347#discussion_r355250676 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] yanlin-Lynn commented on issue #1565: [CALCITE-3481] Support convert TableFunctionScan to SqlNode

2019-12-08 Thread GitBox
yanlin-Lynn commented on issue #1565: [CALCITE-3481] Support convert TableFunctionScan to SqlNode URL: https://github.com/apache/calcite/pull/1565#issuecomment-563046208 hi, @chunweilei , I have updated the PR according to your comment. Anything else to do for this?

[GitHub] [calcite] DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

2019-12-08 Thread GitBox
DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation URL: https://github.com/apache/calcite/pull/1347#discussion_r355247414 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1609: [CALCITE-3520] Type cast from primitive to box is not correct

2019-12-08 Thread GitBox
DonnyZone commented on a change in pull request #1609: [CALCITE-3520] Type cast from primitive to box is not correct URL: https://github.com/apache/calcite/pull/1609#discussion_r355245385 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java

[GitHub] [calcite] chunweilei commented on issue #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates

2019-12-08 Thread GitBox
chunweilei commented on issue #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates URL: https://github.com/apache/calcite/pull/1636#issuecomment-563038173 Could you please resolve the conflicts?

[GitHub] [calcite] jinxing64 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
jinxing64 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355243183 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-08 Thread GitBox
chunweilei commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1640#discussion_r355241884 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-08 Thread GitBox
chunweilei commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1640#discussion_r355242549 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -900,6

[GitHub] [calcite] danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355238662 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355238474 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355238346 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355238346 ## File path:

svn commit: r37139 - /dev/calcite/apache-calcite-avatica-1.16.0-rc0/

2019-12-08 Thread francischuang
Author: francischuang Date: Sun Dec 8 22:07:16 2019 New Revision: 37139 Log: Uploading release candidate Apache Calcite Avatica avatica-1.16.0-rc0 to dev area Added: dev/calcite/apache-calcite-avatica-1.16.0-rc0/

[calcite-avatica] annotated tag avatica-1.16.0-rc0 created (now a9d6f6c)

2019-12-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to annotated tag avatica-1.16.0-rc0 in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. at a9d6f6c (tag) tagging 204d58849ecdf2ef639308edba74f416311f7d88 (commit)

[calcite-avatica] 02/02: Update documentation and history for 1.16.0

2019-12-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git commit 204d58849ecdf2ef639308edba74f416311f7d88 Author: Francis Chuang AuthorDate: Mon Dec 9 08:56:03 2019

[calcite-avatica] branch master updated (6ff9911 -> 204d588)

2019-12-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. discard 6ff9911 Configure Git tags to be pushed to calcite-avatica repository not calcite discard f330e7e

[calcite-avatica] 01/02: Configure Git tags to be pushed to calcite-avatica repository not calcite

2019-12-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git commit 6755f4c1a108b80905ecace5da67514c66a03812 Author: Vladimir Sitnikov AuthorDate: Sat Dec 7 22:38:21 2019

[GitHub] [calcite] jinxing64 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
jinxing64 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355182882 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
jinxing64 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355182819 ## File path:

[GitHub] [calcite] zabetak closed pull request #1638: [CALCITE-3540] FoodmartTest produces many warnings due to incorrect use of CalciteAssert.pooled()

2019-12-08 Thread GitBox
zabetak closed pull request #1638: [CALCITE-3540] FoodmartTest produces many warnings due to incorrect use of CalciteAssert.pooled() URL: https://github.com/apache/calcite/pull/1638 This is an automated message from the

[calcite] branch master updated (d934d12 -> 4f70978)

2019-12-08 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from d934d12 [CALCITE-3565] Explicitly cast assignable operand types to decimal for udf (DonnyZone) add 4f70978

[GitHub] [calcite] zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355169117 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1406: [CALCITE-3243] Incomplete validation of operands in JSON functions

2019-12-08 Thread GitBox
zhztheplayer commented on a change in pull request #1406: [CALCITE-3243] Incomplete validation of operands in JSON functions URL: https://github.com/apache/calcite/pull/1406#discussion_r355168982 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355168637 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java

[GitHub] [calcite] zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355168485 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java

[GitHub] [calcite] zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

2019-12-08 Thread GitBox
zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions URL: https://github.com/apache/calcite/pull/1554#discussion_r355168485 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java