[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361270242 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361270113 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361270058 ## File path: core/src/main/java/org/apache/calcite/util/TimestampWithTimeZone.java ##

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361270085 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361270030 ## File path: core/src/main/java/org/apache/calcite/util/TimestampWithTimeZone.java ##

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361269219 ## File path: core/src/main/java/org/apache/calcite/util/TimeWithTimeZone.java ## @@

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361268928 ## File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java ## @@ -1345,6

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361268633 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java

[GitHub] [calcite] docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361268673 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1688: [CALCITE-3626] Add SortOnCalcToSortUnifyRule in SubstitutionVisitor

2019-12-24 Thread GitBox
chunweilei commented on a change in pull request #1688: [CALCITE-3626] Add SortOnCalcToSortUnifyRule in SubstitutionVisitor URL: https://github.com/apache/calcite/pull/1688#discussion_r361264735 ## File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361261358 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@

[GitHub] [calcite] xy2953396112 opened a new pull request #1688: [CALCITE-3626] Add SortOnCalcToSortUnifyRule in SubstitutionVisitor

2019-12-24 Thread GitBox
xy2953396112 opened a new pull request #1688: [CALCITE-3626] Add SortOnCalcToSortUnifyRule in SubstitutionVisitor URL: https://github.com/apache/calcite/pull/1688 JIRA: https://issues.apache.org/jira/browse/CALCITE-3626 This

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361258387 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361257782 ## File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java ## @@

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361257782 ## File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java ## @@

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361258387 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361258163 ## File path: core/src/main/java/org/apache/calcite/util/TimeWithTimeZone.java ## @@

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361258290 ## File path: core/src/main/java/org/apache/calcite/util/TimestampWithTimeZone.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r36124 ## File path:

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361258486 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361258318 ## File path: core/src/main/java/org/apache/calcite/util/TimestampWithTimeZone.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687#discussion_r361256059 ## File path:

[GitHub] [calcite] docete opened a new pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer

2019-12-24 Thread GitBox
docete opened a new pull request #1687: [CALCITE-3612] Add TIME/TIMESTAMP WITH TIME ZONE in optimizer URL: https://github.com/apache/calcite/pull/1687 * Introduce TIME/TIMESTAMP WITH TIME ZONE types * Introduce TimeWithTimeZone as internal representation of TIME WITH TIME ZONE type

[GitHub] [calcite] chunweilei commented on a change in pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule

2019-12-24 Thread GitBox
chunweilei commented on a change in pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule URL: https://github.com/apache/calcite/pull/1686#discussion_r361252973 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule

2019-12-24 Thread GitBox
danny0405 commented on a change in pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule URL: https://github.com/apache/calcite/pull/1686#discussion_r361251853 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java ## @@

[GitHub] [calcite] chunweilei opened a new pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule

2019-12-24 Thread GitBox
chunweilei opened a new pull request #1686: [CALCITE-3630] Improve ReduceExpressionsRule URL: https://github.com/apache/calcite/pull/1686 JIRA: https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-3630 This is an

[GitHub] [calcite] helloppx commented on issue #1680: [CALCITE-3621] Push down sort to DB, SQL of Sort rel contains explicit field name instead of * when sort is not top rel

2019-12-24 Thread GitBox
helloppx commented on issue #1680: [CALCITE-3621] Push down sort to DB, SQL of Sort rel contains explicit field name instead of * when sort is not top rel URL: https://github.com/apache/calcite/pull/1680#issuecomment-568823430 By the way, when we switch "calcite.enable.enumerable" to

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1685: [CALCITE-3625] Update mongo tests upgrade from junit4 to junit5

2019-12-24 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1685: [CALCITE-3625] Update mongo tests upgrade from junit4 to junit5 URL: https://github.com/apache/calcite/pull/1685#discussion_r361240161 ## File path:

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia edited a comment on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875 @danny0405 I understand your concerns. Current

[GitHub] [calcite] vlsi commented on a change in pull request #1685: [CALCITE-3625] Update mongo tests upgrade from junit4 to junit5

2019-12-24 Thread GitBox
vlsi commented on a change in pull request #1685: [CALCITE-3625] Update mongo tests upgrade from junit4 to junit5 URL: https://github.com/apache/calcite/pull/1685#discussion_r361199192 ## File path: mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoDatabasePolicy.java

[calcite] branch master updated: Following [CALCITE-3525] Fix slow tests expected plan

2019-12-24 Thread volodymyr
This is an automated email from the ASF dual-hosted git repository. volodymyr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new a69d249 Following [CALCITE-3525] Fix slow

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1685: [CALCITE-3625] Update mongo tests upgrade from junit4 to junit5

2019-12-24 Thread GitBox
XuQianJin-Stars opened a new pull request #1685: [CALCITE-3625] Update mongo tests upgrade from junit4 to junit5 URL: https://github.com/apache/calcite/pull/1685 As illustrated in CALCITE-3625 Update `mongo` tests upgrade from junit4 to junit5.

[GitHub] [calcite] wangxlong commented on a change in pull request #1676: [CALCITE-3591] Add bit_xor aggregate function

2019-12-24 Thread GitBox
wangxlong commented on a change in pull request #1676: [CALCITE-3591] Add bit_xor aggregate function URL: https://github.com/apache/calcite/pull/1676#discussion_r361161110 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@

[GitHub] [calcite] wangxlong commented on a change in pull request #1676: [CALCITE-3591] Add bit_xor aggregate function

2019-12-24 Thread GitBox
wangxlong commented on a change in pull request #1676: [CALCITE-3591] Add bit_xor aggregate function URL: https://github.com/apache/calcite/pull/1676#discussion_r361161110 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@

[GitHub] [calcite] wangxlong commented on a change in pull request #1676: [CALCITE-3591] Add bit_xor aggregate function

2019-12-24 Thread GitBox
wangxlong commented on a change in pull request #1676: [CALCITE-3591] Add bit_xor aggregate function URL: https://github.com/apache/calcite/pull/1676#discussion_r361161088 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@

[calcite] branch master updated: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-24 Thread volodymyr
This is an automated email from the ASF dual-hosted git repository. volodymyr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 1f3b710 [CALCITE-3525] RexSimplify:

[GitHub] [calcite] asfgit closed pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-24 Thread GitBox
asfgit closed pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] DonnyZone commented on issue #1274: [CALCITE-771] Use materialization for scan-project-sort query

2019-12-24 Thread GitBox
DonnyZone commented on issue #1274: [CALCITE-771] Use materialization for scan-project-sort query URL: https://github.com/apache/calcite/pull/1274#issuecomment-568709820 @jinxing64 @xy2953396112 I have been kind of busy recently. I'm glad that you can continue this work. Thanks!

[GitHub] [calcite] DonnyZone opened a new pull request #1684: [CALCITE-3627] Incorrect null semantic for ROW function

2019-12-24 Thread GitBox
DonnyZone opened a new pull request #1684: [CALCITE-3627] Incorrect null semantic for ROW function URL: https://github.com/apache/calcite/pull/1684 As illustrated in [CALCITE-3627](https://issues.apache.org/jira/browse/CALCITE-3627) This PR: (1) allows `ROW` function's return type

[GitHub] [calcite] xy2953396112 commented on issue #1274: [CALCITE-771] Use materialization for scan-project-sort query

2019-12-24 Thread GitBox
xy2953396112 commented on issue #1274: [CALCITE-771] Use materialization for scan-project-sort query URL: https://github.com/apache/calcite/pull/1274#issuecomment-568704781 Hi @DonnyZone, thanks for feedback ~ Are you still working on this? if no I would like to take it and have a try

[GitHub] [calcite] jinxing64 commented on issue #1274: [CALCITE-771] Use materialization for scan-project-sort query

2019-12-24 Thread GitBox
jinxing64 commented on issue #1274: [CALCITE-771] Use materialization for scan-project-sort query URL: https://github.com/apache/calcite/pull/1274#issuecomment-568703612 Hi @DonnyZone Would you please resolve the conflicts ?

[GitHub] [calcite] danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-568700275 No need to keep my credit, the `if (isTumble)` decision is too

[GitHub] [calcite] amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2019-12-24 Thread GitBox
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#issuecomment-568686794 @danny0405 thanks for your awesome work! I merged your change