[GitHub] [calcite] xy2953396112 opened a new pull request #1762: [CALCITE-3740] Add FilterSetOpTransposeRule to normalize materialized…

2020-01-14 Thread GitBox
xy2953396112 opened a new pull request #1762: [CALCITE-3740] Add FilterSetOpTransposeRule to normalize materialized… URL: https://github.com/apache/calcite/pull/1762 … view JIRA:[JIRA](https://issues.apache.org/jira/browse/CALCITE-3740l)

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1709: [CALCITE-3653] Support TableModify in ToLogicalConverter

2020-01-14 Thread GitBox
xy2953396112 commented on a change in pull request #1709: [CALCITE-3653] Support TableModify in ToLogicalConverter URL: https://github.com/apache/calcite/pull/1709#discussion_r366715500 ## File path: core/src/test/java/org/apache/calcite/rel/logical/ToLogicalConverterTest.java

[GitHub] [calcite] amaliujia opened a new pull request #1761: [CALCITE-3737] HOP Table-valued Function

2020-01-14 Thread GitBox
amaliujia opened a new pull request #1761: [CALCITE-3737] HOP Table-valued Function URL: https://github.com/apache/calcite/pull/1761 see: https://issues.apache.org/jira/browse/CALCITE-3737 This is an automated message from

[GitHub] [calcite] danny0405 commented on a change in pull request #1709: [CALCITE-3653] Support TableModify in ToLogicalConverter

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1709: [CALCITE-3653] Support TableModify in ToLogicalConverter URL: https://github.com/apache/calcite/pull/1709#discussion_r366708684 ## File path: core/src/test/java/org/apache/calcite/rel/logical/ToLogicalConverterTest.java

[GitHub] [calcite] jinxing64 commented on a change in pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str…

2020-01-14 Thread GitBox
jinxing64 commented on a change in pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str… URL: https://github.com/apache/calcite/pull/1757#discussion_r366706059 ## File path: core/src/test/java/org/apache/calcite/test/TableInRootSchemaTest.java

[GitHub] [calcite] danny0405 edited a comment on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel

2020-01-14 Thread GitBox
danny0405 edited a comment on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel URL: https://github.com/apache/calcite/pull/1635#issuecomment-574488829 If we have no use cases for that, i suggest to close the PR.

[GitHub] [calcite] xy2953396112 closed pull request #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel

2020-01-14 Thread GitBox
xy2953396112 closed pull request #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel URL: https://github.com/apache/calcite/pull/1635 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] xy2953396112 commented on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel

2020-01-14 Thread GitBox
xy2953396112 commented on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel URL: https://github.com/apache/calcite/pull/1635#issuecomment-574499000 > I we have no use cases for that, i suggest to close the PR. Thanks for review.

[GitHub] [calcite] danny0405 commented on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel

2020-01-14 Thread GitBox
danny0405 commented on issue #1635: [CALCITE-3570] Support MutableSnapshot in MutableRel URL: https://github.com/apache/calcite/pull/1635#issuecomment-574488829 I we have no use cases for that, i suggest to close the PR.

[GitHub] [calcite] danny0405 opened a new pull request #1760: [CALCITE-3736] Add an interface in RelOptRuleCall to customize the pr…

2020-01-14 Thread GitBox
danny0405 opened a new pull request #1760: [CALCITE-3736] Add an interface in RelOptRuleCall to customize the pr… URL: https://github.com/apache/calcite/pull/1760 …opagation of hints before registering into planner rule This

[GitHub] [calcite] hsyuan commented on a change in pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception

2020-01-14 Thread GitBox
hsyuan commented on a change in pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception URL: https://github.com/apache/calcite/pull/1759#discussion_r366685330 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception

2020-01-14 Thread GitBox
hsyuan commented on a change in pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception URL: https://github.com/apache/calcite/pull/1759#discussion_r366685330 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] jinxing64 commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view

2020-01-14 Thread GitBox
jinxing64 commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view URL: https://github.com/apache/calcite/pull/1704#discussion_r366681134 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception

2020-01-14 Thread GitBox
hsyuan commented on a change in pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception URL: https://github.com/apache/calcite/pull/1759#discussion_r366671373 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366407494 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception

2020-01-14 Thread GitBox
XuQianJin-Stars opened a new pull request #1759: [CALCITE-3676] VolcanoPlanner. dumpGraphviz should handle exception URL: https://github.com/apache/calcite/pull/1759 As illustrated in [CALCITE-3676](https://issues.apache.org/jira/browse/CALCITE-3676)

[calcite] branch master updated (7bb120d -> 990ed29)

2020-01-14 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 7bb120d [CALCITE-3721] Filter of distinct aggregate call is lost after applying

[GitHub] [calcite] danny0405 closed pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support

2020-01-14 Thread GitBox
danny0405 closed pull request #1727: [CALCITE-3640] Oracle EXISTSNODE Function Support URL: https://github.com/apache/calcite/pull/1727 This is an automated message from the Apache Git Service. To respond to the message,

[calcite] branch master updated: [CALCITE-3721] Filter of distinct aggregate call is lost after applying AggregateExpandDistinctAggregatesRule (Shuo Cheng)

2020-01-14 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 7bb120d [CALCITE-3721] Filter of distinct

[GitHub] [calcite] danny0405 closed pull request #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`

2020-01-14 Thread GitBox
danny0405 closed pull request #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule` URL: https://github.com/apache/calcite/pull/1758 This is an automated

[calcite] branch master updated (6257609 -> b80bb1c)

2020-01-14 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 6257609 [CALCITE-3730] Add hints to RelBuilder add b80bb1c [CALCITE-3382] Support TUMBLE as Table Value

[GitHub] [calcite] danny0405 closed pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR

2020-01-14 Thread GitBox
danny0405 closed pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587 This is an

[GitHub] [calcite] danny0405 merged pull request #1754: [CALCITE-3730] Add hints to RelBuilder

2020-01-14 Thread GitBox
danny0405 merged pull request #1754: [CALCITE-3730] Add hints to RelBuilder URL: https://github.com/apache/calcite/pull/1754 This is an automated message from the Apache Git Service. To respond to the message, please log on

[calcite] branch master updated: [CALCITE-3730] Add hints to RelBuilder

2020-01-14 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 6257609 [CALCITE-3730] Add hints to

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366407494 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366407494 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-14 Thread GitBox
xy2953396112 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r366329841 ## File path: site/_docs/reference.md ## @@ -2331,6 +2334,7 @@ semantics.

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str…

2020-01-14 Thread GitBox
xy2953396112 commented on a change in pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str… URL: https://github.com/apache/calcite/pull/1757#discussion_r366325969 ## File path:

[GitHub] [calcite] xy2953396112 commented on issue #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str…

2020-01-14 Thread GitBox
xy2953396112 commented on issue #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str… URL: https://github.com/apache/calcite/pull/1757#issuecomment-574164092 Looks good~ please fix ci This is an

[GitHub] [calcite] xy2953396112 commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`

2020-01-14 Thread GitBox
xy2953396112 commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule` URL: https://github.com/apache/calcite/pull/1758#issuecomment-574148644 Maybe you can squash commits and keep a discussion in one PR.

[GitHub] [calcite] cshuo commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`

2020-01-14 Thread GitBox
cshuo commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule` URL: https://github.com/apache/calcite/pull/1758#issuecomment-574140805 > Please refrain from re-creating PRs with exactly the same changes. It

[GitHub] [calcite] vlsi commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`

2020-01-14 Thread GitBox
vlsi commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule` URL: https://github.com/apache/calcite/pull/1758#issuecomment-574137406 Please refrain from re-creating PRs with exactly the same changes. It loses

[GitHub] [calcite] cshuo commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`

2020-01-14 Thread GitBox
cshuo commented on issue #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule` URL: https://github.com/apache/calcite/pull/1758#issuecomment-574137414 See [pull/1741](https://github.com/apache/calcite/pull/1741) for

[GitHub] [calcite] cshuo commented on issue #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
cshuo commented on issue #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#issuecomment-574137157 See [pull/1758](https://github.com/apache/calcite/pull/1758)

[GitHub] [calcite] cshuo opened a new pull request #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule`

2020-01-14 Thread GitBox
cshuo opened a new pull request #1758: [CALCITE-3721] Filter of distinct aggregate call is lost after applying `AggregateExpandDistinctAggregatesRule` URL: https://github.com/apache/calcite/pull/1758 In `AggregateExpandDistinctAggregatesRule`, when the distinct aggregate call is rewritten

[GitHub] [calcite] cshuo closed pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
cshuo closed pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] cshuo closed pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
cshuo closed pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] cshuo opened a new pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
cshuo opened a new pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741 …ng `AggregateExpandDistinctAggregatesRule` In `AggregateExpandDistinctAggregatesRule`, when the distinct aggregate call is

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366263800 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366263800 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366252399 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#discussion_r366252358 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#discussion_r366251702 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#discussion_r366250355 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi…

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1741: [CALCITE-3721] Filter of distinct aggregate call is lost after applyi… URL: https://github.com/apache/calcite/pull/1741#discussion_r366250026 ## File path:

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366247257 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366246964 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366246619 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -4488,6 +4488,37 @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366246378 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6

[GitHub] [calcite] 34venu commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing)

2020-01-14 Thread GitBox
34venu commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing) URL: https://github.com/apache/calcite/pull/1753#issuecomment-574075024 i have referred the TableFunctionTest and i have run the query select * from

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366215049 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@ -110,8

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366214662 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -4488,6 +4488,37 @@ private

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366212096 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366212096 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] danny0405 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r366207793 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r366205659 ## File path: core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366204707 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -4488,6 +4488,37 @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366203883 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366203189 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r366203359 ## File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366202853 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366202853 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6

[GitHub] [calcite] DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
DonnyZone commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366202853 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6

[GitHub] [calcite] danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

2020-01-14 Thread GitBox
danny0405 commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r366202768 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java