[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

2020-11-09 Thread GitBox
julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520043528 ## File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java ## @@ -1687,10 +1687,8 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

2020-11-09 Thread GitBox
julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520041144 ## File path: core/src/main/java/org/apache/calcite/util/Sarg.java ## @@ -170,6 +170,14 @@ public boolean isComplementedPoints() {

[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

2020-11-09 Thread GitBox
julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r520039486 ## File path: core/src/main/java/org/apache/calcite/util/RangeSets.java ## @@ -128,6 +129,14 @@ private RangeSets() {} && !range.isEmpty();

[GitHub] [calcite] julianhyde commented on a change in pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

2020-11-03 Thread GitBox
julianhyde commented on a change in pull request #2238: URL: https://github.com/apache/calcite/pull/2238#discussion_r516228159 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2710,6 +2710,16 @@ private boolean accept1(RexNode e, SqlKind kind,