[GitHub] [calcite] hsyuan commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
hsyuan commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#discussion_r333845707 ## File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java

[GitHub] [calcite] jinxing64 commented on issue #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
jinxing64 commented on issue #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#issuecomment-540953216 Really thanks for approval ~ This is an

[GitHub] [calcite] danny0405 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
danny0405 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#discussion_r333880147 ## File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java

[GitHub] [calcite] danny0405 commented on issue #1497: [CALCITE-3379] Support expand STRING column expression of table durin…

2019-10-11 Thread GitBox
danny0405 commented on issue #1497: [CALCITE-3379] Support expand STRING column expression of table durin… URL: https://github.com/apache/calcite/pull/1497#issuecomment-540968433 BTW, there is no code to use this feature for Calcite, and i think the change is straightforward, so there is

[GitHub] [calcite] jinxing64 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
jinxing64 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#discussion_r333889245 ## File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java

[GitHub] [calcite] leonardBang commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread GitBox
leonardBang commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#discussion_r333891672 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ##

[GitHub] [calcite] yanlin-Lynn opened a new pull request #1496: [CALCITE-3400] Add support for interpretering left/right/semi/anti/full join

2019-10-11 Thread GitBox
yanlin-Lynn opened a new pull request #1496: [CALCITE-3400] Add support for interpretering left/right/semi/anti/full join URL: https://github.com/apache/calcite/pull/1496 Currently, we can only interpreter inner join with

[GitHub] [calcite] kgyrtkirk commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread GitBox
kgyrtkirk commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#discussion_r333868804 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -204,7

[GitHub] [calcite] kgyrtkirk commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread GitBox
kgyrtkirk commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#discussion_r333870858 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java ## @@

[GitHub] [calcite] danny0405 opened a new pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin…

2019-10-11 Thread GitBox
danny0405 opened a new pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin… URL: https://github.com/apache/calcite/pull/1497 …g sql-to-rel conversion * Add a default implementation in InitializerContext to support parsing string column

[GitHub] [calcite] kgyrtkirk commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread GitBox
kgyrtkirk commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#discussion_r333879923 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -204,7

[GitHub] [calcite] danny0405 commented on a change in pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin…

2019-10-11 Thread GitBox
danny0405 commented on a change in pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin… URL: https://github.com/apache/calcite/pull/1497#discussion_r333881474 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java

[GitHub] [calcite] leonardBang commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread GitBox
leonardBang commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#discussion_r333886685 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -204,7

[GitHub] [calcite] danny0405 commented on a change in pull request #1462: [CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-10-11 Thread GitBox
danny0405 commented on a change in pull request #1462: [CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a new Join URL: https://github.com/apache/calcite/pull/1462#discussion_r333890678 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
danny0405 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#discussion_r333893314 ## File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java

[GitHub] [calcite] jinxing64 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
jinxing64 commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#discussion_r333893691 ## File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java

[GitHub] [calcite] hsyuan closed pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
hsyuan closed pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493 This is an automated message from the Apache Git Service. To respond

[calcite] branch master updated: [CALCITE-3396] Materialized view matches unexpectedly for UNION with different 'all' property (Jin Xing)

2019-10-11 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new c7ab646 [CALCITE-3396] Materialized view

[GitHub] [calcite] hsyuan commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
hsyuan commented on a change in pull request #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#discussion_r334165335 ## File path: core/src/test/java/org/apache/calcite/test/MaterializationTest.java

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1496: [CALCITE-3400] Add support for interpretering left/right/semi/anti/full join

2019-10-11 Thread GitBox
yanlin-Lynn commented on a change in pull request #1496: [CALCITE-3400] Add support for interpretering left/right/semi/anti/full join URL: https://github.com/apache/calcite/pull/1496#discussion_r334216205 ## File path: core/src/main/java/org/apache/calcite/interpreter/JoinNode.java

[GitHub] [calcite] amansinha100 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

2019-10-11 Thread GitBox
amansinha100 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p… URL: https://github.com/apache/calcite/pull/1492#discussion_r334210934 ## File path:

[GitHub] [calcite] amansinha100 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

2019-10-11 Thread GitBox
amansinha100 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p… URL: https://github.com/apache/calcite/pull/1492#discussion_r334211018 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1496: [CALCITE-3400] Add support for interpretering left/right/semi/anti/full join

2019-10-11 Thread GitBox
hsyuan commented on a change in pull request #1496: [CALCITE-3400] Add support for interpretering left/right/semi/anti/full join URL: https://github.com/apache/calcite/pull/1496#discussion_r334185899 ## File path: core/src/main/java/org/apache/calcite/interpreter/JoinNode.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

2019-10-11 Thread GitBox
danny0405 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p… URL: https://github.com/apache/calcite/pull/1492#discussion_r334215196 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

2019-10-11 Thread GitBox
danny0405 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p… URL: https://github.com/apache/calcite/pull/1492#discussion_r334215216 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

2019-10-11 Thread GitBox
danny0405 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p… URL: https://github.com/apache/calcite/pull/1492#discussion_r334215236 ## File path:

[GitHub] [calcite] jinxing64 commented on issue #1493: [CALCITE-3396] Materialization matching succeeds when query and view …

2019-10-11 Thread GitBox
jinxing64 commented on issue #1493: [CALCITE-3396] Materialization matching succeeds when query and view … URL: https://github.com/apache/calcite/pull/1493#issuecomment-541277768 Thanks for merging ! @hsyuan This is an

[GitHub] [calcite] danny0405 opened a new pull request #1498: [CALCITE-3404] Promote plan for AggregateExpandDistinctAggregatesRule…

2019-10-11 Thread GitBox
danny0405 opened a new pull request #1498: [CALCITE-3404] Promote plan for AggregateExpandDistinctAggregatesRule… URL: https://github.com/apache/calcite/pull/1498 … when all the agg expressions are distinct and have same arguments In AggregateExpandDistinctAggregatesRule, if all of

[GitHub] [calcite] leonardBang commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-10-11 Thread GitBox
leonardBang commented on a change in pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#discussion_r333917737 ## File path: core/src/main/java/org/apache/calcite/rex/RexCall.java ## @@ -204,7

[GitHub] [calcite] jinxing64 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

2019-10-11 Thread GitBox
jinxing64 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p… URL: https://github.com/apache/calcite/pull/1492#discussion_r333973587 ## File path:

[GitHub] [calcite] danny0405 merged pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin…

2019-10-11 Thread GitBox
danny0405 merged pull request #1497: [CALCITE-3379] Support expand STRING column expression of table durin… URL: https://github.com/apache/calcite/pull/1497 This is an automated message from the Apache Git Service. To

[calcite] branch master updated (f7ff1c9 -> 22c76fb)

2019-10-11 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from f7ff1c9 [CALCITE-3397] AssertionError for interpretering multiset value (Wang Yanlin) add 22c76fb

[GitHub] [calcite-avatica] stoty opened a new pull request #115: CALCITE-3401 Assume empty keystore passwords by default

2019-10-11 Thread GitBox
stoty opened a new pull request #115: CALCITE-3401 Assume empty keystore passwords by default URL: https://github.com/apache/calcite-avatica/pull/115 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] jinxing64 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p…

2019-10-11 Thread GitBox
jinxing64 commented on a change in pull request #1492: [CALCITE-3390] Add ITEM expression to SqlKind and include it in the p… URL: https://github.com/apache/calcite/pull/1492#discussion_r333980423 ## File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java