[GitHub] [calcite] danny0405 commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled

danny0405 commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled URL: https://github.com/apache/calcite/pull/1584#discussion_r346695179 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] amaliujia opened a new pull request #1588: [CALCITE-3381] Unparse to correct BigQuery interval syntax: "INTERVAL…

amaliujia opened a new pull request #1588: [CALCITE-3381] Unparse to correct BigQuery interval syntax: "INTERVAL… URL: https://github.com/apache/calcite/pull/1588 … int64 time_unit". Range time unit is not supported yet by BigQuery.

[GitHub] [calcite] amaliujia commented on issue #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"…

amaliujia commented on issue #1510: [CALCITE-3418] Grouped Window Function TUMBLE should return "$TUMBLE"… URL: https://github.com/apache/calcite/pull/1510#issuecomment-554228355 This patch is a part of https://github.com/apache/calcite/pull/1587 already.

[GitHub] [calcite] amaliujia closed pull request #1457: [WIP][Prototype][CALCITE-3340] TUMBLE as a TableFunction

amaliujia closed pull request #1457: [WIP][Prototype][CALCITE-3340] TUMBLE as a TableFunction URL: https://github.com/apache/calcite/pull/1457 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] amaliujia commented on issue #1457: [WIP][Prototype][CALCITE-3340] TUMBLE as a TableFunction

amaliujia commented on issue #1457: [WIP][Prototype][CALCITE-3340] TUMBLE as a TableFunction URL: https://github.com/apache/calcite/pull/1457#issuecomment-554228194 Will close this PR. The progress now is in https://github.com/apache/calcite/pull/1587.

[GitHub] [calcite] hsyuan commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled

hsyuan commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled URL: https://github.com/apache/calcite/pull/1584#discussion_r346640964 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] julianhyde commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if…

julianhyde commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if… URL: https://github.com/apache/calcite/pull/1586#discussion_r346639635 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled

danny0405 commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled URL: https://github.com/apache/calcite/pull/1584#discussion_r346616585 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if…

danny0405 commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if… URL: https://github.com/apache/calcite/pull/1586#discussion_r346616014 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled

danny0405 commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled URL: https://github.com/apache/calcite/pull/1584#discussion_r346615063 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] amaliujia opened a new pull request #1587: [CALCITE-3382] Support TUMBLE as Table Value Function

amaliujia opened a new pull request #1587: [CALCITE-3382] Support TUMBLE as Table Value Function URL: https://github.com/apache/calcite/pull/1587 This PR add TUMBLE as table value function and also add stream.iq along with Enumerable implementation. This is a big PR that actually is

[GitHub] [calcite] julianhyde commented on a change in pull request #1556: [CALCITE-3438] Validator should disallow use of the GROUPING function inside a FILTER clause

julianhyde commented on a change in pull request #1556: [CALCITE-3438] Validator should disallow use of the GROUPING function inside a FILTER clause URL: https://github.com/apache/calcite/pull/1556#discussion_r346602042 ## File path:

[GitHub] [calcite] asereda-gs merged pull request #1582: Bump geode-core from 1.9.2 to 1.10.0

asereda-gs merged pull request #1582: Bump geode-core from 1.9.2 to 1.10.0 URL: https://github.com/apache/calcite/pull/1582 This is an automated message from the Apache Git Service. To respond to the message, please log on

[calcite] branch master updated (1667c0d -> 956905b)

This is an automated email from the ASF dual-hosted git repository. sereda pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 1667c0d [CALCITE-3494] Support decimal type aggregate in Interpreter (Wang Yanlin) add 956905b Bump

[GitHub] [calcite] hsyuan commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if…

hsyuan commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if… URL: https://github.com/apache/calcite/pull/1586#discussion_r346569044 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if…

hsyuan commented on a change in pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if… URL: https://github.com/apache/calcite/pull/1586#discussion_r346568160 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[calcite] branch master updated (5999578 -> 1667c0d)

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 5999578 Improve folder detection logic in DocumentationTest add 1667c0d [CALCITE-3494] Support decimal type

[GitHub] [calcite] hsyuan merged pull request #1572: [CALCITE-3494] Support decimal type aggregate in Interpreter

hsyuan merged pull request #1572: [CALCITE-3494] Support decimal type aggregate in Interpreter URL: https://github.com/apache/calcite/pull/1572 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#issuecomment-554097058 > Have you seen https://issues.apache.org/jira/browse/CALCITE-2223 ? > I think 3455 duplicates 2223, and,

[GitHub] [calcite] xndai commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

xndai commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#discussion_r346563987 ## File path:

[GitHub] [calcite] xndai opened a new pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if…

xndai opened a new pull request #1586: [CALCITE-3491] VolcanoPlanner.completeConversion() is bypassed by "if… URL: https://github.com/apache/calcite/pull/1586 … (true) return;" Remove unused function. This is an

[calcite] branch master updated (7341708 -> 5999578)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 7341708 [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled (Xiening Dai) add

[GitHub] [calcite] julianhyde commented on issue #1582: Bump geode-core from 1.9.2 to 1.10.0

julianhyde commented on issue #1582: Bump geode-core from 1.9.2 to 1.10.0 URL: https://github.com/apache/calcite/pull/1582#issuecomment-554045544 I think these PRs from dependabot count as "small", therefore no JIRA is necessary. However, it is worth doing a build on each JDK version and

[GitHub] [calcite] asereda-gs commented on issue #1582: Bump geode-core from 1.9.2 to 1.10.0

asereda-gs commented on issue #1582: Bump geode-core from 1.9.2 to 1.10.0 URL: https://github.com/apache/calcite/pull/1582#issuecomment-554044223 @julianhyde will do. as a general approach should we create a JRIA ticket for this PR ?

[GitHub] [calcite] julianhyde commented on issue #1582: Bump geode-core from 1.9.2 to 1.10.0

julianhyde commented on issue #1582: Bump geode-core from 1.9.2 to 1.10.0 URL: https://github.com/apache/calcite/pull/1582#issuecomment-554028976 @asereda-gs can you take a look at this? This is an automated message from the

[calcite] branch master updated (4e7f7a3 -> 7341708)

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. discard 4e7f7a3 [CALCITE-3530] NPE at VolcanoPlanner#isValid when DEBUG is enabled add 7341708 [CALCITE-3503] NPE at

[calcite] branch master updated (472523c -> 4e7f7a3)

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 472523c Use proper ClassLoader in SparkHandlerImpl add 4e7f7a3 [CALCITE-3530] NPE at VolcanoPlanner#isValid

[GitHub] [calcite] hsyuan merged pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled

hsyuan merged pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled URL: https://github.com/apache/calcite/pull/1584 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] betogontijo opened a new pull request #1585: Fixing function MOD

betogontijo opened a new pull request #1585: Fixing function MOD URL: https://github.com/apache/calcite/pull/1585 Returning int value if second operator is int This is an automated message from the Apache Git Service. To

[calcite] branch master updated (47b70d2 -> 472523c)

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 47b70d2 [CALCITE-3502] Upgrade Geode dependency 1.6.0 -> 1.9.2 add e6b2df1 Use Class#getResource

[calcite-avatica] branch master updated: Bump release plugin 1.44.0 -> 1.45.0: do not require GPG key for publishDist

This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new ed05329 Bump release plugin

[GitHub] [calcite] DonnyZone commented on issue #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

DonnyZone commented on issue #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic URL: https://github.com/apache/calcite/pull/1575#issuecomment-553844508 Thanks for review! This is an automated message

[GitHub] [calcite] rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic URL: https://github.com/apache/calcite/pull/1575#discussion_r346228217 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

DonnyZone commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic URL: https://github.com/apache/calcite/pull/1575#discussion_r346200285 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] DonnyZone commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

DonnyZone commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic URL: https://github.com/apache/calcite/pull/1575#discussion_r346193979 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic URL: https://github.com/apache/calcite/pull/1575#discussion_r346192777 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic URL: https://github.com/apache/calcite/pull/1575#discussion_r346171376 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic URL: https://github.com/apache/calcite/pull/1575#discussion_r346171177 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] [calcite] xndai opened a new pull request #1584: [CALCITE-3530] NPE at VolcanoPlanner#isValid when DEBUG is enabled

xndai opened a new pull request #1584: [CALCITE-3530] NPE at VolcanoPlanner#isValid when DEBUG is enabled URL: https://github.com/apache/calcite/pull/1584 When planner root is null, we should skip the validation since the memo is empty at that moment.