[GitHub] [calcite] xy2953396112 commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

xy2953396112 commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r526574744 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,39 @@ public RelOptPredicateList

[GitHub] [calcite] chunweilei commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

chunweilei commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r526573000 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,39 @@ public RelOptPredicateList

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

Aaron commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r526552481 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] Aaaaaaron commented on pull request #2253: [CALCITE-4385] Simplifies AND/OR condition that has common expressions, extract and eliminate/merge them as much as possible (Jiatao Tao)

Aaron commented on pull request #2253: URL: https://github.com/apache/calcite/pull/2253#issuecomment-730084700 Recently I'm really busy, sorry for the slow progress, will restart soon. This is an automated message from

[GitHub] [calcite] xy2953396112 closed pull request #2270: [CALCITE-4407] Support unparse special syntax when operator is DELETE…

xy2953396112 closed pull request #2270: URL: https://github.com/apache/calcite/pull/2270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] julianhyde commented on a change in pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

julianhyde commented on a change in pull request #2271: URL: https://github.com/apache/calcite/pull/2271#discussion_r526469745 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ## @@ -2186,6 +2186,13 @@ protected static Calendar

[GitHub] [calcite] jamesstarr opened a new pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

jamesstarr opened a new pull request #2271: URL: https://github.com/apache/calcite/pull/2271 …opereator(James Starr) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] vlsi commented on a change in pull request #2270: [CALCITE-4407] Support unparse special syntax when operator is DELETE…

vlsi commented on a change in pull request #2270: URL: https://github.com/apache/calcite/pull/2270#discussion_r526448125 ## File path: core/src/main/java/org/apache/calcite/sql/SqlDelete.java ## @@ -30,7 +30,12 @@ */ public class SqlDelete extends SqlCall { public static

[GitHub] [calcite] julianhyde commented on a change in pull request #2270: [CALCITE-4407] Support unparse special syntax when operator is DELETE…

julianhyde commented on a change in pull request #2270: URL: https://github.com/apache/calcite/pull/2270#discussion_r526317610 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ## @@ -6186,6 +6186,31 @@ public void

[GitHub] [calcite] julianhyde commented on a change in pull request #2270: [CALCITE-4407] Support unparse special syntax when operator is DELETE…

julianhyde commented on a change in pull request #2270: URL: https://github.com/apache/calcite/pull/2270#discussion_r526317081 ## File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java ## @@ -6186,6 +6186,31 @@ public void

[GitHub] [calcite] asolimando commented on pull request #2267: Following [CALCITE-4354], added 'calcite.experimental.allow.field.ind…

asolimando commented on pull request #2267: URL: https://github.com/apache/calcite/pull/2267#issuecomment-729655799 There is a test failure for the last commit: https://ci.appveyor.com/project/ApacheSoftwareFoundation/calcite/builds/36376813/job/5k2lubas8qbehk8o But it looks

[GitHub] [calcite] rubenada commented on pull request #2266: [CALCITE-4402] SqlCall#equalsDeep does not take into account the function quantifier

rubenada commented on pull request #2266: URL: https://github.com/apache/calcite/pull/2266#issuecomment-729634370 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[calcite] branch master updated (61771cc -> f3c173c)

This is an automated email from the ASF dual-hosted git repository. yanlin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 61771cc [CALCITE-4406] SqlTableRef OPERATOR should create a SqlTableRef as the call add f3c173c

[GitHub] [calcite] yanlin-Lynn merged pull request #2189: [CALCITE-4251] Get the origin column, even if it is derived (xzh)

yanlin-Lynn merged pull request #2189: URL: https://github.com/apache/calcite/pull/2189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] xy2953396112 commented on pull request #2189: [CALCITE-4251] Get the origin column, even if it is derived (xzh)

xy2953396112 commented on pull request #2189: URL: https://github.com/apache/calcite/pull/2189#issuecomment-729623742 > +1 Thanks This is an automated message from the Apache Git Service. To respond to the message,

[calcite] branch master updated (3846b50 -> 61771cc)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 3846b50 [CALCITE-4277] When rel has been removed from its subset, skip the origin rule match (Jiatao Tao)

[calcite] branch master updated (3846b50 -> 61771cc)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 3846b50 [CALCITE-4277] When rel has been removed from its subset, skip the origin rule match (Jiatao Tao)

[GitHub] [calcite] danny0405 merged pull request #2269: [CALCITE-4406] SqlTableRef OPERATOR should create a SqlTableRef as th…

danny0405 merged pull request #2269: URL: https://github.com/apache/calcite/pull/2269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] asolimando commented on a change in pull request #2267: Following [CALCITE-4354], added 'calcite.experimental.allow.field.ind…

asolimando commented on a change in pull request #2267: URL: https://github.com/apache/calcite/pull/2267#discussion_r526006792 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@ -131,6 +131,15 @@ public static final

[GitHub] [calcite] asolimando edited a comment on pull request #2267: Following [CALCITE-4354], added 'calcite.experimental.allow.field.ind…

asolimando edited a comment on pull request #2267: URL: https://github.com/apache/calcite/pull/2267#issuecomment-729599150 > One minor comment would be to see if we can enable the property by default during tests so that we have better coverage. I guess it should be doable to pass this to

[GitHub] [calcite] xy2953396112 commented on pull request #2269: [CALCITE-4406] SqlTableRef OPERATOR should create a SqlTableRef as th…

xy2953396112 commented on pull request #2269: URL: https://github.com/apache/calcite/pull/2269#issuecomment-729603530 LGTM~ This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [calcite] asolimando commented on pull request #2267: Following [CALCITE-4354], added 'calcite.experimental.allow.field.ind…

asolimando commented on pull request #2267: URL: https://github.com/apache/calcite/pull/2267#issuecomment-729599150 > One minor comment would be to see if we can enable the property by default during tests so that we have better coverage. I guess it should be doable to pass this to the

[GitHub] [calcite] rubenada commented on a change in pull request #2266: [CALCITE-4402] SqlCall#equalsDeep does not take into account the function quantifier

rubenada commented on a change in pull request #2266: URL: https://github.com/apache/calcite/pull/2266#discussion_r525986104 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCall.java ## @@ -153,6 +153,9 @@ public int operandCount() { if

[GitHub] [calcite] zabetak closed pull request #678: [CALCITE-2279] Fix issue in DruidJsonFilter reported by errorprone

zabetak closed pull request #678: URL: https://github.com/apache/calcite/pull/678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] zabetak commented on pull request #678: [CALCITE-2279] Fix issue in DruidJsonFilter reported by errorprone

zabetak commented on pull request #678: URL: https://github.com/apache/calcite/pull/678#issuecomment-729575180 I am closing this PR as the issue has been fixed in https://github.com/apache/calcite/commit/155276591288615c4d02d55fb7d77eceb2e24b2d.

[GitHub] [calcite] zabetak commented on a change in pull request #2267: Following [CALCITE-4354], added 'calcite.experimental.allow.field.ind…

zabetak commented on a change in pull request #2267: URL: https://github.com/apache/calcite/pull/2267#discussion_r525938001 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@ -131,6 +131,15 @@ public static final

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

xy2953396112 commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r525948729 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,40 @@ public RelOptPredicateList

[GitHub] [calcite] hqx871 commented on a change in pull request #2266: [CALCITE-4402] SqlCall#equalsDeep does not take into account the function quantifier

hqx871 commented on a change in pull request #2266: URL: https://github.com/apache/calcite/pull/2266#discussion_r525926724 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlEqualsDeepTest.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

[calcite] branch master updated (2ddc836 -> 3846b50)

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 2ddc836 [CALCITE-4392] The operation of checking types equal ignoring null can be more efficient add

[calcite] branch master updated (b973aa4 -> 2ddc836)

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from b973aa4 Update release instructions add 2ddc836 [CALCITE-4392] The operation of checking types equal

[GitHub] [calcite] xy2953396112 opened a new pull request #2270: [CALCITE-4407] Support unparse special syntax when operator is DELETE…

xy2953396112 opened a new pull request #2270: URL: https://github.com/apache/calcite/pull/2270 … (xzh) https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4407 This is an automated message from the Apache Git

[GitHub] [calcite] chunweilei merged pull request #2222: [CALCITE-4277] When rel has been removed from its subset, skip the origin rule match (Jiatao Tao)

chunweilei merged pull request #: URL: https://github.com/apache/calcite/pull/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei merged pull request #2256: [CALCITE-4392] The operation of checking types equal ignoring null can be more efficient

chunweilei merged pull request #2256: URL: https://github.com/apache/calcite/pull/2256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

chunweilei commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r525910610 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,40 @@ public RelOptPredicateList

[GitHub] [calcite] rubenada commented on a change in pull request #2266: [CALCITE-4402] SqlCall#equalsDeep does not take into account the function quantifier

rubenada commented on a change in pull request #2266: URL: https://github.com/apache/calcite/pull/2266#discussion_r525910302 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlEqualsDeepTest.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] rubenada commented on a change in pull request #2266: [CALCITE-4402] SqlCall#equalsDeep does not take into account the function quantifier

rubenada commented on a change in pull request #2266: URL: https://github.com/apache/calcite/pull/2266#discussion_r525907595 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCall.java ## @@ -146,6 +146,9 @@ public int operandCount() { return litmus.fail("{} !=

[calcite] branch master updated (3ccad7b -> b973aa4)

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 3ccad7b Following [CALCITE-4364], fix the plan diff of TpcdsTest add b973aa4 Update release instructions

[GitHub] [calcite] rubenada merged pull request #2229: Update release instructions

rubenada merged pull request #2229: URL: https://github.com/apache/calcite/pull/2229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] xy2953396112 commented on pull request #2269: [CALCITE-4406] SqlTableRef OPERATOR should create a SqlTableRef as th…

xy2953396112 commented on pull request #2269: URL: https://github.com/apache/calcite/pull/2269#issuecomment-729509064 comment in [JIRA](https://issues.apache.org/jira/browse/CALCITE-4406) This is an automated message from