[GitHub] [calcite] danny0405 commented on a change in pull request #2274: [CALCITE-4411] RelNode to SQL lost the distinct when doing window aggregation (Jiatao Tao)

danny0405 commented on a change in pull request #2274: URL: https://github.com/apache/calcite/pull/2274#discussion_r527468886 ## File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java ## @@ -3008,6 +3008,12 @@ private void checkLiteral2(String

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

xy2953396112 commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r527383309 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,39 @@ public RelOptPredicateList

[GitHub] [calcite] Aaaaaaron opened a new pull request #2274: [CALCITE-4411] RelNode to SQL lost the distinct when doing window aggregation (Jiatao Tao)

Aaron opened a new pull request #2274: URL: https://github.com/apache/calcite/pull/2274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

xy2953396112 commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r527361088 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,39 @@ public RelOptPredicateList

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

yanlin-Lynn commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r527346752 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,39 @@ public RelOptPredicateList

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1983: [CALCITE-4005] Support Calc and SetOp operator in RelMdAllPredicates

yanlin-Lynn commented on a change in pull request #1983: URL: https://github.com/apache/calcite/pull/1983#discussion_r527346612 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdAllPredicates.java ## @@ -113,19 +115,39 @@ public RelOptPredicateList

[GitHub] [calcite] a-rafay commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

a-rafay commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r527319515 ## File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java ## @@ -263,6 +263,9 @@ Tester withCatalogReaderFactory( /** Returns

[GitHub] [calcite] a-rafay commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

a-rafay commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r527314255 ## File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java ## @@ -263,6 +263,11 @@ Tester withCatalogReaderFactory( /**

[GitHub] [calcite] a-rafay commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

a-rafay commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r527310512 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] jamesstarr commented on pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

jamesstarr commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-730704266 @julianhyde, I renamed SqlLibraryOperators.SUBSTR to SqlLibraryOperators.ORACLE_SUBSTR and I have updated the comment. If I understand you other comments, you are

[GitHub] [calcite] julianhyde commented on pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

julianhyde commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-730682951 Also, correct the javadoc "It has similar semantics to standard SQL's {@link SqlStdOperatorTable#SUBSTRING} function but different syntax". That is a wrong assumption.

[GitHub] [calcite] julianhyde commented on pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

julianhyde commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-730682073 If Oracle's `SUBSTR` has very different semantics, treat it as a different function. Consider calling it `ORACLE_SUBSTR` or something so that no one gets confused. Adding a

[GitHub] [calcite] julianhyde commented on pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

julianhyde commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-730680731 Let's just suppose for a minute that Oracle's SUBSTR function had the same semantics as standard SUBSTRING, just different syntax. Then it is not a goal to keep it intact

[GitHub] [calcite] vlsi opened a new pull request #2273: [CALCITE-4199] review-only: nullability annotations

vlsi opened a new pull request #2273: URL: https://github.com/apache/calcite/pull/2273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] jamesstarr commented on pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

jamesstarr commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-730663893 From what I have read, oracles substr has a different behavior then the standard sql substr. Particularly, that is can return null if a 0 or a negative length is passed in,

[GitHub] [calcite] vlsi commented on pull request #2271: CALCITE-4408 Adding an operand type checker for the Oracle substring …

vlsi commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-730653973 > I.e. treat Oracle's function as syntactic sugar That would not work if downstream Oracle DB has a functional-based index with `SUBSTRING`. If Calcite transforms

[GitHub] [calcite] rubenada opened a new pull request #2272: [CALCITE-4409] Improve exception when RelBuilder tries to create a field on a non-struct expression

rubenada opened a new pull request #2272: URL: https://github.com/apache/calcite/pull/2272 Jira: [CALCITE-4409](https://issues.apache.org/jira/browse/CALCITE-4409) This is an automated message from the Apache Git Service. To

[GitHub] [calcite] zabetak closed pull request #2267: Following [CALCITE-4354], added 'calcite.experimental.allow.field.ind…

zabetak closed pull request #2267: URL: https://github.com/apache/calcite/pull/2267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: Following [CALCITE-4354], control field index access at runtime via feature flag (Alessandro Solimando)

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3f0353c Following [CALCITE-4354], control

[GitHub] [calcite] rubenada commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

rubenada commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r526691162 ## File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java ## @@ -263,6 +263,11 @@ Tester withCatalogReaderFactory( /**

[GitHub] [calcite] rubenada commented on a change in pull request #2211: [CALCITE-4317] RelFieldTrimmer after trimming all the fields in an ag…

rubenada commented on a change in pull request #2211: URL: https://github.com/apache/calcite/pull/2211#discussion_r526689986 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] rubenada commented on pull request #2255: [CALCITE-4393] ExceptionInInitializerError due to NPE in SqlCallBinding caused by circular dependency

rubenada commented on pull request #2255: URL: https://github.com/apache/calcite/pull/2255#issuecomment-730220423 Do we agree on the proposed solution? Can we move forward and merge the PR? This is an automated message from

[calcite] branch master updated (f3c173c -> 5a847ea)

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from f3c173c [CALCITE-4251] Get the origin column, even if it is derived (xzh) add 5a847ea [CALCITE-4402]

[GitHub] [calcite] rubenada merged pull request #2266: [CALCITE-4402] SqlCall#equalsDeep does not take into account the function quantifier

rubenada merged pull request #2266: URL: https://github.com/apache/calcite/pull/2266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go