[GitHub] [calcite] asfgit closed pull request #3199: [CALCITE-5698] EXTRACT from INTERVAL partially does not follow the SQL standard

2023-05-18 Thread via GitHub
asfgit closed pull request #3199: [CALCITE-5698] EXTRACT from INTERVAL partially does not follow the SQL standard URL: https://github.com/apache/calcite/pull/3199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[calcite] branch main updated: [CALCITE-5698] EXTRACT from INTERVAL should return negative numbers if interval is negative

2023-05-18 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new c56d556462 [CALCITE-5698] EXTRACT from INTERVAL

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3054: (do not check in)

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3054: URL: https://github.com/apache/calcite/pull/3054#issuecomment-1553987524 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3168: CALCITE-5662/ Allow CAST(BOOLEAN as INTEGER)

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3168: URL: https://github.com/apache/calcite/pull/3168#issuecomment-1553448559 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] julianhyde commented on a diff in pull request #3201: [CALCITE-5626] Sub-query with fully qualified table name throws table not found exception in validation phase

2023-05-18 Thread via GitHub
julianhyde commented on code in PR #3201: URL: https://github.com/apache/calcite/pull/3201#discussion_r1198065729 ## core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java: ## @@ -258,6 +258,9 @@ public SqlIdentifier getId() { } @Override public

[GitHub] [calcite] julianhyde commented on a diff in pull request #3201: [CALCITE-5626] Sub-query with fully qualified table name throws table not found exception in validation phase

2023-05-18 Thread via GitHub
julianhyde commented on code in PR #3201: URL: https://github.com/apache/calcite/pull/3201#discussion_r1198058420 ## core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java: ## @@ -258,6 +258,9 @@ public SqlIdentifier getId() { } @Override public

[GitHub] [calcite] julianhyde commented on a diff in pull request #3210: [CALCITE-5564] Add parsing and validation for PERCENTILE_CONT/PERCENTILE_DISC functions (enabled in BigQuery)

2023-05-18 Thread via GitHub
julianhyde commented on code in PR #3210: URL: https://github.com/apache/calcite/pull/3210#discussion_r1198012023 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -593,6 +593,48 @@ private boolean hasFractionalPart(BigDecimal bd) { } };

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3201: [CALCITE-5626] Sub-query with fully qualified table name throws table not found exception in validation phase

2023-05-18 Thread via GitHub
herunkang2018 commented on code in PR #3201: URL: https://github.com/apache/calcite/pull/3201#discussion_r1197919218 ## core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java: ## @@ -258,6 +258,9 @@ public SqlIdentifier getId() { } @Override public

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3201: [CALCITE-5626] Sub-query with fully qualified table name throws table not found exception in validation phase

2023-05-18 Thread via GitHub
herunkang2018 commented on code in PR #3201: URL: https://github.com/apache/calcite/pull/3201#discussion_r1197919218 ## core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java: ## @@ -258,6 +258,9 @@ public SqlIdentifier getId() { } @Override public

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3196: [CALCITE-5691] IN sub-query inside FILTER clause throws IndexOutOfBoundsException

2023-05-18 Thread via GitHub
herunkang2018 commented on code in PR #3196: URL: https://github.com/apache/calcite/pull/3196#discussion_r1197906538 ## core/src/main/java/org/apache/calcite/plan/RelOptPredicateList.java: ## @@ -233,7 +234,8 @@ public boolean isEffectivelyNotNull(RexNode e) { return

[GitHub] [calcite] rubenada commented on a diff in pull request #3196: [CALCITE-5691] IN sub-query inside FILTER clause throws IndexOutOfBoundsException

2023-05-18 Thread via GitHub
rubenada commented on code in PR #3196: URL: https://github.com/apache/calcite/pull/3196#discussion_r1197694506 ## core/src/main/java/org/apache/calcite/plan/RelOptPredicateList.java: ## @@ -233,7 +234,8 @@ public boolean isEffectivelyNotNull(RexNode e) { return true;

[GitHub] [calcite] rubenada commented on a diff in pull request #3196: [CALCITE-5691] IN sub-query inside FILTER clause throws IndexOutOfBoundsException

2023-05-18 Thread via GitHub
rubenada commented on code in PR #3196: URL: https://github.com/apache/calcite/pull/3196#discussion_r1197694506 ## core/src/main/java/org/apache/calcite/plan/RelOptPredicateList.java: ## @@ -233,7 +234,8 @@ public boolean isEffectivelyNotNull(RexNode e) { return true;

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3189: URL: https://github.com/apache/calcite/pull/3189#issuecomment-1552837488 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-18 Thread via GitHub
liuyongvs commented on code in PR #3189: URL: https://github.com/apache/calcite/pull/3189#discussion_r1197634750 ## core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java: ## @@ -122,8 +128,50 @@ static SqlReturnTypeInference returnTypeInference(boolean safe) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1552790785 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite] branch main updated: [CALCITE-5602] Implement CSC and SEC functions

2023-05-18 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new dbefd68825 [CALCITE-5602] Implement CSC and SEC

[GitHub] [calcite] rubenada merged pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-18 Thread via GitHub
rubenada merged PR #3192: URL: https://github.com/apache/calcite/pull/3192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] liuyongvs commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…

2023-05-18 Thread via GitHub
liuyongvs commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1552769423 hi @JiajunBernoulli will you also review it if you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3212: URL: https://github.com/apache/calcite/pull/3212#issuecomment-1552761279 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs opened a new pull request, #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…

2023-05-18 Thread via GitHub
liuyongvs opened a new pull request, #3212: URL: https://github.com/apache/calcite/pull/3212 ARRAY_MAX - Returns the maximum value in the array ARRAY_MIN - Returns the minmum value in the array For more details https://spark.apache.org/docs/latest/api/sql/index.html

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3192: URL: https://github.com/apache/calcite/pull/3192#issuecomment-1552732176 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-18 Thread via GitHub
rubenada commented on PR #3192: URL: https://github.com/apache/calcite/pull/3192#issuecomment-1552713877 Thanks @zoudan , LGTM. Could you please squash commits into a single one? Also may I ask you a minor correction on the final commit message: `[CALCITE-5602] Implement CSC and SEC

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3211: [CALCITE-5708] Change SUBSTRING result if either of parameters is NULL

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3211: URL: https://github.com/apache/calcite/pull/3211#issuecomment-1552701258 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #3192: URL: https://github.com/apache/calcite/pull/3192#issuecomment-1552689072 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zstan opened a new pull request, #3211: [CALCITE-5708] Change SUBSTRING result if either of parameters is NULL

2023-05-18 Thread via GitHub
zstan opened a new pull request, #3211: URL: https://github.com/apache/calcite/pull/3211 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] zoudan commented on a diff in pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-18 Thread via GitHub
zoudan commented on code in PR #3192: URL: https://github.com/apache/calcite/pull/3192#discussion_r1197513085 ## core/src/main/java/org/apache/calcite/util/BuiltInMethod.java: ## @@ -440,6 +440,8 @@ public enum BuiltInMethod { LOG(SqlFunctions.class, "log", long.class,

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-18 Thread via GitHub
liuyongvs commented on code in PR #3189: URL: https://github.com/apache/calcite/pull/3189#discussion_r1197508002 ## core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java: ## @@ -122,8 +128,50 @@ static SqlReturnTypeInference returnTypeInference(boolean safe) {

[GitHub] [calcite] rubenada commented on a diff in pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-18 Thread via GitHub
rubenada commented on code in PR #3192: URL: https://github.com/apache/calcite/pull/3192#discussion_r1197490985 ## core/src/main/java/org/apache/calcite/util/BuiltInMethod.java: ## @@ -440,6 +440,8 @@ public enum BuiltInMethod { LOG(SqlFunctions.class, "log", long.class,

[GitHub] [calcite] libenchao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-18 Thread via GitHub
libenchao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1197490314 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {