julianhyde commented on code in PR #3201:
URL: https://github.com/apache/calcite/pull/3201#discussion_r1198065729
##########
core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java:
##########
@@ -258,6 +258,9 @@ public SqlIdentifier getId() {
}
@Override public @Nullable SqlValidatorTable getTable() {
+ if (resolvedNamespace == null) {
+ validator.validateNamespace(this, validator.unknownType);
+ }
return resolvedNamespace == null ? null : resolve().getTable();
Review Comment:
I acknowledge the problems with `SqlAdvisorValidator`.
However.
The logic in your current fix is so subtle that a future maintainer will not
understand it.
You need to find a way to make the logic self-evidently correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
