julianhyde commented on code in PR #3201:
URL: https://github.com/apache/calcite/pull/3201#discussion_r1198058420
##########
core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java:
##########
@@ -258,6 +258,9 @@ public SqlIdentifier getId() {
}
@Override public @Nullable SqlValidatorTable getTable() {
+ if (resolvedNamespace == null) {
+ validator.validateNamespace(this, validator.unknownType);
+ }
return resolvedNamespace == null ? null : resolve().getTable();
Review Comment:
There are 3 states to validation - not validated, under validation, and
validated. `AbstractNamespace.validate` and `SqlNamespace.validateImpl` work in
a rather subtle way. Your change has broken that, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
