herunkang2018 commented on code in PR #3201:
URL: https://github.com/apache/calcite/pull/3201#discussion_r1197919218
##########
core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java:
##########
@@ -258,6 +258,9 @@ public SqlIdentifier getId() {
}
@Override public @Nullable SqlValidatorTable getTable() {
+ if (resolvedNamespace == null) {
+ validator.validateNamespace(this, validator.unknownType);
+ }
return resolvedNamespace == null ? null : resolve().getTable();
Review Comment:
Due to SqlAdvisorValidator's special logic with table not found, I think
keep the current PR's logic is also reasonable. @julianhyde @JiajunBernoulli
looking forward to hearing your opinions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
