kramerul commented on PR #3692:
URL: https://github.com/apache/calcite/pull/3692#issuecomment-1953649441
> BTW: until the reviews are completed, it is recommended to just add new
commits, so reviewers can easily see the new changes. Then you can squash the
commits into a single one.
sonarcloud[bot] commented on PR #3689:
URL: https://github.com/apache/calcite/pull/3689#issuecomment-1953439302
## [ {
return
mihaibudiu commented on code in PR #3640:
URL: https://github.com/apache/calcite/pull/3640#discussion_r1495188308
##
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCorrelateTest.java:
##
@@ -142,10 +142,10 @@ class EnumerableCorrelateTest {
tester(false,
HanumathRao commented on code in PR #3640:
URL: https://github.com/apache/calcite/pull/3640#discussion_r1495187202
##
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCorrelateTest.java:
##
@@ -142,10 +142,10 @@ class EnumerableCorrelateTest {
tester(false,
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495186737
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6222,6 +6222,49 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495183607
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
mihaibudiu commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495182033
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495180029
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
sonarcloud[bot] commented on PR #3640:
URL: https://github.com/apache/calcite/pull/3640#issuecomment-1953398744
## [ {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495170001
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495170001
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
mihaibudiu commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495168265
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495167517
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495167517
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495165517
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
mihaibudiu commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495165126
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495164374
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495163992
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
mihaibudiu commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495160602
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
mihaibudiu commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495160430
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495159761
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2788,6 +2788,18 @@ public static double log(BigDecimal d0, BigDecimal d1) {
return
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495159761
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2788,6 +2788,18 @@ public static double log(BigDecimal d0, BigDecimal d1) {
return
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495158019
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6222,6 +6222,41 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495158019
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6222,6 +6222,41 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
mihaibudiu commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495157340
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6222,6 +6222,41 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495156852
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6222,6 +6222,41 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
mihaibudiu commented on code in PR #3640:
URL: https://github.com/apache/calcite/pull/3640#discussion_r1495155596
##
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCorrelateTest.java:
##
@@ -142,10 +142,10 @@ class EnumerableCorrelateTest {
tester(false,
JiajunBernoulli merged PR #3695:
URL: https://github.com/apache/calcite/pull/3695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
jiajunxie pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 31d66e797d [CALCITE-6273] Add sqrt negative
caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495152436
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2788,6 +2788,18 @@ public static double log(BigDecimal d0, BigDecimal d1) {
return
mihaibudiu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1495018416
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -2259,6 +2272,27 @@ private static void
mihaibudiu commented on PR #3692:
URL: https://github.com/apache/calcite/pull/3692#issuecomment-1953163472
BTW: until the reviews are completed, it is recommended to just add new
commits, so reviewers can easily see the new changes. Then you can squash the
commits into a single one.
--
mihaibudiu commented on code in PR #3692:
URL: https://github.com/apache/calcite/pull/3692#discussion_r1494969469
##
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##
@@ -241,6 +245,55 @@ public class JdbcTest {
+ "(8,1,4))\n"
+ " as
mihaibudiu commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1494967077
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2788,6 +2788,18 @@ public static double log(BigDecimal d0, BigDecimal d1) {
return
caicancai commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1494627130
##
site/_docs/reference.md:
##
@@ -2700,12 +2700,14 @@ In the following:
| s | BIT_GET(value, position) | Returns the bit (0 or
1) value at
rubenada commented on PR #3674:
URL: https://github.com/apache/calcite/pull/3674#issuecomment-1952221395
That would be great @caicancai .
Apart from this PR, you can also take a look at
https://github.com/apache/calcite/commit/f7069cc5245c22f816c565669f52b4f30b046f4d
, which was a
caicancai commented on PR #3674:
URL: https://github.com/apache/calcite/pull/3674#issuecomment-1952211163
@rubenada @tanclary Maybe I can try reading this pr change to see if there
are any tests that need to be added, I agree with clary to some extent
--
This is an automated message from
sonarcloud[bot] commented on PR #3689:
URL: https://github.com/apache/calcite/pull/3689#issuecomment-1952089788
## [ were added to refs/heads/main by this push:
new a19a954738 [CALCITE-6249]
rubenada merged PR #3674:
URL: https://github.com/apache/calcite/pull/3674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3692:
URL: https://github.com/apache/calcite/pull/3692#issuecomment-1951929853
## [