[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497813#comment-17497813
]
Ekaterina Dimitrova commented on CASSANDRA-16956:
-
After all latest discussions and
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486828#comment-17486828
]
Berenguer Blasi commented on CASSANDRA-16956:
-
Hi Stefan,
if you {{grep -ri windows}}
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486600#comment-17486600
]
Josh McKenzie commented on CASSANDRA-16956:
---
Left some comments on the PR and a few
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486490#comment-17486490
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
The build I got:
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486368#comment-17486368
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
* yeah I ll do that
* it is already
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486329#comment-17486329
]
Michael Semb Wever commented on CASSANDRA-16956:
bq. Docs refactoring has finished
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486262#comment-17486262
]
Berenguer Blasi commented on CASSANDRA-16956:
-
Hi Stefan:
- Looks like CI for j11 is
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486137#comment-17486137
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Based on the discussions held here as
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479620#comment-17479620
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Aha, this is interesting, I forgot
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479614#comment-17479614
]
Brandon Williams commented on CASSANDRA-16956:
--
Are you talking about reverting
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479609#comment-17479609
]
Josh McKenzie commented on CASSANDRA-16956:
---
{quote}once we say we do not support Windows
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479504#comment-17479504
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Fair enough. I still consider it to
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479387#comment-17479387
]
Josh McKenzie commented on CASSANDRA-16956:
---
{quote}I find the argument for not
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475786#comment-17475786
]
Josh McKenzie commented on CASSANDRA-16956:
---
Oh! Leaving "It", as in the code, not the
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475771#comment-17475771
]
Brandon Williams commented on CASSANDRA-16956:
--
bq. I am fine with leaving it in 4.0.
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475764#comment-17475764
]
Josh McKenzie commented on CASSANDRA-16956:
---
bq. I wish this had been brought up in
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475436#comment-17475436
]
Brandon Williams commented on CASSANDRA-16956:
--
{quote}The two committers reviewing
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475420#comment-17475420
]
Josh McKenzie commented on CASSANDRA-16956:
---
bq. I would also prefer not to touch 4.0
The
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474258#comment-17474258
]
Berenguer Blasi commented on CASSANDRA-16956:
-
Thanks for looking into it [~mck]!
>
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17473175#comment-17473175
]
Michael Semb Wever commented on CASSANDRA-16956:
The
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472548#comment-17472548
]
Berenguer Blasi commented on CASSANDRA-16956:
-
Thx [~brandon.williams]!
Just for the
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472201#comment-17472201
]
Brandon Williams commented on CASSANDRA-16956:
--
bq. Removal of code is not zero-risk,
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472185#comment-17472185
]
Josh McKenzie commented on CASSANDRA-16956:
---
{quote}bq. why keep cruft around?
{quote}
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472102#comment-17472102
]
Brandon Williams commented on CASSANDRA-16956:
--
If 4.0 doesn't support windows (and it
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472101#comment-17472101
]
Josh McKenzie commented on CASSANDRA-16956:
---
I don't think we should go in removing
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471776#comment-17471776
]
Berenguer Blasi commented on CASSANDRA-16956:
-
Hi [~stefan.miklosovic],
I see you
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466454#comment-17466454
]
Josh McKenzie commented on CASSANDRA-16956:
---
OOO right now; will take a look hopefully
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461879#comment-17461879
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
ok let's wait! :) I just dont like
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461876#comment-17461876
]
Brandon Williams commented on CASSANDRA-16956:
--
Per policy, my +1 is always explicit. I
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461873#comment-17461873
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
I ll merge this on base on Brandon's
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461515#comment-17461515
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
4.0
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460676#comment-17460676
]
Benjamin Lerer commented on CASSANDRA-16956:
Sorry, for not having the time to look into
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460673#comment-17460673
]
Brandon Williams commented on CASSANDRA-16956:
--
bq. There does not seem to be any
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460617#comment-17460617
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Based on this comment (1), Linux is
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432403#comment-17432403
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Thanks [~Bowen Song], I am parking
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430738#comment-17430738
]
Bowen Song commented on CASSANDRA-16956:
It seems like the command received from stdin is
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430440#comment-17430440
]
Bowen Song commented on CASSANDRA-16956:
[~stefan.miklosovic] Sure, I'll have a look at it.
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430404#comment-17430404
]
Berenguer Blasi commented on CASSANDRA-16956:
-
If sbdy tries WSL CASSANDRA-15887 seems
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430129#comment-17430129
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
hi [~Bowen Song],
would you mind to
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429871#comment-17429871
]
Berenguer Blasi commented on CASSANDRA-16956:
-
Given the big PR it would be nice to have
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429538#comment-17429538
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Hi [~blerer], could you please try my
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429386#comment-17429386
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428977#comment-17428977
]
Brandon Williams commented on CASSANDRA-16956:
--
Windows support was officially removed
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428970#comment-17428970
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Thanks [~Bowen Song] I pulled, thanks
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428306#comment-17428306
]
Bowen Song commented on CASSANDRA-16956:
[~stefan.miklosovic] Please see PR
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428304#comment-17428304
]
Josh McKenzie commented on CASSANDRA-16956:
---
{quote}all the comments which are also
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428298#comment-17428298
]
Bowen Song commented on CASSANDRA-16956:
That's okay. I will do that.
> Remove
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428296#comment-17428296
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
[~Bowen Song] I saw your comments. I
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428257#comment-17428257
]
Bowen Song commented on CASSANDRA-16956:
[~stefan.miklosovic] I'm happy to do that.
>
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428234#comment-17428234
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
hi [~Bowen Song], could you please go
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425480#comment-17425480
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
Wow this is super tedious to go
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425456#comment-17425456
]
Berenguer Blasi commented on CASSANDRA-16956:
-
On second thoughts, maybe you want to do
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425449#comment-17425449
]
Stefan Miklosovic commented on CASSANDRA-16956:
---
1) yes
2) yes
3) I ll look, thanks,
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425432#comment-17425432
]
Berenguer Blasi commented on CASSANDRA-16956:
-
On a first cursory pass I have these q I
[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422172#comment-17422172
]
Brandon Williams commented on CASSANDRA-16956:
--
We are also still pulling in the [sigar
55 matches
Mail list logo
