test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
nabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log
| test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
an enhancement ticket and
reference it here, @syed - thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
t vlans2 = expandVlanUri(vlanRange2);
+if (vlans1 == null || vlans2 == null) {
Review comment:
You could also use !Collections.disjoint(vlans1, vlans2)
----
This is an automated message from the Apache Git Service.
To res
Java 8
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
tests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
true: then CloudStack will fail to deploy
the system VM when the pool
of reserved IPs has been exhausted, citing the lack of available IPs.
This is an automated message from the Apache Git Service.
To respond to the message, please
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
syed commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-33613
@rhtyd Done!
This is an automated message from the Apache Git Service
t in a sec
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
he commits.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Wi
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache
. JID-1157
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
e progress.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastruct
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
an package
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
progress.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
to the Trillian Tests, I have not squashed yet. I will
squash once we have approval.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
s great a review process to get another set of eyes to look at the
problem and the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
t;12"));
+Assert.assertFalse(UriUtils.checkVlanUriOverlap("100-200",
"30-40,50,201-250"));
Review comment:
Sure, sometimes we do want to over-engineer? :)
This is an automated message from the A
my option it is already covered, if for some
reason someone alters the method to return null, your test cases will catch it
(this is great!). That is why I was saying you do not need those null checks.
This is an automa
1);
+final List vlans2 = expandVlanUri(vlanRange2);
+if (vlans1 == null || vlans2 == null) {
Review comment:
Ah that as well ;)
I am sorry to bother, but if I do not understand something I keep asking
until I can move along.
----
t vlans2 = expandVlanUri(vlanRange2);
+if (vlans1 == null || vlans2 == null) {
Review comment:
I think we're over-discussing, not over-engineering :) I'll ping you on
respective unit tests.
----
This is an automated messa
;12"));
+Assert.assertFalse(UriUtils.checkVlanUriOverlap("100-200",
"30-40,50,201-250"));
Review comment:
@rafaelweingartner unit tests for respective methods in questions are in
this file, please see all the above lines.
e
future (for that it is better to write unit test cases).
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-integers or negative values, then you'll
get empty list. Again, this was defensive programming.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
doing this without needing to deeply inspect the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
1);
+final List vlans2 = expandVlanUri(vlanRange2);
+if (vlans1 == null || vlans2 == null) {
Review comment:
Do you mind explaining why if the method `expandVlanUri` returns an empty
list in the worst case?
----
This is an
ttings.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With r
orings if I get time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
t vlans2 = expandVlanUri(vlanRange2);
+if (vlans1 == null || vlans2 == null) {
Review comment:
Yes, we need this check.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on G
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ccessful, but we do not know what (group already there, some
other exception, and so on).
As I said, I am not against it. I understand that these are personal ways
someone designs a solution, and that is fair. I only wanted to show these
points and try to understand why we are going towards
15 11
26](https://user-images.githubusercontent.com/16554581/31491975-cc4c516e-af66-11e7-9a0d-36cda520bfa6.png)
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and u
y",
+"The shared single sign-on key as configured in Cloudian CMC.",
true);
+
+/**
+ * Returns the base Cloudian Management Console URL
+ * @return returns the url string
+ */
+String getCmcUrl();
+
+/**
+ * Checks if the Cloudian Connector is
scenario it returns an empty list. Do we need this
check?
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service,
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
bility of the code and enable unit tests and Java docs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
f ($(this).val() ==
"Isolated") {
Review comment:
Can both the cases for L2 and Isolated be collapsed, as both are using same
code?
This is an automated message from the Apache Git Service.
To respond to the messa
item[rel=isPersistent]').find('input[type=checkbox]').removeAttr("disabled");
Review comment:
Remove extra new line
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log o
twork.getGuestType().equals(Network.GuestType.L2)) {
Review comment:
Space after `!` may be removed
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to
releasePodIp(Long id) throws
CloudRuntimeException {
}
}
+
Review comment:
Remove extra newline?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
:
Put `} else if ...` on same line as line 2413.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infras
)
}
}
Review comment:
Put `} else if..` on same line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
vlanUse != VlanType.DirectAttached) {
Review comment:
Could this cause a backward compatibility issue?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL abo
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache
DaanHoogland commented on issue #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#issuecomment-336070998
@blueorangutan test
This is an automated message from the Apache Git Service
to the code but don't dare to merge. I will rebase
and go from there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
of print
* be able to write a file instead of stdout
Did I miss s.th.?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
rhtyd commented on issue #2289: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2289#issuecomment-336031031
@blueorangutan package
This is an automated message from the Apache Git Service
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache
nitin-maharana commented on issue #2294: Adding allocated IOPS to storage pool
response
URL: https://github.com/apache/cloudstack/pull/2294#issuecomment-336030471
Code LGTM.
This is an automated message from the Apache Git
"The shared single sign-on key as configured in Cloudian CMC.",
true);
+
+/**
+ * Returns the base Cloudian Management Console URL
+ * @return returns the url string
+ */
+String getCmcUrl();
+
+/**
+ * Checks if the Cloudian Connector is enabled
+ * @r
currently, we only need to know whether a user/group
is not synced and should be added.
The client implementation is not for public consumption as a client/library
but restricted to the plugin to limit its scope, pragmatic implementation, and
use. For general use, there exists Cloud
();
+if (searchVnets != null && searchVnets.size() > 0) {
Review comment:
Fixed, thanks.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
3`
expands to `1,2,3`) is null, i.e. there is no overlap.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
} else {
+final Integer value = NumbersUtil.parseInt(range[0], -1);
+if (value > -1) {
Review comment:
This is used for vlan range checks etc, vlans are always > -1.
--------
This is
.split(",")) {
+if (vlanPart == null || vlanPart.isEmpty()) {
Review comment:
Fixed with `Strings.isNullOrEmpty`, thanks
This is an automated message from the Apache Git Service.
To respond to the mes
thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With r
1, 163.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
simulator.py
test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the mes
101 - 200 of 5898 matches
Mail list logo
