[GitHub] blueorangutan commented on issue #2067: CLOUDSTACK-9852: This patch implements the storage lb feature

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2067: CLOUDSTACK-9852: This patch implements 
the storage lb feature
URL: https://github.com/apache/cloudstack/pull/2067#issuecomment-353932586
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2067: CLOUDSTACK-9852: This patch implements the storage lb feature

2017-12-25 Thread GitBox 
rhtyd commented on issue #2067: CLOUDSTACK-9852: This patch implements the 
storage lb feature
URL: https://github.com/apache/cloudstack/pull/2067#issuecomment-353932553
 
 
   I've fixed the conflicts @anshul-gangwar but your engagement is requested 
for getting the PR accepted.
   Additional review requested - @nvazquez @borisstoyanov @DaanHoogland @wido 
@rafaelweingartner @marcaurele and others
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage 
Usage for uploadedVolume is not collected
URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-353931496
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353931499
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-12-25 Thread GitBox 
rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for 
uploadedVolume is not collected
URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-353931480
 
 
   @blueorangutan test centos7 kvm-centos7 component/test_ss_volume_usage.py


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
rhtyd commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353931415
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on a change in pull request #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

2017-12-25 Thread GitBox 
marcaurele commented on a change in pull request #2373: 
CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for 
same volume.
URL: https://github.com/apache/cloudstack/pull/2373#discussion_r158675822
 
 

 ##
 File path: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
 ##
 @@ -854,15 +855,17 @@ public SnapshotPolicyVO 
createPolicy(CreateSnapshotPolicyCmd cmd, Account policy
 throw new InvalidParameterValueException("Max number of 
snapshots shouldn't exceed the " + message + " level snapshot limit");
 }
 }
-SnapshotPolicyVO policy = 
_snapshotPolicyDao.findOneByVolumeInterval(volumeId, intvType);
-if (policy == null) {
-policy = new SnapshotPolicyVO(volumeId, cmd.getSchedule(), 
timezoneId, intvType, cmd.getMaxSnaps(), display);
-policy = _snapshotPolicyDao.persist(policy);
-_snapSchedMgr.scheduleNextSnapshotJob(policy);
-} else {
-try {
+
+policy = _snapshotPolicyDao.acquireInLockTable(volumeId);
 
 Review comment:
   You can request a lock for the snapshot policy table for existing entries 
and by giving a snapshot policy ID only, not the ID of a volume: `policy = 
_snapshotPolicyDao.acquireInLockTable(policyId);`
   In your case you don't have a policy id yet when creating a new one. You'll 
have to use the global lock.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy 
API create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-353931193
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

2017-12-25 Thread GitBox 
rhtyd commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API 
create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-353931174
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for 
SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-353931096
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary 
storage usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-353931094
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

2017-12-25 Thread GitBox 
rhtyd commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and 
CPVM
URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-353931041
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-12-25 Thread GitBox 
rhtyd commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage 
usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-353931059
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for 
limit to CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-353930988
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2017-12-25 Thread GitBox 
rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to 
CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-353930933
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2045: Fix snmptrap alert bug

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2045: Fix snmptrap alert bug
URL: https://github.com/apache/cloudstack/pull/2045#issuecomment-353930772
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2045: Fix snmptrap alert bug

2017-12-25 Thread GitBox 
rhtyd commented on issue #2045: Fix snmptrap alert bug
URL: https://github.com/apache/cloudstack/pull/2045#issuecomment-353930662
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2362: CLOUDSTACK-10188 - Resource Accounting for primary storage is Broken when Domains are in use

2017-12-25 Thread GitBox 
rhtyd commented on issue #2362: CLOUDSTACK-10188 - Resource Accounting for 
primary storage is Broken when Domains are in use
URL: https://github.com/apache/cloudstack/pull/2362#issuecomment-353930633
 
 
   @bwsw can you fix the conflicts, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template 
deletion when template is in use.
URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-353930668
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

2017-12-25 Thread GitBox 
rhtyd commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion 
when template is in use.
URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-353930588
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting 
deleted while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-353930477
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2017-12-25 Thread GitBox 
rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted 
while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-353930378
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2352: CLOUDSTACK-10175: prevent VPC list leakage

2017-12-25 Thread GitBox 
rhtyd commented on issue #2352: CLOUDSTACK-10175: prevent VPC list leakage
URL: https://github.com/apache/cloudstack/pull/2352#issuecomment-353930350
 
 
   @khos2ow any update?
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

2017-12-25 Thread GitBox 
rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware
URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-353930286
 
 
   @nitin-maharana I've left some remarks and I feel the code may be further 
refactored, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2352: CLOUDSTACK-10175: prevent VPC list leakage

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2352: CLOUDSTACK-10175: prevent VPC list 
leakage
URL: https://github.com/apache/cloudstack/pull/2352#issuecomment-353930373
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage 
Usage for uploadedVolume is not collected
URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-353930213
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1489


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353930212
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1490


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU 
Support on VMware
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r158675087
 
 

 ##
 File path: vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java
 ##
 @@ -1184,4 +1206,261 @@ public ManagedObjectReference waitForPortGroup(String 
networkName, long timeOutM
 }
 return morNetwork;
 }
+
+public ManagedObjectReference getComputeResourceEnvironmentBrowser() 
throws Exception {
+ManagedObjectReference morParent = getParentMor();
+ClusterMO clusterMo = new ClusterMO(_context, morParent);
+return clusterMo.getComputeResourceEnvironmentBrowser();
+}
+
+public VirtualMachinePciPassthroughInfo getHostPciDeviceInfo(final String 
pciDeviceId) throws Exception {
+VirtualMachinePciPassthroughInfo matchingPciPassthroughDevice = null;
+ConfigTarget configTarget = 
_context.getService().queryConfigTarget(getComputeResourceEnvironmentBrowser(), 
_mor);
+List pciPassthroughDevices = 
configTarget.getPciPassthrough();
+for (VirtualMachinePciPassthroughInfo pciPassthroughDevice : 
pciPassthroughDevices) {
+HostPciDevice hostPciDevice = pciPassthroughDevice.getPciDevice();
+if (pciDeviceId.equals(hostPciDevice.getId())) {
+matchingPciPassthroughDevice = pciPassthroughDevice;
+break;
+}
+}
+return matchingPciPassthroughDevice;
+}
+
+public VirtualDevice prepareSharedPciPassthroughDevice(final String 
vGpuProfile) {
+s_logger.debug("Preparing shared PCI device");
+VirtualPCIPassthrough virtualPciPassthrough = new 
VirtualPCIPassthrough();
+VirtualPCIPassthroughVmiopBackingInfo 
virtualPCIPassthroughVmiopBackingInfo = new 
VirtualPCIPassthroughVmiopBackingInfo();
+virtualPCIPassthroughVmiopBackingInfo.setVgpu(vGpuProfile);
+
virtualPciPassthrough.setBacking(virtualPCIPassthroughVmiopBackingInfo);
+Description description = new Description();
+description.setLabel("vGPU device");
+description.setSummary("vGPU type: " + vGpuProfile);
+virtualPciPassthrough.setDeviceInfo(description);
+return virtualPciPassthrough;
+}
+
+public VirtualDevice prepareDirectPciPassthroughDevice(final 
VirtualMachinePciPassthroughInfo hostPciDeviceInfo) {
+// Ex: pciDeviceId is like ":08:00.0" composed of bus,slot,function
+s_logger.debug("Preparing direct PCI device");
+
+VirtualPCIPassthrough pciDevice = new VirtualPCIPassthrough();
+VirtualPCIPassthroughDeviceBackingInfo pciBacking = new 
VirtualPCIPassthroughDeviceBackingInfo();
+pciBacking.setId(hostPciDeviceInfo.getPciDevice().getId());
+
pciBacking.setDeviceId(Integer.toHexString(hostPciDeviceInfo.getPciDevice().getDeviceId()));
+
pciBacking.setDeviceName(hostPciDeviceInfo.getPciDevice().getDeviceName());
+pciBacking.setVendorId(hostPciDeviceInfo.getPciDevice().getVendorId());
+pciBacking.setSystemId(hostPciDeviceInfo.getSystemId());
+pciDevice.setBacking(pciBacking);
+return pciDevice;
+}
+
+public String getPciIdForAvailableDirectPciPassthroughDevice() throws 
Exception {
+String pciId = "";
+List hostGraphicsInfos = getHostGraphicsInfo();
+for (HostGraphicsInfo hostGraphicsInfo : hostGraphicsInfos) {
+if 
(GPU.GPUType.direct.toString().equalsIgnoreCase(hostGraphicsInfo.getGraphicsType()))
 {
+List vms = hostGraphicsInfo.getVm();
+if (CollectionUtils.isEmpty(vms)) {
+pciId = hostGraphicsInfo.getPciId();
+break;
+}
+}
+}
+return pciId;
+}
+
+/**
+ * It updates the info of each vGPU type in the NVidia GRID K1/K2 Card.
+ * @param gpuCapacity (The output is stored in this)
+ * @param groupName - (NVIDIAGRID K1 or NVIDIAGRID K2)
+ * @param countGridKSharedGPUs (Number of Enabled shared GPUs)
+ * @param graphicsInfo (Info regarding the card)
+ * @param sharedPassthruGpuTypes (All the enabled vGPU types)
+ * @param gridKGPUMemory (Video RAM of each GPU in the card)
+ * @throws Exception
+ */
+private void updateGpuCapacities(final HashMap 
gpuCapacity, final String groupName, final long countGridKSharedGPUs, final 
List graphicsInfo, final List sharedPassthruGpuTypes, 
final long gridKGPUMemory) throws Exception {
+/*
+ * 0 - grid_k100 or grid_k200
+ * 1 - grid_k120q or grid_k220q
+ * 2 - grid_k140q or grid_k240q
+ * 3 - grid_k160q or grid_k260q
+ * 4 - grid_k180q or grid_k280q
+ */
+final long remainingCapacities[] = new long[5];
+
+remainingCapacities[0] = 8l * countGridKSharedGPUs;
+remainingCapacities[1] = 8l *

[GitHub] rhtyd commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU 
Support on VMware
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r158675008
 
 

 ##
 File path: vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java
 ##
 @@ -1184,4 +1206,261 @@ public ManagedObjectReference waitForPortGroup(String 
networkName, long timeOutM
 }
 return morNetwork;
 }
+
+public ManagedObjectReference getComputeResourceEnvironmentBrowser() 
throws Exception {
+ManagedObjectReference morParent = getParentMor();
+ClusterMO clusterMo = new ClusterMO(_context, morParent);
+return clusterMo.getComputeResourceEnvironmentBrowser();
+}
+
+public VirtualMachinePciPassthroughInfo getHostPciDeviceInfo(final String 
pciDeviceId) throws Exception {
+VirtualMachinePciPassthroughInfo matchingPciPassthroughDevice = null;
+ConfigTarget configTarget = 
_context.getService().queryConfigTarget(getComputeResourceEnvironmentBrowser(), 
_mor);
+List pciPassthroughDevices = 
configTarget.getPciPassthrough();
+for (VirtualMachinePciPassthroughInfo pciPassthroughDevice : 
pciPassthroughDevices) {
+HostPciDevice hostPciDevice = pciPassthroughDevice.getPciDevice();
+if (pciDeviceId.equals(hostPciDevice.getId())) {
+matchingPciPassthroughDevice = pciPassthroughDevice;
+break;
+}
+}
+return matchingPciPassthroughDevice;
+}
+
+public VirtualDevice prepareSharedPciPassthroughDevice(final String 
vGpuProfile) {
+s_logger.debug("Preparing shared PCI device");
+VirtualPCIPassthrough virtualPciPassthrough = new 
VirtualPCIPassthrough();
+VirtualPCIPassthroughVmiopBackingInfo 
virtualPCIPassthroughVmiopBackingInfo = new 
VirtualPCIPassthroughVmiopBackingInfo();
+virtualPCIPassthroughVmiopBackingInfo.setVgpu(vGpuProfile);
+
virtualPciPassthrough.setBacking(virtualPCIPassthroughVmiopBackingInfo);
+Description description = new Description();
+description.setLabel("vGPU device");
+description.setSummary("vGPU type: " + vGpuProfile);
+virtualPciPassthrough.setDeviceInfo(description);
+return virtualPciPassthrough;
+}
+
+public VirtualDevice prepareDirectPciPassthroughDevice(final 
VirtualMachinePciPassthroughInfo hostPciDeviceInfo) {
+// Ex: pciDeviceId is like ":08:00.0" composed of bus,slot,function
+s_logger.debug("Preparing direct PCI device");
+
+VirtualPCIPassthrough pciDevice = new VirtualPCIPassthrough();
+VirtualPCIPassthroughDeviceBackingInfo pciBacking = new 
VirtualPCIPassthroughDeviceBackingInfo();
+pciBacking.setId(hostPciDeviceInfo.getPciDevice().getId());
+
pciBacking.setDeviceId(Integer.toHexString(hostPciDeviceInfo.getPciDevice().getDeviceId()));
+
pciBacking.setDeviceName(hostPciDeviceInfo.getPciDevice().getDeviceName());
+pciBacking.setVendorId(hostPciDeviceInfo.getPciDevice().getVendorId());
+pciBacking.setSystemId(hostPciDeviceInfo.getSystemId());
+pciDevice.setBacking(pciBacking);
+return pciDevice;
+}
+
+public String getPciIdForAvailableDirectPciPassthroughDevice() throws 
Exception {
+String pciId = "";
+List hostGraphicsInfos = getHostGraphicsInfo();
+for (HostGraphicsInfo hostGraphicsInfo : hostGraphicsInfos) {
+if 
(GPU.GPUType.direct.toString().equalsIgnoreCase(hostGraphicsInfo.getGraphicsType()))
 {
+List vms = hostGraphicsInfo.getVm();
+if (CollectionUtils.isEmpty(vms)) {
+pciId = hostGraphicsInfo.getPciId();
+break;
+}
+}
+}
+return pciId;
+}
+
+/**
+ * It updates the info of each vGPU type in the NVidia GRID K1/K2 Card.
+ * @param gpuCapacity (The output is stored in this)
+ * @param groupName - (NVIDIAGRID K1 or NVIDIAGRID K2)
+ * @param countGridKSharedGPUs (Number of Enabled shared GPUs)
+ * @param graphicsInfo (Info regarding the card)
+ * @param sharedPassthruGpuTypes (All the enabled vGPU types)
+ * @param gridKGPUMemory (Video RAM of each GPU in the card)
+ * @throws Exception
+ */
+private void updateGpuCapacities(final HashMap 
gpuCapacity, final String groupName, final long countGridKSharedGPUs, final 
List graphicsInfo, final List sharedPassthruGpuTypes, 
final long gridKGPUMemory) throws Exception {
+/*
+ * 0 - grid_k100 or grid_k200
+ * 1 - grid_k120q or grid_k220q
+ * 2 - grid_k140q or grid_k240q
+ * 3 - grid_k160q or grid_k260q
+ * 4 - grid_k180q or grid_k280q
+ */
+final long remainingCapacities[] = new long[5];
+
+remainingCapacities[0] = 8l * countGridKSharedGPUs;
+remainingCapacities[1] = 8l *

[GitHub] rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume 
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r158674795
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##
 @@ -98,28 +98,31 @@
 @Override
 public boolean execute(VmwareHostService hostService, 
CreateEntityDownloadURLCommand cmd) {
 DataTO data = cmd.getData();
+int timeout = 
NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()),
 VmwareManagerImpl.DEFAULT_VM_OVA_PACKAGE_TIMEOUT);
 
 Review comment:
   @mrunalinikankariya you can get a `default()` from a ConfigKey, just like 
you did with the `key()`. This won't read the value from the db.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?

2017-12-25 Thread GitBox 
rhtyd commented on issue #2203: [CLOUDSTACK-10029] All private, public, and 
guest interfaceses are marked as untagged ca?
URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-353929855
 
 
   @konstantintrushin can you check if this is necessary given #2304 got merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume 
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r158674795
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##
 @@ -98,28 +98,31 @@
 @Override
 public boolean execute(VmwareHostService hostService, 
CreateEntityDownloadURLCommand cmd) {
 DataTO data = cmd.getData();
+int timeout = 
NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()),
 VmwareManagerImpl.DEFAULT_VM_OVA_PACKAGE_TIMEOUT);
 
 Review comment:
   @mrunalinikankariya you can get a `default()` from a ConfigKey. This won't 
read the value from the db.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume 
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r158674726
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java
 ##
 @@ -42,6 +44,9 @@
 static final ConfigKey s_vmwareSearchExcludeFolder = new 
ConfigKey("Advanced", String.class, "vmware.search.exclude.folders", 
null,
 "Comma seperated list of Datastore Folders to exclude from VMWare 
search", true, ConfigKey.Scope.Global);
 
+static final ConfigKey s_vmwareOVAPackageTimeout = new 
ConfigKey(Integer.class, "vmware.package.ova.timeout", 
"Advanced",String.valueOf(VM_OVA_PACKAGE_TIMEOUT_SEC),
 
 Review comment:
   @mrunalinikankariya see ` "Advanced",String.valueOf` would look better as ` 
"Advanced", String.valueOf` this is what I meant by fixing the space.
   The constant are default values for the ConfigKey, and not used anywhere 
else. ConfigKey defaul values are themselves treated as well `defaults`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy 
API create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-353929623
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1488


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-353929528
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2347: CLOUDSTACK-10166: Get accountId and domainId from VPC when tagging a NetworkACL as a user

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2347: CLOUDSTACK-10166: Get accountId and 
domainId from VPC when tagging a NetworkACL as a user
URL: https://github.com/apache/cloudstack/pull/2347#issuecomment-353929522
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2347: CLOUDSTACK-10166: Get accountId and domainId from VPC when tagging a NetworkACL as a user

2017-12-25 Thread GitBox 
rhtyd commented on issue #2347: CLOUDSTACK-10166: Get accountId and domainId 
from VPC when tagging a NetworkACL as a user
URL: https://github.com/apache/cloudstack/pull/2347#issuecomment-353929456
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.

2017-12-25 Thread GitBox 
rhtyd commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 
and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-353929419
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1934: [CLOUDSTACK-9772] Template: perform a 
HEAD request to check file size from a URL
URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-353929307
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-12-25 Thread GitBox 
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed 
storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-353929041
 
 
   @mike-tutkowski I've left some comments, my only major concern is the 
placement of the `SIOC API plug-in for VMware SIOC` otherwise LGTM.
   
   Since it touches upon various parts of the code, the final acceptance would 
require running regression smoke tests on KVM/VMware/XenServer which we'll do 
once we've additional lgtm/reviews from others.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

2017-12-25 Thread GitBox 
rhtyd commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD 
request to check file size from a URL
URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-353929226
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-12-25 Thread GitBox 
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed 
storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-353929041
 
 
   @mike-tutkowski I've left some comments, my only major concern is the 
placement of the `SIOC API plug-in for VMware SIOC` otherwise LGTM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: 
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r158673781
 
 

 ##
 File path: plugins/api/solidfire-sioc/pom.xml
 ##
 @@ -0,0 +1,47 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  cloud-plugin-api-solidfire-sioc
+  Apache CloudStack Plugin - API SolidFire (SIOC)
 
 Review comment:
   @mike-tutkowski what is SIOC, can this be under `plugins/solidfire/...` than 
under `plugin/api`? Looking at the classes, they required the vmware sdk to 
compile, should this be moved to vmware or related? This probably needs to be 
activated by the `-Dnoredist` flag/profile.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: 
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r158673931
 
 

 ##
 File path: 
plugins/api/solidfire-sioc/src/org/apache/cloudstack/api/command/admin/solidfire/UpdateSiocInfoCmd.java
 ##
 @@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.solidfire;
+
+import javax.inject.Inject;
+
+import org.apache.log4j.Logger;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.StoragePoolResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.cloudstack.api.response.solidfire.ApiUpdateSiocInfoResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.solidfire.SolidFireSiocManager;
+
+import com.cloud.user.Account;
+
+@APICommand(name = "updateSiocInfo", responseObject = 
ApiUpdateSiocInfoResponse.class, description = "Update SIOC info",
 
 Review comment:
   @mike-tutkowski please add `version`, `authorized` etc. See the 
`*RoleCmd.java` as an example.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: 
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r158673893
 
 

 ##
 File path: 
plugins/api/solidfire-sioc/src/org/apache/cloudstack/api/command/admin/solidfire/UpdateSiocInfoCmd.java
 ##
 @@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.solidfire;
+
+import javax.inject.Inject;
+
+import org.apache.log4j.Logger;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.StoragePoolResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.cloudstack.api.response.solidfire.ApiUpdateSiocInfoResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.solidfire.SolidFireSiocManager;
+
+import com.cloud.user.Account;
+
+@APICommand(name = "updateSiocInfo", responseObject = 
ApiUpdateSiocInfoResponse.class, description = "Update SIOC info",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class UpdateSiocInfoCmd extends BaseCmd {
+private static final Logger s_logger = 
Logger.getLogger(UpdateSiocInfoCmd.class.getName());
+private static final String s_name = "updatesiocinforesponse";
 
 Review comment:
   Please refactor using APINAME pattern, see recent API implementations such 
as the `*RoleCmd.java`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: 
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r158673781
 
 

 ##
 File path: plugins/api/solidfire-sioc/pom.xml
 ##
 @@ -0,0 +1,47 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  cloud-plugin-api-solidfire-sioc
+  Apache CloudStack Plugin - API SolidFire (SIOC)
 
 Review comment:
   @mike-tutkowski what is SIOC, can this be under `plugins/solidfire/...` than 
under `plugin/api`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

2017-12-25 Thread GitBox 
rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables 
instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-353927976
 
 
   Tests LGTM.
   @DaanHoogland @syed are you still -1/nLGTM on it consider test results and 
code review?
   Additional discussion and review requested - @nvazquez @borisstoyanov @wido 
@marcaurele @rafaelweingartner and others, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353927772
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

2017-12-25 Thread GitBox 
rhtyd commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range 
to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-353927763
 
 
   @yvsubhash please check/fix travis build/test failures


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2017-12-25 Thread GitBox 
rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353927716
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2344: CLOUDSTACK-10163: Component tests sanity

2017-12-25 Thread GitBox 
rhtyd commented on issue #2344: CLOUDSTACK-10163: Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#issuecomment-353927645
 
 
   Pinging for additional review - @nvazquez @DaanHoogland @wido @marcaurele 
@rafaelweingartner and others, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2374: CLOUDSTACK-10024: Network Migration: 
Tackle review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353926876
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

2017-12-25 Thread GitBox 
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle 
review comments
URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-353926773
 
 
   Additional review requested - @borisstoyanov @nvazquez @DaanHoogland @wido 
@rafaelweingartner @marcaurele and others, thanks.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2350: Cloudstack 10170 - fixes resource tags security bugs and adds account tags support

2017-12-25 Thread GitBox 
rhtyd commented on issue #2350: Cloudstack 10170 - fixes resource tags security 
bugs and adds account tags support
URL: https://github.com/apache/cloudstack/pull/2350#issuecomment-353926643
 
 
   @bwsw can you have a look at build/Travis failures?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2360: Adding nuage VSD managed network support to CloudStack.

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2360: Adding nuage VSD managed network 
support to CloudStack.
URL: https://github.com/apache/cloudstack/pull/2360#issuecomment-353926577
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2360: Adding nuage VSD managed network support to CloudStack.

2017-12-25 Thread GitBox 
rhtyd commented on issue #2360: Adding nuage VSD managed network support to 
CloudStack.
URL: https://github.com/apache/cloudstack/pull/2360#issuecomment-353926538
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353926466
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
rhtyd commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353926402
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353773850
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353796536
 
 
   Trillian test result (tid-1903)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30042 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1760-t1903-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 231.55 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 201.37 | 
test_privategw_acl.py
   test_07_resize_fail | `Failure` | 15.27 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a 
multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353774923
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2258: Cloudstack 10064: Secondary storage 
Usage for uploadedVolume is not collected
URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-353926041
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

2017-12-25 Thread GitBox 
rhtyd commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API 
create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-353926005
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353774854
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1480


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-12-25 Thread GitBox 
rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits 
comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-353926181
 
 
   Tests LGTM, can we have a more code review/lgtm to merge this -- 
@borisstoyanov @wido @nvazquez @rafaelweingartner @DaanHoogland and others?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353774954
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy 
API create multiple entries in DB for same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-353926037
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for uploadedVolume is not collected

2017-12-25 Thread GitBox 
rhtyd commented on issue #2258: Cloudstack 10064: Secondary storage Usage for 
uploadedVolume is not collected
URL: https://github.com/apache/cloudstack/pull/2258#issuecomment-353925980
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672220
 
 

 ##
 File path: 
engine/schema/src/com/cloud/configuration/ManagementServiceConfiguration.java
 ##
 @@ -0,0 +1,39 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.configuration;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
+
+public class ManagementServiceConfiguration implements Configurable {
 
 Review comment:
   Just an idea - this can be implemented as an interface or moved to an 
existing interface with the actual exporting of ConfigKey done via a more 
appropriate `ManagementServerImpl.java`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158671979
 
 

 ##
 File path: 
engine/schema/src/com/cloud/configuration/ManagementServiceConfiguration.java
 ##
 @@ -0,0 +1,39 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.configuration;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
+
+public class ManagementServiceConfiguration implements Configurable {
+public static final ConfigKey PingInterval = new 
ConfigKey("Advanced", Integer.class, "ping.interval", "60",
+"Interval to send application level pings to make sure the 
connection is still working", false);
+public static final ConfigKey PingTimeout = new 
ConfigKey("Advanced", Float.class, "ping.timeout", "2.5",
+"Multiplier to ping.interval before announcing an agent has timed 
out", true);
+
+@Override
+public String getConfigComponentName() {
+return ManagementServiceConfiguration.class.getSimpleName();
+}
+
+@Override
+public ConfigKey[] getConfigKeys() {
+return new ConfigKey[] {PingInterval, PingTimeout};
+}
+
 
 Review comment:
   Remove extra newline.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672111
 
 

 ##
 File path: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
 ##
 @@ -242,11 +239,11 @@ public boolean configure(final String name, final 
Map params) th
 }
 
 protected int getPingInterval() {
-return PingInterval.value();
+return ManagementServiceConfiguration.PingInterval.value();
 }
 
 protected long getTimeout() {
 
 Review comment:
   Since you've introduced a new `ManagementServiceConfiguration`, why not 
refactor/move this method to the class and make it reusable across 
server/codebase.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672147
 
 

 ##
 File path: 
engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java
 ##
 @@ -107,7 +104,7 @@ private void processReport(long hostId, Map tra
 s_logger.debug("Run missing VM report. current time: " + 
currentTime.getTime());
 
 // 2 times of sync-update interval for graceful period
-long milliSecondsGracefullPeriod = PingInterval.value() * 2000L;
+long milliSecondsGracefullPeriod = 
ManagementServiceConfiguration.PingInterval.value() * 2000L;
 
 Review comment:
   Since you've introduced a new `ManagementServiceConfiguration`, why not 
consume the value using a method?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158671990
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -79,6 +78,7 @@
 
 private static final String LIST_CLUSTERID_FOR_HOST_TAG = "select distinct 
cluster_id from host join host_tags on host.id = host_tags.host_id and 
host_tags.tag = ?";
 
+
 
 Review comment:
   Remove additional new line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672100
 
 

 ##
 File path: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
 ##
 @@ -242,11 +239,11 @@ public boolean configure(final String name, final 
Map params) th
 }
 
 protected int getPingInterval() {
 
 Review comment:
   Since you've introduced a new `ManagementServiceConfiguration`, why not 
refactor/move this method to the class and make it reusable across 
server/codebase.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672304
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -993,8 +991,8 @@ public boolean updateState(Status oldStatus, Event event, 
Status newStatus, Host
 }
 }
 if (event.equals(Event.ManagementServerDown)) {
-Float pingTimeout = 
NumbersUtil.parseFloat(_configDao.getValue("ping.timeout"), 2.5f);
-Integer pingInterval = 
NumbersUtil.parseInt(_configDao.getValue("ping.interval"), 60);
+float pingTimeout = 
ManagementServiceConfiguration.PingTimeout.value();
+int pingInterval = 
ManagementServiceConfiguration.PingInterval.value();
 ub.set(host, _pingTimeAttr, ((System.currentTimeMillis() >> 10) - 
(long)(pingTimeout * pingInterval)));
 
 Review comment:
   The value `pingTimeout * pingInterval` is used again, this can be consumed 
from the class/interface of `ManagementServiceConfiguration` via a 
`getTimeout()` that is also used in `AgentManagerImpl.java`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-9456: Upgrade spring and misc dependencies (#2375)

2017-12-25 Thread rohit 
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new e0d5364  CLOUDSTACK-9456: Upgrade spring and misc dependencies (#2375)
e0d5364 is described below

commit e0d5364b700f907f3965447b83f3f6f3d292d4de
Author: Rohit Yadav 
AuthorDate: Tue Dec 26 11:53:48 2017 +0530

CLOUDSTACK-9456: Upgrade spring and misc dependencies (#2375)

Upgrades spring, jetty and misc dependencies

Signed-off-by: Rohit Yadav 
---
 core/pom.xml |  2 +-
 plugins/event-bus/rabbitmq/pom.xml   |  2 +-
 .../nested-cloudstack/pom.xml|  2 +-
 plugins/storage/volume/cloudbyte/pom.xml |  2 +-
 plugins/user-authenticators/ldap/pom.xml |  2 +-
 pom.xml  | 20 ++--
 usage/pom.xml|  2 +-
 7 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/core/pom.xml b/core/pom.xml
index 4697311..d6624e5 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -50,7 +50,7 @@
   
   org.apache.commons
   commons-compress
-  1.14
+  1.15
   
   
 
diff --git a/plugins/event-bus/rabbitmq/pom.xml 
b/plugins/event-bus/rabbitmq/pom.xml
index 50c7710..c335bb5 100644
--- a/plugins/event-bus/rabbitmq/pom.xml
+++ b/plugins/event-bus/rabbitmq/pom.xml
@@ -31,7 +31,7 @@
 
 com.rabbitmq
   amqp-client
-5.0.0
+5.1.1
 
 
 org.apache.cloudstack
diff --git a/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml 
b/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml
index 29ae888..5375ffb 100644
--- a/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml
+++ b/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml
@@ -40,7 +40,7 @@
 
 br.com.autonomiccs
 apache-cloudstack-java-client
-1.0.6
+1.0.9
 
   
 
diff --git a/plugins/storage/volume/cloudbyte/pom.xml 
b/plugins/storage/volume/cloudbyte/pom.xml
index fbbe9b1..42827d3 100755
--- a/plugins/storage/volume/cloudbyte/pom.xml
+++ b/plugins/storage/volume/cloudbyte/pom.xml
@@ -54,7 +54,7 @@
 
com.sun.jersey
jersey-bundle
-   1.19.3
+   1.19.4
 
   
   
diff --git a/plugins/user-authenticators/ldap/pom.xml 
b/plugins/user-authenticators/ldap/pom.xml
index 49c562e..9f97f08 100644
--- a/plugins/user-authenticators/ldap/pom.xml
+++ b/plugins/user-authenticators/ldap/pom.xml
@@ -96,7 +96,7 @@
 
   org.spockframework
   spock-core
-  1.0-groovy-2.4
+  1.1-groovy-2.4
   test
 
 
diff --git a/pom.xml b/pom.xml
index e6b61a8..66cfd09 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,7 +52,7 @@
 3.2.5
 1.4
 1.6
-1.10
+1.11
 1.10
 1.1.1
 0.5
@@ -69,9 +69,9 @@
 2.6.11
 1.7.2
 18.0
-23.2-jre
+23.6-jre
 6.2.0-3.1
-4.5.3
+4.5.4
 4.4.8
 3.1
 5.1.34
@@ -88,14 +88,14 @@
 1.2.1
 
1.0-20081010.060147
 6.0
-5.0.0.RELEASE
+5.0.2.RELEASE
 1.10.19
 1.6.4
 1.11.213
 2.9.2
 2.6
 3.4
-2.5
+2.6
 1.3.3
 4.1
 1.6
@@ -106,7 +106,7 @@
 0.5.1
 0.2.0
 target
-1.0.15
+1.1.0
 4.0.0
 2.17
 2.11
@@ -116,12 +116,12 @@
 1.4.01
 2.8.1
 1.9.1
-2.5.7_1
+2.5.8_1
 3.2.0
 2.4.12
 10.1
 2.11.0
-9.4.7.v20170914
+9.4.8.v20171121
 
9.2.22.v20170606
   
 
@@ -441,12 +441,12 @@
   
 org.aspectj
 aspectjtools
-1.8.11
+1.8.13
   
   
 org.aspectj
 aspectjweaver
-1.8.11
+1.8.13
   
   
 org.apache.axis
diff --git a/usage/pom.xml b/usage/pom.xml
index 864787a..bf3ab66 100644
--- a/usage/pom.xml
+++ b/usage/pom.xml
@@ -63,7 +63,7 @@
 
   org.dbunit
   dbunit
-  2.5.3
+  2.5.4
   test
 
   

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc dependencies

2017-12-25 Thread GitBox 
rhtyd commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc 
dependencies
URL: https://github.com/apache/cloudstack/pull/2375#issuecomment-353924879
 
 
   Merging this based on two lgtms and test results with 0 smoketest failures. 
I'll look into intermittent failures and improve test/infra to avoid them, 
intermittently failing tests are those which fail on the first run but pass on 
the second-run.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc dependencies

2017-12-25 Thread GitBox 
rhtyd closed pull request #2375: CLOUDSTACK-9456: Upgrade spring, jetty and 
misc dependencies
URL: https://github.com/apache/cloudstack/pull/2375
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/pom.xml b/core/pom.xml
index 469731177b3..d6624e5725b 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -50,7 +50,7 @@
   
   org.apache.commons
   commons-compress
-  1.14
+  1.15
   
   
 
diff --git a/plugins/event-bus/rabbitmq/pom.xml 
b/plugins/event-bus/rabbitmq/pom.xml
index 50c7710fce6..c335bb59145 100644
--- a/plugins/event-bus/rabbitmq/pom.xml
+++ b/plugins/event-bus/rabbitmq/pom.xml
@@ -31,7 +31,7 @@
 
 com.rabbitmq
   amqp-client
-5.0.0
+5.1.1
 
 
 org.apache.cloudstack
diff --git a/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml 
b/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml
index 29ae8883155..5375ffbab27 100644
--- a/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml
+++ b/plugins/outofbandmanagement-drivers/nested-cloudstack/pom.xml
@@ -40,7 +40,7 @@
 
 br.com.autonomiccs
 apache-cloudstack-java-client
-1.0.6
+1.0.9
 
   
 
diff --git a/plugins/storage/volume/cloudbyte/pom.xml 
b/plugins/storage/volume/cloudbyte/pom.xml
index fbbe9b151b7..42827d310dd 100755
--- a/plugins/storage/volume/cloudbyte/pom.xml
+++ b/plugins/storage/volume/cloudbyte/pom.xml
@@ -54,7 +54,7 @@
 
com.sun.jersey
jersey-bundle
-   1.19.3
+   1.19.4
 
   
   
diff --git a/plugins/user-authenticators/ldap/pom.xml 
b/plugins/user-authenticators/ldap/pom.xml
index 49c562e7ab1..9f97f08f3fd 100644
--- a/plugins/user-authenticators/ldap/pom.xml
+++ b/plugins/user-authenticators/ldap/pom.xml
@@ -96,7 +96,7 @@
 
   org.spockframework
   spock-core
-  1.0-groovy-2.4
+  1.1-groovy-2.4
   test
 
 
diff --git a/pom.xml b/pom.xml
index e6b61a83f07..66cfd0992a2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,7 +52,7 @@
 3.2.5
 1.4
 1.6
-1.10
+1.11
 1.10
 1.1.1
 0.5
@@ -69,9 +69,9 @@
 2.6.11
 1.7.2
 18.0
-23.2-jre
+23.6-jre
 6.2.0-3.1
-4.5.3
+4.5.4
 4.4.8
 3.1
 5.1.34
@@ -88,14 +88,14 @@
 1.2.1
 
1.0-20081010.060147
 6.0
-5.0.0.RELEASE
+5.0.2.RELEASE
 1.10.19
 1.6.4
 1.11.213
 2.9.2
 2.6
 3.4
-2.5
+2.6
 1.3.3
 4.1
 1.6
@@ -106,7 +106,7 @@
 0.5.1
 0.2.0
 target
-1.0.15
+1.1.0
 4.0.0
 2.17
 2.11
@@ -116,12 +116,12 @@
 1.4.01
 2.8.1
 1.9.1
-2.5.7_1
+2.5.8_1
 3.2.0
 2.4.12
 10.1
 2.11.0
-9.4.7.v20170914
+9.4.8.v20171121
 
9.2.22.v20170606
   
 
@@ -441,12 +441,12 @@
   
 org.aspectj
 aspectjtools
-1.8.11
+1.8.13
   
   
 org.aspectj
 aspectjweaver
-1.8.11
+1.8.13
   
   
 org.apache.axis
diff --git a/usage/pom.xml b/usage/pom.xml
index 864787a68a4..bf3ab665666 100644
--- a/usage/pom.xml
+++ b/usage/pom.xml
@@ -63,7 +63,7 @@
 
   org.dbunit
   dbunit
-  2.5.3
+  2.5.4
   test
 
   


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bwsw commented on issue #2350: Cloudstack 10170 - fixes resource tags security bugs and adds account tags support

2017-12-25 Thread GitBox 
bwsw commented on issue #2350: Cloudstack 10170 - fixes resource tags security 
bugs and adds account tags support
URL: https://github.com/apache/cloudstack/pull/2350#issuecomment-353922687
 
 
   @borisstoyanov conflicts are resolved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2017-12-25 Thread GitBox 
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based 
approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-353919345
 
 
   @rhtyd , can you please review the changes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource 
limits comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-353894268
 
 
   Trillian test result (tid-1913)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37819 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1554-t1913-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc dependencies

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty 
and misc dependencies
URL: https://github.com/apache/cloudstack/pull/2375#issuecomment-353887694
 
 
   Trillian test result (tid-1915)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 25838 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2375-t1915-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 66 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource 
limits comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-353865787
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353865794
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc dependencies

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty 
and misc dependencies
URL: https://github.com/apache/cloudstack/pull/2375#issuecomment-353865791
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-12-25 Thread GitBox 
rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits 
comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-353865756
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc dependencies

2017-12-25 Thread GitBox 
rhtyd commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc 
dependencies
URL: https://github.com/apache/cloudstack/pull/2375#issuecomment-353865751
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a 
multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353865746
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353860041
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1487


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-353859891
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1486


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-353859435
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1485


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2017-12-25 Thread GitBox 
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor?
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-353858935
 
 
   @yvsubhash you are right... My problem is not related to this one here. The 
snapshots in XenServer is working as you said. However, sometimes if exceptions 
happen during copy of the snapshot to the secondary storage, snapshots in the 
primary storage are not cleaned. I am still investigating and trying to find a 
way to solve this problem.
   
   BTW thanks for the reply!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2373: CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for same volume.

2017-12-25 Thread GitBox 
rafaelweingartner commented on issue #2373: 
CLOUDSTACK-10202:createSnapshotPolicy API create multiple entries in DB for 
same volume.
URL: https://github.com/apache/cloudstack/pull/2373#issuecomment-353858705
 
 
   I have experienced the same problem some time ago. I did not manage to 
reproduce it though. One of the volumes had two "daily snapshots" in the 
database. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource 
limits comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-353858033
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1484


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty and misc dependencies

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2375: CLOUDSTACK-9456: Upgrade spring, jetty 
and misc dependencies
URL: https://github.com/apache/cloudstack/pull/2375#issuecomment-353857764
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1482


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

2017-12-25 Thread GitBox 
blueorangutan commented on issue #1934: [CLOUDSTACK-9772] Template: perform a 
HEAD request to check file size from a URL
URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-353857763
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1483


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bwsw commented on issue #2350: Cloudstack 10170 - fixes resource tags security bugs and adds account tags support

2017-12-25 Thread GitBox 
bwsw commented on issue #2350: Cloudstack 10170 - fixes resource tags security 
bugs and adds account tags support
URL: https://github.com/apache/cloudstack/pull/2350#issuecomment-353856183
 
 
   @borisstoyanov could you please direct me what is the most supposable test 
to look at. I tried several and found unrelated issues, which seems to be 
connected to general server outage rather than tags. It looks like overal test 
suite run is broken.
   
   ```
{jobprocstatus : 0, created : u'2017-12-19T20:58:00+', jobresult : 
{errorcode : 530, errortext : u'Failed to create 
templatecom.cloud.utils.exception.CloudRuntimeException: 
com.cloud.utils.exception.CloudRuntimeException: Failed to send command, due to 
Agent:6, com.cloud.exception.OperationTimedoutException: Commands 
4283486195582763016 to Host 6 timed out after 1800'}, cmd : 
u'org.apache.cloudstack.api.command.admin.template.CreateTemplateCmdByAdmin', 
userid : u'7fd4-bd56-4523-a5ef-ed5d476ca32f', jobstatus : 2, jobid : 
u'956b3ab1-c0f0-4a4d-a380-1b21336f2fd5', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'Template', accountid : 
u'68d35e5b-eea2-4ad6-92f0-06d74abc5c5c'}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353855395
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2301: CLOUDSTACK-10121 moveUser

2017-12-25 Thread GitBox 
rhtyd commented on issue #2301: CLOUDSTACK-10121 moveUser
URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-353855314
 
 
   Thanks @borisstoyanov let me re-run tests as master has changed.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

2017-12-25 Thread GitBox 
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-353791499
 
 
   Trillian test result (tid-1899)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28753 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t1899-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 5.81 | 
test_hostha_kvm.py
   
   This looks like an intermittent failure, I'll investigate it this week. On 
subsequent run it passes.
   :white_check_mark: :tada: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

  1   2   >