[GitHub] [cloudstack] rohityadavcloud merged pull request #7898: server: allow user to list available IPs on shared networks

2023-08-24 Thread via GitHub
rohityadavcloud merged PR #7898: URL: https://github.com/apache/cloudstack/pull/7898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-24 Thread via GitHub
rohityadavcloud commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1691994741 Needs assistance on fixing the UI unit tests - @nvazquez @Pearl1594 @shwstppr @blueorangutan package @blueorangutan ui -- This is an automated message from the

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7898: server: allow user to list available IPs on shared networks

2023-08-24 Thread via GitHub
weizhouapache commented on code in PR #7898: URL: https://github.com/apache/cloudstack/pull/7898#discussion_r1304126696 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -2475,7 +2476,20 @@ public Pair, Integer> searchForIPAddresses(final ListP

[GitHub] [cloudstack] weizhouapache merged pull request #7924: PowerFlex: Handle missing volumes gracefully during delete volume

2023-08-31 Thread via GitHub
weizhouapache merged PR #7924: URL: https://github.com/apache/cloudstack/pull/7924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] blueorangutan commented on pull request #7923: kvm: fix error when enable SSL for kvm agent

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1701703209 [SF] Trillian test result (tid-7612) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 46270 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7868: Removed state for removed accounts

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7868: URL: https://github.com/apache/cloudstack/pull/7868#issuecomment-1701842987 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6955 -- This is

[GitHub] [cloudstack] blueorangutan commented on pull request #7912: utils: build both SHADED and original jars

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1701387698 [LL]Trillian test result (tid-6731) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38461 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7923: kvm: fix error when enable SSL for kvm agent

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1701557562 [SF] Trillian test result (tid-7611) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 41113 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7912: utils: build both SHADED and original jars

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1701415837 [LL]Trillian test result (tid-6733) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39588 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7924: PowerFlex: Handle missing volumes gracefully during delete volume

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7924: URL: https://github.com/apache/cloudstack/pull/7924#issuecomment-1701660252 [SF] Trillian test result (tid-7610) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45706 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7922: Add index on cluster_details.name for FirstFitPlanner speedup

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7922: URL: https://github.com/apache/cloudstack/pull/7922#issuecomment-1701914735 [SF] Trillian test result (tid-7614) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 57667 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7912: utils: build both SHADED and original jars

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1701523089 [LL]Trillian test result (tid-6732) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 43720 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7922: Add index on cluster_details.name for FirstFitPlanner speedup

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7922: URL: https://github.com/apache/cloudstack/pull/7922#issuecomment-1701537875 [SF] Trillian test result (tid-7613) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38117 seconds Marvin logs:

[GitHub] [cloudstack] GutoVeronezi commented on pull request #7813: Remove GetUploadParamsForIsoCmd API duplicate parameters

2023-08-31 Thread via GitHub
GutoVeronezi commented on PR #7813: URL: https://github.com/apache/cloudstack/pull/7813#issuecomment-1701788902 I checked the tests errors (https://github.com/apache/cloudstack/pull/7813#issuecomment-1673786069) and they are not related to the PR. I did some testing and the API is

[GitHub] [cloudstack] GutoVeronezi merged pull request #7813: Remove GetUploadParamsForIsoCmd API duplicate parameters

2023-08-31 Thread via GitHub
GutoVeronezi merged PR #7813: URL: https://github.com/apache/cloudstack/pull/7813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] weizhouapache commented on pull request #7858: Keep deleted projects name

2023-08-31 Thread via GitHub
weizhouapache commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1701840019 > > not sure if the tests done by @kiranchavala cover all basis, but there is functional agreement that this is the proper functionality, and fallout needs to be dealt with.

[GitHub] [cloudstack] hsato03 commented on pull request #7858: Keep deleted projects name

2023-08-31 Thread via GitHub
hsato03 commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1701767142 > not sure if the tests done by @kiranchavala cover all basis, but there is functional agreement that this is the proper functionality, and fallout needs to be dealt with. Shall we

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-08-31 Thread via GitHub
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1701796495 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] hsato03 commented on pull request #7868: Removed state for removed accounts

2023-08-31 Thread via GitHub
hsato03 commented on PR #7868: URL: https://github.com/apache/cloudstack/pull/7868#issuecomment-1701809341 I agree with @rohityadavcloud and @weizhouapache, REMOVED sounds better for accounts. @DaanHoogland Although your idea of ​​standardizing the state of entities is good, there are

[GitHub] [cloudstack] weizhouapache opened a new issue, #7918: [4.19] UserData must have a header

2023-08-28 Thread via GitHub
weizhouapache opened a new issue, #7918: URL: https://github.com/apache/cloudstack/issues/7918 With #7643 , userdata must have a header, a plain text cannot be used as userdata any more. This breaks backward compatibility while in elder versions userdata can be any string. #

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307574986 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -65,6 +66,7 @@ @Component public class

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307717859 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -1847,6 +1832,29 @@ public boolean deleteUserAccount(long accountId) { return

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1696141683 [SF] Trillian test result (tid-7582) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46560 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1696046807 [SF] Trillian test result (tid-7587) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42033 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-28 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1696063040 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6924 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1696139260 @nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1696021713 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] GutoVeronezi commented on pull request #7895: Flexible URI for connection with DB

2023-08-28 Thread via GitHub
GutoVeronezi commented on PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1696021793 > > @JoaoJandre You can generate the uri by settings in db properties > > > > * driver > > * replicas > > * failover mode (new) > > * url params > > > > what

[GitHub] [cloudstack] mlsorensen commented on issue #6778: If Kafka is turned on internal subs dont work

2023-08-28 Thread via GitHub
mlsorensen commented on issue #6778: URL: https://github.com/apache/cloudstack/issues/6778#issuecomment-1696028344 > ok, so your idea is that we create a list of channels and in have a default MessageBus.publish() iterate the list of registered message busses and call eache publish

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1696089914 [SF] Trillian test result (tid-7584) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44108 seconds Marvin logs:

[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-28 Thread via GitHub
nvazquez commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1696141018 Hi @itsayushpandey can you please check the build failures? It seems like there are unit tests failures on the `server` module: Error: Errors: Error:

[GitHub] [cloudstack] blueorangutan commented on pull request #7731: Default value of force should be false for template delete operation

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7731: URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1696026605 [SF] Trillian test result (tid-7588) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40241 seconds Marvin logs:

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
nvazquez commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307535660 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -115,7 +124,7 @@ public void onPublishMessage(String

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695884534 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695884896 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695936048 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1696017113 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6923 -- This is an

[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-28 Thread via GitHub
nvazquez commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1696137350 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1696159090 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15.

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695840262 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6918 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695865931 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6919 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695865932 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6920 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695887484 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6922 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695887493 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6921 -- This is an

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307576891 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -115,7 +124,7 @@ public void onPublishMessage(String

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
nvazquez commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307586265 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -65,6 +66,7 @@ @Component public class LdapManagerImpl

[GitHub] [cloudstack] DaanHoogland commented on pull request #6812: Normalize encryption on global configurations values

2023-08-28 Thread via GitHub
DaanHoogland commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1695987742 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-28 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1695989069 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] weizhouapache commented on pull request #7895: Flexible URI for connection with DB

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1696034699 @GutoVeronezi cc @JoaoJandre You only mentioned the flexible URI in the title and description. However, there are lots of changes for mariadb support. please remove the

[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1696034852 [SF] Trillian test result (tid-7585) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41624 seconds Marvin logs:

[GitHub] [cloudstack] weizhouapache commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695867492 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695868453 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695938897 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] DaanHoogland commented on issue #6778: If Kafka is turned on internal subs dont work

2023-08-28 Thread via GitHub
DaanHoogland commented on issue #6778: URL: https://github.com/apache/cloudstack/issues/6778#issuecomment-1696002188 ok, so your idea is that we create a list of channels and in have a default MessageBus.publish() iterate the list of registered message busses and call eache publish

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1696019973 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7895: Flexible URI for connection with DB

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#discussion_r1307689512 ## framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java: ## @@ -1143,6 +1134,38 @@ public static void initDataSource(Properties dbProps) {

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1696209948 [SF] Trillian test result (tid-7583) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48387 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7932: Fix direct download https compressed qcow2 template checker

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7932: URL: https://github.com/apache/cloudstack/pull/7932#issuecomment-1702123751 [SF] Trillian test result (tid-7619) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42848 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1702022980 [SF] Trillian test result (tid-7618) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39688 seconds Marvin logs:

[GitHub] [cloudstack] xuanyuanaosheng commented on issue #7838: The VPC Redundant router "Virtual routers" can not work as expected

2023-08-31 Thread via GitHub
xuanyuanaosheng commented on issue #7838: URL: https://github.com/apache/cloudstack/issues/7838#issuecomment-1702209516 > Linux native VXLAN uses multicast by default. You need to have an IP address on each of your host VXLAN subinterfaces that is within the same network.

[GitHub] [cloudstack] kishankavala commented on a diff in pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-09-01 Thread via GitHub
kishankavala commented on code in PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#discussion_r1312678832 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -4760,15 +4762,14 @@ protected String validateUserData(String userData, HTTPMethod

[GitHub] [cloudstack] blueorangutan commented on pull request #7932: Fix direct download https compressed qcow2 template checker

2023-09-01 Thread via GitHub
blueorangutan commented on PR #7932: URL: https://github.com/apache/cloudstack/pull/7932#issuecomment-1702318350 [SF] Trillian test result (tid-7620) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41550 seconds Marvin logs:

[GitHub] [cloudstack] weizhouapache merged pull request #7932: Fix direct download https compressed qcow2 template checker

2023-09-01 Thread via GitHub
weizhouapache merged PR #7932: URL: https://github.com/apache/cloudstack/pull/7932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] shwstppr commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
shwstppr commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1702568364 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
blueorangutan commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1702630233 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6961 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7922: Add index on cluster_details.name for FirstFitPlanner speedup

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7922: URL: https://github.com/apache/cloudstack/pull/7922#issuecomment-1701673155 [SF] Trillian test result (tid-7615) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42941 seconds Marvin logs:

[GitHub] [cloudstack] weizhouapache merged pull request #7922: Add index on cluster_details.name for FirstFitPlanner speedup

2023-08-31 Thread via GitHub
weizhouapache merged PR #7922: URL: https://github.com/apache/cloudstack/pull/7922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] blueorangutan commented on pull request #7868: Removed state for removed accounts

2023-08-31 Thread via GitHub
blueorangutan commented on PR #7868: URL: https://github.com/apache/cloudstack/pull/7868#issuecomment-1701799382 @soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] soreana commented on pull request #7868: Removed state for removed accounts

2023-08-31 Thread via GitHub
soreana commented on PR #7868: URL: https://github.com/apache/cloudstack/pull/7868#issuecomment-1701797959 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
blueorangutan commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1702570525 @shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] codecov[bot] commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
codecov[bot] commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1702641040 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7933?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging

[GitHub] [cloudstack] shwstppr opened a new pull request, #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
shwstppr opened a new pull request, #7933: URL: https://github.com/apache/cloudstack/pull/7933 ### Description Fixes #7926 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699286878 @nvazquez I think this might be an intended error even in the case of vmware ? Basically either the service offering spec should match or the VM should be in powered off state

[GitHub] [cloudstack] mlsorensen opened a new pull request, #7924: PowerFlex: Handle missing volumes gracefully during delete volume

2023-08-30 Thread via GitHub
mlsorensen opened a new pull request, #7924: URL: https://github.com/apache/cloudstack/pull/7924 ### Description This PR allows the PowerFlex plugin to gracefully handle the case where volume has been removed already from the backend PowerFlex storage. Without this, attempting to

[GitHub] [cloudstack] blueorangutan commented on pull request #7923: kvm: fix error when enable SSL for kvm agent

2023-08-30 Thread via GitHub
blueorangutan commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1699423954 @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7923: kvm: fix error when enable SSL for kvm agent

2023-08-30 Thread via GitHub
rohityadavcloud commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1699423214 @weizhouapache is that a critical/blocker issue for 4.18.1, could env loose the passphrase key from agent.properties on usage or upgrade? @blueorangutan test -- This

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-08-30 Thread via GitHub
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1699399305 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] mlsorensen commented on pull request #7922: Add index on cluster_details.name for FirstFitPlanner speedup

2023-08-30 Thread via GitHub
mlsorensen commented on PR #7922: URL: https://github.com/apache/cloudstack/pull/7922#issuecomment-1699399507 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] JoaoJandre commented on pull request #7895: Flexible URI for connection with DB and new MariaDB driver

2023-08-30 Thread via GitHub
JoaoJandre commented on PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1699497564 @GutoVeronezi sure, I've added it to the description and title. @weizhouapache about adding more properties, as previously written by @GutoVeronezi, I think that it is out of

[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
nvazquez commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699556870 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
blueorangutan commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699558331 @nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7924: PowerFlex: Handle missing volumes gracefully during delete volume

2023-08-30 Thread via GitHub
rohityadavcloud commented on PR #7924: URL: https://github.com/apache/cloudstack/pull/7924#issuecomment-1699437422 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7924: PowerFlex: Handle missing volumes gracefully during delete volume

2023-08-30 Thread via GitHub
blueorangutan commented on PR #7924: URL: https://github.com/apache/cloudstack/pull/7924#issuecomment-1699438680 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699437475 Hi @nvazquez , can you please share the custom offering details with me? I can perhaps try to reproduce and debug locally. I am able to reproduce the first error now and

[GitHub] [cloudstack] blueorangutan commented on pull request #7922: Add index on cluster_details.name for FirstFitPlanner speedup

2023-08-30 Thread via GitHub
blueorangutan commented on PR #7922: URL: https://github.com/apache/cloudstack/pull/7922#issuecomment-1699496012 Packaging result [SF]: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 6942

[GitHub] [cloudstack] codecov[bot] commented on pull request #7924: PowerFlex: Handle missing volumes gracefully during delete volume

2023-08-30 Thread via GitHub
codecov[bot] commented on PR #7924: URL: https://github.com/apache/cloudstack/pull/7924#issuecomment-1699521732 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7924?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > Merging

[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
nvazquez commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699382123 @itsayushpandey I'm trying on KVM to import a VM using the same service offering from the one I've created the VM on CloudStack before unmanaging. Perhaps I'm missing a parameter,

[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
nvazquez commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699458796 @itsayushpandey sure, you can create one under Service Offerings using the Custom Unconstrained option. Then create a VM selecting this offering and CloudStack will ask you to

[GitHub] [cloudstack] blueorangutan commented on pull request #7923: kvm: fix error when enable SSL for kvm agent

2023-08-30 Thread via GitHub
blueorangutan commented on PR #7923: URL: https://github.com/apache/cloudstack/pull/7923#issuecomment-1699486471 @weizhouapache [SF] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported

[GitHub] [cloudstack] blueorangutan commented on pull request #7922: Add index on cluster_details.name for FirstFitPlanner speedup

2023-08-30 Thread via GitHub
blueorangutan commented on PR #7922: URL: https://github.com/apache/cloudstack/pull/7922#issuecomment-1699402154 @mlsorensen a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
nvazquez commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699566325 @itsayushpandey the previous issues were tested on a L2 network. I'm able to import an unmanaged VM from an Isolated network. One minor improvement: the display name is ignored and

[GitHub] [cloudstack] blueorangutan commented on pull request #7924: PowerFlex: Handle missing volumes gracefully during delete volume

2023-08-30 Thread via GitHub
blueorangutan commented on PR #7924: URL: https://github.com/apache/cloudstack/pull/7924#issuecomment-1699523965 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6943 -- This is an

[GitHub] [cloudstack] soreana commented on issue #7927: PEP 440 When Installing cloudstack-marvin breaks building wheels

2023-09-01 Thread via GitHub
soreana commented on issue #7927: URL: https://github.com/apache/cloudstack/issues/7927#issuecomment-1702912771 @weizhouapache I've managed to install Marvin on CentOS 8, but I've had additional challenges such as the absence of the Rust compiler and some missing dependencies that were not

[GitHub] [cloudstack] weizhouapache commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
weizhouapache commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1702965827 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] weizhouapache commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
weizhouapache commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1702965615 code lgtm need testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
blueorangutan commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1702967451 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache merged pull request #7912: utils: build both SHADED and original jars

2023-09-01 Thread via GitHub
weizhouapache merged PR #7912: URL: https://github.com/apache/cloudstack/pull/7912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-09-01 Thread via GitHub
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1703118509 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

[GitHub] [cloudstack] weizhouapache commented on pull request #7912: utils: build both SHADED and original jars

2023-09-01 Thread via GitHub
weizhouapache commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1703030971 > @weizhouapache I did some basic tests and it LGTM. I also tested this with #7131 and it does solve the issue. I added the log4j2 dependencies to the shaded jar and the system

[GitHub] [cloudstack] blueorangutan commented on pull request #7933: server: fix dualstack ipv6 networks for vxlan

2023-09-01 Thread via GitHub
blueorangutan commented on PR #7933: URL: https://github.com/apache/cloudstack/pull/7933#issuecomment-1703696391 [SF] Trillian test result (tid-7621) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45377 seconds Marvin logs:

<    1   2   3   4   5   6   7   8   9   10   >