[GitHub] [incubator-druid] ggjjl1 commented on issue #6759: Unknown provider[mysql] of Key[type=org.apache.druid.metadata.MetadataStorageProvider,

ggjjl1 commented on issue #6759: Unknown provider[mysql] of Key[type=org.apache.druid.metadata.MetadataStorageProvider, URL: https://github.com/apache/incubator-druid/issues/6759#issuecomment-474203119 http://druid.io/docs/latest/development/extensions-core/mysql.html

[GitHub] [incubator-druid] surekhasaharan opened a new pull request #7295: Kafka integration test

surekhasaharan opened a new pull request #7295: Kafka integration test URL: https://github.com/apache/incubator-druid/pull/7295 Refactor common code into `AbstractKafkaIndexerTest.java`. Added `ITKafkaIndexingServiceTransactionalTest.java` for transactional kafka topics.

[GitHub] [incubator-druid] peterlittig commented on issue #6974: sql support for dynamic parameters

peterlittig commented on issue #6974: sql support for dynamic parameters URL: https://github.com/apache/incubator-druid/pull/6974#issuecomment-474189879 I found my way here via [CALCITE-2873](https://issues.apache.org/jira/browse/CALCITE-2873) and am receiving the same AvaticaSqlException

[GitHub] [incubator-druid] FaxianZhao opened a new pull request #7294: make hdfs index map reduce task add jar more reasonable

FaxianZhao opened a new pull request #7294: make hdfs index map reduce task add jar more reasonable URL: https://github.com/apache/incubator-druid/pull/7294 When I wanna run the updated MR index code(same jar name), it always confuse me. Because the current upload logic only compare

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266719143 ## File path: web-console/src/views/segments-view.tsx ##

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266717715 ## File path: web-console/src/components/table-column-selection.tsx

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266715886 ## File path: web-console/src/components/table-column-selection.tsx

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266717136 ## File path: web-console/src/components/table-column-selection.tsx

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266717073 ## File path: web-console/src/components/table-column-selection.tsx

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266718475 ## File path: web-console/src/views/tasks-view.tsx ## @@

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266719491 ## File path: web-console/src/views/segments-view.tsx ##

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266718274 ## File path: web-console/src/views/tasks-view.tsx ## @@

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266719253 ## File path: web-console/src/views/segments-view.tsx ##

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266719009 ## File path: web-console/src/views/segments-view.tsx ##

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on a change in pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266718040 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on issue #7292: Add table column selection in druid console to allow hiding/showing of columns

vogievetsky commented on issue #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#issuecomment-474179154 > Shouldn't the label be called "Show Columns" instead of "Hide Columns"? No, it

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266701884 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266701830 ## File path:

[GitHub] [incubator-druid] gianm commented on issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar

gianm commented on issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar URL: https://github.com/apache/incubator-druid/issues/7288#issuecomment-474156790 Here it is: https://github.com/apache/incubator-druid/pull/7293. I added some comments for

[GitHub] [incubator-druid] gianm opened a new pull request #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories.

gianm opened a new pull request #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293 Also, rename "getRequiredColumns" to "getTransferFactories", which I think better reflects what it's used for.

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266695618 ## File path:

[GitHub] [incubator-druid] clintropolis commented on issue #7169: Parquet Hadoop parser fails to parse columns specified in transformSpec only.

clintropolis commented on issue #7169: Parquet Hadoop parser fails to parse columns specified in transformSpec only. URL: https://github.com/apache/incubator-druid/issues/7169#issuecomment-474155232 I believe this is an artifact of how the "contrib" Parquet extension functions, [that it

[GitHub] [incubator-druid] fjy commented on issue #7292: Add table column selection in druid console to allow hiding/showing of columns

fjy commented on issue #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292#issuecomment-474153226 Shouldn't the label be called "Show Columns" instead of "Hide Columns"?

[GitHub] [incubator-druid] shuqi7 opened a new pull request #7292: Add table column selection in druid console to allow hiding/showing of columns

shuqi7 opened a new pull request #7292: Add table column selection in druid console to allow hiding/showing of columns URL: https://github.com/apache/incubator-druid/pull/7292 - Every table in the console now has a button on the top right corner which would render a popover list that

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266670736 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266671016 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266670736 ## File path:

[incubator-druid] branch 0.14.0-incubating updated: [Backport] Fix 0.14.0 rc1 voting issues (#7289)

This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new ed5d0f0

[GitHub] [incubator-druid] clintropolis merged pull request #7289: [Backport] Fix 0.14.0 rc1 voting issues

clintropolis merged pull request #7289: [Backport] Fix 0.14.0 rc1 voting issues URL: https://github.com/apache/incubator-druid/pull/7289 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266670359 ## File path:

[GitHub] [incubator-druid] jihoonson commented on issue #7291: Fix exclusivity for start offset in kinesis indexing service

jihoonson commented on issue #7291: Fix exclusivity for start offset in kinesis indexing service URL: https://github.com/apache/incubator-druid/pull/7291#issuecomment-474147113 I found another bug of that `isExclusive` is missing in `SeekableStreamDataSourceMetadata`. I'll update this PR

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266686171 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266686171 ## File path:

[GitHub] [incubator-druid] yurmix commented on issue #7290: Moving average query pr2

yurmix commented on issue #7290: Moving average query pr2 URL: https://github.com/apache/incubator-druid/pull/7290#issuecomment-474145356 > @yurmix thanks. I'm not sure reopening is better or not though. Sure thing, I'll go back to the original pr, if we have a merge issue to master, I

[GitHub] [incubator-druid] yurmix closed pull request #7290: Moving average query pr2

yurmix closed pull request #7290: Moving average query pr2 URL: https://github.com/apache/incubator-druid/pull/7290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid] yurmix commented on a change in pull request #7290: Moving average query pr2

yurmix commented on a change in pull request #7290: Moving average query pr2 URL: https://github.com/apache/incubator-druid/pull/7290#discussion_r266685426 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266681217 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] vogievetsky commented on issue #7283: Small tweak to override Blueprint's CSS rule for lookup edit dialog

vogievetsky commented on issue #7283: Small tweak to override Blueprint's CSS rule for lookup edit dialog URL: https://github.com/apache/incubator-druid/pull/7283#issuecomment-474140181 Thank you for fixing  This is an

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266680313 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266680313 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] gianm commented on a change in pull request #7206: Add the pull-request template

gianm commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266679338 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id of

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r266677981 ## File path:

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r266677465 ## File path:

[GitHub] [incubator-druid] jihoonson opened a new pull request #7291: Fix exclusivity for start offset in kinesis indexing service

jihoonson opened a new pull request #7291: Fix exclusivity for start offset in kinesis indexing service URL: https://github.com/apache/incubator-druid/pull/7291 Hopefully fixes #7286. The start offsets should be exclusive except for the very first task group.

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266674895 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266674831 ## File path: extensions-contrib/moving-average-query/src/test/resources/runtime.properties

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266674372 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266672933 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7206: Add the pull-request template

jon-wei commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266671864 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266671149 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266671016 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266670736 ## File path:

[GitHub] [incubator-druid] yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source.

yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266670359 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7290: Moving average query pr2

jihoonson commented on a change in pull request #7290: Moving average query pr2 URL: https://github.com/apache/incubator-druid/pull/7290#discussion_r29556 ## File path:

[GitHub] [incubator-druid] yurmix opened a new pull request #7290: Moving average query pr2

yurmix opened a new pull request #7290: Moving average query pr2 URL: https://github.com/apache/incubator-druid/pull/7290 Implements #6320. I'm closing the original pr #6430 because it has a messy merge commit. This is

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r28157 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] gianm commented on a change in pull request #7206: Add the pull-request template

gianm commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r26688 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id of

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r24882 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] gianm commented on a change in pull request #7206: Add the pull-request template

gianm commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r23968 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id of

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r21806 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] gianm commented on a change in pull request #7206: Add the pull-request template

gianm commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266651740 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id of

[GitHub] [incubator-druid] gianm commented on a change in pull request #7206: Add the pull-request template

gianm commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r266651261 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id of

[GitHub] [incubator-druid] leventov commented on issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar

leventov commented on issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar URL: https://github.com/apache/incubator-druid/issues/7288#issuecomment-474107696 @gianm thanks, now it makes much more sense. Could you please create a PR where you move

[GitHub] [incubator-druid] gianm merged pull request #7283: Small tweak to override Blueprint's CSS rule for lookup edit dialog

gianm merged pull request #7283: Small tweak to override Blueprint's CSS rule for lookup edit dialog URL: https://github.com/apache/incubator-druid/pull/7283 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] jon-wei opened a new pull request #7289: [Backport] Fix 0.14.0 rc1 voting issues

jon-wei opened a new pull request #7289: [Backport] Fix 0.14.0 rc1 voting issues URL: https://github.com/apache/incubator-druid/pull/7289 Backport of #7284 to 0.14.0-incubating This is an automated message from the Apache

[incubator-druid] branch master updated: Fix flattening Avro Maps with Utf8 keys (#7258)

This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new b2a940a Fix flattening Avro Maps with

[GitHub] [incubator-druid] gianm merged pull request #7258: Fix flattening Avro Maps with Utf8 keys

gianm merged pull request #7258: Fix flattening Avro Maps with Utf8 keys URL: https://github.com/apache/incubator-druid/pull/7258 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] gianm commented on issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar

gianm commented on issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar URL: https://github.com/apache/incubator-druid/issues/7288#issuecomment-474106325 I think in most (all?) cases, `foo.getCombiningFactory()` could be replaced by

[GitHub] [incubator-druid] clintropolis commented on issue #7258: #5884 Avro Maps can't be flattened in Kafka Indexing on master

clintropolis commented on issue #7258: #5884 Avro Maps can't be flattened in Kafka Indexing on master URL: https://github.com/apache/incubator-druid/pull/7258#issuecomment-474106178 >I spend my morning trying to run a test case, but it's not so easy has using the

[GitHub] [incubator-druid] mlubavin-vg commented on issue #6043: Faulty channel in resource pool

mlubavin-vg commented on issue #6043: Faulty channel in resource pool URL: https://github.com/apache/incubator-druid/issues/6043#issuecomment-474105630 Happening to us as well, couple times a day, connecting from broker to middle manager. Our exception though is "connection refused":

[incubator-druid] branch master updated: Fix 0.14.0 rc1 voting issues (#7284)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new c17f4bb Fix 0.14.0 rc1 voting issues

[GitHub] [incubator-druid] fjy merged pull request #7284: Fix 0.14.0 rc1 voting issues

fjy merged pull request #7284: Fix 0.14.0 rc1 voting issues URL: https://github.com/apache/incubator-druid/pull/7284 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] leventov commented on issue #7285: Fix concurrency of VersionedIntervalTimeline

leventov commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474104107 > Lots of the methods with this annotation today are meant to be used in production, but just privately. Those methods

[GitHub] [incubator-druid] leventov commented on a change in pull request #7273: Fix some IntelliJ inspections

leventov commented on a change in pull request #7273: Fix some IntelliJ inspections URL: https://github.com/apache/incubator-druid/pull/7273#discussion_r266643824 ## File path:

[GitHub] [incubator-druid] gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline

gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474102354 I don't really love that solution. Adding "InTest" seems to me like it would be pretty ugly, especially in the 200+ places that we

[GitHub] [incubator-druid] gianm commented on issue #7287: Refactor AggregatorFactory interface into two different interfaces, return the second one from getCombiningFactory()

gianm commented on issue #7287: Refactor AggregatorFactory interface into two different interfaces, return the second one from getCombiningFactory() URL: https://github.com/apache/incubator-druid/issues/7287#issuecomment-474100842 Could you (or whoever picks this up, if you aren't

[GitHub] [incubator-druid] leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline

leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474100570 I think we shouldn't add an annotation without enforcing that the annotated methods are not called from production code

[GitHub] [incubator-druid] leventov commented on issue #7285: Fix concurrency of VersionedIntervalTimeline

leventov commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474100570 I think we shouldn't add an annotation without enforcing that the annotated methods are not called from production code (that

[GitHub] [incubator-druid] leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline

leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474084476 @gianm it's not a bug that `DruidCoordinatorLogger` uses this method. `@VisibleForTesting` is also used to "explain"

[GitHub] [incubator-druid] leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline

leventov edited a comment on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474084476 @gianm it's not a bug that `DruidCoordinatorLogger` uses this method. `@VisibleForTesting` is also used to "explain"

[GitHub] [incubator-druid] leventov opened a new issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar

leventov opened a new issue #7288: AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar URL: https://github.com/apache/incubator-druid/issues/7288 Even after reading Javadoc of both, I don't understand why both methods exist and what is the difference between

[GitHub] [incubator-druid] leventov opened a new issue #7287: Refactor AggregatorFactory interface into two different interfaces, return the second one from getCombiningFactory()

leventov opened a new issue #7287: Refactor AggregatorFactory interface into two different interfaces, return the second one from getCombiningFactory() URL: https://github.com/apache/incubator-druid/issues/7287 Currently, `AggregatorFactory.getCombiningFactory()` and `getMergingFactory()`

[GitHub] [incubator-druid] clintropolis commented on issue #7254: #5884 Avro Maps can't be flattened in Kafka Indexing

clintropolis commented on issue #7254: #5884 Avro Maps can't be flattened in Kafka Indexing URL: https://github.com/apache/incubator-druid/pull/7254#issuecomment-474096719 Oops, I just noticed that this isn't a dupe, but instead a PR against 0.12.3. We don't merge PRs into previously

[GitHub] [incubator-druid] drcrallen commented on issue #6953: Move GCP to a core extension

drcrallen commented on issue #6953: Move GCP to a core extension URL: https://github.com/apache/incubator-druid/pull/6953#issuecomment-474096594 Related: https://github.com/apache/incubator-druid/pull/7218 This is an

[GitHub] [incubator-druid] drcrallen commented on a change in pull request #7273: Fix some IntelliJ inspections

drcrallen commented on a change in pull request #7273: Fix some IntelliJ inspections URL: https://github.com/apache/incubator-druid/pull/7273#discussion_r266636877 ## File path:

[GitHub] [incubator-druid] gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline

gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474095468 In that case, maybe I misunderstand what `@VisibleForTesting` is for. Personally I've always used it to mean "would be private,

[GitHub] [incubator-druid] leventov commented on issue #7243: stringFirst/stringLast crashes at aggregation time

leventov commented on issue #7243: stringFirst/stringLast crashes at aggregation time URL: https://github.com/apache/incubator-druid/issues/7243#issuecomment-474093212 The problem is that `StringFirstFoldingAggregatorFactory` and `StringLastFoldingAggregatorFactory` have improper

[GitHub] [incubator-druid] jihoonson commented on issue #7286: Duplicate data ingestion in Kinesis indexing service

jihoonson commented on issue #7286: Duplicate data ingestion in Kinesis indexing service URL: https://github.com/apache/incubator-druid/issues/7286#issuecomment-474093322 ![Screen Shot 2019-03-18 at 1 42 50

[GitHub] [incubator-druid] leventov commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

leventov commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r266629274 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r266625130 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r266626363 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7275: More TeamCity and Structural Search inspection instructions

leventov commented on a change in pull request #7275: More TeamCity and Structural Search inspection instructions URL: https://github.com/apache/incubator-druid/pull/7275#discussion_r266626056 ## File path: ci/README_TeamCity.md ## @@ -39,5 +39,60 @@ Then, somebody who is

[GitHub] [incubator-druid] leventov commented on issue #7285: Fix concurrency of VersionedIntervalTimeline

leventov commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474084476 @gianm it's not a bug that `DruidCoordinatorLogger` uses this method. `@VisibleForTesting` is also used to "explain" why some

[GitHub] [incubator-druid] gianm commented on issue #7286: Duplicate data ingestion in Kinesis indexing service

gianm commented on issue #7286: Duplicate data ingestion in Kinesis indexing service URL: https://github.com/apache/incubator-druid/issues/7286#issuecomment-474081650 It's possible the other datasource had duplicates at a different point. I think we were just looking at one second's

[GitHub] [incubator-druid] gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline

gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474081070 The method is marked `@VisibleForTesting`, which is like a way of saying "should be private, but has to be public so tests can use

[GitHub] [incubator-druid] jihoonson opened a new issue #7286: Duplicate data ingestion in Kinesis indexing service

jihoonson opened a new issue #7286: Duplicate data ingestion in Kinesis indexing service URL: https://github.com/apache/incubator-druid/issues/7286 ### Affected Version 0.14.0-rc1 ### Description I created two dataSources for the same Kinesis stream, but it returned

[GitHub] [incubator-druid] leventov opened a new issue #7285: Fix concurrency of VersionedIntervalTimeline

leventov opened a new issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285 `getAllTimelineEntries()` allows accessing a collection that might be modified concurrently. See

[GitHub] [incubator-druid] leventov commented on a change in pull request #4320: Replace usages of CountingMap with Object2LongMap

leventov commented on a change in pull request #4320: Replace usages of CountingMap with Object2LongMap URL: https://github.com/apache/incubator-druid/pull/4320#discussion_r266606780 ## File path: server/src/main/java/io/druid/server/coordinator/helper/DruidCoordinatorLogger.java

[GitHub] [incubator-druid] leventov commented on issue #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

leventov commented on issue #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#issuecomment-474058891 @clintropolis @egor-ryashin do you have more comments?

svn commit: r33047 - /release/incubator/druid/KEYS

Author: jonwei Date: Mon Mar 18 18:22:24 2019 New Revision: 33047 Log: Add jonwei to KEYS Modified: release/incubator/druid/KEYS Modified: release/incubator/druid/KEYS == --- release/incubator/druid/KEYS (original)

  1   2   >